Subject: bug#15535: closed (Re: bug#15535: Acknowledgement (24.3.50; basic-save-buffer should update buffer-file-coding-system value if the contents were written using different coding system))

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 13 Oct 2013 20:44:02 +0000

Your bug report

#15535: 24.3.50; basic-save-buffer should update buffer-file-coding-system value if the contents were written using different coding system

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
15535: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15535
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#15535: Acknowledgement (24.3.50; basic-save-buffer should update buffer-file-coding-system value if the contents were written using different coding system)
From: Dmitry Gutov <[email-masked]>
To: Eli Zaretskii <[email-masked]>, Kenichi Handa <[email-masked]>
Cc: [email-masked]
Date: Sun, 13 Oct 2013 23:43:29 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 24.4

Fixed for me too, thanks.

Subject: 24.3.50; basic-save-buffer should update buffer-file-coding-system value if the contents were written using different coding system
From: Dmitry Gutov <[email-masked]>
To: [email-masked]
Date: Sun, 06 Oct 2013 01:44:09 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Otherwise it's hard to find out which coding system was used, after all.

See here why it's useful:
http://lists.gnu.org/archive/html/emacs-devel/2013-10/msg00129.html

The following test passes in Emacs 24.3 but fails on trunk:

(ert-deftest save-buffer-updates-buffer-file-coding-system ()
  (let ((file (expand-file-name "foo" temporary-file-directory))
        (default-buffer-file-coding-system 'utf-8-unix))
    (unwind-protect
        (with-temp-buffer
          (insert "abcdef\n")
          (write-file file))
      (with-current-buffer (find-file-noselect file)
        (should (eq 'undecided (coding-system-change-eol-conversion
                                buffer-file-coding-system nil)))
        (insert "водка матрёшка селёдка")
        (save-buffer)
        ;; Fails here:
        (should (eq 'utf-8-unix buffer-file-coding-system)))
      (delete-file file))))

In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.6.4)
 of 2013-10-04 on axl
Bzr revision: 114513 [email-masked]
Windowing system distributor `The X.Org Foundation', version 11.0.11303000
System Description:	Ubuntu 13.04