From unknown Mon Jun 23 07:47:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#15531 <15531@debbugs.gnu.org> To: bug#15531 <15531@debbugs.gnu.org> Subject: Status: Emacs configure fails with gif 5.0 Reply-To: bug#15531 <15531@debbugs.gnu.org> Date: Mon, 23 Jun 2025 14:47:18 +0000 retitle 15531 Emacs configure fails with gif 5.0 reassign 15531 emacs submitter 15531 Barry Fishman severity 15531 important thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 14:13:08 2013 Received: (at submit) by debbugs.gnu.org; 5 Oct 2013 18:13:08 +0000 Received: from localhost ([127.0.0.1]:56357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSWLj-0001UV-3R for submit@debbugs.gnu.org; Sat, 05 Oct 2013 14:13:07 -0400 Received: from bzsmtp01vmoc.mail2world.com ([74.202.142.112]:2616) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSTlu-00060o-QN for submit@debbugs.gnu.org; Sat, 05 Oct 2013 11:27:59 -0400 Received: from mail pickup service by bzsmtp01vmoc.mail2world.com with Microsoft SMTPSVC; Sat, 5 Oct 2013 08:27:56 -0700 auth-sender: bfishman@alum.rpi.edu Received: from 71.52.212.238 unverified ([71.52.212.238]) by bzsmtp01vmoc.mail2world.com with Mail2World SMTP Server; Sat, 05 Oct 2013 08:27:54 -0700 From: Barry Fishman To: submit@debbugs.gnu.org Subject: Emacs configure fails with gif 5.0 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAALVBMVEXG87t8xXThBQWq85q9 87AvUC6PUVH/BgamyajC87a/87P////r6+ud7oq49KsBy7dJAAACKUlEQVQ4jc3Sv2vbQBQH 8CulwcEdeoOKwM1QD/bSzVktKDEdMpRqeMKQFNqAhEGbh3aVB5sDafAYL106xZMzuAiehnqI EciLMR2viz0Vor+hdydZMa6z97sI9NH7cYdI9ZGQr4/kP4Fu1akehFqHDaoHoOviPLD3oVtz 7PIErFCeeRdqOuvptwDMYSyfpKB7iYh3DOCTeOKzegGvk8hD1O22eD2B9tUWum9wbpXYy6NA wAzMeQFu1AeT2VAW0Af4sYUvfmRbCWLciXq0B2ZYf4C+GL/AGBIcOP4O4MzFKbiTAGOPYg7V mu1j5OIdfIgT7FtHGKoZIHKB6IuK9kDODpNsK0pPVnqCFbyFSyYWMMPnIA9CVsbm5l2HuRjZ FVERBXFPs8QQMhIZvqUX8jJmiTzIRy5FwWhEdAmR4y1KnQbn1KrnMOrLj6PPDnW8bw2+1K7I OINrecF9jwyJyBlfAvkzvlEy6DBHJ3m+8yU5HY9V0TWl+nALx+slMQTkRWKHQprEOJeST3qg p8RoHZRjsmm1ctrrJ0HkX0mFvG+uTnf7qe3SNG2dcc4bm70iAemaHxAJ91zF2G2noMl/UVVk bAoihgINlKwa6XkuhBsKGJgnPBuVEeG/5Wzqz3tZ0bYh4SsBS+qXZtTMRTWUcC/Bnybi7+R5 VoaAdZNz7ZU/RT8u2nEuQTw0VpmjH/7UChHQlFAGT1Rg8GS7Hcm+0F4EDgvYIohLAFS++wvs R0Pau3fdJgAAAABJRU5ErkJggg== Date: Sat, 05 Oct 2013 11:27:53 -0400 Message-ID: User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OriginalArrivalTime: 05 Oct 2013 15:27:56.0530 (UTC) FILETIME=[77650520:01CEC1DF] X-Spam-Score: 4.2 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Package: emacs Version: 24.3.50 The configure script fails to recognize the gif_lib.h header file for gif 5.0 and so prints an error that git support can not be found. The gif_lib.h header file has been reorganized for gif 5.0. There is no longer a EGifPutExtensionLast function. However there is a new GifMakeMapObject I used in my patch. A better way would probably be to look at the new GIFLIB_MAJOR define now in gif_lib.h. [...] Content analysis details: (4.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 FSL_HELO_BARE_IP_2 FSL_HELO_BARE_IP_2 -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.202.142.112 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.9 RCVD_NUMERIC_HELO Received: contains an IP address used for HELO X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 05 Oct 2013 14:13:05 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 4.2 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Package: emacs Version: 24.3.50 The configure script fails to recognize the gif_lib.h header file for gif 5.0 and so prints an error that git support can not be found. The gif_lib.h header file has been reorganized for gif 5.0. There is no longer a EGifPutExtensionLast function. However there is a new GifMakeMapObject I used in my patch. A better way would probably be to look at the new GIFLIB_MAJOR define now in gif_lib.h. [...] Content analysis details: (4.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 FSL_HELO_BARE_IP_2 FSL_HELO_BARE_IP_2 -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.202.142.112 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.9 RCVD_NUMERIC_HELO Received: contains an IP address used for HELO --=-=-= Content-Type: text/plain Package: emacs Version: 24.3.50 The configure script fails to recognize the gif_lib.h header file for gif 5.0 and so prints an error that git support can not be found. The gif_lib.h header file has been reorganized for gif 5.0. There is no longer a EGifPutExtensionLast function. However there is a new GifMakeMapObject I used in my patch. A better way would probably be to look at the new GIFLIB_MAJOR define now in gif_lib.h. I have included a patch, but I do not have many OS/platforms that I can check. I am far from understanding autoconfig, but my attempt at a fix (git patch) is included below: --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=emacs-gif-5.patch Content-Description: configure and image.c patches diff --git a/configure.ac b/configure.ac index 53426b6..0f05d8e 100644 --- a/configure.ac +++ b/configure.ac @@ -3109,8 +3109,9 @@ elif test "${HAVE_X11}" = "yes" && test "${with_gif}" != "no" \ || test "${HAVE_W32}" = "yes"; then AC_CHECK_HEADER(gif_lib.h, # EGifPutExtensionLast only exists from version libungif-4.1.0b1. -# Earlier versions can crash Emacs. - [AC_CHECK_LIB(gif, EGifPutExtensionLast, HAVE_GIF=yes, HAVE_GIF=maybe)]) +# Earlier versions can crash Emacs, but version 5.0 removes EGifPutExtensionLast. + [AC_CHECK_LIB(gif, GifMakeMapObject, HAVE_GIF=yes, + [AC_CHECK_LIB(gif, EGifPutExtensionLast, HAVE_GIF=yes, HAVE_GIF=maybe)])]) if test "$HAVE_GIF" = yes; then LIBGIF=-lgif diff --git a/src/image.c b/src/image.c index e429830..c414f5b 100644 --- a/src/image.c +++ b/src/image.c @@ -7219,14 +7219,22 @@ gif_image_p (Lisp_Object object) #endif /* HAVE_NTGUI */ +#ifndef GIFLIB_MAJOR +#define GIFLIB_MAJOR 0 +#endif #ifdef WINDOWSNT /* GIF library details. */ DEF_IMGLIB_FN (int, DGifCloseFile, (GifFileType *)); DEF_IMGLIB_FN (int, DGifSlurp, (GifFileType *)); +#if GIFLIB_MAJOR < 5 DEF_IMGLIB_FN (GifFileType *, DGifOpen, (void *, InputFunc)); DEF_IMGLIB_FN (GifFileType *, DGifOpenFileName, (const char *)); +#else +DEF_IMGLIB_FN (GifFileType *, DGifOpen, (void *, InputFunc, int *)); +DEF_IMGLIB_FN (GifFileType *, DGifOpenFileName, (const char *, int *)); +#endif static bool init_gif_functions (void) @@ -7316,7 +7324,11 @@ gif_load (struct frame *f, struct image *img) } /* Open the GIF file. */ +#if GIFLIB_MAJOR < 5 gif = fn_DGifOpenFileName (SSDATA (file)); +#else + gif = fn_DGifOpenFileName (SSDATA (file), NULL); +#endif if (gif == NULL) { image_error ("Cannot open `%s'", file, Qnil); @@ -7337,7 +7349,11 @@ gif_load (struct frame *f, struct image *img) memsrc.len = SBYTES (specified_data); memsrc.index = 0; +#if GIFLIB_MAJOR < 5 gif = fn_DGifOpen (&memsrc, gif_read_from_memory); +#else + gif = fn_DGifOpen (&memsrc, gif_read_from_memory, NULL); +#endif if (!gif) { image_error ("Cannot open memory source `%s'", img->spec, Qnil); --=-=-= Content-Type: text/plain -- Barry Fishman --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 14:26:23 2013 Received: (at 15531) by debbugs.gnu.org; 5 Oct 2013 18:26:24 +0000 Received: from localhost ([127.0.0.1]:56387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSWYZ-0001oS-1Z for submit@debbugs.gnu.org; Sat, 05 Oct 2013 14:26:23 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:49557) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSWYT-0001oF-77 for 15531@debbugs.gnu.org; Sat, 05 Oct 2013 14:26:18 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MU700F00KFX1W00@a-mtaout21.012.net.il> for 15531@debbugs.gnu.org; Sat, 05 Oct 2013 21:26:15 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MU700FZJKJR1910@a-mtaout21.012.net.il>; Sat, 05 Oct 2013 21:26:15 +0300 (IDT) Date: Sat, 05 Oct 2013 21:26:06 +0300 From: Eli Zaretskii Subject: Re: bug#15531: Emacs configure fails with gif 5.0 In-reply-to: X-012-Sender: halo1@inter.net.il To: Barry Fishman Message-id: <83a9in7ewx.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15531 Cc: 15531@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Barry Fishman > Date: Sat, 05 Oct 2013 11:27:53 -0400 > > The configure script fails to recognize the gif_lib.h header file for > gif 5.0 and so prints an error that git support can not be found. > > The gif_lib.h header file has been reorganized for gif 5.0. There is no > longer a EGifPutExtensionLast function. However there is a new > GifMakeMapObject I used in my patch. A better way would probably be to > look at the new GIFLIB_MAJOR define now in gif_lib.h. > > I have included a patch, but I do not have many OS/platforms that I > can check. I am far from understanding autoconfig, but my attempt at a > fix (git patch) is included below: Thanks. For the record, this is not enough for Windows, because we must prevent Emacs compiled with libungif 5.0 or newer to dynamically load an older shared library, or vice versa. Btw, where can one find this new version? I can only find versions 4.x or older. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 05 15:19:28 2013 Received: (at 15531) by debbugs.gnu.org; 5 Oct 2013 19:19:28 +0000 Received: from localhost ([127.0.0.1]:56465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSXNw-00035Y-7c for submit@debbugs.gnu.org; Sat, 05 Oct 2013 15:19:28 -0400 Received: from bzsmtp01vmoc.mail2world.com ([74.202.142.112]:3181) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSXNt-00035N-Vp for 15531@debbugs.gnu.org; Sat, 05 Oct 2013 15:19:26 -0400 Received: from mail pickup service by bzsmtp01vmoc.mail2world.com with Microsoft SMTPSVC; Sat, 5 Oct 2013 12:19:19 -0700 auth-sender: bfishman@alum.rpi.edu Received: from 71.52.212.238 unverified ([71.52.212.238]) by bzsmtp01vmoc.mail2world.com with Mail2World SMTP Server; Sat, 05 Oct 2013 12:19:17 -0700 From: Barry Fishman To: Eli Zaretskii Subject: Re: bug#15531: Emacs configure fails with gif 5.0 References: <83a9in7ewx.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAALVBMVEXG87t8xXThBQWq85q9 87AvUC6PUVH/BgamyajC87a/87P////r6+ud7oq49KsBy7dJAAACKUlEQVQ4jc3Sv2vbQBQH 8CulwcEdeoOKwM1QD/bSzVktKDEdMpRqeMKQFNqAhEGbh3aVB5sDafAYL106xZMzuAiehnqI EciLMR2viz0Vor+hdydZMa6z97sI9NH7cYdI9ZGQr4/kP4Fu1akehFqHDaoHoOviPLD3oVtz 7PIErFCeeRdqOuvptwDMYSyfpKB7iYh3DOCTeOKzegGvk8hD1O22eD2B9tUWum9wbpXYy6NA wAzMeQFu1AeT2VAW0Af4sYUvfmRbCWLciXq0B2ZYf4C+GL/AGBIcOP4O4MzFKbiTAGOPYg7V mu1j5OIdfIgT7FtHGKoZIHKB6IuK9kDODpNsK0pPVnqCFbyFSyYWMMPnIA9CVsbm5l2HuRjZ FVERBXFPs8QQMhIZvqUX8jJmiTzIRy5FwWhEdAmR4y1KnQbn1KrnMOrLj6PPDnW8bw2+1K7I OINrecF9jwyJyBlfAvkzvlEy6DBHJ3m+8yU5HY9V0TWl+nALx+slMQTkRWKHQprEOJeST3qg p8RoHZRjsmm1ctrrJ0HkX0mFvG+uTnf7qe3SNG2dcc4bm70iAemaHxAJ91zF2G2noMl/UVVk bAoihgINlKwa6XkuhBsKGJgnPBuVEeG/5Wzqz3tZ0bYh4SsBS+qXZtTMRTWUcC/Bnybi7+R5 VoaAdZNz7ZU/RT8u2nEuQTw0VpmjH/7UChHQlFAGT1Rg8GS7Hcm+0F4EDgvYIohLAFS++wvs R0Pau3fdJgAAAABJRU5ErkJggg== Date: Sat, 05 Oct 2013 15:19:15 -0400 In-Reply-To: <83a9in7ewx.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Oct 2013 21:26:06 +0300") Message-ID: User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-OriginalArrivalTime: 05 Oct 2013 19:19:19.0075 (UTC) FILETIME=[CA094730:01CEC1FF] X-Spam-Score: 4.2 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 2013-10-05 14:26:06 EDT, Eli Zaretskii wrote: > For the record, this is not enough for Windows, because we must > prevent Emacs compiled with libungif 5.0 or newer to dynamically load > an older shared library, or vice versa. > > Btw, where can one find this new version? I can only find versions > 4.x or older. [...] Content analysis details: (4.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.4 FSL_HELO_BARE_IP_2 FSL_HELO_BARE_IP_2 -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.202.142.112 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.9 RCVD_NUMERIC_HELO Received: contains an IP address used for HELO X-Debbugs-Envelope-To: 15531 Cc: 15531@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 4.2 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 2013-10-05 14:26:06 EDT, Eli Zaretskii wrote: > For the record, this is not enough for Windows, because we must > prevent Emacs compiled with libungif 5.0 or newer to dynamically load > an older shared library, or vice versa. > > Btw, where can one find this new version? I can only find versions > 4.x or older. [...] Content analysis details: (4.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.202.142.112 listed in list.dnswl.org] 2.4 FSL_HELO_BARE_IP_2 FSL_HELO_BARE_IP_2 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.9 RCVD_NUMERIC_HELO Received: contains an IP address used for HELO On 2013-10-05 14:26:06 EDT, Eli Zaretskii wrote: > For the record, this is not enough for Windows, because we must > prevent Emacs compiled with libungif 5.0 or newer to dynamically load > an older shared library, or vice versa. > > Btw, where can one find this new version? I can only find versions > 4.x or older. I use Arch GNU/Linux which defaults to using giflib 5.0.4. They point back to http://sourceforge.net/projects/giflib/. It has the download for 5.0.5 listed under the "Recent Releases" heading. Its also tagged in its git repository. -- Barry Fishman From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 20:40:51 2013 Received: (at 15531-done) by debbugs.gnu.org; 10 Oct 2013 00:40:51 +0000 Received: from localhost ([127.0.0.1]:38977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VU4J7-0007XJ-Mm for submit@debbugs.gnu.org; Wed, 09 Oct 2013 20:40:50 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:34927) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VU4J4-0007X6-DN for 15531-done@debbugs.gnu.org; Wed, 09 Oct 2013 20:40:46 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VU4J3-0003Zj-9h; Wed, 09 Oct 2013 20:40:45 -0400 From: Glenn Morris To: 15531-done@debbugs.gnu.org Subject: Re: bug#15531: Emacs configure fails with gif 5.0 References: X-Spook: argus Steve Case LLNL bank Janet Reno BCCI SRI satellite X-Ran: 1,pKqE*u"-TU-)lRU9888#*R@v0"e,HQ=DN_9*\M;qpf}*QDFDC\f~B@p(':aL~#W;KW]U X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 09 Oct 2013 20:40:45 -0400 In-Reply-To: (Barry Fishman's message of "Sat, 05 Oct 2013 11:27:53 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: 15531-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) Version: 24.4 Thank you; applied. We'll need a copyright assignment to accept any more code from you. If you think you might contribute more in future, let me know off-list, and I can send you a form to get started. From unknown Mon Jun 23 07:47:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Nov 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator