From unknown Fri Jul 11 07:15:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#15520 <15520@debbugs.gnu.org> To: bug#15520 <15520@debbugs.gnu.org> Subject: Status: 24.3; secrets.el secrets-create-item has wrong dbus arguments (fix included) Reply-To: bug#15520 <15520@debbugs.gnu.org> Date: Fri, 11 Jul 2025 14:15:17 +0000 retitle 15520 24.3; secrets.el secrets-create-item has wrong dbus arguments= (fix included) reassign 15520 emacs submitter 15520 Nicolas Petton severity 15520 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 16:29:26 2013 Received: (at submit) by debbugs.gnu.org; 3 Oct 2013 20:29:26 +0000 Received: from localhost ([127.0.0.1]:52378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRpWW-0006aS-Uf for submit@debbugs.gnu.org; Thu, 03 Oct 2013 16:29:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57353) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRQ6I-0001I1-N6 for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:20:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRQ69-0006EM-Oa for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:20:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQ69-0006ED-Lu for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:20:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQ60-0007Zj-Rz for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:20:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRQ5s-000646-Fg for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:20:20 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:49781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRQ5s-00063h-5b for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:20:12 -0400 Received: by mail-wi0-f180.google.com with SMTP id hj3so1327481wib.1 for ; Wed, 02 Oct 2013 10:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:date:content-type:mime-version :content-transfer-encoding; bh=tMN4Ri6S5+vc4aRcSIcIPdeq3bNykxsfwTZ0nHtDh48=; b=RIRjvkKxQID4lvc+9wxXb9i9Jik9xa5y9ul405AIYs28uRB6ylbNmwnIf8fGnhrk5j w0WBdlIqwDKBWpWt7t3eVp+bc39hbUo73jig/Y+0X1/MQuHaLnhl3WUIFtmzjY/5bZnH o08LH9uQlQghMXnl+gLUK/OH4cAEOUE20qddL4dWVO+i/noWqTRtqD6PNR8pC/xoaK22 dF+CgiLGFFsbGRz2WEAkzkaehNm7y2HnKsniDCx1TBdwenloJCYeZCcl4ubH7P96D7q/ hp2iyAKose6/NIL1WB3yjNNLi4zqse0VKHH8p98rf9bJ6eTKQG9cQRki22oye2Y/1bZr g2Cw== X-Received: by 10.180.72.148 with SMTP id d20mr3061115wiv.21.1380734410871; Wed, 02 Oct 2013 10:20:10 -0700 (PDT) Received: from [192.168.0.45] ([88.160.125.31]) by mx.google.com with ESMTPSA id q5sm5519178wiz.3.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 02 Oct 2013 10:20:10 -0700 (PDT) Message-ID: <1380734406.9521.13.camel@lingonberry> Subject: 24.3; secrets.el secrets-create-item has wrong dbus arguments (fix included) From: Nicolas Petton To: bug-gnu-emacs@gnu.org Date: Wed, 02 Oct 2013 19:20:06 +0200 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.0-0ubuntu1~saucy1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 03 Oct 2013 16:29:24 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) In secrets.el, secrets-create-item has the wrong label property for the created item, and the secret struct is not built correctly. Here's a new version that fixes the issue. (defun secrets-create-item (collection item password &rest attributes) "Create a new item in COLLECTION with label ITEM and password PASSWORD. ATTRIBUTES are key-value pairs set for the created item. The keys are keyword symbols, starting with a colon. Example: \(secrets-create-item \"Tramp collection\" \"item\" \"geheim\" :method \"sudo\" :user \"joe\" :host \"remote-host\"\) The object path of the created item is returned." (unless (member item (secrets-list-items collection)) (let ((collection-path (secrets-unlock-collection collection)) result props) (unless (secrets-empty-path collection-path) ;; Create attributes list. (while (consp (cdr attributes)) (unless (keywordp (car attributes)) (error 'wrong-type-argument (car attributes))) (setq props (add-to-list 'props (list :dict-entry (substring (symbol-name (car attributes)) 1) (cadr attributes)) 'append) attributes (cddr attributes))) ;; Create the item. (setq result (dbus-call-method :session secrets-service collection-path secrets-interface-collection "CreateItem" ;; Properties. (append `(:array (:dict-entry "org.freedesktop.Secret.Item.Label" (:variant ,item))) (when props `((:dict-entry "org.freedesktop.Secret.Item.Attributes" (:variant ,(append '(:array) props)))))) ;; Secret. `(:struct :object-path ,secrets-session-path ,(dbus-string-to-byte-array "") ,(dbus-string-to-byte-array password) "text/plain") ;; Do not replace. Replace does not seem to work. nil)) (secrets-prompt (cadr result)) ;; Return the object path. (car result))))) From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 06:26:28 2013 Received: (at 15520) by debbugs.gnu.org; 4 Oct 2013 10:26:28 +0000 Received: from localhost ([127.0.0.1]:53262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VS2aZ-0003FR-4h for submit@debbugs.gnu.org; Fri, 04 Oct 2013 06:26:27 -0400 Received: from mout.gmx.net ([212.227.17.21]:57891) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VS2aR-0003F8-1O for 15520@debbugs.gnu.org; Fri, 04 Oct 2013 06:26:25 -0400 Received: from detlef.gmx.de ([87.146.63.33]) by mail.gmx.com (mrgmx001) with ESMTPS (Nemesis) id 0Lt2BW-1Vpf1917ms-012XxY for <15520@debbugs.gnu.org>; Fri, 04 Oct 2013 12:26:17 +0200 From: Michael Albinus To: Nicolas Petton Subject: Re: bug#15520: 24.3; secrets.el secrets-create-item has wrong dbus arguments (fix included) References: <1380734406.9521.13.camel@lingonberry> Date: Fri, 04 Oct 2013 12:26:12 +0200 In-Reply-To: <1380734406.9521.13.camel@lingonberry> (Nicolas Petton's message of "Wed, 02 Oct 2013 19:20:06 +0200") Message-ID: <87txgx1ge3.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:nD+XZ/fBiVhiOWXWMlG5g89+kc2AV7lqn2Wb5FrS9AsV5ezEH8A qfFXYHg7ZnII6jYwMp6+HA9xvZxDtWwXqJz8njm/fwxvAcQXu65O/vPmWsApY6cgYQJnzQK Q23EHTOJc7lTmUwjo4xRxqgtajq12A503S3RGiEnNsAQYXqULnyO859CjWGxVg9q1POZGp8 UH8LWnJFqjTQcPag8+XVg== X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Nicolas Petton writes: Hi Nicolas, > In secrets.el, secrets-create-item has the wrong label property for the > created item, and the secret struct is not built correctly. > > Here's a new version that fixes the issue. [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.21 listed in list.dnswl.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 SPF_PASS SPF: sender matches SPF record X-Debbugs-Envelope-To: 15520 Cc: 15520@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Nicolas Petton writes: Hi Nicolas, > In secrets.el, secrets-create-item has the wrong label property for the > created item, and the secret struct is not built correctly. > > Here's a new version that fixes the issue. [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.17.21 listed in list.dnswl.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) -0.0 SPF_PASS SPF: sender matches SPF record Nicolas Petton writes: Hi Nicolas, > In secrets.el, secrets-create-item has the wrong label property for the > created item, and the secret struct is not built correctly. > > Here's a new version that fixes the issue. Thanks for the report. This problem was solved back in June already. That solution ought to be backwards compatible, because it was due to an interface change of "org.freedesktop.Secret.Item.CreateItem". Please check, whether works for you. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 20:32:56 2013 Received: (at control) by debbugs.gnu.org; 7 Oct 2013 00:32:56 +0000 Received: from localhost ([127.0.0.1]:58524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSykq-0005DB-1p for submit@debbugs.gnu.org; Sun, 06 Oct 2013 20:32:56 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:55063) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSyko-0005D1-23 for control@debbugs.gnu.org; Sun, 06 Oct 2013 20:32:54 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VSykn-000416-NT for control@debbugs.gnu.org; Sun, 06 Oct 2013 20:32:53 -0400 Date: Sun, 06 Oct 2013 20:32:53 -0400 Message-Id: Subject: control message for bug 15520 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) close 15520 24.4 From unknown Fri Jul 11 07:15:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 04 Nov 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator