GNU bug report logs - #15520
24.3; secrets.el secrets-create-item has wrong dbus arguments (fix included)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15520 in the body.
You can then email your comments to 15520 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <petton.nicolas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; secrets.el secrets-create-item has wrong dbus arguments (fix
 included)
Date: Wed, 02 Oct 2013 19:20:06 +0200

In secrets.el, secrets-create-item has the wrong label property for the
created item, and the secret struct is not built correctly.

Here's a new version that fixes the issue.


(defun secrets-create-item (collection item password &rest attributes)
  "Create a new item in COLLECTION with label ITEM and password
PASSWORD.
ATTRIBUTES are key-value pairs set for the created item.  The
keys are keyword symbols, starting with a colon.  Example:

  \(secrets-create-item \"Tramp collection\" \"item\" \"geheim\"
   :method \"sudo\" :user \"joe\" :host \"remote-host\"\)

The object path of the created item is returned."
  (unless (member item (secrets-list-items collection))
    (let ((collection-path (secrets-unlock-collection collection))
	  result props)
      (unless (secrets-empty-path collection-path)
	;; Create attributes list.
	(while (consp (cdr attributes))
	  (unless (keywordp (car attributes))
	    (error 'wrong-type-argument (car attributes)))
	  (setq props (add-to-list
		       'props
		       (list :dict-entry
			     (substring (symbol-name (car attributes)) 1)
			     (cadr attributes))
		       'append)
		attributes (cddr attributes)))
	;; Create the item.
	(setq result
	      (dbus-call-method
	       :session secrets-service collection-path
	       secrets-interface-collection "CreateItem"
	       ;; Properties.
	       (append
		`(:array
		  (:dict-entry "org.freedesktop.Secret.Item.Label" (:variant ,item)))
		(when props
		  `((:dict-entry
		     "org.freedesktop.Secret.Item.Attributes" (:variant ,(append
'(:array) props))))))
	       ;; Secret.
	       `(:struct :object-path ,secrets-session-path
			 ,(dbus-string-to-byte-array "")
			 ,(dbus-string-to-byte-array password)
			 "text/plain")
	       ;; Do not replace. Replace does not seem to work.
	       nil))
	(secrets-prompt (cadr result))
	;; Return the object path.
	(car result)))))

Message #8 received at 15520 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Nicolas Petton <petton.nicolas <at> gmail.com>
Cc: 15520 <at> debbugs.gnu.org
Subject: Re: bug#15520: 24.3;
 secrets.el secrets-create-item has wrong dbus arguments (fix included)
Date: Fri, 04 Oct 2013 12:26:12 +0200

Nicolas Petton <petton.nicolas <at> gmail.com> writes:

Hi Nicolas,

> In secrets.el, secrets-create-item has the wrong label property for the
> created item, and the secret struct is not built correctly.
>
> Here's a new version that fixes the issue.

Thanks for the report.

This problem was solved back in June already. That solution ought to be
backwards compatible, because it was due to an interface change of
"org.freedesktop.Secret.Item.CreateItem".

Please check, whether
<http://bzr.savannah.gnu.org/lh/emacs/trunk/download/head:/secrets.el-20100313201810-6s62gy70hbdnhfs1-1/secrets.el>
works for you.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.