From unknown Thu Jul 10 19:40:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included) Resent-From: Nicolas Petton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2013 20:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15516 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 15516@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138083210725167 (code B ref -1); Thu, 03 Oct 2013 20:29:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 Oct 2013 20:28:27 +0000 Received: from localhost ([127.0.0.1]:52364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRpVa-0006Xr-Uf for submit@debbugs.gnu.org; Thu, 03 Oct 2013 16:28:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55555) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRPyx-00016Y-Tn for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:13:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRPyp-0003Wk-8i for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:13:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRPyp-0003Wg-62 for submit@debbugs.gnu.org; Wed, 02 Oct 2013 13:12:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRPyg-00042j-EL for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:12:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRPyU-0003Si-T5 for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:12:46 -0400 Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:44212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRPyU-0003S1-M0 for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 13:12:34 -0400 Received: by mail-we0-f181.google.com with SMTP id p61so1360687wes.12 for ; Wed, 02 Oct 2013 10:12:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:user-agent:date:message-id:mime-version :content-type; bh=SgljbpCBtTb1lp+ahSdsQwfQlKc0s230985fHTiLvDs=; b=KUGq3AzFueDIDNlkeajjThl1uuNOVc8EySwj4PCAVggFwhwY2TZznzibIEvMcHcq9l PnP2OkHP7/BCx/3vw2QCo8lvktBhUaguau7mO6S+F+nlm5QdYBDfrj/Z+hbwDrrJGm0w aKbOYEDh6LLpjiKd8n5g+NgLVpHeEczKvVZ80K8z4qk/8ieosWnpiJY6fR93hSlCmwWO 8/lbQPv3Rg0hPoDQMS5XJ1LzWwBqBfdq8NUOYhJPIFWft8bFjiVnsqdImg4hZVGANZhb Y/EqK9Fnjv2B7DNmLfnWSioITS2kXjohwD68fQk3chiqcLWECz/Oi1uGlfaIC1gvFiMh 4Axw== X-Received: by 10.180.105.198 with SMTP id go6mr24490289wib.0.1380733953202; Wed, 02 Oct 2013 10:12:33 -0700 (PDT) Received: from localhost (hel59-4-88-160-125-31.fbx.proxad.net. [88.160.125.31]) by mx.google.com with ESMTPSA id c13sm18421031wib.5.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 02 Oct 2013 10:12:32 -0700 (PDT) From: Nicolas Petton User-Agent: Notmuch/0.16+54~g5c19eb4 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 02 Oct 2013 19:12:31 +0200 Message-ID: <87mwmrd2bk.fsf@lingonberry.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Thu, 03 Oct 2013 16:28:24 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) In secrets.el, secrets-create-collection is broken (the DBus message signature is wrong and the collection label is not the right one). Here's a fixed version of the function: (defun secrets-create-collection (collection) "Create collection labeled COLLECTION if it doesn't exist. Return the D-Bus object path for collection." (let ((collection-path (secrets-collection-path collection))) ;; Create the collection. (when (secrets-empty-path collection-path) (setq collection-path (secrets-prompt (cadr ;; "CreateCollection" returns the prompt path as second arg. (dbus-call-method :session secrets-service secrets-path secrets-interface-service "CreateCollection" `(:array (:dict-entry "org.freedesktop.Secret.Collection.Label" (:variant ,collection))) ""))))) ;; Return object path of the collection. collection-path)) From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 04 05:37:44 2013 Received: (at control) by debbugs.gnu.org; 4 Oct 2013 09:37:44 +0000 Received: from localhost ([127.0.0.1]:53226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VS1pQ-00010E-6V for submit@debbugs.gnu.org; Fri, 04 Oct 2013 05:37:44 -0400 Received: from mout.gmx.net ([212.227.15.15]:55572) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VS1pN-000104-CL for control@debbugs.gnu.org; Fri, 04 Oct 2013 05:37:42 -0400 Received: from detlef.gmx.de ([87.146.63.33]) by mail.gmx.com (mrgmx001) with ESMTPS (Nemesis) id 0LdYdG-1W9NJp0IUM-00inv6 for ; Fri, 04 Oct 2013 11:37:39 +0200 Date: Fri, 04 Oct 2013 11:37:34 +0200 Message-Id: <87wqlt1in5.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #15519 X-Provags-ID: V03:K0:zjxMhwJ+HSw2zVtGDAtO1Wi9BSYV2Mt8ioCjq1VVZo5dQcq1dzr spgdSJ+rk2T1C4snhJFobpvfGM7Mh+f7WYAjIDpzCjp1PSS/VTMRRJpTHuIv73W9l7145Md F4n8tV0WM2JwxzKGrY85mFUGVNY0/Xc397JPeTU83s3jKpBi0dMeamEnI5FswFNmVvHfFyU 7j0R0nPO8WSIDB6V84YkQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) merge 15519 15516 From unknown Thu Jul 10 19:40:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included) Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Oct 2013 10:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15516 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nicolas Petton Cc: 15516@debbugs.gnu.org Received: via spool by 15516-submit@debbugs.gnu.org id=B15516.138088299313521 (code B ref 15516); Fri, 04 Oct 2013 10:37:01 +0000 Received: (at 15516) by debbugs.gnu.org; 4 Oct 2013 10:36:33 +0000 Received: from localhost ([127.0.0.1]:53276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VS2kK-0003W0-HO for submit@debbugs.gnu.org; Fri, 04 Oct 2013 06:36:32 -0400 Received: from mout.gmx.net ([212.227.15.19]:62295) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VS2kH-0003Vs-Kh for 15516@debbugs.gnu.org; Fri, 04 Oct 2013 06:36:30 -0400 Received: from detlef.gmx.de ([87.146.63.33]) by mail.gmx.com (mrgmx102) with ESMTPS (Nemesis) id 0LfHs4-1WC6zr207M-00omBd for <15516@debbugs.gnu.org>; Fri, 04 Oct 2013 12:36:27 +0200 From: Michael Albinus References: <87mwmrd2bk.fsf@lingonberry.i-did-not-set--mail-host-address--so-tickle-me> Date: Fri, 04 Oct 2013 12:36:22 +0200 In-Reply-To: <87mwmrd2bk.fsf@lingonberry.i-did-not-set--mail-host-address--so-tickle-me> (Nicolas Petton's message of "Wed, 02 Oct 2013 19:12:31 +0200") Message-ID: <87ob751fx5.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:95SRe41IkecX0I76RNJfvXfisHZ++8bYu053HUBAgtjcA+n3lE0 HSGdAm9g1WHchTP8YVaehGu3lf06ESU5zvR3tkZaXNY9xjpLY4n61WH/YkU4lefx9PD8gMW KyXfZ0XtzPAJxazBuLH/6tKaPiWnaKVdvovXT9xsqwY2CuZ8l85KZN/rdMc7FfiOvNuiMnF gDTJq+VAiW9qPhk86n+vQ== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Nicolas Petton writes: Hi Nicolas, > In secrets.el, secrets-create-collection is broken (the DBus message > signature is wrong and the collection label is not the right one). Thanks for the report. I have applied a slightly different patch to the Emacs repository. Please check . Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 20:33:20 2013 Received: (at control) by debbugs.gnu.org; 7 Oct 2013 00:33:20 +0000 Received: from localhost ([127.0.0.1]:58529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSylE-0005Ea-C6 for submit@debbugs.gnu.org; Sun, 06 Oct 2013 20:33:20 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:55064) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSylB-0005EP-Kf for control@debbugs.gnu.org; Sun, 06 Oct 2013 20:33:18 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VSylB-00044Z-BB for control@debbugs.gnu.org; Sun, 06 Oct 2013 20:33:17 -0400 Date: Sun, 06 Oct 2013 20:33:17 -0400 Message-Id: Subject: control message for bug 15516 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) close 15516 24.4