GNU bug report logs - #15466
24.3.50; [PATCH] Add some keybindings for doc-view-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#15466: closed (24.3.50; [PATCH] Add some keybindings for
 doc-view-mode)
Date: Thu, 26 Sep 2013 19:09:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 26 Sep 2013 21:08:29 +0200
with message-id <878uyj5rki.fsf <at> thinkpad.tsdh.org>
and subject line Re: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode
has caused the debbugs.gnu.org bug report #15466,
regarding 24.3.50; [PATCH] Add some keybindings for doc-view-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
15466: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15466
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Xue Fuqiao <xfq.free <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; [PATCH] Add some keybindings for doc-view-mode
Date: Thu, 26 Sep 2013 22:14:54 +0800

severity minor
tags patch

This patch adds some keybindings to doc-view-mode:

=== modified file 'lisp/doc-view.el'
*** lisp/doc-view.el    2013-09-18 04:38:49 +0000
--- lisp/doc-view.el    2013-09-26 14:10:57 +0000
***************
*** 405,411 ****
--- 405,415 ----
      (define-key map (kbd "RET")       'image-next-line)
      ;; Zoom in/out.
      (define-key map "+"               'doc-view-enlarge)
+     (define-key map "="               'doc-view-enlarge)
+     (define-key map (kbd "C-x C-+")   'doc-view-enlarge)
+     (define-key map (kbd "C-x C-=")   'doc-view-enlarge)
      (define-key map "-"               'doc-view-shrink)
+     (define-key map (kbd "C-x C--")   'doc-view-shrink)
      ;; Fit the image to the window
      (define-key map "W"               'doc-view-fit-width-to-window)
      (define-key map "H"               'doc-view-fit-height-to-window)



-- 
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/

[Message part 3 (message/rfc822, inline)]

From: Tassilo Horn <tsdh <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Xue Fuqiao <xfq.free <at> gmail.com>, 15466-done <at> debbugs.gnu.org
Subject: Re: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode
Date: Thu, 26 Sep 2013 21:08:29 +0200

Tassilo Horn <tsdh <at> gnu.org> writes:

> Yeah
>
>   (define-key map [remap text-scale-adjust] 'doc-view-enlarge)
>   (define-key map (kbd "C-x C--")           'doc-view-shrink)
>
> should be equivalent.  Well, except that C-x C-0 would also enlarge.  It
> wouldn't be bad to have a command to reset to the original size.

I've committed the bindings and added a new command
doc-view-reset-zoom-level in revno 114463 on the trunk.  So now all
text-scaling key bindings work appropriately in doc-view buffers.

I'm closing the bug.

Bye,
Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.