From unknown Sun Jun 15 08:47:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode Resent-From: Xue Fuqiao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2013 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 15466@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs Received: via spool by submit@debbugs.gnu.org id=B.138020491331827 (code B ref -1); Thu, 26 Sep 2013 14:16:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Sep 2013 14:15:13 +0000 Received: from localhost ([127.0.0.1]:37973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPCLY-0008HG-Ou for submit@debbugs.gnu.org; Thu, 26 Sep 2013 10:15:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50966) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPCLW-0008H8-7R for submit@debbugs.gnu.org; Thu, 26 Sep 2013 10:15:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPCLO-0008Nk-6z for submit@debbugs.gnu.org; Thu, 26 Sep 2013 10:15:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCLO-0008La-30 for submit@debbugs.gnu.org; Thu, 26 Sep 2013 10:15:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCLM-0008CJ-Hj for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 10:15:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPCLH-0008Jy-R8 for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 10:15:00 -0400 Received: from mail-ie0-x22e.google.com ([2607:f8b0:4001:c03::22e]:60600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCLH-0008Ju-M9 for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 10:14:55 -0400 Received: by mail-ie0-f174.google.com with SMTP id u16so1409293iet.5 for ; Thu, 26 Sep 2013 07:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=WqhtKlmuAFitZScK8saRj+vdWqK/lUh+abgxGA9V4PM=; b=K5JjRtK4oURrkNpdt8GjuK1sRnBLQhd2gpE0gLXa1bWujtomtQBYjPCaPPlyhYKcRU ZVnVebLB6NZPaUyOmiE/R9alB1dDBYLY4JxRBlIxKV/zmnEv6f7iziV3weDfbYIqLcV8 S+5R7HH0KW9q94TP3nNRUq3JVNudtiYbbjnwUR5dFfvC+u/Jl4xRWFGgdVLV3s2ft+3D 4+ElNCYrOHMH0adrLVVyH1zHX427sBVKLI0G6e2pEtdYANpc6LKAkH3CxPJ6rjcz/M8e y6bdXKCdHCU2r2oFlO6XCHoNcdsnX3N5lzqRTXd9CtkNo0x377DCAHF9M0e3yu/0z2kA maqA== MIME-Version: 1.0 X-Received: by 10.42.63.194 with SMTP id d2mr1406514ici.10.1380204894678; Thu, 26 Sep 2013 07:14:54 -0700 (PDT) Received: by 10.42.133.72 with HTTP; Thu, 26 Sep 2013 07:14:54 -0700 (PDT) Date: Thu, 26 Sep 2013 22:14:54 +0800 Message-ID: From: Xue Fuqiao Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) severity minor tags patch This patch adds some keybindings to doc-view-mode: === modified file 'lisp/doc-view.el' *** lisp/doc-view.el 2013-09-18 04:38:49 +0000 --- lisp/doc-view.el 2013-09-26 14:10:57 +0000 *************** *** 405,411 **** --- 405,415 ---- (define-key map (kbd "RET") 'image-next-line) ;; Zoom in/out. (define-key map "+" 'doc-view-enlarge) + (define-key map "=" 'doc-view-enlarge) + (define-key map (kbd "C-x C-+") 'doc-view-enlarge) + (define-key map (kbd "C-x C-=") 'doc-view-enlarge) (define-key map "-" 'doc-view-shrink) + (define-key map (kbd "C-x C--") 'doc-view-shrink) ;; Fit the image to the window (define-key map "W" 'doc-view-fit-width-to-window) (define-key map "H" 'doc-view-fit-height-to-window) -- Best regards, Xue Fuqiao. http://www.gnu.org/software/emacs/ From unknown Sun Jun 15 08:47:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2013 18:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Xue Fuqiao , Tassilo Horn Cc: 15466@debbugs.gnu.org Received: via spool by 15466-submit@debbugs.gnu.org id=B15466.138021871320460 (code B ref 15466); Thu, 26 Sep 2013 18:06:02 +0000 Received: (at 15466) by debbugs.gnu.org; 26 Sep 2013 18:05:13 +0000 Received: from localhost ([127.0.0.1]:38462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPFw9-0005Jw-0n for submit@debbugs.gnu.org; Thu, 26 Sep 2013 14:05:13 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:33307) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPFw6-0005Jl-Te for 15466@debbugs.gnu.org; Thu, 26 Sep 2013 14:05:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rw/I/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kAYgjwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFG4rw/I/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kAYgjwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="29174868" Received: from 184-175-15-200.dsl.teksavvy.com (HELO pastel.home) ([184.175.15.200]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Sep 2013 14:02:10 -0400 Received: by pastel.home (Postfix, from userid 20848) id ACD7C61E0B; Thu, 26 Sep 2013 14:05:09 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Thu, 26 Sep 2013 14:05:09 -0400 In-Reply-To: (Xue Fuqiao's message of "Thu, 26 Sep 2013 22:14:54 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (define-key map (kbd "RET") 'image-next-line) > ;; Zoom in/out. > (define-key map "+" 'doc-view-enlarge) > + (define-key map "=" 'doc-view-enlarge) > + (define-key map (kbd "C-x C-+") 'doc-view-enlarge) > + (define-key map (kbd "C-x C-=") 'doc-view-enlarge) > (define-key map "-" 'doc-view-shrink) > + (define-key map (kbd "C-x C--") 'doc-view-shrink) > ;; Fit the image to the window > (define-key map "W" 'doc-view-fit-width-to-window) > (define-key map "H" 'doc-view-fit-height-to-window) I think it's OK (unless Tassilo disagrees, obviously), but it needs some comments about why it's added (for the = binding, I guess it's because it's the "unshifted +", which for the other it's to override text-scale-adjust). Also, maybe instead of rebinding C-x C-+, we should remap text-scale-adjust. Stefan From unknown Sun Jun 15 08:47:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2013 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Xue Fuqiao , 15466@debbugs.gnu.org Received: via spool by 15466-submit@debbugs.gnu.org id=B15466.138022069423499 (code B ref 15466); Thu, 26 Sep 2013 18:39:02 +0000 Received: (at 15466) by debbugs.gnu.org; 26 Sep 2013 18:38:14 +0000 Received: from localhost ([127.0.0.1]:38521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPGS2-00066n-O7 for submit@debbugs.gnu.org; Thu, 26 Sep 2013 14:38:14 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:55851) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPGRw-00066G-HD for 15466@debbugs.gnu.org; Thu, 26 Sep 2013 14:38:08 -0400 Received: from compute1.internal (compute1.nyi.mail.srv.osa [10.202.2.41]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id D1C8321E9A; Thu, 26 Sep 2013 14:38:02 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Thu, 26 Sep 2013 14:38:02 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=ttH2iP27jfR3Hd0/l2HvMEaFGFM=; b=oXqrvzOfcuthTlefjVt8Djz2WTyL 6JReapXl0v8GqoWY+Ht1hsldKUawTAWY+M5rs5Q7r7cAo4AEXU5cHDFOeu3OP/CD PFVleNQN7Cf05Z7UfLIUYsX+7tps7gAaug+gXV8gIzxCDj26ufgNNJUEp0NPQGtd R3u3XlBqA8wYtDE= X-Sasl-enc: qegr7oooJuksAJNkLJb5uv0KoVwPcnMD1sR0imq7/rL4 1380220682 Received: from thinkpad.tsdh.org (unknown [91.67.164.26]) by mail.messagingengine.com (Postfix) with ESMTPA id 0FD466800F7; Thu, 26 Sep 2013 14:38:01 -0400 (EDT) From: Tassilo Horn References: Date: Thu, 26 Sep 2013 20:38:00 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 26 Sep 2013 14:05:09 -0400") Message-ID: <87d2nv5szb.fsf@thinkpad.tsdh.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Stefan Monnier writes: >> (define-key map (kbd "RET") 'image-next-line) >> ;; Zoom in/out. >> (define-key map "+" 'doc-view-enlarge) >> + (define-key map "=" 'doc-view-enlarge) >> + (define-key map (kbd "C-x C-+") 'doc-view-enlarge) >> + (define-key map (kbd "C-x C-=") 'doc-view-enlarge) >> (define-key map "-" 'doc-view-shrink) >> + (define-key map (kbd "C-x C--") 'doc-view-shrink) >> ;; Fit the image to the window >> (define-key map "W" 'doc-view-fit-width-to-window) >> (define-key map "H" 'doc-view-fit-height-to-window) > > I think it's OK (unless Tassilo disagrees, obviously), No, it's fine with me. > Also, maybe instead of rebinding C-x C-+, we should remap > text-scale-adjust. Yeah (define-key map [remap text-scale-adjust] 'doc-view-enlarge) (define-key map (kbd "C-x C--") 'doc-view-shrink) should be equivalent. Well, except that C-x C-0 would also enlarge. It wouldn't be bad to have a command to reset to the original size. That shouldn't be hard to do. In the non-ImageMagick case, it's killing the buffer-local value of doc-view-resolution and reconverting, and in the ImageMagick case it's just killing the local value of doc-view-image-width and re-inserting the image with doc-view-insert-image. Bye, Tassilo From unknown Sun Jun 15 08:47:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Xue Fuqiao Subject: bug#15466: closed (Re: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode) Message-ID: References: <878uyj5rki.fsf@thinkpad.tsdh.org> X-Gnu-PR-Message: they-closed 15466 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 15466@debbugs.gnu.org Date: Thu, 26 Sep 2013 19:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1380222542-26245-1" This is a multi-part message in MIME format... ------------=_1380222542-26245-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 15466@debbugs.gnu.org. --=20 15466: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15466 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1380222542-26245-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 15466-done) by debbugs.gnu.org; 26 Sep 2013 19:08:42 +0000 Received: from localhost ([127.0.0.1]:38580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPGvW-0006og-2A for submit@debbugs.gnu.org; Thu, 26 Sep 2013 15:08:41 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:57238) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPGvQ-0006oV-Iv for 15466-done@debbugs.gnu.org; Thu, 26 Sep 2013 15:08:36 -0400 Received: from compute1.internal (compute1.nyi.mail.srv.osa [10.202.2.41]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id CDB5320A1E; Thu, 26 Sep 2013 15:08:31 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 26 Sep 2013 15:08:31 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=0j1wJqKDRlqhDi+Rtn359OFFhCg=; b=sq0w1I4IazM4uUzsPNLs9QKMRgzv TRuKrC1h9v3txaaxbBImW3ndNH11olcEDZ89r3QfikKb5LZTBGQrgOMAWxqo+VhU 4l7S9bnL1CI1IkMH2A98YSXbe+/Tp2JsX2t18qVudwnzXWB40xbzA11FhzP1YqmQ b6/PmddUJTgKIEI= X-Sasl-enc: PYeZr+hI/ylTEQhF13SZgWx9u64nstf4alXBzgXvJrfO 1380222511 Received: from thinkpad.tsdh.org (unknown [91.67.164.26]) by mail.messagingengine.com (Postfix) with ESMTPA id E74A4C00E80; Thu, 26 Sep 2013 15:08:30 -0400 (EDT) From: Tassilo Horn To: Stefan Monnier Subject: Re: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode References: <87d2nv5szb.fsf@thinkpad.tsdh.org> Date: Thu, 26 Sep 2013 21:08:29 +0200 In-Reply-To: <87d2nv5szb.fsf@thinkpad.tsdh.org> (Tassilo Horn's message of "Thu, 26 Sep 2013 20:38:00 +0200") Message-ID: <878uyj5rki.fsf@thinkpad.tsdh.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15466-done Cc: Xue Fuqiao , 15466-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Tassilo Horn writes: > Yeah > > (define-key map [remap text-scale-adjust] 'doc-view-enlarge) > (define-key map (kbd "C-x C--") 'doc-view-shrink) > > should be equivalent. Well, except that C-x C-0 would also enlarge. It > wouldn't be bad to have a command to reset to the original size. I've committed the bindings and added a new command doc-view-reset-zoom-level in revno 114463 on the trunk. So now all text-scaling key bindings work appropriately in doc-view buffers. I'm closing the bug. Bye, Tassilo ------------=_1380222542-26245-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 Sep 2013 14:15:13 +0000 Received: from localhost ([127.0.0.1]:37973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPCLY-0008HG-Ou for submit@debbugs.gnu.org; Thu, 26 Sep 2013 10:15:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50966) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPCLW-0008H8-7R for submit@debbugs.gnu.org; Thu, 26 Sep 2013 10:15:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPCLO-0008Nk-6z for submit@debbugs.gnu.org; Thu, 26 Sep 2013 10:15:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCLO-0008La-30 for submit@debbugs.gnu.org; Thu, 26 Sep 2013 10:15:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCLM-0008CJ-Hj for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 10:15:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VPCLH-0008Jy-R8 for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 10:15:00 -0400 Received: from mail-ie0-x22e.google.com ([2607:f8b0:4001:c03::22e]:60600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VPCLH-0008Ju-M9 for bug-gnu-emacs@gnu.org; Thu, 26 Sep 2013 10:14:55 -0400 Received: by mail-ie0-f174.google.com with SMTP id u16so1409293iet.5 for ; Thu, 26 Sep 2013 07:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=WqhtKlmuAFitZScK8saRj+vdWqK/lUh+abgxGA9V4PM=; b=K5JjRtK4oURrkNpdt8GjuK1sRnBLQhd2gpE0gLXa1bWujtomtQBYjPCaPPlyhYKcRU ZVnVebLB6NZPaUyOmiE/R9alB1dDBYLY4JxRBlIxKV/zmnEv6f7iziV3weDfbYIqLcV8 S+5R7HH0KW9q94TP3nNRUq3JVNudtiYbbjnwUR5dFfvC+u/Jl4xRWFGgdVLV3s2ft+3D 4+ElNCYrOHMH0adrLVVyH1zHX427sBVKLI0G6e2pEtdYANpc6LKAkH3CxPJ6rjcz/M8e y6bdXKCdHCU2r2oFlO6XCHoNcdsnX3N5lzqRTXd9CtkNo0x377DCAHF9M0e3yu/0z2kA maqA== MIME-Version: 1.0 X-Received: by 10.42.63.194 with SMTP id d2mr1406514ici.10.1380204894678; Thu, 26 Sep 2013 07:14:54 -0700 (PDT) Received: by 10.42.133.72 with HTTP; Thu, 26 Sep 2013 07:14:54 -0700 (PDT) Date: Thu, 26 Sep 2013 22:14:54 +0800 Message-ID: Subject: 24.3.50; [PATCH] Add some keybindings for doc-view-mode From: Xue Fuqiao To: bug-gnu-emacs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) severity minor tags patch This patch adds some keybindings to doc-view-mode: === modified file 'lisp/doc-view.el' *** lisp/doc-view.el 2013-09-18 04:38:49 +0000 --- lisp/doc-view.el 2013-09-26 14:10:57 +0000 *************** *** 405,411 **** --- 405,415 ---- (define-key map (kbd "RET") 'image-next-line) ;; Zoom in/out. (define-key map "+" 'doc-view-enlarge) + (define-key map "=" 'doc-view-enlarge) + (define-key map (kbd "C-x C-+") 'doc-view-enlarge) + (define-key map (kbd "C-x C-=") 'doc-view-enlarge) (define-key map "-" 'doc-view-shrink) + (define-key map (kbd "C-x C--") 'doc-view-shrink) ;; Fit the image to the window (define-key map "W" 'doc-view-fit-width-to-window) (define-key map "H" 'doc-view-fit-height-to-window) -- Best regards, Xue Fuqiao. http://www.gnu.org/software/emacs/ ------------=_1380222542-26245-1-- From unknown Sun Jun 15 08:47:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Sep 2013 06:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Xue Fuqiao , 15466-done@debbugs.gnu.org Received: via spool by 15466-done@debbugs.gnu.org id=D15466.138026466331378 (code D ref 15466); Fri, 27 Sep 2013 06:52:02 +0000 Received: (at 15466-done) by debbugs.gnu.org; 27 Sep 2013 06:51:03 +0000 Received: from localhost ([127.0.0.1]:39638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPRtG-00089s-6S for submit@debbugs.gnu.org; Fri, 27 Sep 2013 02:51:02 -0400 Received: from deliver.uni-koblenz.de ([141.26.64.15]:48874) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPRtE-00089b-7U for 15466-done@debbugs.gnu.org; Fri, 27 Sep 2013 02:51:01 -0400 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id CE41D3D6010; Fri, 27 Sep 2013 08:50:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A1lVpsBR6pg4; Fri, 27 Sep 2013 08:50:58 +0200 (CEST) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from thinkpad.tsdh.org (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 7D3FA3D600A; Fri, 27 Sep 2013 08:50:58 +0200 (CEST) From: Tassilo Horn References: <87d2nv5szb.fsf@thinkpad.tsdh.org> <878uyj5rki.fsf@thinkpad.tsdh.org> Date: Fri, 27 Sep 2013 08:50:58 +0200 In-Reply-To: <878uyj5rki.fsf@thinkpad.tsdh.org> (Tassilo Horn's message of "Thu, 26 Sep 2013 21:08:29 +0200") Message-ID: <87fvsq7o6l.fsf@thinkpad.tsdh.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Tassilo Horn writes: >> (define-key map [remap text-scale-adjust] 'doc-view-enlarge) >> (define-key map (kbd "C-x C--") 'doc-view-shrink) >> >> should be equivalent. Well, except that C-x C-0 would also enlarge. It >> wouldn't be bad to have a command to reset to the original size. > > I've committed the bindings and added a new command > doc-view-reset-zoom-level in revno 114463 on the trunk. So now all > text-scaling key bindings work appropriately in doc-view buffers. Of course the above was a bit bogus in case a user has bound text-scale-adjust to something different that C-x C-<+,=,-,0>. So now I've added a new command `doc-view-scale-adjust' that dispatches the action to take by the key binding like `text-scale-adjust' does, and that's now the remapping binding (revno 114464). Bye, Tassilo From unknown Sun Jun 15 08:47:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15466: 24.3.50; [PATCH] Add some keybindings for doc-view-mode Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Sep 2013 13:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15466 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Tassilo Horn Cc: Xue Fuqiao , 15466-done@debbugs.gnu.org Received: via spool by 15466-done@debbugs.gnu.org id=D15466.13802870814183 (code D ref 15466); Fri, 27 Sep 2013 13:05:02 +0000 Received: (at 15466-done) by debbugs.gnu.org; 27 Sep 2013 13:04:41 +0000 Received: from localhost ([127.0.0.1]:40319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPXiq-00015O-J5 for submit@debbugs.gnu.org; Fri, 27 Sep 2013 09:04:40 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:61984) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPXiZ-00014z-Sy for 15466-done@debbugs.gnu.org; Fri, 27 Sep 2013 09:04:37 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rw/I/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFG4rw/I/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="29226370" Received: from 184-175-15-200.dsl.teksavvy.com (HELO pastel.home) ([184.175.15.200]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 27 Sep 2013 09:01:20 -0400 Received: by pastel.home (Postfix, from userid 20848) id 6FC58631A0; Fri, 27 Sep 2013 09:04:22 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87d2nv5szb.fsf@thinkpad.tsdh.org> <878uyj5rki.fsf@thinkpad.tsdh.org> <87fvsq7o6l.fsf@thinkpad.tsdh.org> Date: Fri, 27 Sep 2013 09:04:22 -0400 In-Reply-To: <87fvsq7o6l.fsf@thinkpad.tsdh.org> (Tassilo Horn's message of "Fri, 27 Sep 2013 08:50:58 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Of course the above was a bit bogus in case a user has bound > text-scale-adjust to something different that C-x C-<+,=,-,0>. So now > I've added a new command `doc-view-scale-adjust' that dispatches the > action to take by the key binding like `text-scale-adjust' does, and > that's now the remapping binding (revno 114464). Great, thanks, Stefan