From unknown Sun Jun 22 04:07:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15463: FTBFS c-stack under gcc 4.8 with --enable-gcc-warnings Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-diffutils@gnu.org Resent-Date: Wed, 25 Sep 2013 18:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15463 X-GNU-PR-Package: diffutils X-GNU-PR-Keywords: To: 15463@debbugs.gnu.org, bug-gnulib@gnu.org X-Debbugs-Original-To: bug-diffutils@gnu.org, Bug-gnulib Received: via spool by submit@debbugs.gnu.org id=B.138013209124766 (code B ref -1); Wed, 25 Sep 2013 18:02:01 +0000 Received: (at submit) by debbugs.gnu.org; 25 Sep 2013 18:01:31 +0000 Received: from localhost ([127.0.0.1]:35745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOtOz-0006RM-Qh for submit@debbugs.gnu.org; Wed, 25 Sep 2013 14:01:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50941) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOtOv-0006RC-V1 for submit@debbugs.gnu.org; Wed, 25 Sep 2013 14:01:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOtOq-00080Y-0N for submit@debbugs.gnu.org; Wed, 25 Sep 2013 14:01:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOtOp-00080O-Tl for submit@debbugs.gnu.org; Wed, 25 Sep 2013 14:01:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOtOk-0001jQ-Qz for bug-diffutils@gnu.org; Wed, 25 Sep 2013 14:01:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOtOf-0007tB-1Y for bug-diffutils@gnu.org; Wed, 25 Sep 2013 14:01:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOtOe-0007sJ-QH; Wed, 25 Sep 2013 14:01:08 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8PI1286017799 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Sep 2013 14:01:02 -0400 Received: from [10.3.113.164] (ovpn-113-164.phx2.redhat.com [10.3.113.164]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8PI11bf005435; Wed, 25 Sep 2013 14:01:01 -0400 Message-ID: <524324DD.6040405@redhat.com> Date: Wed, 25 Sep 2013 12:01:01 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 X-Enigmail-Version: 1.5.2 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3lc4c1DbfWhIsejwn3QfwoEhDl84EKxXk" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3lc4c1DbfWhIsejwn3QfwoEhDl84EKxXk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I tried to build diffutils from git on my Fedora 19 machine: $ gcc --version |head -n1 gcc (GCC) 4.8.1 20130603 (Red Hat 4.8.1-1) It's dying inside of gnulib's c-stack: CC c-stack.o c-stack.c: In function 'segv_handler': c-stack.c:163:12: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=3Dsuggest-attribute=3Dp= ure] static int segv_handler (void *address __attribute__ ((unused)), ^ cc1: all warnings being treated as errors I don't know if this is a case of diffutils being too aggressive about the warnings it uses on gnulib files (after all, at least coreutils explicitly uses fewer warnings for gnulib files than for its own), or if it is something we should be fixing in gnulib. More interesting, the function is only pure if DEBUG was not enabled during compilation, so if we do decide to fix it in gnulib, the fix has to use the same condition on whether to apply the attribute. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3lc4c1DbfWhIsejwn3QfwoEhDl84EKxXk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSQyTdAAoJEKeha0olJ0NqR78IAJd3T+vKu3XIGifIjuPBSmTE cMJeZCP35i0LwpMpv34gH65gVNlO1QLxinNMcYCoJ+j5lFlLWga0D0bh8p4J2a32 /SuA1wtL8dnmNKyTnm2nJJHuLNvWl/7+nlQNAAuN3+4y8K9VdkdDgFLSsy7m/NUB Nj4f038M2jnKJE6jVhHh0/U3zSVl95r/RSLUMn0aXPQo0EOf8YIUK5TM3lLRhq/3 jgrfDjJWTz8RWjEfRrzJkTPNS3Rj82GXhbmg65Efx6Il58g3YJ9sCurR0yWMyI4V LF7aCWaDJUMyh5KU2vftGTxUzvyEtY8kEgyCbmszMb2JzN9914jkMwWRmYAF9uk= =cQke -----END PGP SIGNATURE----- --3lc4c1DbfWhIsejwn3QfwoEhDl84EKxXk-- From unknown Sun Jun 22 04:07:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Eric Blake Subject: bug#15463: closed (Re: [bug-diffutils] bug#15463: FTBFS c-stack under gcc 4.8 with --enable-gcc-warnings) Message-ID: References: <52448948.7030703@cs.ucla.edu> <524324DD.6040405@redhat.com> X-Gnu-PR-Message: they-closed 15463 X-Gnu-PR-Package: diffutils Reply-To: 15463@debbugs.gnu.org Date: Thu, 26 Sep 2013 19:22:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1380223323-27395-1" This is a multi-part message in MIME format... ------------=_1380223323-27395-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #15463: FTBFS c-stack under gcc 4.8 with --enable-gcc-warnings which was filed against the diffutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 15463@debbugs.gnu.org. --=20 15463: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15463 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1380223323-27395-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 15463-done) by debbugs.gnu.org; 26 Sep 2013 19:22:01 +0000 Received: from localhost ([127.0.0.1]:38605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPH8O-00077Z-Tu for submit@debbugs.gnu.org; Thu, 26 Sep 2013 15:22:01 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:46505) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPH8J-00077M-A6 for 15463-done@debbugs.gnu.org; Thu, 26 Sep 2013 15:21:55 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 4045039E8008; Thu, 26 Sep 2013 12:21:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AhoI4hzcsHl8; Thu, 26 Sep 2013 12:21:45 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 2AE3D39E810F; Thu, 26 Sep 2013 12:21:45 -0700 (PDT) Message-ID: <52448948.7030703@cs.ucla.edu> Date: Thu, 26 Sep 2013 12:21:44 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: Eric Blake Subject: Re: [bug-diffutils] bug#15463: FTBFS c-stack under gcc 4.8 with --enable-gcc-warnings References: <524324DD.6040405@redhat.com> In-Reply-To: <524324DD.6040405@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: 15463-done Cc: 15463-done@debbugs.gnu.org, bug-gnulib@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.7 (----) On 09/25/13 11:01, Eric Blake wrote: > I don't know if this is a case of diffutils being too aggressive about > the warnings it uses on gnulib files Yes, that sounds good enough. I pushed this into diffutils: >From 1d69c1591812101e2dffa64c45e2f1c3c901fadc Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 26 Sep 2013 12:20:00 -0700 Subject: [PATCH] build: omit -Wsuggest-attribute=pure for lib * configure.ac (WARN_CFLAGS): Omit -Wsuggest-attribute=pure when compiling the lib subdirectory. Reported for Fedora 19 by Eric Blake in . --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 90bebc9..f7efcb1 100644 --- a/configure.ac +++ b/configure.ac @@ -123,6 +123,7 @@ if test "$gl_gcc_warnings" = yes; then nw="$nw -Wunused-macros" nw="$nw -Wmissing-prototypes" nw="$nw -Wold-style-definition" + nw="$nw -Wsuggest-attribute=pure" gl_MANYWARN_COMPLEMENT([GNULIB_WARN_CFLAGS], [$WARN_CFLAGS], [$nw]) AC_SUBST([GNULIB_WARN_CFLAGS]) fi -- 1.8.3.1 ------------=_1380223323-27395-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Sep 2013 18:01:31 +0000 Received: from localhost ([127.0.0.1]:35745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOtOz-0006RM-Qh for submit@debbugs.gnu.org; Wed, 25 Sep 2013 14:01:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50941) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOtOv-0006RC-V1 for submit@debbugs.gnu.org; Wed, 25 Sep 2013 14:01:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOtOq-00080Y-0N for submit@debbugs.gnu.org; Wed, 25 Sep 2013 14:01:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56054) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOtOp-00080O-Tl for submit@debbugs.gnu.org; Wed, 25 Sep 2013 14:01:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOtOk-0001jQ-Qz for bug-diffutils@gnu.org; Wed, 25 Sep 2013 14:01:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOtOf-0007tB-1Y for bug-diffutils@gnu.org; Wed, 25 Sep 2013 14:01:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOtOe-0007sJ-QH; Wed, 25 Sep 2013 14:01:08 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8PI1286017799 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Sep 2013 14:01:02 -0400 Received: from [10.3.113.164] (ovpn-113-164.phx2.redhat.com [10.3.113.164]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r8PI11bf005435; Wed, 25 Sep 2013 14:01:01 -0400 Message-ID: <524324DD.6040405@redhat.com> Date: Wed, 25 Sep 2013 12:01:01 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 MIME-Version: 1.0 To: bug-diffutils@gnu.org, Bug-gnulib Subject: FTBFS c-stack under gcc 4.8 with --enable-gcc-warnings X-Enigmail-Version: 1.5.2 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3lc4c1DbfWhIsejwn3QfwoEhDl84EKxXk" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3lc4c1DbfWhIsejwn3QfwoEhDl84EKxXk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I tried to build diffutils from git on my Fedora 19 machine: $ gcc --version |head -n1 gcc (GCC) 4.8.1 20130603 (Red Hat 4.8.1-1) It's dying inside of gnulib's c-stack: CC c-stack.o c-stack.c: In function 'segv_handler': c-stack.c:163:12: error: function might be candidate for attribute 'pure' if it is known to return normally [-Werror=3Dsuggest-attribute=3Dp= ure] static int segv_handler (void *address __attribute__ ((unused)), ^ cc1: all warnings being treated as errors I don't know if this is a case of diffutils being too aggressive about the warnings it uses on gnulib files (after all, at least coreutils explicitly uses fewer warnings for gnulib files than for its own), or if it is something we should be fixing in gnulib. More interesting, the function is only pure if DEBUG was not enabled during compilation, so if we do decide to fix it in gnulib, the fix has to use the same condition on whether to apply the attribute. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3lc4c1DbfWhIsejwn3QfwoEhDl84EKxXk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSQyTdAAoJEKeha0olJ0NqR78IAJd3T+vKu3XIGifIjuPBSmTE cMJeZCP35i0LwpMpv34gH65gVNlO1QLxinNMcYCoJ+j5lFlLWga0D0bh8p4J2a32 /SuA1wtL8dnmNKyTnm2nJJHuLNvWl/7+nlQNAAuN3+4y8K9VdkdDgFLSsy7m/NUB Nj4f038M2jnKJE6jVhHh0/U3zSVl95r/RSLUMn0aXPQo0EOf8YIUK5TM3lLRhq/3 jgrfDjJWTz8RWjEfRrzJkTPNS3Rj82GXhbmg65Efx6Il58g3YJ9sCurR0yWMyI4V LF7aCWaDJUMyh5KU2vftGTxUzvyEtY8kEgyCbmszMb2JzN9914jkMwWRmYAF9uk= =cQke -----END PGP SIGNATURE----- --3lc4c1DbfWhIsejwn3QfwoEhDl84EKxXk-- ------------=_1380223323-27395-1--