From unknown Thu Jun 19 14:04:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15460: 24.3; [PATCH] rename lookup-words to ispell-lookup-words Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Sep 2013 05:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15460 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 15460@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138008604315224 (code B ref -1); Wed, 25 Sep 2013 05:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Sep 2013 05:14:03 +0000 Received: from localhost ([127.0.0.1]:33966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOhQI-0003xT-Ip for submit@debbugs.gnu.org; Wed, 25 Sep 2013 01:14:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59392) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOhQG-0003wx-NO for submit@debbugs.gnu.org; Wed, 25 Sep 2013 01:14:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOhQ8-0002d2-0P for submit@debbugs.gnu.org; Wed, 25 Sep 2013 01:14:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOhQ7-0002cy-TX for submit@debbugs.gnu.org; Wed, 25 Sep 2013 01:13:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOhPz-0006vE-Ez for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 01:13:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOhPr-0002cP-0I for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 01:13:43 -0400 Received: from mail-pb0-x22c.google.com ([2607:f8b0:400e:c01::22c]:56410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOhPq-0002cL-Oe for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 01:13:34 -0400 Received: by mail-pb0-f44.google.com with SMTP id xa7so5531506pbc.31 for ; Tue, 24 Sep 2013 22:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=DOG/droaXtHpV4Z1kVvthQK0Q/GtDYbrCUOKT9an83k=; b=iRlq+Pq0VPxwtJ91pW+knOgKuGjKYnwY+OCTzeb2c3yhrws2uesaexod+eXYAXCoMX x9awhb3KeMvz0abyNZF7KCe5tbLDL/WA5qbdTowSVnVylS90HohZSkah64vmf78yQjan mKZKU40IxnleckUIbKnNi3gXBBrsbadT/mUu083wNgjWkOGhFE8Ck8+FfiT/tfKotdvz VVUy0BGwkLtCsrRiFHQsnpTAiCPJm5Rk16uwYojsu0baLGZNsH7aicVG35nNYXsoYA94 aJm9CUGZkijmeTMITXA/xeAc21jZg/t1dK0UMgaIQqNFVkd3jQIGIla6Ii0KHqfVbHUo 4Azg== X-Received: by 10.68.182.3 with SMTP id ea3mr15417066pbc.124.1380086013386; Tue, 24 Sep 2013 22:13:33 -0700 (PDT) Received: from localhost ([123.115.251.172]) by mx.google.com with ESMTPSA id ha10sm44838196pbc.23.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 24 Sep 2013 22:13:32 -0700 (PDT) From: Leo Liu Date: Wed, 25 Sep 2013 13:13:28 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Any objection to renaming lookup-words? === modified file 'lisp/cedet/semantic/texi.el' --- lisp/cedet/semantic/texi.el 2013-01-01 09:11:05 +0000 +++ lisp/cedet/semantic/texi.el 2013-09-25 05:09:43 +0000 @@ -32,7 +32,7 @@ (require 'texinfo) (defvar ede-minor-mode) -(declare-function lookup-words "ispell") +(declare-function ispell-lookup-words "ispell") (declare-function ede-current-project "ede") (defvar semantic-texi-super-regex @@ -431,7 +431,7 @@ ((member 'word (oref context :prefixclass)) ;; Do completion for words via ispell. (require 'ispell) - (let ((word-list (lookup-words prefix))) + (let ((word-list (ispell-lookup-words prefix))) (mapcar (lambda (f) (semantic-tag f 'word)) word-list)) ) (t nil)) === modified file 'lisp/textmodes/ispell.el' --- lisp/textmodes/ispell.el 2013-08-05 14:26:57 +0000 +++ lisp/textmodes/ispell.el 2013-09-25 05:11:28 +0000 @@ -2407,7 +2407,7 @@ " -- word-list: " (or ispell-complete-word-dict ispell-alternate-dictionary)) - miss (lookup-words new-word) + miss (ispell-lookup-words new-word) choices miss line ispell-choices-win-default-height) (while (and choices ; adjust choices window. @@ -2614,7 +2614,7 @@ (erase-buffer))))))) -(defun lookup-words (word &optional lookup-dict) +(defun ispell-lookup-words (word &optional lookup-dict) "Look up WORD in optional word-list dictionary LOOKUP-DICT. A `*' serves as a wild card. If no wild cards, `look' is used if it exists. Otherwise the variable `ispell-grep-command' contains the command used to @@ -3766,7 +3766,7 @@ ;;;###autoload (defun ispell-complete-word (&optional interior-frag) - "Try to complete the word before or under point (see `lookup-words'). + "Try to complete the word before or under point. If optional INTERIOR-FRAG is non-nil then the word may be a character sequence inside of a word. @@ -3782,11 +3782,12 @@ word (car word) possibilities (or (string= word "") ; Will give you every word - (lookup-words (concat (and interior-frag "*") word - (if (or interior-frag (null ispell-look-p)) - "*")) - (or ispell-complete-word-dict - ispell-alternate-dictionary)))) + (ispell-lookup-words + (concat (and interior-frag "*") word + (if (or interior-frag (null ispell-look-p)) + "*")) + (or ispell-complete-word-dict + ispell-alternate-dictionary)))) (cond ((eq possibilities t) (message "No word to complete")) ((null possibilities) From unknown Thu Jun 19 14:04:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Liu Subject: bug#15460: closed (Re: bug#15460: 24.3; [PATCH] rename lookup-words to ispell-lookup-words) Message-ID: References: X-Gnu-PR-Message: they-closed 15460 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 15460@debbugs.gnu.org Date: Sat, 28 Sep 2013 02:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1380337022-14319-1" This is a multi-part message in MIME format... ------------=_1380337022-14319-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #15460: 24.3; [PATCH] rename lookup-words to ispell-lookup-words which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 15460@debbugs.gnu.org. --=20 15460: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15460 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1380337022-14319-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 15460-done) by debbugs.gnu.org; 28 Sep 2013 02:56:45 +0000 Received: from localhost ([127.0.0.1]:41920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPki4-0003iR-CT for submit@debbugs.gnu.org; Fri, 27 Sep 2013 22:56:44 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:44278) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VPki2-0003iJ-9K for 15460-done@debbugs.gnu.org; Fri, 27 Sep 2013 22:56:43 -0400 Received: by mail-pd0-f170.google.com with SMTP id x10so3371911pdj.1 for <15460-done@debbugs.gnu.org>; Fri, 27 Sep 2013 19:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=TjEP2FoPC4iOkV/qF8/vT3h7pxvHal927OE9qLUXQCE=; b=abswwYi6HaB3W0qrUaoWmNB56d92BxWf30T6nhklFlJY4C6+GclVizo+bC7pic3sFW LWKoBz78sL/+Iey8JrqMSDQbrJl3gbmcOBhBnEg7AgMS2rgDk3Fsq0jdQn09VkW7AJXK Y8H2DUBcbF8/pqyAG+bH+jxUi6jJEfSHGrHe1cXfv2q6PnsRLnDjErfiTba93RlIiM9m UVMkO3k56N9fbxwWth2w2cNQBdz1EciUB57ihY51yBH28OLH0fra2Jskpx1a2yKAh3iT BTLDRP5NSs3inpOdR0gR+G/ZnEAIY1VShMSlCDfdq7G+oAD5GApXcx29TOUFG9oRFqgI kBqQ== X-Received: by 10.66.250.138 with SMTP id zc10mr15325692pac.72.1380337001285; Fri, 27 Sep 2013 19:56:41 -0700 (PDT) Received: from localhost ([221.222.144.23]) by mx.google.com with ESMTPSA id yg3sm16139898pab.16.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 27 Sep 2013 19:56:40 -0700 (PDT) From: Leo Liu To: 15460-done@debbugs.gnu.org Subject: Re: bug#15460: 24.3; [PATCH] rename lookup-words to ispell-lookup-words References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Sat, 28 Sep 2013 10:56:41 +0800 In-Reply-To: (Leo Liu's message of "Wed, 25 Sep 2013 13:13:28 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.5) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15460-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Fixed in Emacs 24.4 ------------=_1380337022-14319-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Sep 2013 05:14:03 +0000 Received: from localhost ([127.0.0.1]:33966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOhQI-0003xT-Ip for submit@debbugs.gnu.org; Wed, 25 Sep 2013 01:14:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59392) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOhQG-0003wx-NO for submit@debbugs.gnu.org; Wed, 25 Sep 2013 01:14:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOhQ8-0002d2-0P for submit@debbugs.gnu.org; Wed, 25 Sep 2013 01:14:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56519) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOhQ7-0002cy-TX for submit@debbugs.gnu.org; Wed, 25 Sep 2013 01:13:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOhPz-0006vE-Ez for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 01:13:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VOhPr-0002cP-0I for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 01:13:43 -0400 Received: from mail-pb0-x22c.google.com ([2607:f8b0:400e:c01::22c]:56410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VOhPq-0002cL-Oe for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2013 01:13:34 -0400 Received: by mail-pb0-f44.google.com with SMTP id xa7so5531506pbc.31 for ; Tue, 24 Sep 2013 22:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=DOG/droaXtHpV4Z1kVvthQK0Q/GtDYbrCUOKT9an83k=; b=iRlq+Pq0VPxwtJ91pW+knOgKuGjKYnwY+OCTzeb2c3yhrws2uesaexod+eXYAXCoMX x9awhb3KeMvz0abyNZF7KCe5tbLDL/WA5qbdTowSVnVylS90HohZSkah64vmf78yQjan mKZKU40IxnleckUIbKnNi3gXBBrsbadT/mUu083wNgjWkOGhFE8Ck8+FfiT/tfKotdvz VVUy0BGwkLtCsrRiFHQsnpTAiCPJm5Rk16uwYojsu0baLGZNsH7aicVG35nNYXsoYA94 aJm9CUGZkijmeTMITXA/xeAc21jZg/t1dK0UMgaIQqNFVkd3jQIGIla6Ii0KHqfVbHUo 4Azg== X-Received: by 10.68.182.3 with SMTP id ea3mr15417066pbc.124.1380086013386; Tue, 24 Sep 2013 22:13:33 -0700 (PDT) Received: from localhost ([123.115.251.172]) by mx.google.com with ESMTPSA id ha10sm44838196pbc.23.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 24 Sep 2013 22:13:32 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.3; [PATCH] rename lookup-words to ispell-lookup-words Date: Wed, 25 Sep 2013 13:13:28 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Any objection to renaming lookup-words? === modified file 'lisp/cedet/semantic/texi.el' --- lisp/cedet/semantic/texi.el 2013-01-01 09:11:05 +0000 +++ lisp/cedet/semantic/texi.el 2013-09-25 05:09:43 +0000 @@ -32,7 +32,7 @@ (require 'texinfo) (defvar ede-minor-mode) -(declare-function lookup-words "ispell") +(declare-function ispell-lookup-words "ispell") (declare-function ede-current-project "ede") (defvar semantic-texi-super-regex @@ -431,7 +431,7 @@ ((member 'word (oref context :prefixclass)) ;; Do completion for words via ispell. (require 'ispell) - (let ((word-list (lookup-words prefix))) + (let ((word-list (ispell-lookup-words prefix))) (mapcar (lambda (f) (semantic-tag f 'word)) word-list)) ) (t nil)) === modified file 'lisp/textmodes/ispell.el' --- lisp/textmodes/ispell.el 2013-08-05 14:26:57 +0000 +++ lisp/textmodes/ispell.el 2013-09-25 05:11:28 +0000 @@ -2407,7 +2407,7 @@ " -- word-list: " (or ispell-complete-word-dict ispell-alternate-dictionary)) - miss (lookup-words new-word) + miss (ispell-lookup-words new-word) choices miss line ispell-choices-win-default-height) (while (and choices ; adjust choices window. @@ -2614,7 +2614,7 @@ (erase-buffer))))))) -(defun lookup-words (word &optional lookup-dict) +(defun ispell-lookup-words (word &optional lookup-dict) "Look up WORD in optional word-list dictionary LOOKUP-DICT. A `*' serves as a wild card. If no wild cards, `look' is used if it exists. Otherwise the variable `ispell-grep-command' contains the command used to @@ -3766,7 +3766,7 @@ ;;;###autoload (defun ispell-complete-word (&optional interior-frag) - "Try to complete the word before or under point (see `lookup-words'). + "Try to complete the word before or under point. If optional INTERIOR-FRAG is non-nil then the word may be a character sequence inside of a word. @@ -3782,11 +3782,12 @@ word (car word) possibilities (or (string= word "") ; Will give you every word - (lookup-words (concat (and interior-frag "*") word - (if (or interior-frag (null ispell-look-p)) - "*")) - (or ispell-complete-word-dict - ispell-alternate-dictionary)))) + (ispell-lookup-words + (concat (and interior-frag "*") word + (if (or interior-frag (null ispell-look-p)) + "*")) + (or ispell-complete-word-dict + ispell-alternate-dictionary)))) (cond ((eq possibilities t) (message "No word to complete")) ((null possibilities) ------------=_1380337022-14319-1--