GNU bug report logs - #15443
hs-forward-sexp design issue

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15443 in the body.
You can then email your comments to 15443 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: bug-gnu-emacs <at> gnu.org
Subject: hs-forward-sexp design issue
Date: Mon, 23 Sep 2013 13:10:49 +0200

hs-forward-sexp insists to be called with an argument

    (funcall hs-forward-sexp-func arg)))


That way it's not possible to instrument hs-forward-sexp-func just saying

(search-forward "something")

Instead

(lambda (arg)(search-forward "something"))

would be required.

As it's a function to be set by modes/users

life will be easier if this argument is optional.

Thanks!

Message #8 received at 15443 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 15443 <at> debbugs.gnu.org
Subject: Re: bug#15443: hs-forward-sexp design issue
Date: Mon, 23 Sep 2013 13:33:14 +0200

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:

> hs-forward-sexp insists to be called with an argument
>
>     (funcall hs-forward-sexp-func arg)))
>
>
> That way it's not possible to instrument hs-forward-sexp-func just saying
>
> (search-forward "something")

This is not a function, so what are you trying to do?

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab <at> suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Message #11 received at 15443 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: Andreas Schwab <schwab <at> suse.de>
Cc: 15443 <at> debbugs.gnu.org
Subject: Re: bug#15443: hs-forward-sexp design issue
Date: Mon, 23 Sep 2013 15:13:58 +0200

Am 23.09.2013 13:33, schrieb Andreas Schwab:
> Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:
>
>> hs-forward-sexp insists to be called with an argument
>>
>>      (funcall hs-forward-sexp-func arg)))
>>
>>
>> That way it's not possible to instrument hs-forward-sexp-func just saying
>>
>> (search-forward "something")
>
> This is not a function, so what are you trying to do?
>
> Andreas.
>

Did you look into the code in quesition?


hs-hide-block-at-point

calls

(hs-forward-sexp mdata 1)

with an hardcoded second argument "1"

And here the code of

(defun hs-forward-sexp (match-data arg)
  "Adjust point based on MATCH-DATA and call `hs-forward-sexp-func' w/ ARG.
Original match data is restored upon return."
  (save-match-data
    (set-match-data match-data)
    (goto-char (match-beginning hs-block-start-mdata-select))
    (funcall hs-forward-sexp-func arg)))


While hs-forward-sexp-func is to be set by mode/user

it will always be called with "1" as first argument.

Can't see any reason for this.

Message #14 received at 15443 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 15443 <at> debbugs.gnu.org
Subject: Re: bug#15443: hs-forward-sexp design issue
Date: Mon, 23 Sep 2013 15:16:13 +0200

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:

> Am 23.09.2013 13:33, schrieb Andreas Schwab:
>> Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:
>>
>>> hs-forward-sexp insists to be called with an argument
>>>
>>>      (funcall hs-forward-sexp-func arg)))
>>>
>>>
>>> That way it's not possible to instrument hs-forward-sexp-func just saying
>>>
>>> (search-forward "something")
>>
>> This is not a function, so what are you trying to do?
>>
>> Andreas.
>>
>
> Did you look into the code in quesition?

How is that relevant for my question?

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab <at> suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Message #19 received at 15443 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Cc: 15443 <at> debbugs.gnu.org
Subject: Re: bug#15443: hs-forward-sexp design issue
Date: Sat, 26 Dec 2015 01:59:51 +0100

Andreas Röhler <andreas.roehler <at> easy-emacs.de> writes:

> hs-forward-sexp insists to be called with an argument
>
>     (funcall hs-forward-sexp-func arg)))
>
> That way it's not possible to instrument hs-forward-sexp-func just saying
>
> (search-forward "something")
>
> Instead
>
> (lambda (arg)(search-forward "something"))
>
> would be required.
>
> As it's a function to be set by modes/users
>
> life will be easier if this argument is optional.

The argument has to be a function -- it can't just be a form.  That
would be very odd.  So I don't think there's anything to do here, and
I'm closing the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.