GNU bug report logs - #15441
[PATCH] tests: ensure neither \s nor \S matches an invalid multibyte character

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15441 in the body.
You can then email your comments to 15441 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: bug-grep <at> gnu.org
Subject: [PATCH] tests: ensure neither \s nor \S matches an invalid multibyte
 character
Date: Sun, 22 Sep 2013 22:18:48 -0700

[Message part 1 (text/plain, inline)]

Here's a test for the original problem, which is also fixed by the
preceding patch:

[0004-tests-ensure-neither-s-nor-S-matches-an-invalid-mult.patch (application/octet-stream, attachment)]

Message #8 received at 15441 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 15441 <at> debbugs.gnu.org
Subject: Re: bug#15441: [PATCH] tests: ensure neither \s nor \S matches an
 invalid multibyte character
Date: Mon, 23 Sep 2013 14:26:12 +0100

Hi Jim.

On 09/23/2013 06:18 AM, Jim Meyering wrote:
> Here's a test for the original problem, which is also fixed by the
> preceding patch:
>
> ...
>
>+grep '^\S$' in > out-S && fail=1
> +compare /dev/null out-S || exit=1
>
Shouldn't this be "|| fail=1"?

> +grep '^\s$' in > out-s && fail=1
> +compare /dev/null out-s || exit=1
>
Ditto.

Regards,
  Stefano

Message #11 received at 15441 <at> debbugs.gnu.org (full text, mbox):

From: Joseph Mingrone <jrm <at> ftfl.ca>
To: Aidan Gauland <aidalgol <at> no8wireless.co.nz>
Cc: Glenn Morris <rgm <at> gnu.org>, 15441 <at> debbugs.gnu.org
Subject: Re: bug#15414: 24.3; piping problems in eshell
Date: Mon, 23 Sep 2013 13:10:52 -0300

Hello;

Aidan Gauland <aidalgol <at> no8wireless.co.nz> writes:
> I can not reproduce this on my system (Debian 7.1 x86_64).  Which OS are
> you running?

I originally stumbled upon the problem running 24.3 on FreeBSD 9.  I also
tested on a couple of GNU/Linux systems and things worked as expected,
but the problem exists on OS X.  I'm not sure of the OS version here, I just have
a shell account, but uname -a says Darwin Kernel Version 10.8.0)

Message #14 received at 15441 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 15441 <at> debbugs.gnu.org
Subject: Re: bug#15441: [PATCH] tests: ensure neither \s nor \S matches an
 invalid multibyte character
Date: Mon, 23 Sep 2013 10:43:49 -0700

On Mon, Sep 23, 2013 at 6:26 AM, Stefano Lattarini
<stefano.lattarini <at> gmail.com> wrote:
> Hi Jim.
>
> On 09/23/2013 06:18 AM, Jim Meyering wrote:
>>
>> Here's a test for the original problem, which is also fixed by the
>> preceding patch:
>>
>> ...
>
>>
>>
>> +grep '^\S$' in > out-S && fail=1
>
>> +compare /dev/null out-S || exit=1
>>
> Shouldn't this be "|| fail=1"?
>
>> +grep '^\s$' in > out-s && fail=1
>> +compare /dev/null out-s || exit=1

Yes, there are two typos there, which I'll fix by s/exit/fail/
(actually I saw it as I typed, and fixed one or two, but forgot to fix
the others -- good catch!).
Thanks for the review!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.