GNU bug report logs - #15430
24.3; ido-completing-read is not a replacement for completing-read

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15430 in the body.
You can then email your comments to 15430 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; ido-completing-read is not a replacement for completing-read
Date: Sat, 21 Sep 2013 00:44:54 -0400

Starting from emacs -Q -nw --eval "(setq completing-read-function
#'ido-completing-read)"

Then M-x gives
ido-set-matches: Wrong type argument: listp, [gnus-put-display-table
message-check-news-body-syntax gnus-make-overlay ido-save-history
message-check-element qp-or-base64 message-insert-wide-reply
help-xref-url-regexp ido-word-matching-substring gnus-set-file-modes
...]

I gather from http://thread.gmane.org/gmane.emacs.devel/134000 that
ido-completing-read is supposed to be wrapped, but there should at
least be some indication of this in the docstring. It certainly
shouldn't claim to be the "Ido replacement for the built-in
`completing-read'."


In GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, X toolkit)
 of 2013-08-23 on localhost
Configured using:
 `configure '-C' '--with-x-toolkit=lucid'
 '--without-toolkit-scroll-bars' '--with-gif=no' 'CFLAGS=-O2
 -march=native''

Message #8 received at 15430 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 15430 <at> debbugs.gnu.org
Subject: Re: bug#15430: 24.3;
 ido-completing-read is not a replacement for completing-read
Date: Sat, 21 Sep 2013 15:19:28 +0800

On 2013-09-21 12:44 +0800, Noam Postavsky wrote:
> Starting from emacs -Q -nw --eval "(setq completing-read-function
> #'ido-completing-read)"
>
> Then M-x gives
> ido-set-matches: Wrong type argument: listp, [gnus-put-display-table
> message-check-news-body-syntax gnus-make-overlay ido-save-history
> message-check-element qp-or-base64 message-insert-wide-reply
> help-xref-url-regexp ido-word-matching-substring gnus-set-file-modes
> ...]

ido-completing-read only accepts a list of strings. At the moment you
have to do the conversion yourself.

Leo

Message #13 received at 15430-done <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: 15430-done <at> debbugs.gnu.org
Subject: Re: bug#15430: 24.3;
 ido-completing-read is not a replacement for completing-read
Date: Sun, 7 Dec 2014 11:21:43 -0500

I probably shouldn't have read "replacement for" as "perfect
replacement for". The docstrings do explain the different type
requirements, so there is no need to keep this open.

Note: for an actual ido completing-read-function see ido-ubiquitous.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.