From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 10:17:16 2013 Received: (at submit) by debbugs.gnu.org; 19 Sep 2013 14:17:16 +0000 Received: from localhost ([127.0.0.1]:49232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMf2f-0001e6-Dc for submit@debbugs.gnu.org; Thu, 19 Sep 2013 10:17:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41286) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMf2c-0001do-Ap for submit@debbugs.gnu.org; Thu, 19 Sep 2013 10:17:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMf2V-0003XE-4E for submit@debbugs.gnu.org; Thu, 19 Sep 2013 10:17:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMf2V-0003X4-0g for submit@debbugs.gnu.org; Thu, 19 Sep 2013 10:17:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42991) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMf2P-00019e-KO for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:17:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMf2J-0003Ng-OQ for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:16:57 -0400 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:58643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMf2J-0003NR-D2 for bug-gnu-emacs@gnu.org; Thu, 19 Sep 2013 10:16:51 -0400 Received: by mail-ea0-f180.google.com with SMTP id h10so4152435eaj.25 for ; Thu, 19 Sep 2013 07:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=0uEQdoBy2xxOXHz23FQIGyt17K3F3M1sP6uATg0tb9k=; b=diRnpy8O6SQTlODkoUxHg2LFHzhNxzC8SS64gY19hL4+wWthwIzEO8qoPCEvetWgdG OfmXH8iFGyUPsgjeYBXTbwAGuwfRvVKdvkmswRAKJrp44zLMpCPyGrRqK0xyGLdok/jq MIdBZ3f71EGur5GVrAsyK1+P3rpzHUamwxbh6/BbjgvFQZgmPyrEsyIN3xHlQPgy1/Hv EC+3bFG4A7+P8/sSFvXtZTSnja9UJSKeOq5zhofuxmnAwMV/CWvaY7qaXf8SAabtmnYD nBbNJMhRx6q9sqWK/uEGvoFyp2TimBQHit1SO19jUmzODvbsc9JkX7FKM0MxJsBpIkkE imYA== MIME-Version: 1.0 X-Received: by 10.15.45.135 with SMTP id b7mr67450eew.135.1379600209908; Thu, 19 Sep 2013 07:16:49 -0700 (PDT) Received: by 10.14.152.132 with HTTP; Thu, 19 Sep 2013 07:16:49 -0700 (PDT) Date: Thu, 19 Sep 2013 15:16:49 +0100 Message-ID: Subject: 24.3.50; RCS annotate broken in vc-rcs.el r114131 From: Richard Copley To: "bug-gnu-emacs@gnu.org" Content-Type: multipart/alternative; boundary=089e0160bc9471ba8804e6bd3414 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e0160bc9471ba8804e6bd3414 Content-Type: text/plain; charset=ISO-8859-1 For some files under RCS version control, `vc-annotate' now fails with error `(wrong-type-argument integer-or-marker-p nil)'. I think the problem is with the variable `b' whose dynamic binding was used by `gather' and set by `incg' (local functions in `vc-rcs-parse'), prior to r114131. Sorry, I haven't been able to craft an example RCS master file that reproduces the problem. The top of the stack trace looks like this. Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil) buffer-substring-no-properties(nil 6747) (let ((x (buffer-substring-no-properties (cadr pairs) (car pairs)))) (message "%d %d %s" (cadr pairs) (car pairs) x) (setq acc (cons x acc))) (while pairs (let ((x (buffer-substring-no-properties (cadr pairs) (car pairs)))) (message "%d %d %s" (cadr pairs) (car pairs) x) (setq acc (cons x acc))) (setq pairs (cddr pairs))) (let ((pairs (cons e (append @-holes (list b)))) acc) (while pairs (let ((x (buffer-substring-no-properties (cadr pairs) (car pairs)))) (message "%d %d %s" (cadr pairs) (car pairs) x) (setq acc (cons x acc))) (setq pairs (cddr pairs))) (apply (quote concat) acc)) In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-09-19 on 57172UHB Bzr revision: 114395 michael.albinus@gmx.de-20130919110801-tl6ne4cxp0bmx0kf Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix c:/emacs/emacs-114395 --enable-locallisppath=%emacs_dir%/../site-lisp 'CPPFLAGS=-I G:/usr/include -I C:/GnuWin32/include' 'LDFLAGS=-L G:/usr/lib -L C:/GnuWin32/lib'' Important settings: value of $LANG: ENG locale-coding-system: cp1252 default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x r - e - b Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32notify w32 multi-tty emacs) --089e0160bc9471ba8804e6bd3414 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
For some files under RCS version control, `vc-annotate'= ; now fails with
error `(wrong-type-argument integer-or-marker-p nil)= 9;.

I think the problem is with the variable `b' whose dynamic b= inding
was used by `gather' and set by `incg' (local functions in
`vc-= rcs-parse'), prior to r114131.

Sorry, I haven't been able to= craft an example RCS master file that
reproduces the problem. The top o= f the stack trace looks like this.

Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p = nil)
=A0 buffer-substring-no-properties(nil 6747)
=A0 (let ((x (buffe= r-substring-no-properties (cadr pairs) (car pairs)))) (message "%d %d = %s" (cadr pairs) (car pairs) x) (setq acc (cons x acc)))
=A0 (while pairs (let ((x (buffer-substring-no-properties (cadr pairs) (car= pairs)))) (message "%d %d %s" (cadr pairs) (car pairs) x) (setq = acc (cons x acc))) (setq pairs (cddr pairs)))
=A0 (let ((pairs (cons e (= append @-holes (list b)))) acc) (while pairs (let ((x (buffer-substring-no-= properties (cadr pairs) (car pairs)))) (message "%d %d %s" (cadr = pairs) (car pairs) x) (setq acc (cons x acc))) (setq pairs (cddr pairs))) (= apply (quote concat) acc))


In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
=A0of 2013-09-19 on 571= 72UHB
Bzr revision: 114395 michael.albinus@gmx.de-20130919110801-tl6ne4c= xp0bmx0kf
Windowing system distributor `Microsoft Corp.', version 6.= 1.7601
Configured using:
=A0`configure --prefix c:/emacs/emacs-114395
=A0--e= nable-locallisppath=3D%emacs_dir%/../site-lisp 'CPPFLAGS=3D-I
=A0G:/= usr/include -I C:/GnuWin32/include' 'LDFLAGS=3D-L G:/usr/lib -L
= =A0C:/GnuWin32/lib''

Important settings:
=A0 value of $LANG: ENG
=A0 locale-coding-sys= tem: cp1252
=A0 default enable-multibyte-characters: t

Major mode= : Lisp Interaction

Minor modes in effect:
=A0 tooltip-mode: t
= =A0 mouse-wheel-mode: t
=A0 tool-bar-mode: t
=A0 menu-bar-mode: t
=A0 file-name-shadow-mode: = t
=A0 global-font-lock-mode: t
=A0 font-lock-mode: t
=A0 blink-cur= sor-mode: t
=A0 auto-composition-mode: t
=A0 auto-encryption-mode: t<= br>=A0 auto-compression-mode: t
=A0 line-number-mode: t
=A0 transient-mark-mode: t

Recent input:<= br>M-x r - e - b <return>

Recent messages:
For information = about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:=
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug m= essage format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-en= code mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047= rfc2045 ietf-drums
mm-util mail-prsvr mail-utils time-date tooltip ediff-hook vc-hooks
lisp= -float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win
w32= -vars tool-bar dnd fontset image regexp-opt fringe tabulated-list
newcom= ment lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
fra= me cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet l= ao korean japanese hebrew greek romanian slovak czech european
ethiopic = indian cyrillic chinese case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexpfiles text-properties overlay sha1 md5 base64 format env code-pages mulecustom widget hashtable-print-readable backquote make-network-process
w32notify w32 multi-tty emacs)

--089e0160bc9471ba8804e6bd3414-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 24 17:11:11 2013 Received: (at 15418) by debbugs.gnu.org; 24 Sep 2013 21:11:11 +0000 Received: from localhost ([127.0.0.1]:33311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOZt0-0001Cz-Fb for submit@debbugs.gnu.org; Tue, 24 Sep 2013 17:11:10 -0400 Received: from relais.videotron.ca ([24.201.245.36]:24739) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOZsx-0001Cl-GB for 15418@debbugs.gnu.org; Tue, 24 Sep 2013 17:11:08 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from ceviche.home ([24.201.53.56]) by VL-VM-MR006.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MTN00KYZEUH1U20@VL-VM-MR006.ip.videotron.ca> for 15418@debbugs.gnu.org; Tue, 24 Sep 2013 17:11:06 -0400 (EDT) Received: by ceviche.home (Postfix, from userid 20848) id 212AF6650F; Thu, 19 Sep 2013 17:26:06 -0400 (EDT) From: Stefan Monnier To: Richard Copley Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 Message-id: References: Date: Thu, 19 Sep 2013 17:26:06 -0400 In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: 3.1 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >>>>> "Richard" == Richard Copley writes: > For some files under RCS version control, `vc-annotate' now fails with > error `(wrong-type-argument integer-or-marker-p nil)'. > I think the problem is with the variable `b' whose dynamic binding > was used by `gather' and set by `incg' (local functions in > `vc-rcs-parse'), prior to r114131. [...] Content analysis details: (3.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [24.201.245.36 listed in list.dnswl.org] 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 T_HDRS_LCASE Odd capitalization of message header 0.0 T_MANY_HDRS_LCASE Odd capitalization of multiple message headers X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >>>>> "Richard" == Richard Copley writes: > For some files under RCS version control, `vc-annotate' now fails with > error `(wrong-type-argument integer-or-marker-p nil)'. > I think the problem is with the variable `b' whose dynamic binding > was used by `gather' and set by `incg' (local functions in > `vc-rcs-parse'), prior to r114131. [...] Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [24.201.245.36 listed in list.dnswl.org] 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) >>>>> "Richard" == Richard Copley writes: > For some files under RCS version control, `vc-annotate' now fails with > error `(wrong-type-argument integer-or-marker-p nil)'. > I think the problem is with the variable `b' whose dynamic binding > was used by `gather' and set by `incg' (local functions in > `vc-rcs-parse'), prior to r114131. Indeed, it seems like there was some subtle dynamic scoping at play. Does the patch below fix your problem? Stefan === modified file 'lisp/vc/vc-rcs.el' --- lisp/vc/vc-rcs.el 2013-09-04 21:09:42 +0000 +++ lisp/vc/vc-rcs.el 2013-09-19 21:24:53 +0000 @@ -1234,6 +1234,8 @@ (vc-do-command "*vc*" 0 "rcs" (vc-name file) (concat "-b" branch)) (vc-file-setprop file 'vc-rcs-default-branch branch)) +(defvar vc-rcs--b) + (defun vc-rcs-parse (&optional buffer) "Parse current buffer, presumed to be in RCS-style masterfile format. Optional arg BUFFER specifies another buffer to parse. Return an alist @@ -1314,7 +1316,7 @@ tok ;; Region (begin and end buffer positions) of the printed ;; representation for the current tag. - b e + vc-rcs--b e ;; A list of buffer positions where "@@" can be found within the ;; printed representation region. For each location, we push two ;; elements onto the list, 1+ and 2+ the location, respectively, @@ -1330,11 +1332,11 @@ (to-eol () (buffer-substring-no-properties (point) (progn (forward-line 1) (1- (point))))) - (to-semi () (setq b (point) + (to-semi () (setq vc-rcs--b (point) e (progn (search-forward ";") (1- (point))))) (to-one@ () (setq @-holes nil - b (progn (search-forward "@") (point)) + vc-rcs--b (progn (search-forward "@") (point)) e (progn (while (and (search-forward "@") (= ?@ (char-after)) (progn @@ -1349,9 +1351,9 @@ (funcall set-b+e) (cons tok (if proc (funcall proc) - (buffer-substring-no-properties b e)))) + (buffer-substring-no-properties vc-rcs--b e)))) (k-semi (name &optional proc) (tok+val #'to-semi name proc)) - (gather () (let ((pairs `(,e ,@@-holes ,b)) + (gather () (let ((pairs `(,e ,@@-holes ,vc-rcs--b)) acc) (while pairs (push (buffer-substring-no-properties @@ -1381,7 +1383,7 @@ (setcdr two (cadr two)) two)) (split-string - (buffer-substring-no-properties b e))))) + (buffer-substring-no-properties vc-rcs--b e))))) (hpush 'locks)) (push `(strict . ,(when (at 'strict) (search-forward ";") @@ -1403,7 +1405,7 @@ (let ((ls (mapcar 'string-to-number (split-string (buffer-substring-no-properties - b e) + vc-rcs--b e) "\\.")))) ;; Hack the year -- verified to be the ;; same algorithm used in RCS 5.7. @@ -1414,7 +1416,7 @@ ,(k-semi 'branches (lambda () (split-string - (buffer-substring-no-properties b e)))) + (buffer-substring-no-properties vc-rcs--b e)))) ,(k-semi 'next)) revs) (sw)) @@ -1440,8 +1442,8 @@ ;; only the former since it behaves identically to the ;; latter in the absence of "@@".) sub) - (cl-flet ((incg (_beg end) - (let ((e end) @-holes) + (cl-flet ((incg (beg end) + (let ((vc-rcs--b beg) (e end) @-holes) (while (and asc (< (car asc) e)) (push (pop asc) @-holes)) ;; Self-deprecate when work is done. @@ -1471,7 +1473,7 @@ (setq asc (nreverse @-holes) sub #'incg) (setq sub #'buffer-substring-no-properties)) - (goto-char b) + (goto-char vc-rcs--b) (setq acc nil) (while (< (point) e) (forward-char 1) From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 24 18:47:51 2013 Received: (at 15418) by debbugs.gnu.org; 24 Sep 2013 22:47:51 +0000 Received: from localhost ([127.0.0.1]:33503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VObOY-0003Sd-F5 for submit@debbugs.gnu.org; Tue, 24 Sep 2013 18:47:50 -0400 Received: from mail-ea0-f170.google.com ([209.85.215.170]:38240) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VObOU-0003SQ-T4 for 15418@debbugs.gnu.org; Tue, 24 Sep 2013 18:47:47 -0400 Received: by mail-ea0-f170.google.com with SMTP id h14so2847904eak.1 for <15418@debbugs.gnu.org>; Tue, 24 Sep 2013 15:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=mRWthPUXR3fye2TtiyVUolIYreWf7ug88Tum9VKk9Z0=; b=oDJciYCmO0gOCcGhSsssSPKwkMKGUdqTa0tiSBUQbBZVv7uLhz/DsGvd1/3yrWUmGf 4+dOLxm6fKZhNdukskRhbEljW5yrTy3Nk+T9AonQ7fSELdK5GFtE7jqPwy5QrEuZ4hHb sQ0Zr1BN6+oRCJCdcM3grkEJtf7pua9LXy/rYTacZtBwqhv7FRBm5M+6HPsvMzLinZgw ewySVzW4WuWWN2RAnQF3bme/DXMRX95m+JrnpiLTK0G+7pTF/PvIGOwY14GqtrgRoaXd DycWOtwPiuO7pjKCjS2lboEnL+F3QdENdoDv+ApLX4o4nBfHe4CtH4RKjkzrn8wNjzml TJIA== MIME-Version: 1.0 X-Received: by 10.15.98.194 with SMTP id bj42mr50552005eeb.12.1380062866009; Tue, 24 Sep 2013 15:47:46 -0700 (PDT) Received: by 10.14.152.132 with HTTP; Tue, 24 Sep 2013 15:47:45 -0700 (PDT) In-Reply-To: References: Date: Tue, 24 Sep 2013 23:47:45 +0100 Message-ID: Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 From: Richard Copley To: Stefan Monnier Content-Type: multipart/alternative; boundary=089e0160cd88e58fb704e728ecb0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e0160cd88e58fb704e728ecb0 Content-Type: text/plain; charset=ISO-8859-1 On 19 September 2013 22:26, Stefan Monnier wrote: > >>>>> "Richard" == Richard Copley writes: > > > For some files under RCS version control, `vc-annotate' now fails with > > error `(wrong-type-argument integer-or-marker-p nil)'. > > > I think the problem is with the variable `b' whose dynamic binding > > was used by `gather' and set by `incg' (local functions in > > `vc-rcs-parse'), prior to r114131. > > Indeed, it seems like there was some subtle dynamic scoping at play. > Does the patch below fix your problem? > No, I'm afraid it does not. I get the same error. Thanks. --089e0160cd88e58fb704e728ecb0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

= On 19 September 2013 22:26, Stefan Monnier <monnier@iro.umontreal.c= a> wrote:
>>>>> &quo= t;Richard" =3D=3D Richard Copley <rcopley@gmail.com> writes:

> For some files under RCS version control, `vc-annotate' now fails = with
> error `(wrong-type-argument integer-or-marker-p nil)'.

> I think the problem is with the variable `b' whose dynamic binding=
> was used by `gather' and set by `incg' (local functions in
> `vc-rcs-parse'), prior to r114131.

Indeed, it seems like there was some subtle dynamic scoping at play.
Does the patch below fix your problem?

No, I'm afraid = it does not. I get the same error.
Than= ks.

--089e0160cd88e58fb704e728ecb0-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 24 20:55:21 2013 Received: (at 15418) by debbugs.gnu.org; 25 Sep 2013 00:55:21 +0000 Received: from localhost ([127.0.0.1]:33662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOdNx-0006LY-BV for submit@debbugs.gnu.org; Tue, 24 Sep 2013 20:55:21 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:57090) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOdNt-0006LP-Q2 for 15418@debbugs.gnu.org; Tue, 24 Sep 2013 20:55:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rw0Z/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IPAS-Result: Av8EABK/CFG4rw0Z/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgaxH5AOkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="28972987" Received: from 184-175-13-25.dsl.teksavvy.com (HELO pastel.home) ([184.175.13.25]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Sep 2013 20:51:02 -0400 Received: by pastel.home (Postfix, from userid 20848) id D1CD762F54; Tue, 24 Sep 2013 20:55:13 -0400 (EDT) From: Stefan Monnier To: Richard Copley Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 Message-ID: References: Date: Tue, 24 Sep 2013 20:55:13 -0400 In-Reply-To: (Richard Copley's message of "Tue, 24 Sep 2013 23:47:45 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> > For some files under RCS version control, `vc-annotate' now fails with >> > error `(wrong-type-argument integer-or-marker-p nil)'. >> > I think the problem is with the variable `b' whose dynamic binding >> > was used by `gather' and set by `incg' (local functions in >> > `vc-rcs-parse'), prior to r114131. >> Indeed, it seems like there was some subtle dynamic scoping at play. >> Does the patch below fix your problem? > No, I'm afraid it does not. I get the same error. Can you show the new backtrace? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 03:08:56 2013 Received: (at 15418) by debbugs.gnu.org; 25 Sep 2013 07:08:56 +0000 Received: from localhost ([127.0.0.1]:34174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOjDT-0006i6-FY for submit@debbugs.gnu.org; Wed, 25 Sep 2013 03:08:56 -0400 Received: from mail-ea0-f170.google.com ([209.85.215.170]:44019) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOjDQ-0006hx-Sr for 15418@debbugs.gnu.org; Wed, 25 Sep 2013 03:08:53 -0400 Received: by mail-ea0-f170.google.com with SMTP id h14so2960802eak.29 for <15418@debbugs.gnu.org>; Wed, 25 Sep 2013 00:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+iu68EPrEB3Caq1dsqyV1aNlDQccC69k5S/h30U5v1I=; b=HrOO16iXbtWs93QCSaRFto8RwvuKUNEVMh47Gm0vj/1XuBOiugiEDbQyQ/RSZVcAG8 fbuq8Dkb4Dqwi2yyqtBogPSuVGtNJDK1W35OyUGUPRzYJ3DJfE4KJU7rEn6ITp0XGxsh MNZRnzoG3JSDQ9nF26kbPYKQDC8oddGHb/SxSMJmH8r5HW32Axiy0Uy3iVvuzDM6KoAA +L0PEKsz2uasnJSk8nobJ1oiiy1Z1wCJGj8W037fa0Eo2DweTG3IQHdNN54Hz1OiYuYH KDNs1nOaiYrUj844nchSq677M4FU8O7A3BI3rgj8+2dSxFavYEOeK7R0wGBSPBtryzTN v/Sg== MIME-Version: 1.0 X-Received: by 10.14.223.1 with SMTP id u1mr53348794eep.10.1380092932055; Wed, 25 Sep 2013 00:08:52 -0700 (PDT) Received: by 10.14.152.132 with HTTP; Wed, 25 Sep 2013 00:08:51 -0700 (PDT) In-Reply-To: References: Date: Wed, 25 Sep 2013 08:08:51 +0100 Message-ID: Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 From: Richard Copley To: Stefan Monnier Content-Type: multipart/alternative; boundary=047d7b6703a3f907cb04e72fec03 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7b6703a3f907cb04e72fec03 Content-Type: text/plain; charset=ISO-8859-1 The top of the stack trace is exactly the same as before, except for the new name for "b". buffer-substring-no-properties(nil 6747) (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc) (setq acc (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc)) (while pairs (setq acc (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc)) (setq pairs (cddr pairs))) (let ((pairs (cons e (append @-holes (list vc-rcs--b)))) acc) (while pairs (setq acc (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc)) (setq pairs (cddr pairs))) (apply (quote concat) acc)) (The next line of the backtrace has 159030 characters, most of which are from the master file. Sorry again that I can't provide an example, but the file doesn't belong to me.) On 25 September 2013 01:55, Stefan Monnier wrote: > >> > For some files under RCS version control, `vc-annotate' now fails with > >> > error `(wrong-type-argument integer-or-marker-p nil)'. > >> > I think the problem is with the variable `b' whose dynamic binding > >> > was used by `gather' and set by `incg' (local functions in > >> > `vc-rcs-parse'), prior to r114131. > >> Indeed, it seems like there was some subtle dynamic scoping at play. > >> Does the patch below fix your problem? > > No, I'm afraid it does not. I get the same error. > > Can you show the new backtrace? > > > Stefan > --047d7b6703a3f907cb04e72fec03 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
The top of the stack trace is exactly the same a= s before, except for the new name for "b".

=A0 buffe= r-substring-no-properties(nil 6747)
=A0 (cons (buffer-substring-no-prope= rties (cadr pairs) (car pairs)) acc)
=A0 (setq acc (cons (buffer-substring-no-properties (cadr pairs) (car pairs= )) acc))
=A0 (while pairs (setq acc (cons (buffer-substring-no-propertie= s (cadr pairs) (car pairs)) acc)) (setq pairs (cddr pairs)))
=A0 (let ((= pairs (cons e (append @-holes (list vc-rcs--b)))) acc) (while pairs (setq a= cc (cons (buffer-substring-no-properties (cadr pairs) (car pairs)) acc)) (s= etq pairs (cddr pairs))) (apply (quote concat) acc))

(The next line of the backtrace has 159030 characters, most of wh= ich are from the master file. Sorry again that I can't provide an examp= le, but the file doesn't belong to me.)



On 25 September 2013 01:55, Stefan Monni= er <monnier@iro.umontreal.ca> wrote:
>> > For some files under RCS version control, `= vc-annotate' now fails with
>> > error `(wrong-type-argument integer-or-marker-p nil)'. >> > I think the problem is with the variable `b' whose dynami= c binding
>> > was used by `gather' and set by `incg' (local functio= ns in
>> > `vc-rcs-parse'), prior to r114131.
>> Indeed, it seems like there was some subtle dynamic scoping at pla= y.
>> Does the patch below fix your problem?
> No, I'm afraid it does not. I get the same error.

Can you show the new backtrace?


=A0 =A0 =A0 =A0 Stefan

--047d7b6703a3f907cb04e72fec03-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 12:14:20 2013 Received: (at 15418) by debbugs.gnu.org; 14 Oct 2013 16:14:20 +0000 Received: from localhost ([127.0.0.1]:49096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VVkmi-0003rO-BM for submit@debbugs.gnu.org; Mon, 14 Oct 2013 12:14:20 -0400 Received: from mail-ee0-f51.google.com ([74.125.83.51]:60083) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VVkmg-0003rB-67 for 15418@debbugs.gnu.org; Mon, 14 Oct 2013 12:14:18 -0400 Received: by mail-ee0-f51.google.com with SMTP id c1so3502989eek.10 for <15418@debbugs.gnu.org>; Mon, 14 Oct 2013 09:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=WAKa6vIaLk8Utxoj2l3Yktr1gk7j0mdi1TzRQx1SbXs=; b=tgC9MTtK9gREtjxAkdQGqQ1gStLttf9lfv8KgRWQVWivNPfwvUFBY3HOswyj2b+C/G GtshH6XDzh9SgqRdwubtbhYiwvEJFzc2TS9NJepaHzuYb4anu/CONUwNyn3kXkLDU3l6 6hj8576aaIMPIysvdZJJmnh0U4nZ/S3dt+EvIaTI508mpbUpSvyaQjD7dlTFPNUTrGQl iN6jyXqaGQ+tsRuc2TA/YKbr1IACSoJTYGslnd1/thUx7imIjDraDI2d2/0byR+O3XpH yOgtZyO+M4k0cHPjoVhr+KcgzdPBoPHxyZapxtGMG6hOk3KDmwwHoAC/TXkrDkVU4s8b 8SPg== MIME-Version: 1.0 X-Received: by 10.14.174.71 with SMTP id w47mr828163eel.84.1381767252367; Mon, 14 Oct 2013 09:14:12 -0700 (PDT) Received: by 10.14.10.70 with HTTP; Mon, 14 Oct 2013 09:14:12 -0700 (PDT) In-Reply-To: References: Date: Mon, 14 Oct 2013 17:14:12 +0100 Message-ID: Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 From: Richard Copley To: Stefan Monnier Content-Type: multipart/mixed; boundary=047d7b6243103d5e8704e8b5c252 X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 25 September 2013 08:08, Richard Copley wrote: > [...] Sorry again that I can't provide an example, but the file doesn't > belong to me. > Attached is a simple RCS master file that reproduces the issue. [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rcopley[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.83.51 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 2.8 OBFU_TEXT_ATTACH BODY: Text attachment with non-text MIME type 0.0 HTML_MESSAGE BODY: HTML included in message 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 25 September 2013 08:08, Richard Copley wrote: > [...] Sorry again that I can't provide an example, but the file doesn't > belong to me. > Attached is a simple RCS master file that reproduces the issue. [...] Content analysis details: (2.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [74.125.83.51 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rcopley[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 2.8 OBFU_TEXT_ATTACH BODY: Text attachment with non-text MIME type 0.0 HTML_MESSAGE BODY: HTML included in message 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid --047d7b6243103d5e8704e8b5c252 Content-Type: multipart/alternative; boundary=047d7b6243103d5e8304e8b5c250 --047d7b6243103d5e8304e8b5c250 Content-Type: text/plain; charset=ISO-8859-1 On 25 September 2013 08:08, Richard Copley wrote: > [...] Sorry again that I can't provide an example, but the file doesn't > belong to me. > Attached is a simple RCS master file that reproduces the issue. --047d7b6243103d5e8304e8b5c250 Content-Type: text/html; charset=ISO-8859-1
On 25 September 2013 08:08, Richard Copley <rcopley@gmail.com> wrote:
[...] Sorry again that I can't provide an example, but the file doesn't belong to me.

Attached is a simple RCS master file that reproduces the issue.

--047d7b6243103d5e8304e8b5c250-- --047d7b6243103d5e8704e8b5c252 Content-Type: application/octet-stream; name="vcbug.txt,v" Content-Disposition: attachment; filename="vcbug.txt,v" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hmrwj5o20 aGVhZAkxLjM7CmFjY2VzczsKc3ltYm9sczsKbG9ja3MKCVJDTzoxLjM7IHN0cmljdDsKY29tbWVu dAlAIyBAOwoKCjEuMwpkYXRlCTIwMTMuMTAuMTQuMTYuMDguMTY7CWF1dGhvciBSQ087CXN0YXRl IEV4cDsKYnJhbmNoZXM7Cm5leHQJMS4yOwoKMS4yCmRhdGUJMjAxMy4xMC4xNC4xNS41OC41MTsJ YXV0aG9yIFJDTzsJc3RhdGUgRXhwOwpicmFuY2hlczsKbmV4dAkxLjE7CgoxLjEKZGF0ZQkyMDEz LjEwLjE0LjE1LjU3LjU1OwlhdXRob3IgUkNPOwlzdGF0ZSBFeHA7CmJyYW5jaGVzOwpuZXh0CTsK CgpkZXNjCkBKdXN0IGEgdGVzdApACgoKMS4zCmxvZwpARW1wdGllZApACnRleHQKQEAKCgoxLjIK bG9nCkBBbm90aGVyIHZlcnNpb24KQAp0ZXh0CkBhMCAxClRoaXMgdmVyc2lvbiBAQCBoYXMgQEAg dGhyZWUgQEAgaG9sZXMuCkAKCgoxLjEKbG9nCkBJbml0aWFsIHJldmlzaW9uCkAKdGV4dApAZDEg MQphMSAzCgoKCkAK --047d7b6243103d5e8704e8b5c252-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 18:33:57 2013 Received: (at 15418) by debbugs.gnu.org; 14 Oct 2013 22:33:57 +0000 Received: from localhost ([127.0.0.1]:49468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VVqi4-0005x7-If for submit@debbugs.gnu.org; Mon, 14 Oct 2013 18:33:56 -0400 Received: from mail-ee0-f48.google.com ([74.125.83.48]:63284) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VVqi2-0005wt-Gu for 15418@debbugs.gnu.org; Mon, 14 Oct 2013 18:33:55 -0400 Received: by mail-ee0-f48.google.com with SMTP id l10so3693705eei.21 for <15418@debbugs.gnu.org>; Mon, 14 Oct 2013 15:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=fPdYyM91CKphttiSnvqKst9fk2Z4eeIZS5YFx1FbUjY=; b=X2zFMYkvMwkiEKnOrqdPbZVqwP7NfBwVjglEzxQISsZGcJtY3+3gBxBBP1+SJGw0xU B5ZDkvbUAq3lJ8EYX53Geze+0nMmIBwTtal/3bPcrksxvvb91T1LZBtVPGSRBRE64I/6 Dpu8Aphh8jXalczPx0gNU/0wL3F1tc6qgtPdUWNNU/DlfjH65AbBXCNRTZ4h949DbIBd CXmkidoVlTdgGBciynPhGG1gAD/Zi2WyOIb2iWOm6MjL/pHEZeOvDBr2X5w0oS+jyjB7 /0tLlpYk8iVBhHvzwZAv8TfZAQBhJyD8lNWOrlzkdm50bydNt3XzyrVkY1fcYq8T/J5n 1DLA== MIME-Version: 1.0 X-Received: by 10.14.241.74 with SMTP id f50mr60138194eer.29.1381790028438; Mon, 14 Oct 2013 15:33:48 -0700 (PDT) Received: by 10.14.10.70 with HTTP; Mon, 14 Oct 2013 15:33:48 -0700 (PDT) In-Reply-To: References: Date: Mon, 14 Oct 2013 23:33:48 +0100 Message-ID: Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 From: Richard Copley To: Stefan Monnier Content-Type: multipart/alternative; boundary=001a1132e8dacca18e04e8bb0f1d X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1132e8dacca18e04e8bb0f1d Content-Type: text/plain; charset=ISO-8859-1 Making `e' and `@-holes' special variables, in addition to `b', as in your patch, does seem to work. --001a1132e8dacca18e04e8bb0f1d Content-Type: text/html; charset=ISO-8859-1
Making `e' and `@-holes' special variables, in addition to `b', as in your patch, does seem to work.

--001a1132e8dacca18e04e8bb0f1d-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 15 17:09:44 2013 Received: (at 15418) by debbugs.gnu.org; 15 Oct 2013 21:09:44 +0000 Received: from localhost ([127.0.0.1]:52484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWBs7-0001tv-3I for submit@debbugs.gnu.org; Tue, 15 Oct 2013 17:09:43 -0400 Received: from mail-ea0-f176.google.com ([209.85.215.176]:64357) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWBs5-0001te-6T for 15418@debbugs.gnu.org; Tue, 15 Oct 2013 17:09:41 -0400 Received: by mail-ea0-f176.google.com with SMTP id q16so4171586ead.7 for <15418@debbugs.gnu.org>; Tue, 15 Oct 2013 14:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=tGFL8H7Xc033BbVydpWQNJj/y2yevPDAJKIVHotKuqE=; b=hheauHSq7OGBhxLRt7o5QgB7+b0eH0k1dCIcVT98AFkS4/wxIqNSZRL7U7TN7/ddsA +xv1mTgDchL1lci6lc8J2E0zjvKkr90HNt5cq2+iEdC4JWwg2raEqglLPt9ZqGIkRvxS sQRyZqUVIILQPUK0jXKWHgkoSNMbXgUpoR2GZMzjWFkic4XGPPQdi84d6mysnlskVtEz Ylf4hNwqN4eyju4yhYwpNAV+CtFEIeaMPy0bXx6LyQxQMhlDla/n773SiCVdMWzbmfNj iUPTKiSWAZheo7xR8sFYPC+/oyBFkXiqsYtBtqMIAZo31qrroHzbhigj/UUBGCHlZ/P1 OurQ== MIME-Version: 1.0 X-Received: by 10.15.75.73 with SMTP id k49mr3672230eey.36.1381871375455; Tue, 15 Oct 2013 14:09:35 -0700 (PDT) Received: by 10.14.10.70 with HTTP; Tue, 15 Oct 2013 14:09:35 -0700 (PDT) In-Reply-To: References: Date: Tue, 15 Oct 2013 22:09:35 +0100 Message-ID: Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 From: Richard Copley To: Stefan Monnier Content-Type: multipart/alternative; boundary=001a11c1af4c759cb604e8ce0085 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c1af4c759cb604e8ce0085 Content-Type: text/plain; charset=ISO-8859-1 On 14 October 2013 23:33, Richard Copley wrote: > Making `e' and `@-holes' special variables, in addition to `b', as in your > patch, does seem to work. > > No, it doesn't, sorry. With those changes, `vc-annotate' no longer signals an error, but it also annotates files wrongly. Some lines are attributed to version 1 that shouldn't be. Do you see the same for the RCS master files you have available for testing? I tried to find the mistake(s) but it's very hard to spot let- and lambda-bindings intended to be used outside their lexical scope. --001a11c1af4c759cb604e8ce0085 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On 1= 4 October 2013 23:33, Richard Copley <rcopley@gmail.com> wro= te:
Making `e' and `@-holes'= ; special variables, in addition to `b', as in your patch, does seem to= work.

No, it doesn't, sorry. With those changes, `vc-annot= ate' no longer signals an error, but it also annotates files wrongly. S= ome lines are attributed to version 1 that shouldn't be. Do you see the= same for the RCS master files you have available for testing?

I tried to find the mistake(s) but it&= #39;s very hard to spot let- and lambda-bindings intended to be used outsid= e their lexical scope.

--001a11c1af4c759cb604e8ce0085-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 15 23:05:42 2013 Received: (at 15418) by debbugs.gnu.org; 16 Oct 2013 03:05:42 +0000 Received: from localhost ([127.0.0.1]:53359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWHQb-0002bP-NY for submit@debbugs.gnu.org; Tue, 15 Oct 2013 23:05:41 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:47859) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWHQY-0002bH-T1 for 15418@debbugs.gnu.org; Tue, 15 Oct 2013 23:05:39 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r9G35cpx022914; Tue, 15 Oct 2013 23:05:38 -0400 Received: by pastel.home (Postfix, from userid 20848) id E327162EBC; Tue, 15 Oct 2013 23:05:37 -0400 (EDT) From: Stefan Monnier To: Richard Copley Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 Message-ID: References: Date: Tue, 15 Oct 2013 23:05:37 -0400 In-Reply-To: (Richard Copley's message of "Mon, 14 Oct 2013 17:14:12 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4732=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4732> : inlines <150> : streams <1056602> : uri <1566602> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) >> [...] Sorry again that I can't provide an example, but the file doesn't >> belong to me. > Attached is a simple RCS master file that reproduces the issue. Thanks, I'll take a look, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 05:09:37 2013 Received: (at 15418) by debbugs.gnu.org; 5 Nov 2013 10:09:37 +0000 Received: from localhost ([127.0.0.1]:35042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VddZp-0003RE-CJ for submit@debbugs.gnu.org; Tue, 05 Nov 2013 05:09:37 -0500 Received: from mail-ea0-f177.google.com ([209.85.215.177]:50419) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VddZm-0003Qy-Mn for 15418@debbugs.gnu.org; Tue, 05 Nov 2013 05:09:35 -0500 Received: by mail-ea0-f177.google.com with SMTP id f15so4029603eak.36 for <15418@debbugs.gnu.org>; Tue, 05 Nov 2013 02:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=i9cek6naLCOgTZodaInWNOZgq0xTmvZ0lVgtEHZk6xI=; b=Jcyc0DT1tJS2g96lxaY8vrt7jCs+aASKxjBg9O/TRnZS04YTKWbyk5pDJI3k4OVoIo zOn8a5VA3mktMfHU0Yq5Og+6J1L12MUx6wdnvt1vhfozM9oARWusQ1C8djicBl/MGbMZ YMf/D1LABaaBmEr9WZ6Fod8JyFfgO/aZF09/9GQMJ8J/kvjnHw5XQYK/p9Sk90gOjxRB VaioCUNm5nqezDuQJICLcYnjcgxjatJi4mSgeNgB24WSZFYeCvIRdOELuJD08a7B5hwx at3JHnXRaybEL7pWHFDOfRiv0XwVulCJDLkPnEuBrAxdef2MV4bJLZr5ImY+SI2fOfBD FgAA== MIME-Version: 1.0 X-Received: by 10.15.95.9 with SMTP id bc9mr1304140eeb.97.1383646168720; Tue, 05 Nov 2013 02:09:28 -0800 (PST) Received: by 10.14.10.70 with HTTP; Tue, 5 Nov 2013 02:09:28 -0800 (PST) In-Reply-To: References: Date: Tue, 5 Nov 2013 10:09:28 +0000 Message-ID: Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 From: Richard Copley To: Stefan Monnier Content-Type: multipart/alternative; boundary=089e01681d2061a90904ea6b3a61 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e01681d2061a90904ea6b3a61 Content-Type: text/plain; charset=ISO-8859-1 On 16 October 2013 03:05, Stefan Monnier wrote: > > Thanks, I'll take a look, > In the meantime, it would be convenient if RCS blame were working on the trunk. Would you consider reverting vc-rcs.el to the last working version, r112756? Richard. --089e01681d2061a90904ea6b3a61 Content-Type: text/html; charset=ISO-8859-1
On 16 October 2013 03:05, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

Thanks, I'll take a look,

In the meantime, it would be convenient if RCS blame were working on the trunk. Would you consider reverting vc-rcs.el to the last working version, r112756?

Richard.

--089e01681d2061a90904ea6b3a61-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 10:38:19 2013 Received: (at 15418) by debbugs.gnu.org; 5 Nov 2013 15:38:19 +0000 Received: from localhost ([127.0.0.1]:35919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdihu-0004C7-Ix for submit@debbugs.gnu.org; Tue, 05 Nov 2013 10:38:19 -0500 Received: from relais.videotron.ca ([24.201.245.36]:22825) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdihp-0004Bw-Ke for 15418@debbugs.gnu.org; Tue, 05 Nov 2013 10:38:14 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from ceviche.home ([24.201.53.56]) by VL-VM-MR005.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MVS00DDKRF80Z50@VL-VM-MR005.ip.videotron.ca> for 15418@debbugs.gnu.org; Tue, 05 Nov 2013 10:37:58 -0500 (EST) Received: by ceviche.home (Postfix, from userid 20848) id E3D3C6609C; Tue, 05 Nov 2013 10:37:56 -0500 (EST) From: Stefan Monnier To: Richard Copley Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 Message-id: References: Date: Tue, 05 Nov 2013 10:37:56 -0500 In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Attached is a simple RCS master file that reproduces the issue. Thanks. I installed the patch below which fixes the problem at least on this trivial file. And sorry for taking so long. Please confirm that it fixes the problem in real life as well. Stefan === modified file 'lisp/vc/vc-rcs.el' --- lisp/vc/vc-rcs.el 2013-10-04 23:47:00 +0000 +++ lisp/vc/vc-rcs.el 2013-11-05 15:25:06 +0000 @@ -1355,18 +1354,18 @@ (funcall proc) (buffer-substring-no-properties b e)))) (k-semi (name &optional proc) (tok+val #'to-semi name proc)) - (gather () (let ((pairs `(,e ,@@-holes ,b)) + (gather (b e @-holes) + (let ((pairs `(,e ,@@-holes ,b)) acc) (while pairs (push (buffer-substring-no-properties (cadr pairs) (car pairs)) acc) (setq pairs (cddr pairs))) - (apply 'concat acc))) - (k-one@ (name &optional later) (tok+val #'to-one@ name - (if later - (lambda () t) - #'gather)))) + (apply #'concat acc))) + (gather1 () (gather b e @-holes)) + (k-one@ (name &optional later) + (tok+val #'to-one@ name (if later (lambda () t) #'gather1)))) (save-excursion (goto-char (point-min)) ;; headers @@ -1444,9 +1443,10 @@ ;; only the former since it behaves identically to the ;; latter in the absence of "@@".) sub) - (cl-flet ((incg (_beg end) - (let ((e end) @-holes) + (cl-flet ((incg (beg end) + (let ((b beg) (e end) @-holes) (while (and asc (< (car asc) e)) + (push (pop asc) @-holes) (push (pop asc) @-holes)) ;; Self-deprecate when work is done. ;; Folding many dimensions into one. @@ -1454,7 +1454,7 @@ ;; O beauteous math! --the Unvexed Bum (unless asc (setq sub #'buffer-substring-no-properties)) - (gather)))) + (gather b e @-holes)))) (while (and (sw) (not (eobp)) (setq context (to-eol) @@ -1470,7 +1470,7 @@ ;; other revisions, replace the `text' tag+value with `:insn' ;; plus value, always scanning in-place. (if (string= context (cdr (assq 'head headers))) - (setcdr (cadr rev) (gather)) + (setcdr (cadr rev) (gather b e @-holes)) (if @-holes (setq asc (nreverse @-holes) sub #'incg) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 05:56:58 2013 Received: (at 15418) by debbugs.gnu.org; 6 Nov 2013 10:56:58 +0000 Received: from localhost ([127.0.0.1]:36728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ve0nB-0001Ef-EA for submit@debbugs.gnu.org; Wed, 06 Nov 2013 05:56:58 -0500 Received: from mail-ea0-f177.google.com ([209.85.215.177]:58088) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ve0n8-0001ER-9K for 15418@debbugs.gnu.org; Wed, 06 Nov 2013 05:56:54 -0500 Received: by mail-ea0-f177.google.com with SMTP id f15so4823702eak.22 for <15418@debbugs.gnu.org>; Wed, 06 Nov 2013 02:56:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=58CSK+k3SaMSRhb+1lhUpIl9PonrtDpVf+nET6pCC90=; b=RROskbm58rLFCrDstnYbtAxuUIwMKonO7alV1EpyEWA/RcsiftE3MTgK76/vlSikau AnXOqtJAukxjglbnFnbbmmFFBEC/Cb2B1pTZrR5Sb8lpMx9dXN0tWxZayHRgaZUtgwrb mVmFuawQK5S16mnt7t9QuFEEGl//gLJSOiNJyTYERQ64lmmfX7WOIL3QbzzwVqW4VYIg E3aSH5QviF9hjtbeUhxyWj4D1ap2wdIKFXaxPADqQa7+d76w9eQHlq5hJ3qzYSn4qHv+ MPTuRwwbjIsUSH8Hn+3T3b/DeROryHuKnvjgFHDfqV306Ej9zNqKAga6z8xPi5QFG+p1 IPdg== MIME-Version: 1.0 X-Received: by 10.14.38.194 with SMTP id a42mr2909042eeb.12.1383735408309; Wed, 06 Nov 2013 02:56:48 -0800 (PST) Received: by 10.14.10.70 with HTTP; Wed, 6 Nov 2013 02:56:48 -0800 (PST) In-Reply-To: References: Date: Wed, 6 Nov 2013 10:56:48 +0000 Message-ID: Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 From: Richard Copley To: Stefan Monnier Content-Type: multipart/alternative; boundary=089e016816ec79bc1404ea8001d0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e016816ec79bc1404ea8001d0 Content-Type: text/plain; charset=ISO-8859-1 On 5 November 2013 15:37, Stefan Monnier wrote: > Attached is a simple RCS master file that reproduces the issue. Thanks. I installed the patch below which fixes the problem at least on this trivial file. And sorry for taking so long. Please confirm that it fixes the problem in real life as well. Thanks. I rebuilt Emacs from trunk r114733 to test. `vc-annotate' no longer signals an error, but neither does it work correctly. For non-trivial master files, many lines are wrongly attributed to revision 1.1. --089e016816ec79bc1404ea8001d0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On 5 November 2013 15:37, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
<= br>=A0=A0=A0 > Attached is a simple RCS master file that reproduces the = issue.
=A0=A0=A0 Thanks.=A0 I installed the patch below which fixes the problem at= least on
=A0=A0=A0 this trivial file.=A0 And sorry for taking so long.= =A0 Please confirm that
=A0=A0=A0 it fixes the problem in real life as w= ell.

Thanks. I rebuilt Emacs from trunk r114733 to test. `vc-annotat= e' no longer signals an error, but neither does it work correctly. For = non-trivial master files, many lines are wrongly attributed to revision 1.1= .

--089e016816ec79bc1404ea8001d0-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 06:19:10 2013 Received: (at 15418) by debbugs.gnu.org; 6 Nov 2013 11:19:11 +0000 Received: from localhost ([127.0.0.1]:36742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ve18g-0001p2-5i for submit@debbugs.gnu.org; Wed, 06 Nov 2013 06:19:10 -0500 Received: from mail-ee0-f50.google.com ([74.125.83.50]:64940) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ve18e-0001oo-3V for 15418@debbugs.gnu.org; Wed, 06 Nov 2013 06:19:08 -0500 Received: by mail-ee0-f50.google.com with SMTP id b45so1662581eek.23 for <15418@debbugs.gnu.org>; Wed, 06 Nov 2013 03:19:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=JSgYnSivvAHC7c91zUZtuKgRkwNCZkiOzR0okpRufkc=; b=a5Mzg5h8G75FWkhwaZ+21RQd//8MpZhEPOF+k2ryam6d8Zh3BqQbB2njdub5xcuDuK yCddm1U2jUA2U3fB2UPQeC43Z+ImekDEkFU0fC1H7oT2J//iITMavrO4RrqRSjgqY2ha sOM2VjF1uB81ppv3tStQ4f57+MJolCqUeuIbQ7TWq26SDBn/nql14RWi2D56El3dBzHT zDh95RJfluoo4skHsHzl8lcHlPE3J107rVmDa434tyd41Ykj1Fbt8FRKOVgX5HUQxdzt lMBg+pR7rTzSnHyhvEUAygLrMF3b59ZQzY0SXOf5vK4YYR5IzM6TzKZmDuiP/wLzVenW rW0g== MIME-Version: 1.0 X-Received: by 10.14.45.70 with SMTP id o46mr2933241eeb.19.1383736742194; Wed, 06 Nov 2013 03:19:02 -0800 (PST) Received: by 10.14.10.70 with HTTP; Wed, 6 Nov 2013 03:19:02 -0800 (PST) In-Reply-To: References: Date: Wed, 6 Nov 2013 11:19:02 +0000 Message-ID: Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 From: Richard Copley To: Stefan Monnier Content-Type: multipart/alternative; boundary=001a1133d526fb35d804ea805078 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15418 Cc: 15418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1133d526fb35d804ea805078 Content-Type: text/plain; charset=ISO-8859-1 On 6 November 2013 10:56, Richard Copley wrote: > Thanks. I rebuilt Emacs from trunk r114733 to test. `vc-annotate' no > longer signals an error, but neither does it work correctly. For > non-trivial master files, many lines are wrongly attributed to revision 1.1. > Oops, sorry. I was testing the wrong version (because I didn't notice that my build had failed). I've tested again by loading the new version of vc-rcs.el. I think it works perfectly now. I ran `vc-annotate' on a large, complex master file using vc-rcs.el revisions 112756 (before lexical-bindings) and 114977 (latest revision) and got exactly the same results from both versions. Thanks. --001a1133d526fb35d804ea805078 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On 6= November 2013 10:56, Richard Copley <rcopley@gmail.com> wro= te:
Thanks. I rebuilt Emacs from trunk r114733 to test. `vc-an= notate' no longer signals an error, but neither does it work correctly.= For non-trivial master files, many lines are wrongly attributed to revisio= n 1.1.

Oops, sorry. I was testing the wrong versi= on (because I didn't notice that my build had failed).

I&#= 39;ve tested again by loading the new version of vc-rcs.el. I think it work= s perfectly now. I ran `vc-annotate' on a large, complex master file us= ing vc-rcs.el revisions 112756 (before lexical-bindings) and 114977 (latest= revision) and got exactly the same results from both versions.

Thanks.

--001a1133d526fb35d804ea805078-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 08:46:27 2013 Received: (at 15418-done) by debbugs.gnu.org; 6 Nov 2013 13:46:28 +0000 Received: from localhost ([127.0.0.1]:36919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ve3RC-0007li-4c for submit@debbugs.gnu.org; Wed, 06 Nov 2013 08:46:27 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:44366) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ve3RA-0007lS-7w for 15418-done@debbugs.gnu.org; Wed, 06 Nov 2013 08:46:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37209320" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Nov 2013 08:46:18 -0500 Received: by pastel.home (Postfix, from userid 20848) id 937EE6009C; Wed, 6 Nov 2013 08:46:17 -0500 (EST) From: Stefan Monnier To: Richard Copley Subject: Re: bug#15418: 24.3.50; RCS annotate broken in vc-rcs.el r114131 Message-ID: References: Date: Wed, 06 Nov 2013 08:46:17 -0500 In-Reply-To: (Richard Copley's message of "Wed, 6 Nov 2013 11:19:02 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15418-done Cc: 15418-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I've tested again by loading the new version of vc-rcs.el. I think it works > perfectly now. I ran `vc-annotate' on a large, complex master file using > vc-rcs.el revisions 112756 (before lexical-bindings) and 114977 (latest > revision) and got exactly the same results from both versions. Yay! Thanks for your patience, Stefan From unknown Wed Jun 25 10:49:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Dec 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator