GNU bug report logs - #15417
(compile "cd /u*r && ... cd: No such directory found via CDPATH environment variable

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15417 in the body.
You can then email your comments to 15417 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: bug-gnu-emacs <at> gnu.org
Subject: (compile "cd /u*r && ... cd: No such directory found via CDPATH
 environment variable
Date: Thu, 19 Sep 2013 18:55:45 +0800

Cannot do
(compile "cd /u*r && echo wow")
will get
cd: No such directory found via CDPATH environment variable

OK, but add "kindly don't use wildcards" etc. to tell the user this is
intentional if so...

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#15417: (compile "cd /u*r && ... cd: No such directory found
 via CDPATH environment variable
Date: Tue, 24 Sep 2013 23:44:02 -0600

On 9/19/13 4:55 AM, jidanni <at> jidanni.org wrote:
> Cannot do
> (compile "cd /u*r&&  echo wow")
> will get
> cd: No such directory found via CDPATH environment variable
>
> OK, but add "kindly don't use wildcards" etc. to tell the user this is
> intentional if so...

Why is this a bug?  i.e. is there a /u*r directory, and do its permissions
allow you to cd to it (executable bit set for user/group/other as appropriate)?

-- 
Kevin Rodgers
Denver, Colorado, USA

Message #11 received at 15417 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
Cc: 15417 <at> debbugs.gnu.org
Subject: Re: bug#15417: (compile "cd /u*r && ... cd: No such directory found
 via CDPATH environment variable
Date: Wed, 25 Sep 2013 13:06:20 -0400

> Why is this a bug?  i.e. is there a /u*r directory, and do its permissions

Yes, in the shell (which is normally what runs this command), "cd /u*r"
will probably succeed by expanding "/u*r" to "/usr".
But the hack I added to "M-x compile" which tries to recognize a leading
"cd <blabla>" gets in the way.


        Stefan

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#15417: (compile "cd /u*r && ... cd: No such directory found
 via CDPATH environment variable
Date: Wed, 25 Sep 2013 23:45:18 -0600

On 9/25/13 11:06 AM, Stefan Monnier wrote:
>> Why is this a bug?  i.e. is there a /u*r directory, and do its permissions
>
> Yes, in the shell (which is normally what runs this command), "cd /u*r"
> will probably succeed by expanding "/u*r" to "/usr".
> But the hack I added to "M-x compile" which tries to recognize a leading
> "cd<blabla>" gets in the way.

Ah, I see.

Seems like after extracting the <blabla> arg and substituting the values
of any referenced environment variables (already implemented by the
current hack), you could pass the result to file-expand-wildcards.  Then
check that there is only a single directory in the result, and pass that
directory to `cd'.

-- 
Kevin Rodgers
Denver, Colorado, USA

Message #17 received at 15417 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
Cc: 15417 <at> debbugs.gnu.org
Subject: Re: bug#15417: (compile "cd /u*r && ... cd: No such directory found
 via CDPATH environment variable
Date: Thu, 26 Sep 2013 09:56:49 -0400

> Seems like after extracting the <blabla> arg and substituting the values
> of any referenced environment variables (already implemented by the
> current hack), you could pass the result to file-expand-wildcards.  Then
> check that there is only a single directory in the result, and pass that
> directory to `cd'.

Indeed.  Could you take care of it?


        Stefan

Message #20 received at 15417 <at> debbugs.gnu.org (full text, mbox):

From: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 15417 <at> debbugs.gnu.org
Subject: Re: bug#15417: (compile "cd /u*r && ... cd: No such directory found
 via CDPATH environment variable
Date: Wed, 2 Oct 2013 07:41:04 -0600

[Message part 1 (text/plain, inline)]

> > Seems like after extracting the <blabla> arg and substituting the values
> > of any referenced environment variables (already implemented by the
> > current hack), you could pass the result to file-expand-wildcards.  Then
> > check that there is only a single directory in the result, and pass that
> > directory to `cd'.
>
> Indeed.  Could you take care of it?

Sure, sorry for the delay:

**** compile.el~    Fri Jan 21 18:08:13 2011
--- compile.el    Wed Oct  2 07:25:47 2013
***************
*** 1217,1223 ****
      ;; sh -c "cd ..; make"
      (cd (if (string-match "^\\s *cd\\(?:\\s +\\(\\S +?\\)\\)?\\s *[;&\n]"
command)
          (if (match-end 1)
!             (substitute-env-vars (match-string 1 command))
            "~")
            default-directory))
      (erase-buffer)
--- 1217,1229 ----
      ;; sh -c "cd ..; make"
      (cd (if (string-match "^\\s *cd\\(?:\\s +\\(\\S +?\\)\\)?\\s *[;&\n]"
command)
          (if (match-end 1)
!             (let* ((substituted-dir
!                 (substitute-env-vars (match-string 1 command)))
!                (expanded-dir
!                 (file-expand-wildcards substituted-dir)))
!               (if (= (length expanded-dir) 1)
!               (car expanded-dir)
!             substituted-dir))
            "~")
            default-directory))
      (erase-buffer)

-- 
Kevin Rodgers
Denver, Colorado


>
>
>         Stefan
>



On Thu, Sep 26, 2013 at 7:56 AM, Stefan Monnier <monnier <at> iro.umontreal.ca>wrote:

> > Seems like after extracting the <blabla> arg and substituting the values
> > of any referenced environment variables (already implemented by the
> > current hack), you could pass the result to file-expand-wildcards.  Then
> > check that there is only a single directory in the result, and pass that
> > directory to `cd'.
>
> Indeed.  Could you take care of it?
>
>
>         Stefan
>

[Message part 2 (text/html, inline)]

Message #25 received at 15417-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
Cc: 15417-done <at> debbugs.gnu.org
Subject: Re: bug#15417: (compile "cd /u*r && ... cd: No such directory found
 via CDPATH environment variable
Date: Wed, 02 Oct 2013 19:35:35 -0400

> Sure, sorry for the delay:

Thanks, installed.  There are still many ways to make the code fail, tho.
I think the better solution would be to pass the whole argument to
a shell, so we get the actually correct expansion.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.