GNU bug report logs - #15405
24.3; #[] freezes emacs

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Wed, 18 Sep 2013 01:52:02 UTC

Severity: normal

Merged with 16512

Found in version 24.3

Fixed in version 24.4

Done: Barry OReilly <gundaetiapo <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #92 received at 15405 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Antipov <dmantipov <at> yandex.ru>
To: Barry OReilly <gundaetiapo <at> gmail.com>, 
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, stephen.berman <at> gmx.net, 15405 <at> debbugs.gnu.org,
 Leo Liu <sdl.web <at> gmail.com>
Subject: Re: bug#15405: 24.3; #[] freezes emacs
Date: Thu, 26 Sep 2013 01:50:23 +0400

On 09/25/2013 11:09 PM, Barry OReilly wrote:

> How's this?

OK for me, except...

> @@ -3132,6 +3132,8 @@ usage: (vector &rest OBJECTS)  */)
>   void
>   make_byte_code (struct Lisp_Vector *v)
>   {
> +  /* Don't allow the global zero_vector to become a byte code object. */
> +  eassert(v->header.size!=0);

Since v->header.size is signed (ptrdiff_t), I would suggest

eassert (v->header.size > 0)

for the better catch of bogus values.

Thanks,
Dmitry
This bug report was last modified 11 years and 122 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.