GNU bug report logs - #15388
24.3.50; OSX fullscreen mode and tool-bar-mode

Previous Next

Package: emacs;

Reported by: Bernd Rellermeyer <bernd.rellermeyer <at> arcor.de>

Date: Sun, 15 Sep 2013 18:05:03 UTC

Severity: normal

Merged with 18297

Found in version 24.3.50

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 15388 <at> debbugs.gnu.org (full text, mbox):

From: David Caldwell <david <at> porkrind.org>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 15388 <at> debbugs.gnu.org
Subject: Re: bug#15388: 24.3.50; OSX fullscreen mode and tool-bar-mode
Date: Mon, 07 Oct 2013 11:12:41 -0700
[Message part 1 (text/plain, inline)]
> Hello.
> 
> There is indeed something strange with 10.7.  I've checked in some changes, please try them.
> 
> Thanks.
> 
> 	Jan D.

These changes cause problems for OS X versions less than 10.7:

gcc -mmacosx-version-min=10.5  -std=gnu99 -c  -Demacs  -I.
-I/Users/david/src/emacs-dev/emacs-bzr/build-2013-10-07/src -I../lib
-I/Users/david/src/emacs-dev/emacs-bzr/build-2013-10-07/src/../lib
  -I/usr/include/libxml2          -MMD -MF deps/nsterm.d -MP     -g3 -O2
  nsterm.m
nsterm.m: In function '-[EmacsView windowDidEnterFullScreen:]':
nsterm.m:6141: error: 'NSApplicationPresentationFullScreen' undeclared
(first use in this function)
nsterm.m:6141: error: (Each undeclared identifier is reported only once
nsterm.m:6141: error: for each function it appears in.)
nsterm.m:6142: error: 'NSApplicationPresentationAutoHideToolbar'
undeclared (first use in this function)
nsterm.m: In function '-[EmacsView windowDidExitFullScreen:]':
nsterm.m:6162: warning: 'EmacsView' may not respond to
'-updateCollectionBehaviour'
nsterm.m:6162: warning: (Messages without a matching method signature
nsterm.m:6162: warning: will be assumed to return 'id' and accept
nsterm.m:6162: warning: '...' as arguments.)
nsterm.m: In function '-[EmacsView toggleFullScreen:]':
nsterm.m:6223: warning: 'NSWindow' may not respond to '-toggleFullScreen:'
make[1]: *** [nsterm.o] Error 1
make: *** [src] Error 2


It should probably be wrapped with something like this (untested):

  #if MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_7

-David


[smime.p7s (application/pkcs7-signature, attachment)]

This bug report was last modified 10 years and 276 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.