From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 13 19:40:55 2013 Received: (at submit) by debbugs.gnu.org; 13 Sep 2013 23:40:56 +0000 Received: from localhost ([127.0.0.1]:34998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKcyt-0007e0-3j for submit@debbugs.gnu.org; Fri, 13 Sep 2013 19:40:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57308) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKcPz-0006dC-NF for submit@debbugs.gnu.org; Fri, 13 Sep 2013 19:04:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKcPl-0006SW-0k for submit@debbugs.gnu.org; Fri, 13 Sep 2013 19:04:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKcPk-0006SR-Ty for submit@debbugs.gnu.org; Fri, 13 Sep 2013 19:04:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKcPd-0003Ou-CC for bug-automake@gnu.org; Fri, 13 Sep 2013 19:04:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKcPW-0006RX-22 for bug-automake@gnu.org; Fri, 13 Sep 2013 19:04:29 -0400 Received: from mail.physnet.uni-hamburg.de ([134.100.106.230]:44271) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKcPV-0006QD-Ri for bug-automake@gnu.org; Fri, 13 Sep 2013 19:04:21 -0400 Received: from dslb-178-003-232-230.pools.arcor-ip.net ([178.3.232.230] helo=[192.168.2.101]) by mail.physnet.uni-hamburg.de with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1VKcP5-0004k5-39 for bug-automake@gnu.org; Sat, 14 Sep 2013 01:03:55 +0200 Message-ID: <52339A71.6010104@debian.org> Date: Sat, 14 Sep 2013 01:06:25 +0200 From: Tobias Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130704 Icedove/17.0.7 MIME-Version: 1.0 To: bug-automake@gnu.org Subject: install-sh -t accepts arguments that are not a directory X-Enigmail-Version: 1.5.1 Content-Type: multipart/mixed; boundary="------------020005010400000104010409" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 13 Sep 2013 19:40:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------020005010400000104010409 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Version: 1.14 Tags: patch Hi automake maintainers, the -t parameter of install-sh is supposed to accept a target directory. If it is given a file or a name of a non-existent file/directory, the source is copied into this file. For example, if I have a file foo and do install-sh -t foo2 foo I will have the two files foo and foo2. install-sh should abort whenever the argument of the -t option is not a directory, just like install does. Attached is a patch that fixes the issue. Best regards, Tobias Hansen --------------020005010400000104010409 Content-Type: text/x-diff; name="install-sh_t_check_directory.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="install-sh_t_check_directory.patch" diff -uri a/install-sh b/install-sh --- a/install-sh 2013-09-14 01:04:27.285245115 +0200 +++ b/install-sh 2013-09-14 01:04:34.917244870 +0200 @@ -160,6 +160,10 @@ case $dst_arg in -* | [=\(\)!]) dst_arg=./$dst_arg;; esac + if test ! -d $dst_arg; then + echo "$0: $dst_arg is not a directory." >&2 + exit 1 + fi shift;; -T) no_target_directory=true;; --------------020005010400000104010409-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 18:18:31 2013 Received: (at 15376) by debbugs.gnu.org; 25 Dec 2013 23:18:31 +0000 Received: from localhost ([127.0.0.1]:42131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvxig-0004BS-MP for submit@debbugs.gnu.org; Wed, 25 Dec 2013 18:18:31 -0500 Received: from mail-ee0-f50.google.com ([74.125.83.50]:37330) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvxic-0004BB-Vp; Wed, 25 Dec 2013 18:18:28 -0500 Received: by mail-ee0-f50.google.com with SMTP id c41so3431192eek.37 for ; Wed, 25 Dec 2013 15:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:content-type; bh=+jJGD0ICqQsXSbY1ZuR+bS6FBScM3lvK6hiWFZAHpII=; b=UsaLByNn+keVZ6Rdaf9PmGVtqlAhO2Ol/C3R8B+nDFNnmeH/E/scC7zWIuN9BPBX9a n03uBONhU3Rk/GCvXjuR5JbXmuTA3aRldnN/DnTQd/K+bpJopQgSyNrmfqWY0Hs7RWLo gjisM0mqYfWNV6Zja3aXrHvKRByg0inGUu9H/NQFB4LU6XJ+xy0BDcCMojeFPdLfcC6z FogokiAUkiuBZwylpJ+sb7Vnv2/Q1udglGBYTXWZnfasrQTdakCUbF5Q4Va8RWR5zyB3 nrZpfJegErD+73upAuu+mE5OIFgnxT/wH8RfPsQwwfPbE7szFn3rLWAid7TnLVc/j4Lj O2lQ== X-Received: by 10.15.24.142 with SMTP id j14mr32583152eeu.52.1388013506178; Wed, 25 Dec 2013 15:18:26 -0800 (PST) Received: from [192.168.0.101] (host143-4-dynamic.5-87-r.retail.telecomitalia.it. [87.5.4.143]) by mx.google.com with ESMTPSA id p45sm67817649eeg.1.2013.12.25.15.18.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 25 Dec 2013 15:18:24 -0800 (PST) Message-ID: <52BB67B6.7020200@gmail.com> Date: Thu, 26 Dec 2013 00:18:14 +0100 From: Stefano Lattarini MIME-Version: 1.0 To: Tobias Hansen Subject: [PATCH] install-sh: be stricter in catching invalid usages Content-Type: multipart/mixed; boundary="------------010707050802050801010800" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15376 Cc: 15376@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------010707050802050801010800 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit severity 15376 minor tags 15376 + patch close 15376 stop Reference: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15376 Hi Tobias, thanks for the report and the patch, and sorry for the shameful delay. I've adjusted the problem you reported, plus other similar issues I noticed along the way, with the attached patch. Thank you, Stefano --------------010707050802050801010800 Content-Type: text/x-patch; name="0001-install-sh-be-stricter-in-catching-invalid-usages.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-install-sh-be-stricter-in-catching-invalid-usages.patch" >From 222337e60bfc87456773a4c7cbbbd3192fde956d Mon Sep 17 00:00:00 2001 Message-Id: <222337e60bfc87456773a4c7cbbbd3192fde956d.1388013465.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Thu, 26 Dec 2013 00:07:27 +0100 Subject: [PATCH] install-sh: be stricter in catching invalid usages Such usages (which are rejected by GNU install as well) are: - options -d and -t used together; - argument passed to option -t must be a directory; - if there are two or more SOURCEFILE arguments, the DESTINATION argument must be a directory. Note that we still allow the use of options -d and -T together, by making -d take the precedence; this is for compatibility with GNU install. This change fixes, among other things, automake bug#15376. * lib/install-sh: Adjust. * t/install-sh-unittests.sh: Enhance. * NEWS: Update. * THANKS: Add reporter of bug#15376. Helped-by: Tobias Hansen Signed-off-by: Stefano Lattarini --- NEWS | 13 +++++++++--- THANKS | 1 + lib/install-sh | 31 ++++++++++++++++++++++----- t/install-sh-unittests.sh | 54 ++++++++++++++++++++++++++++++++--------------- 4 files changed, 74 insertions(+), 25 deletions(-) diff --git a/NEWS b/NEWS index a6e1979..8d902c0 100644 --- a/NEWS +++ b/NEWS @@ -64,15 +64,22 @@ New in 1.15: -* Cleanups and modernizations: +* Improvements and refactorings in the install-sh script: - - The install-sh script has been modernized, and now makes the following - assumptions *unconditionally*: + - It has been modernized, and now makes the following assumptions + *unconditionally*: (1) a working 'dirname' program is available; (2) the ${var:-value} shell parameters substitution works; (3) the "set -f" and "set +f" shell commands work, and, respectively, disable and enable shell globbing. + - The script implements stricter error checking, an it will now complain + and bail out if: + (1) the options -d and -t are used together; + (2) the argument passed to option -t must be a directory; + (3) if there are two or more SOURCEFILE arguments, the + DESTINATION argument must be a directory. + * Automake-generated testsuites: - The default test-driver used by the Automake-generates testsuites now diff --git a/THANKS b/THANKS index e4f70f3..2b4f8ee 100644 --- a/THANKS +++ b/THANKS @@ -401,6 +401,7 @@ Tim Mooney mooney@dogbert.cc.ndsu.NoDak.edu Tim Retout diocles@debian.org Tim Rice tim@multitalents.net Tim Van Holder tim.van.holder@pandora.be +Tobias Hansen thansen@debian.org Toshio Kuratomi toshio@tiki-lounge.com Tom Epperly tepperly@llnl.gov Tom Rini tom_rini@mentor.com diff --git a/lib/install-sh b/lib/install-sh index 0436737..d8de87f 100755 --- a/lib/install-sh +++ b/lib/install-sh @@ -1,7 +1,7 @@ #!/bin/sh # install - install a program, script, or datafile -scriptversion=2013-10-30.23; # UTC +scriptversion=2013-12-25.23; # UTC # This originates from X11R5 (mit/util/scripts/install.sh), which was # later released in X11R6 (xc/config/util/install.sh) with the @@ -82,7 +82,7 @@ dir_arg= dst_arg= copy_on_change=false -no_target_directory= +is_target_a_directory=possibly usage="\ Usage: $0 [OPTION]... [-T] SRCFILE DSTFILE @@ -139,14 +139,16 @@ while test $# -ne 0; do -s) stripcmd=$stripprog;; - -t) dst_arg=$2 + -t) + is_target_a_directory=always + dst_arg=$2 # Protect names problematic for 'test' and other utilities. case $dst_arg in -* | [=\(\)!]) dst_arg=./$dst_arg;; esac shift;; - -T) no_target_directory=true;; + -T) is_target_a_directory=never;; --version) echo "$0 $scriptversion"; exit $?;; @@ -161,6 +163,16 @@ while test $# -ne 0; do shift done +# We allow the use of options -d and -T together, by making -d +# take the precedence; this is for compatibility with GNU install. + +if test -n "$dir_arg"; then + if test -n "$dst_arg"; then + echo "$0: target directory not allowed when installing a directory." >&2 + exit 1 + fi +fi + if test $# -ne 0 && test -z "$dir_arg$dst_arg"; then # When -d is used, all remaining arguments are directories to create. # When -t is used, the destination is already specified. @@ -181,6 +193,15 @@ if test $# -ne 0 && test -z "$dir_arg$dst_arg"; then done fi +if test -z "$dir_arg"; then + if test $# -gt 1 || test "$is_target_a_directory" = always; then + if test ! -d "$dst_arg"; then + echo "$0: $dst_arg: Is not a directory." >&2 + exit 1 + fi + fi +fi + if test $# -eq 0; then if test -z "$dir_arg"; then echo "$0: no input file specified." >&2 @@ -253,7 +274,7 @@ do # If destination is a directory, append the input filename; won't work # if double slashes aren't ignored. if test -d "$dst"; then - if test -n "$no_target_directory"; then + if test "$is_target_a_directory" = never; then echo "$0: $dst_arg: Is a directory" >&2 exit 1 fi diff --git a/t/install-sh-unittests.sh b/t/install-sh-unittests.sh index 8a60d74..1b85c9c 100644 --- a/t/install-sh-unittests.sh +++ b/t/install-sh-unittests.sh @@ -25,26 +25,46 @@ get_shell_script install-sh ./install-sh && exit 1 ./install-sh -m 644 dest && exit 1 -# Directories. +# Incorrect usages. +: > bar +: > baz +: > qux +./install-sh -d -t foo && exit 1 +./install-sh -d -t foo bar && exit 1 +./install-sh -t foo bar && exit 1 +./install-sh bar baz foo && exit 1 +mkdir foo +./install-sh -d -t foo && exit 1 +./install-sh -d -t foo bar && exit 1 +rmdir foo +rm -f bar baz qux -# It should be OK to create no directory. We sometimes need -# this when directory are conditionally defined. -./install-sh -d -# One directory. -./install-sh -d d0 -test -d d0 -# Multiple directories (for make installdirs). -./install-sh -d d1 d2 d3 d4 -test -d d1 -test -d d2 -test -d d3 -test -d d4 -# Subdirectories. -./install-sh -d p1/p2/p3 p4//p5//p6// -test -d p1/p2/p3 -test -d p4/p5/p6 +# Directories. +for opts in '-d' '-d -T' '-T -d' '-d -T -d' '-T -d -T -d -T'; do + # It should be OK to create no directory. We sometimes need + # this when directory are conditionally defined. + ./install-sh $opts + # One directory. + ./install-sh $opts d0 + test -d d0 + # Multiple directories (for make installdirs). + ./install-sh $opts d1 d2 d3 d4 + test -d d1 + test -d d2 + test -d d3 + test -d d4 + rmdir d[0-9] + # Subdirectories. + ./install-sh $opts p1/p2/p3 p4//p5//p6// + test -d p1/p2/p3 + test -d p4/p5/p6 + rmdir p[0-9]/p[0-9]/p[0-9] + rmdir p[0-9]/p[0-9] + rmdir p[0-9] +done # Files. +mkdir d0 d1 d2 d3 d4 : > x ./install-sh -c -m 644 x y test -f x -- 1.8.5.rc0.335.g7794a68 --------------010707050802050801010800-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 18:43:01 2013 Received: (at 15376) by debbugs.gnu.org; 25 Dec 2013 23:43:01 +0000 Received: from localhost ([127.0.0.1]:42160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvy6P-00062Y-3p for submit@debbugs.gnu.org; Wed, 25 Dec 2013 18:43:01 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:36965) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvy6M-00062P-Ru for 15376@debbugs.gnu.org; Wed, 25 Dec 2013 18:42:59 -0500 Received: by mail-ee0-f45.google.com with SMTP id d49so3453343eek.32 for <15376@debbugs.gnu.org>; Wed, 25 Dec 2013 15:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=0IBF8K4GRmGBQCpEMkcdfcYSuhaqV0pciAsmZH1MED8=; b=V6qP6duH8A0zE6F2T5mWS7eiiRhacwxb+pmhWQEsOUAE7EjJrgUIGGBDiTRnNovvYe WkzjrAJb8yEh2fjDfHpsLfeIba5hVRUMnXvVz0krJ99y0zapvqAjJ7dHbia5mGevdBZK TeOdqCIQdn7TX3Q+MxbRIgv07dZZP0lWbBKcn+ACL/Vft/ZgV7+vywi0M7o+sjMs45fN tiSwNz95KVxQrLbRf1A9LD2cmK+e2c+EWfCXm1/sdXGqC+BeI19UfoJwlr5B7jvx2Nhs ea2uaPkg8b2/Mr6R/21N0I+dKvtZEZjPxBHBGHOc+oFtIxIVoZ6RCp80m102TnKH2lr/ ckOw== X-Received: by 10.14.3.130 with SMTP id 2mr33532859eeh.36.1388014977842; Wed, 25 Dec 2013 15:42:57 -0800 (PST) Received: from localhost.localdomain (host143-4-dynamic.5-87-r.retail.telecomitalia.it. [87.5.4.143]) by mx.google.com with ESMTPSA id e3sm67939144eeg.11.2013.12.25.15.42.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Dec 2013 15:42:57 -0800 (PST) From: Stefano Lattarini To: automake-patches@gnu.org Subject: [FYI] {minor} install-sh: a slightly better diagnostic, and tests enhancements Date: Thu, 26 Dec 2013 00:42:44 +0100 Message-Id: <0af75c2ee9d1efa3b0be0192897f8a9792406fab.1388014906.git.stefano.lattarini@gmail.com> X-Mailer: git-send-email 1.8.5.rc0.335.g7794a68 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15376 Cc: 15376@debbugs.gnu.org, Tobias Hansen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * lib/install-sh: When called with no non-option arguments and the '-t' option with an argument that is not an existing directory, have the diagnostic output complain about the lack of required arguments rather than about the bad argument passed to '-t'. * t/install-sh-unittests.sh: Enhance to also check diagnostic printed in cases of expected failure. Signed-off-by: Stefano Lattarini --- lib/install-sh | 18 +++++++++--------- t/install-sh-unittests.sh | 38 ++++++++++++++++++++++++++------------ 2 files changed, 35 insertions(+), 21 deletions(-) diff --git a/lib/install-sh b/lib/install-sh index d8de87f..0b0fdcb 100755 --- a/lib/install-sh +++ b/lib/install-sh @@ -193,15 +193,6 @@ if test $# -ne 0 && test -z "$dir_arg$dst_arg"; then done fi -if test -z "$dir_arg"; then - if test $# -gt 1 || test "$is_target_a_directory" = always; then - if test ! -d "$dst_arg"; then - echo "$0: $dst_arg: Is not a directory." >&2 - exit 1 - fi - fi -fi - if test $# -eq 0; then if test -z "$dir_arg"; then echo "$0: no input file specified." >&2 @@ -213,6 +204,15 @@ if test $# -eq 0; then fi if test -z "$dir_arg"; then + if test $# -gt 1 || test "$is_target_a_directory" = always; then + if test ! -d "$dst_arg"; then + echo "$0: $dst_arg: Is not a directory." >&2 + exit 1 + fi + fi +fi + +if test -z "$dir_arg"; then do_exit='(exit $ret); exit $ret' trap "ret=129; $do_exit" 1 trap "ret=130; $do_exit" 2 diff --git a/t/install-sh-unittests.sh b/t/install-sh-unittests.sh index 1b85c9c..dff0c51 100644 --- a/t/install-sh-unittests.sh +++ b/t/install-sh-unittests.sh @@ -19,23 +19,37 @@ am_create_testdir=empty . test-init.sh +install_sh_fail () +{ + err_rx=$1; shift + ./install-sh ${1+"$@"} 2>stderr && { cat stderr >&2; exit 1; } + cat stderr >&2 + $EGREP "install-sh:.* $err_rx" stderr || exit 1 +} + get_shell_script install-sh # Basic errors. -./install-sh && exit 1 -./install-sh -m 644 dest && exit 1 +install_sh_fail 'no input file specified' +install_sh_fail 'no input file specified' dest +install_sh_fail 'no input file specified' -m 644 dest +install_sh_fail 'no input file specified' -c -t dest # Incorrect usages. : > bar : > baz : > qux -./install-sh -d -t foo && exit 1 -./install-sh -d -t foo bar && exit 1 -./install-sh -t foo bar && exit 1 -./install-sh bar baz foo && exit 1 +install_sh_fail 'target directory not allowed when installing a directory' \ + -d -t foo +install_sh_fail 'target directory not allowed when installing a directory' \ + -d -t foo bar +install_sh_fail 'foo: [iI]s not a directory' -t foo bar +install_sh_fail 'foo: [iI]s not a directory' bar baz foo mkdir foo -./install-sh -d -t foo && exit 1 -./install-sh -d -t foo bar && exit 1 +install_sh_fail 'target directory not allowed when installing a directory' \ + -d -t foo +install_sh_fail 'target directory not allowed when installing a directory' \ + -d -t foo bar rmdir foo rm -f bar baz qux @@ -96,8 +110,8 @@ test -f d4/z ./install-sh -T x d3/y test -f x test -f d3/y -./install-sh -T x d3 && exit 1 -./install-sh -T x d4// && exit 1 +install_sh_fail 'd3: [iI]s a directory' -T x d3 +install_sh_fail 'd4(//)?: [iI]s a directory' -T x d4// # Ensure that install-sh works with names that include spaces. touch 'a b' @@ -108,8 +122,8 @@ test -f 'a b' # Ensure we do not run into 'test' operator precedence bugs with Tru64 sh. for c in = '(' ')' '!'; do - ./install-sh $c 2>stderr && { cat stderr >&2; exit 1; } - cat stderr >&2 + install_sh_fail 'no input file specified' $c + test -f stderr # sanity check grep 'test: ' stderr && exit 1 # Skip tests if the file system is not capable. mkdir ./$c || continue -- 1.8.5.rc0.335.g7794a68 From unknown Sun Sep 21 03:01:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Jan 2014 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator