From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 13 18:18:08 2013 Received: (at submit) by debbugs.gnu.org; 13 Sep 2013 22:18:08 +0000 Received: from localhost ([127.0.0.1]:34849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKbgm-0005RP-H3 for submit@debbugs.gnu.org; Fri, 13 Sep 2013 18:18:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51153) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKbgk-0005Qw-He for submit@debbugs.gnu.org; Fri, 13 Sep 2013 18:18:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKbgV-0002fb-Cf for submit@debbugs.gnu.org; Fri, 13 Sep 2013 18:18:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKbgV-0002fX-9T for submit@debbugs.gnu.org; Fri, 13 Sep 2013 18:17:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKbgM-0005ge-NZ for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2013 18:17:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKbgE-0002bM-5G for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2013 18:17:42 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:31367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKbgD-0002bC-TY for bug-gnu-emacs@gnu.org; Fri, 13 Sep 2013 18:17:34 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r8DMHWEq020447 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Sep 2013 22:17:33 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8DMHVX3008041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 13 Sep 2013 22:17:32 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8DMHVoq008037 for ; Fri, 13 Sep 2013 22:17:31 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 13 Sep 2013 15:17:31 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; Elisp manual: mention what units are used for window margin functions X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) (elisp) `Display Margins` talks a lot about window margins, but AFAICT it never once says which units are used for the functions and variables described there. I'm guessing the unit is `frame-char-width', but Emacs should tell us explicitly here. Moreover, we don't even tell users what a nil value means, as opposed to a whole number. For example, right now, `M-: (window-margins)' returns `(nil)' for me, which corresponds to both LEFT and RIGHT being nil. What does a nil value mean for each of these? In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-08-31 on ODIEONE Bzr revision: 114088 rgm@gnu.org-20130901021232-sazo0qla2qgcko95 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include' From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 05:28:11 2013 Received: (at 15375) by debbugs.gnu.org; 14 Sep 2013 09:28:11 +0000 Received: from localhost ([127.0.0.1]:35767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKm9C-0006Ns-RG for submit@debbugs.gnu.org; Sat, 14 Sep 2013 05:28:11 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:65451) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKm9A-0006Nc-Ra for 15375@debbugs.gnu.org; Sat, 14 Sep 2013 05:28:09 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MT300500ZGHQS00@a-mtaout22.012.net.il> for 15375@debbugs.gnu.org; Sat, 14 Sep 2013 12:28:02 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MT3005YFZMPCYD0@a-mtaout22.012.net.il>; Sat, 14 Sep 2013 12:28:02 +0300 (IDT) Date: Sat, 14 Sep 2013 12:27:52 +0300 From: Eli Zaretskii Subject: Re: bug#15375: 24.3.50; Elisp manual: mention what units are used for window margin functions In-reply-to: X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <8361u3hhwn.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15375 Cc: 15375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 13 Sep 2013 15:17:31 -0700 (PDT) > From: Drew Adams > > (elisp) `Display Margins` talks a lot about window margins, but AFAICT > it never once says which units are used for the functions and variables > described there. I'm guessing the unit is `frame-char-width', but Emacs > should tell us explicitly here. The units are character cells (a.k.a. "columns"). I fixed this in trunk revision 114279. > Moreover, we don't even tell users what a nil value means, as opposed > to a whole number. > > For example, right now, `M-: (window-margins)' returns `(nil)' for me, > which corresponds to both LEFT and RIGHT being nil. What does a nil > value mean for each of these? Fixed that as well. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 11:18:49 2013 Received: (at 15375) by debbugs.gnu.org; 14 Sep 2013 15:18:49 +0000 Received: from localhost ([127.0.0.1]:36773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKrcW-0007yl-4o for submit@debbugs.gnu.org; Sat, 14 Sep 2013 11:18:48 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:48353) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKrcU-0007yW-CF for 15375@debbugs.gnu.org; Sat, 14 Sep 2013 11:18:46 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r8EFIdZ9005795 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 14 Sep 2013 15:18:40 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8EFId7B006426 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 14 Sep 2013 15:18:39 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8EFIc0J025840; Sat, 14 Sep 2013 15:18:38 GMT MIME-Version: 1.0 Message-ID: <56620f72-f813-4a5b-b6bc-3b543ebb8e50@default> Date: Sat, 14 Sep 2013 08:18:38 -0700 (PDT) From: Drew Adams To: Eli Zaretskii , Drew Adams Subject: RE: bug#15375: 24.3.50; Elisp manual: mention what units are used for window margin functions References: <> <<8361u3hhwn.fsf@gnu.org>> In-Reply-To: <<8361u3hhwn.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 15375 Cc: 15375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) > > (elisp) `Display Margins` talks a lot about window margins, but AFAICT > > it never once says which units are used for the functions and variables > > described there. I'm guessing the unit is `frame-char-width', but Emac= s > > should tell us explicitly here. >=20 > The units are character cells (a.k.a. "columns"). >=20 > I fixed this in trunk revision 114279. >=20 > > Moreover, we don't even tell users what a nil value means, as opposed > > to a whole number. > > > > For example, right now, `M-: (window-margins)' returns `(nil)' for me, > > which corresponds to both LEFT and RIGHT being nil. What does a nil > > value mean for each of these? >=20 > Fixed that as well. Thanks. Do you want me to close the bug, or do you want to? (Dunno whether you wanted to keep it open for some reason.) From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 11:29:58 2013 Received: (at 15375) by debbugs.gnu.org; 14 Sep 2013 15:29:58 +0000 Received: from localhost ([127.0.0.1]:36777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKrnJ-0008Fx-Kb for submit@debbugs.gnu.org; Sat, 14 Sep 2013 11:29:58 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:60845) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKrnG-0008Fg-Ee for 15375@debbugs.gnu.org; Sat, 14 Sep 2013 11:29:56 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MT400800G9L9N00@a-mtaout22.012.net.il> for 15375@debbugs.gnu.org; Sat, 14 Sep 2013 18:29:47 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MT4007USGDKWQE0@a-mtaout22.012.net.il>; Sat, 14 Sep 2013 18:29:45 +0300 (IDT) Date: Sat, 14 Sep 2013 18:29:36 +0300 From: Eli Zaretskii Subject: Re: bug#15375: 24.3.50; Elisp manual: mention what units are used for window margin functions In-reply-to: <56620f72-f813-4a5b-b6bc-3b543ebb8e50@default> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83ob7vfmlb.fsf@gnu.org> References: <56620f72-f813-4a5b-b6bc-3b543ebb8e50@default> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15375 Cc: 15375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 14 Sep 2013 08:18:38 -0700 (PDT) > From: Drew Adams > Cc: 15375@debbugs.gnu.org > > > > (elisp) `Display Margins` talks a lot about window margins, but AFAICT > > > it never once says which units are used for the functions and variables > > > described there. I'm guessing the unit is `frame-char-width', but Emacs > > > should tell us explicitly here. > > > > The units are character cells (a.k.a. "columns"). > > > > I fixed this in trunk revision 114279. > > > > > Moreover, we don't even tell users what a nil value means, as opposed > > > to a whole number. > > > > > > For example, right now, `M-: (window-margins)' returns `(nil)' for me, > > > which corresponds to both LEFT and RIGHT being nil. What does a nil > > > value mean for each of these? > > > > Fixed that as well. > > Thanks. Do you want me to close the bug, or do you want to? > (Dunno whether you wanted to keep it open for some reason.) I left it open to allow you to review the changes. You can do that either by pointing your browser at http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/doc/lispref/display.texi and going down to line 4160, or by waiting for the next binary snapshot of the trunk. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 12:26:55 2013 Received: (at 15375) by debbugs.gnu.org; 14 Sep 2013 16:26:55 +0000 Received: from localhost ([127.0.0.1]:36841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKsgQ-0001G5-3r for submit@debbugs.gnu.org; Sat, 14 Sep 2013 12:26:54 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:23484) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKsgN-0001Fp-HB for 15375@debbugs.gnu.org; Sat, 14 Sep 2013 12:26:52 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r8EGQi46011061 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 14 Sep 2013 16:26:45 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8EGQhTZ000754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 14 Sep 2013 16:26:44 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r8EGQhR2006084; Sat, 14 Sep 2013 16:26:43 GMT MIME-Version: 1.0 Message-ID: <4b95cb27-17b0-49ac-9fa2-a9d1445e75d9@default> Date: Sat, 14 Sep 2013 09:26:42 -0700 (PDT) From: Drew Adams To: Eli Zaretskii , Drew Adams Subject: RE: bug#15375: 24.3.50; Elisp manual: mention what units are used for window margin functions References: <<56620f72-f813-4a5b-b6bc-3b543ebb8e50@default>> <<83ob7vfmlb.fsf@gnu.org>> In-Reply-To: <<83ob7vfmlb.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 15375 Cc: 15375@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) > I left it open to allow you to review the changes. You can do that > either by pointing your browser at > http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/head:/doc/lispref/dis= pla > y.texi and going down to line 4160, or by waiting for the next binary > snapshot of the trunk. Thanks, and thanks for that URL & line #. Looks good, but I have these minor suggestions, if you have the time: 1. Move the "(a.k.a.@: ``column'')" to the first occurrence of "character cell". I, for one, did not know the latter term, and wondered about it until I got to that aka. 2. You can remove this part, as it is implied: "; if none of the two margin= s exist, the function returns @code{(nil)}." (It does not hurt, but in that case please change "none" to "neither", to be clearer.) 3. You should add a comma before "and" in "The argument @var{left} controls the left margin and @var{right} controls the right margin (default @code{0}= )." , Alternatively, you can use ";" instead of ", and", or split it into two sentences. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 14 12:34:02 2013 Received: (at 15375-done) by debbugs.gnu.org; 14 Sep 2013 16:34:02 +0000 Received: from localhost ([127.0.0.1]:36863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKsnJ-0001Sc-UD for submit@debbugs.gnu.org; Sat, 14 Sep 2013 12:34:02 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:43512) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKsnG-0001S1-HH for 15375-done@debbugs.gnu.org; Sat, 14 Sep 2013 12:34:00 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MT400D00J60ZX00@a-mtaout20.012.net.il> for 15375-done@debbugs.gnu.org; Sat, 14 Sep 2013 19:33:51 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MT400EZZJCF0T00@a-mtaout20.012.net.il>; Sat, 14 Sep 2013 19:33:51 +0300 (IDT) Date: Sat, 14 Sep 2013 19:33:42 +0300 From: Eli Zaretskii Subject: Re: bug#15375: 24.3.50; Elisp manual: mention what units are used for window margin functions In-reply-to: <4b95cb27-17b0-49ac-9fa2-a9d1445e75d9@default> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83li2zfjmh.fsf@gnu.org> References: <4b95cb27-17b0-49ac-9fa2-a9d1445e75d9@default> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15375-done Cc: 15375-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 14 Sep 2013 09:26:42 -0700 (PDT) > From: Drew Adams > Cc: 15375@debbugs.gnu.org > > 1. Move the "(a.k.a.@: ``column'')" to the first occurrence of "character > cell". I, for one, did not know the latter term, and wondered about it > until I got to that aka. > > 2. You can remove this part, as it is implied: "; if none of the two margins > exist, the function returns @code{(nil)}." (It does not hurt, but in that > case please change "none" to "neither", to be clearer.) > > 3. You should add a comma before "and" in "The argument @var{left} controls > the left margin and @var{right} controls the right margin (default @code{0})." > , > Alternatively, you can use ";" instead of ", and", or split it into two > sentences. Done. From unknown Sun Sep 21 01:06:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 13 Oct 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator