GNU bug report logs - #1537
diff-mode for git patches trouble

Previous Next

Package: emacs;

Reported by: Dmitriy Blinov <bda <at> mns.spb.ru>

Date: Thu, 11 Dec 2008 13:15:02 UTC

Severity: wishlist

Merged with 1536

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #34 received at control <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Dmitriy Blinov <bda <at> mns.spb.ru>
Cc: 1537 <at> debbugs.gnu.org
Subject: Re: bug#1537: diff-mode for git patches trouble
Date: Fri, 12 Dec 2008 14:08:19 -0500

severity 1537 wishlist
thanks

>> Of course, in the general case the problem is insoluble (e.g. if you
>> edit the line with the "--"), but clearly we can do better in the
>> "normal" case.
> Probably it was incorrect to post this feature here.  In fact it's git
> problem but not emacs.

No, it definitely has its place here: while it's true that Git's output
is not very friendly to patch-editing as supported by diff-mode, the
output is formally correct and unambiguous.
And your example of changes is also unambiguous, so you can definitely
argue that Emacs should behave correctly in this case.


        Stefan
This bug report was last modified 4 years and 223 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.