GNU bug report logs - #15350
[PATCH 19/19] tests: Restrict gpt-header-munge to little-endian systems

Previous Next

To reply to this bug, email your comments to 15350 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: bug-parted <at> gnu.org
Subject: [PATCH 19/19] tests: Restrict gpt-header-munge to little-endian
 systems
Date: Wed, 11 Sep 2013 12:25:09 -0700

From: "Brian C. Lane" <bcl <at> redhat.com>

gpt-header-munge uses perl to manipulate the gpt header for the test. It
only works on 64 bit little-endian systems so restrict it to x86_64
only.

* tests/t0210-gpt-resized-partition-entry-array.sh: Skip if not x86_64
* tests/t0211-gpt-rewrite-header.sh: Skip if not x86_64
---
 tests/t0210-gpt-resized-partition-entry-array.sh | 5 +++++
 tests/t0211-gpt-rewrite-header.sh                | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/tests/t0210-gpt-resized-partition-entry-array.sh b/tests/t0210-gpt-resized-partition-entry-array.sh
index 8854018..512f342 100755
--- a/tests/t0210-gpt-resized-partition-entry-array.sh
+++ b/tests/t0210-gpt-resized-partition-entry-array.sh
@@ -19,6 +19,11 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../parted $srcdir
 require_perl_digest_crc_
 
+# gpt-header-munge will fail on big-endian systems
+if test $(uname -m) != x86_64; then
+  skip_ 'this test only works on little-endian systems'
+fi
+
 ss=$sector_size_
 
 N=2M
diff --git a/tests/t0211-gpt-rewrite-header.sh b/tests/t0211-gpt-rewrite-header.sh
index 58625a2..a87e753 100644
--- a/tests/t0211-gpt-rewrite-header.sh
+++ b/tests/t0211-gpt-rewrite-header.sh
@@ -23,6 +23,11 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../parted $srcdir
 require_perl_digest_crc_
 
+# gpt-header-munge will fail on big-endian systems
+if test $(uname -m) != x86_64; then
+  skip_ 'this test only works on little-endian systems'
+fi
+
 ss=$sector_size_
 
 ns=100         # Initial number of sectors.
-- 
1.8.3.1

Message #8 received at 15350 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: "Brian C. Lane" <bcl <at> redhat.com>, 15350 <at> debbugs.gnu.org
Subject: Re: bug#15350: [PATCH 19/19] tests: Restrict gpt-header-munge to
 little-endian systems
Date: Fri, 28 Feb 2014 14:15:52 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 9/11/2013 3:25 PM, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl <at> redhat.com>
> 
> gpt-header-munge uses perl to manipulate the gpt header for the
> test. It only works on 64 bit little-endian systems so restrict it
> to x86_64 only.

I was wondering; is this a bug in the script, or a bug in perl?  It
would be preferable to fix it so it works than to skip it.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJTEOBoAAoJEI5FoCIzSKrwUXMIAKhxkI6MVUFujfTa0X2r6GUk
fHykFPJExwaxNe5OI0YDlaBJznxe8/KdzPB+3Gzoubnze5pgJSgY0ibCsfqsgH4O
DOt0zpULEQ3CWwrNf9XiI1wNuzYOYYZ7I33k+4xWe2w/P8jLAOOcM+oFtEp4wkJu
O8h4K2qZU9kjtekaSdv0XMa6LU5X8F6Ue2NaCMd3OwMXjmkAZ4QzIuOhbH8PKm0R
I6LIOEO32lU9DGpxg+IarRFe80PKAvq/XyzL/2w1oTVxQAtqkeNuELixOPoKCw8g
5sJB6cPPmBqkMp9rE/iGl+TR1GB8iMeg+eaQi26YG2c+oSXHqhIGoMeLS8s93JM=
=xQgN
-----END PGP SIGNATURE-----

Message #11 received at 15350 <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: 15350 <at> debbugs.gnu.org
Subject: Re: bug#15350: [PATCH 19/19] tests: Restrict gpt-header-munge to
 little-endian systems
Date: Fri, 28 Feb 2014 11:29:52 -0800

On Fri, Feb 28, 2014 at 02:15:52PM -0500, Phillip Susi wrote:
> On 9/11/2013 3:25 PM, Brian C. Lane wrote:
> > From: "Brian C. Lane" <bcl <at> redhat.com>
> > 
> > gpt-header-munge uses perl to manipulate the gpt header for the
> > test. It only works on 64 bit little-endian systems so restrict it
> > to x86_64 only.
> 
> I was wondering; is this a bug in the script, or a bug in perl?  It
> would be preferable to fix it so it works than to skip it.

IIRC it is a problem with using perl to do this, its unpack doesn't
handle the order correctly.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Message #14 received at 15350 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: "Brian C. Lane" <bcl <at> redhat.com>
Cc: 15350 <at> debbugs.gnu.org
Subject: Re: bug#15350: [PATCH 19/19] tests: Restrict gpt-header-munge to
 little-endian systems
Date: Sat, 01 Mar 2014 21:57:38 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 02/28/2014 02:29 PM, Brian C. Lane wrote:
>>> gpt-header-munge uses perl to manipulate the gpt header for
>>> the test. It only works on 64 bit little-endian systems so
>>> restrict it to x86_64 only.
>> 
>> I was wondering; is this a bug in the script, or a bug in perl?
>> It would be preferable to fix it so it works than to skip it.
> 
> IIRC it is a problem with using perl to do this, its unpack
> doesn't handle the order correctly.

So this test already fails for me on current git master ( didn't have
that perl module installed before so it was skipped ), apparently
because gpt-header-munge puts the backup gpt in the wrong place.  Do
you happen to remember what the error was you saw on the other systems?


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJTEp4iAAoJEI5FoCIzSKrwffcH/2fxgV89d67x0QRe6I7ohSai
SDNL+b7vnzfP4bHhkIjh8EK1EZQN12v3T5/nC26toMCm3VKYvMx1Tv4KOyEDrPlT
kVt7cmndHlx98oQ+4ym2RQZSedzdDQqXuR3YhFusgleExdgYTS3fZ2W3QDnVhQSg
Of5L3lGidB39poy5gqwnetwfpPdlpV/aQxiAn3H4TH8rWJIa/0S4FDWeDh/HHSUN
IBRnhGhjgutlxk+KmC9cvz1edRt8UpiDfoKy7Mf/B6DrBJ4YRMERrIqdSXbR83+h
lR4yBFOIz53uPy5LXoMp9JhsBAV/5ff3IkIkXvm4gLGYfSw0PI/dKYYHDnM76Ic=
=ITxh
-----END PGP SIGNATURE-----

Message #17 received at 15350 <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: 15350 <at> debbugs.gnu.org
Subject: Re: bug#15350: [PATCH 19/19] tests: Restrict gpt-header-munge to
 little-endian systems
Date: Mon, 3 Mar 2014 07:11:16 -0800

On Sat, Mar 01, 2014 at 09:57:38PM -0500, Phillip Susi wrote:
> On 02/28/2014 02:29 PM, Brian C. Lane wrote:
> >>> gpt-header-munge uses perl to manipulate the gpt header for
> >>> the test. It only works on 64 bit little-endian systems so
> >>> restrict it to x86_64 only.
> >> 
> >> I was wondering; is this a bug in the script, or a bug in perl?
> >> It would be preferable to fix it so it works than to skip it.
> > 
> > IIRC it is a problem with using perl to do this, its unpack
> > doesn't handle the order correctly.
> 
> So this test already fails for me on current git master ( didn't have
> that perl module installed before so it was skipped ), apparently
> because gpt-header-munge puts the backup gpt in the wrong place.  Do
> you happen to remember what the error was you saw on the other systems?

Sorry I don't. I just remember that it was related to big vs. little
endian support.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.