GNU bug report logs - #15348
[PATCH 11/19] libparted: don't canonicalize /dev/md/ paths (#872361)

Previous Next

Full log

Message #20 received at 15348 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: "Brian C. Lane" <bcl <at> redhat.com>
Cc: 15348 <at> debbugs.gnu.org
Subject: Re: bug#15348: [PATCH 11/19] libparted: don't canonicalize /dev/md/
 paths (#872361)
Date: Wed, 02 Oct 2013 15:13:26 -0400

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/2/2013 2:45 PM, Brian C. Lane wrote:
> I think parted should always stick with the name the user gives it.
> I'm not sure what side-effects that would have so that's why I only
> changed it for /dev/md/

I kind of like the fact that it tells you what the "real" device is
when you run it on a symlink.

> I don't think looking up specific majors is useful here, the
> actual problem is that when something uses libparted (eg. anaconda)
> to open a device and then later tries to look it up by that same
> path it won't find it if the symlink is followed and the name
> changed.

I don't follow.

> Personally, I can't think of a situation where I'd ever want the
> name I give it to be changed, whether I'm using the cli or
> libparted. Maybe we should drop that whole bit and just use the
> path we're given?

Just because you have a symlink to a disk doesn't mean the partitions
will follow suit.  For instance, if you look at /dev/disk/by-id/foo,
you don't have /dev/disk/by-id/foo1.  That means that we at least
internally have to canonicalize the name to open the correct partition
node.  Would calling tools then be confused and try to look for the
partition in /dev/disk/by-id?


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSTHBWAAoJEJrBOlT6nu75554H/RWRBs2b1NCjv1e38vugEfGy
Iea6//amNYDdWd2bOcwisvZaxWm/X3o399ZORpP88WxrGtub1Pb34ynpLDDpQ5zK
8cc/NBzqJ3ho74F5vb2FyXtg4SrMrDlkC9GO7g3S7NVhKAJHxPNx6WQ4L1MACEus
b2DDx8xEplwYpgSc0FG73Gg5JTi6hF/GmT8tqufPBbQcXg/W6/9vUYclmctGrz74
XdHbGJXXB5zkvFua0J8bjVKdLckaGR/JbiKJF7eG1tpgYp1uSCHC6MgYF8EHe+kq
eiWPEkgzrlHlvYP5k51RKms386AeQLhrY2fn4eolrWLZKQJe8Si8t+AglZtXKNo=
=YeAt
-----END PGP SIGNATURE-----

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.