GNU bug report logs - #15347
[PATCH 18/19] libparted: Flush parent device on open (#962611)

Previous Next

Full log

View this message in rfc822 format

From: "Brian C. Lane" <bcl <at> redhat.com>
To: 15347 <at> debbugs.gnu.org
Subject: bug#15347: [PATCH 18/19] libparted: Flush parent device on open (#962611)
Date: Wed, 11 Sep 2013 12:25:08 -0700

From: "Brian C. Lane" <bcl <at> redhat.com>

Parted probes for filesystems using geometry offsets into the parent
device, not the partition device itself. This means it may get stale
information if a partition has just been formatted.

On kernels before 2.6 this will also flush all partition devices. On 2.6
and newer kernels it will only flush the parent device.

* libparted/arch/linux.c (linux_open): Always call _flush_cache
---
 libparted/arch/linux.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/libparted/arch/linux.c b/libparted/arch/linux.c
index 375be83..492f828 100644
--- a/libparted/arch/linux.c
+++ b/libparted/arch/linux.c
@@ -1669,9 +1669,7 @@ retry:
                 dev->read_only = 0;
         }
 
-        /* With kernels < 2.6 flush cache for cache coherence issues */
-        if (!_have_kern26())
-                _flush_cache (dev);
+        _flush_cache (dev);
 
         return 1;
 }
-- 
1.8.3.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.