From unknown Sun Jun 22 22:45:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15323: 24.3; make hideshow use outline-minor-mode-prefix or a similar hs-minor-mode-prefix Resent-From: Susanne Oberhauser Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Sep 2013 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15323 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 15323@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.137883272628466 (code B ref -1); Tue, 10 Sep 2013 17:06:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Sep 2013 17:05:26 +0000 Received: from localhost ([127.0.0.1]:52948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJRNT-0007Ou-7C for submit@debbugs.gnu.org; Tue, 10 Sep 2013 13:05:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53568) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJRBR-00073B-Ml for submit@debbugs.gnu.org; Tue, 10 Sep 2013 12:52:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJRBE-0003dB-Uk for submit@debbugs.gnu.org; Tue, 10 Sep 2013 12:52:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJRBE-0003d6-R4 for submit@debbugs.gnu.org; Tue, 10 Sep 2013 12:52:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJRB8-00007y-KZ for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 12:52:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJRB2-0003TY-EE for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 12:52:38 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:38211) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJRB2-0003P4-4T for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 12:52:32 -0400 Received: from byron.suse.de (charybdis-ext.suse.de [195.135.221.2]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Tue, 10 Sep 2013 18:52:29 +0200 From: Susanne Oberhauser Date: Tue, 10 Sep 2013 18:51:46 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Mailman-Approved-At: Tue, 10 Sep 2013 13:05:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hi, hideshow mode has the prefix C-c @ hard coded in it's minor mode map. C-c @ on a german keyboard actually is C-c M-q That makes C-c @ C-h into C-c AltGr-q C-h which is slow and puts my fingers at risk :) Now outline minor mode allows to simply define the minor mode prefix to something more convenient. I'd love to have this in hideshow mode, too, e.g. along the lines in the patch below. Thanks, S. =3D=3D=3D modified file 'lisp/progmodes/hideshow.el' --- lisp/progmodes/hideshow.el 2013-03-05 17:13:01 +0000 +++ lisp/progmodes/hideshow.el 2013-09-10 16:28:05 +0000 @@ -335,6 +335,13 @@ as how to set its `display' property. See `hs-make-overlay' and info node `(elisp)Overlays'.") =20 +(defcustom hs-minor-mode-prefix "\C-c@" + "Prefix key to use for hideshow commands in hideshow minor mode. +The value of this variable is only checked as part of loading hideshow mod= e. +After that, changing the prefix key requires manipulating keymaps." + :type 'string + :group 'hideshow) + ;;------------------------------------------------------------------------= --- ;; internal variables =20 @@ -343,14 +350,16 @@ Use the command `hs-minor-mode' to toggle or set this variable.") =20 (defvar hs-minor-mode-map - (let ((map (make-sparse-keymap))) - ;; These bindings roughly imitate those used by Outline mode. - (define-key map "\C-c@\C-h" 'hs-hide-block) - (define-key map "\C-c@\C-s" 'hs-show-block) - (define-key map "\C-c@\C-\M-h" 'hs-hide-all) - (define-key map "\C-c@\C-\M-s" 'hs-show-all) - (define-key map "\C-c@\C-l" 'hs-hide-level) - (define-key map "\C-c@\C-c" 'hs-toggle-hiding) + (let ((map (make-sparse-keymap)) + (prefixed-map (make-sparse-keymap))) + ;; These bindings very roughly imitate those used by Outline mode. + (define-key prefixed-map "\C-h" 'hs-hide-block) + (define-key prefixed-map "\C-s" 'hs-show-block) + (define-key prefixed-map "\C-\M-h" 'hs-hide-all) + (define-key prefixed-map "\C-\M-s" 'hs-show-all) + (define-key prefixed-map "\C-l" 'hs-hide-level) + (define-key prefixed-map "\C-c" 'hs-toggle-hiding) + (define-key map hs-minor-mode-prefix prefixed-map) (define-key map [(shift mouse-2)] 'hs-mouse-toggle-hiding) map) "Keymap for hideshow minor mode.") In GNU Emacs 24.3.1 (x86_64-suse-linux-gnu, GTK+ Version 3.6.4) of 2013-06-15 on build35 Windowing system distributor `The X.Org Foundation', version 11.0.11302000 System Description: openSUSE 12.3 (x86_64) --=20 Susanne Oberhauser SUSE LINUX Products GmbH +49-911-74053-574 Maxfeldstra=C3=9Fe 5 Processes and Infrastructure 90409 N=C3=BCrnberg GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer, HRB 16746 (AG N=C3= =BCrnberg) From unknown Sun Jun 22 22:45:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15323: 24.3; make hideshow use outline-minor-mode-prefix or a similar hs-minor-mode-prefix Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2016 04:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15323 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Susanne Oberhauser Cc: 15323@debbugs.gnu.org Received: via spool by 15323-submit@debbugs.gnu.org id=B15323.145628800816051 (code B ref 15323); Wed, 24 Feb 2016 04:27:01 +0000 Received: (at 15323) by debbugs.gnu.org; 24 Feb 2016 04:26:48 +0000 Received: from localhost ([127.0.0.1]:42138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYR2G-0004Ao-Gg for submit@debbugs.gnu.org; Tue, 23 Feb 2016 23:26:48 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:37406) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYR2E-0004Ah-TF for 15323@debbugs.gnu.org; Tue, 23 Feb 2016 23:26:47 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYR1q-0000Bi-Hz; Wed, 24 Feb 2016 05:26:23 +0100 From: Lars Ingebrigtsen References: Date: Wed, 24 Feb 2016 15:26:17 +1100 In-Reply-To: (Susanne Oberhauser's message of "Tue, 10 Sep 2013 18:51:46 +0200") Message-ID: <87io1eiviu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYR1q-0000Bi-Hz X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456892783.35272@x6NjZnNz3jStipMSP5tDkQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Susanne Oberhauser writes: > hideshow mode has the prefix C-c @ hard coded in it's minor mode map. > > C-c @ on a german keyboard actually is C-c M-q > > That makes C-c @ C-h into C-c AltGr-q C-h which is slow and puts my > fingers at risk :) > > Now outline minor mode allows to simply define the minor mode prefix to > something more convenient. > > I'd love to have this in hideshow mode, too, e.g. along the lines in the > patch below. Looks good to me. Could you resubmit the patch (against the Emacs trunk) including documentation changes and an etc/NEWS entry? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 22:45:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15323: 24.3; make hideshow use outline-minor-mode-prefix or a similar hs-minor-mode-prefix Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2016 04:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15323 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Susanne Oberhauser Cc: 15323@debbugs.gnu.org Received: via spool by 15323-submit@debbugs.gnu.org id=B15323.145628920829728 (code B ref 15323); Wed, 24 Feb 2016 04:47:02 +0000 Received: (at 15323) by debbugs.gnu.org; 24 Feb 2016 04:46:48 +0000 Received: from localhost ([127.0.0.1]:42173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYRLZ-0007hT-NY for submit@debbugs.gnu.org; Tue, 23 Feb 2016 23:46:47 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:54048) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYRLV-0007am-I7 for 15323@debbugs.gnu.org; Tue, 23 Feb 2016 23:46:45 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYRL0-0000g2-JS; Wed, 24 Feb 2016 05:46:11 +0100 From: Lars Ingebrigtsen References: <87io1eiviu.fsf@gnus.org> Date: Wed, 24 Feb 2016 15:46:04 +1100 In-Reply-To: <87io1eiviu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 24 Feb 2016 15:26:17 +1100") Message-ID: <87povmhg1f.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYRL0-0000g2-JS X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456893972.42322@Ep4FPtET9Gq+nIllcXpmIQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Ingebrigtsen writes: > Susanne Oberhauser writes: > >> hideshow mode has the prefix C-c @ hard coded in it's minor mode map. >> >> C-c @ on a german keyboard actually is C-c M-q >> >> That makes C-c @ C-h into C-c AltGr-q C-h which is slow and puts my >> fingers at risk :) >> >> Now outline minor mode allows to simply define the minor mode prefix to >> something more convenient. >> >> I'd love to have this in hideshow mode, too, e.g. along the lines in the >> patch below. > > Looks good to me. Could you resubmit the patch (against the Emacs > trunk) including documentation changes and an etc/NEWS entry? The email bounced, so I guess not... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 22:45:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15323: 24.3; make hideshow use outline-minor-mode-prefix or a similar hs-minor-mode-prefix Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 15:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15323 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Susanne Oberhauser Cc: 15323@debbugs.gnu.org Received: via spool by 15323-submit@debbugs.gnu.org id=B15323.156156295725909 (code B ref 15323); Wed, 26 Jun 2019 15:30:02 +0000 Received: (at 15323) by debbugs.gnu.org; 26 Jun 2019 15:29:17 +0000 Received: from localhost ([127.0.0.1]:36848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg9rJ-0006jp-Kk for submit@debbugs.gnu.org; Wed, 26 Jun 2019 11:29:17 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg9rH-0006jf-Mq for 15323@debbugs.gnu.org; Wed, 26 Jun 2019 11:29:16 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg9rA-0001Fs-Um; Wed, 26 Jun 2019 17:29:12 +0200 From: Lars Ingebrigtsen References: <87io1eiviu.fsf@gnus.org> <87povmhg1f.fsf@gnus.org> Date: Wed, 26 Jun 2019 17:29:08 +0200 In-Reply-To: <87povmhg1f.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 24 Feb 2016 15:46:04 +1100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >> Looks good to me. Could you resubmit the patch (against the Emacs >> trunk) including documentation changes and an etc/NEWS entry? > > The email bounced, so I guess not... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> Looks good to me. Could you resubmit the patch (against the Emacs >> trunk) including documentation changes and an etc/NEWS entry? > > The email bounced, so I guess not... And we don't have copyright papers in place, so I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 11:29:21 2019 Received: (at control) by debbugs.gnu.org; 26 Jun 2019 15:29:21 +0000 Received: from localhost ([127.0.0.1]:36851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg9rM-0006k6-RP for submit@debbugs.gnu.org; Wed, 26 Jun 2019 11:29:21 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg9rL-0006jx-DT for control@debbugs.gnu.org; Wed, 26 Jun 2019 11:29:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg9rI-0001G3-TD for control@debbugs.gnu.org; Wed, 26 Jun 2019 17:29:18 +0200 Date: Wed, 26 Jun 2019 17:29:16 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #15323 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 15323 wontfix close 15323 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 15323 wontfix close 15323 quit