GNU bug report logs - #15322
VC log buffer scrolls itself

Previous Next

Full log

Message #43 received at 15322 <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <pogonyshev <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 15322 <at> debbugs.gnu.org
Subject: Re: bug#15322: VC log buffer scrolls itself
Date: Thu, 26 Sep 2013 09:17:52 +0200

[Message part 1 (text/plain, inline)]

In Emacs built from trunk yesterday it still jumps, though to the "correct"
version (the one reported by 'svn info'). However, given that committing
changes from the buffer does not advance the working directory revision
(e.g. what I have now is 26 revisions in the past), I'm not sure how useful
this is, at least for subversion. Probably it's better for saner VCS's, but
for subversion if feels like annoyance.

Paul


On 12 September 2013 21:30, Glenn Morris <rgm <at> gnu.org> wrote:

> Stefan Monnier wrote:
>
> > And I think that makes sense.  It's natural to select a particular
> > revision when running vc-print-log from (say) vc-annotate, but for
> > a plain `C-x v l', the user just wants to see "the log" and presumably
> > doesn't care about which revision happens to be current.
> >
> > IOW, I think we're trying too hard here.
>
> *** lisp/vc/vc.el       2013-09-12 06:10:12 +0000
> --- lisp/vc/vc.el       2013-09-12 19:28:04 +0000
> ***************
> *** 2299,2305 ****
>     (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef
>          (backend (car vc-fileset))
>          (files (cadr vc-fileset))
> !        (working-revision (or working-revision (vc-working-revision (car
> files)))))
>       (vc-print-log-internal backend files working-revision nil limit)))
>
>   ;;;###autoload
> --- 2299,2306 ----
>     (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef
>          (backend (car vc-fileset))
>          (files (cadr vc-fileset))
> ! ;;     (working-revision (or working-revision (vc-working-revision (car
> files))))
> !          )
>       (vc-print-log-internal backend files working-revision nil limit)))
>
>   ;;;###autoload
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.