From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 10 11:44:41 2013 Received: (at submit) by debbugs.gnu.org; 10 Sep 2013 15:44:41 +0000 Received: from localhost ([127.0.0.1]:52767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJQ7M-0004CA-P0 for submit@debbugs.gnu.org; Tue, 10 Sep 2013 11:44:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53768) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJNwI-0000QW-6o for submit@debbugs.gnu.org; Tue, 10 Sep 2013 09:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJNwC-00031A-3X for submit@debbugs.gnu.org; Tue, 10 Sep 2013 09:25:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJNwC-000314-0F for submit@debbugs.gnu.org; Tue, 10 Sep 2013 09:25:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJNw7-0000Ck-5d for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 09:24:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJNw5-000302-RR for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 09:24:55 -0400 Received: from mail-ob0-x22d.google.com ([2607:f8b0:4003:c01::22d]:41351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJNw5-0002zb-MI for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 09:24:53 -0400 Received: by mail-ob0-f173.google.com with SMTP id ta17so7129043obb.32 for ; Tue, 10 Sep 2013 06:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=PRSBPYL6dEEo6ZOju6QHUnWd8eDKNKtBpapMFrIxJzs=; b=kFUViul7dFf2fQhfOFUBF8ns5hWH9GXVT5HYRm34THsUl+gOhG8XrTMddDIQsJyEYg xwJUZ2MIQrSjuFgl9AhEjJdhF6vuNQtPdq4XLzVm2Vqu86MSh1LE4iQZ1tN0lrRxzKqr aAD4TDtXKhATQoHF8jb2dbId8YmQgsQramDnJUtNdkaEJkqGhbqcrelONiNqXFJrLMXZ 5iyidAzHHus0bbxgKhPpOBBhfQepRMhCqdj1F+4cRU6q9K421xwkRelNnpcyaP4sgHFl mggQeDVZP48f/frs9o3MdX2opTA6dqa2GrGAkRktwQkXrNggHgCDVKqTXpO78A03nRXT vmyQ== MIME-Version: 1.0 X-Received: by 10.182.53.196 with SMTP id d4mr3211836obp.7.1378819492854; Tue, 10 Sep 2013 06:24:52 -0700 (PDT) Received: by 10.182.200.163 with HTTP; Tue, 10 Sep 2013 06:24:52 -0700 (PDT) Date: Tue, 10 Sep 2013 15:24:52 +0200 Message-ID: Subject: VC log buffer scrolls itself From: Paul Pogonyshev To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=001a11c1c93a14c01b04e6076e2a X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 10 Sep 2013 11:44:37 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a11c1c93a14c01b04e6076e2a Content-Type: text/plain; charset=UTF-8 To reproduce (this assumes a large project for which log is generated for 5+ seconds): - 'C-x v d' a project directory; - hit 'l' to view log of changes; - visible (top) part of the buffer is filled with the most recent entries, which you are most likely interested in; - wait till log buffer is filled; - observe the log buffer point jump to some arbitrary (or at least I have no idea what it is) revision's entry. This behavior is certainly not wanted for me. Even assuming the entry it jumps to has some special meaning and not chosen randomly, 99% of time I'm interested in the recent changes, not a change 2 years ago. Paul --001a11c1c93a14c01b04e6076e2a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
To reproduce (this assu= mes a large project for which log is generated for 5+ seconds):

- 'C-x v d' a project directory;
- hit 'l' to vi= ew log of changes;
- visible (top) part of the buffer is filled with the most recent ent= ries, which you are most likely interested in;
- wait till log buf= fer is filled;
- observe the log buffer point jump to some arbitra= ry (or at least I have no idea what it is) revision's entry.

This behavior is certainly not wanted for me. Even assuming the e= ntry it jumps to has some special meaning and not chosen randomly, 99% of t= ime I'm interested in the recent changes, not a change 2 years ago.

Paul
--001a11c1c93a14c01b04e6076e2a-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 10 11:57:51 2013 Received: (at 15322) by debbugs.gnu.org; 10 Sep 2013 15:57:51 +0000 Received: from localhost ([127.0.0.1]:52815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJQK6-0004Zd-6r for submit@debbugs.gnu.org; Tue, 10 Sep 2013 11:57:51 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:54942) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJQK2-0004ZM-QX for 15322@debbugs.gnu.org; Tue, 10 Sep 2013 11:57:47 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MSX005002JEAQ00@a-mtaout22.012.net.il> for 15322@debbugs.gnu.org; Tue, 10 Sep 2013 18:57:38 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MSX005HY3028950@a-mtaout22.012.net.il>; Tue, 10 Sep 2013 18:57:38 +0300 (IDT) Date: Tue, 10 Sep 2013 18:57:40 +0300 From: Eli Zaretskii Subject: Re: bug#15322: VC log buffer scrolls itself In-reply-to: X-012-Sender: halo1@inter.net.il To: Paul Pogonyshev Message-id: <838uz4k6tn.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15322 Cc: 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 10 Sep 2013 15:24:52 +0200 > From: Paul Pogonyshev > > To reproduce (this assumes a large project for which log is generated for > 5+ seconds): > > - 'C-x v d' a project directory; > - hit 'l' to view log of changes; > - visible (top) part of the buffer is filled with the most recent entries, > which you are most likely interested in; > - wait till log buffer is filled; > - observe the log buffer point jump to some arbitrary (or at least I have > no idea what it is) revision's entry. With what back-ends, and which Emacs version? FWIW, with either the current trunk or v24.3 I don't see this when the VCS is bzr or git. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 10 12:04:41 2013 Received: (at 15322) by debbugs.gnu.org; 10 Sep 2013 16:04:42 +0000 Received: from localhost ([127.0.0.1]:52826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJQQj-0005mI-0I for submit@debbugs.gnu.org; Tue, 10 Sep 2013 12:04:41 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:57139 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJQQg-0005m9-CR for 15322@debbugs.gnu.org; Tue, 10 Sep 2013 12:04:38 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VJQQf-000817-AD; Tue, 10 Sep 2013 12:04:37 -0400 From: Glenn Morris To: Paul Pogonyshev Subject: Re: bug#15322: VC log buffer scrolls itself References: X-Spook: Semtex threat quarter bemd defense information warfare X-Ran: A%p^o5'--wjCySdP/E5eYCb%!mh'I:?5@N^Y/wL`x8`Fx9Kf)@I~uJsnYOFDVX,mUz)WrA X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 10 Sep 2013 12:04:37 -0400 In-Reply-To: (Paul Pogonyshev's message of "Tue, 10 Sep 2013 15:24:52 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 15322 Cc: 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Paul Pogonyshev wrote: > To reproduce (this assumes a large project for which log is generated for > 5+ seconds): > > - 'C-x v d' a project directory; > - hit 'l' to view log of changes; > - visible (top) part of the buffer is filled with the most recent entries, > which you are most likely interested in; > - wait till log buffer is filled; > - observe the log buffer point jump to some arbitrary (or at least I have > no idea what it is) revision's entry. No, I don't observe that. So please say: what version of Emacs this is, what VCS this is, what file is under point when you hit l, what Emacs thinks the working revision of that file is. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 10 14:05:47 2013 Received: (at 15322) by debbugs.gnu.org; 10 Sep 2013 18:05:48 +0000 Received: from localhost ([127.0.0.1]:53050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJSJv-0000Yu-C6 for submit@debbugs.gnu.org; Tue, 10 Sep 2013 14:05:47 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59279 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJSJo-0000Yf-Go for 15322@debbugs.gnu.org; Tue, 10 Sep 2013 14:05:45 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VJSJn-0003ax-80; Tue, 10 Sep 2013 14:05:39 -0400 From: Glenn Morris To: Paul Pogonyshev Subject: Re: bug#15322: VC log buffer scrolls itself References: X-Spook: Mena Belknap Arnett bullion Waco, Texas Consul national X-Ran: ^>d"kuo@8CZt2|=-k9F*gao:D_"tacay<}Lt)lY~d{3ycrOr~Mx`xyUOX!=`XGAr,ma({. X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 10 Sep 2013 14:05:39 -0400 In-Reply-To: (Glenn Morris's message of "Tue, 10 Sep 2013 12:04:37 -0400") Message-ID: <55fvtc5z7w.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 15322 Cc: 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) I'm going to guess that this happens with svn, and that the revision you end up on is the working revision of whatever file happens to be listed last in the output of: svn status -v /path/to/svn/directory Looks like a bug in vc-svn-parse-status when called with filename == directory, caused by the "don't trust the output's filename unless we have to" part. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 10 14:30:44 2013 Received: (at 15322) by debbugs.gnu.org; 10 Sep 2013 18:30:44 +0000 Received: from localhost ([127.0.0.1]:53112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJSi3-0001zi-HT for submit@debbugs.gnu.org; Tue, 10 Sep 2013 14:30:43 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:41405) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJShz-0001nk-PW for 15322@debbugs.gnu.org; Tue, 10 Sep 2013 14:30:41 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MSX00500A19QP00@a-mtaout23.012.net.il> for 15322@debbugs.gnu.org; Tue, 10 Sep 2013 21:30:07 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MSX005SVA27MU70@a-mtaout23.012.net.il>; Tue, 10 Sep 2013 21:30:07 +0300 (IDT) Date: Tue, 10 Sep 2013 21:30:09 +0300 From: Eli Zaretskii Subject: Re: bug#15322: VC log buffer scrolls itself In-reply-to: <55fvtc5z7w.fsf@fencepost.gnu.org> X-012-Sender: halo1@inter.net.il To: Glenn Morris Message-id: <837geojzri.fsf@gnu.org> References: <55fvtc5z7w.fsf@fencepost.gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15322 Cc: pogonyshev@gmail.com, 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Glenn Morris > Date: Tue, 10 Sep 2013 14:05:39 -0400 > Cc: 15322@debbugs.gnu.org > > I'm going to guess that this happens with svn, and that the revision you > end up on is the working revision of whatever file happens to be listed > last in the output of: svn status -v /path/to/svn/directory Yep, with svn that's what I see, too. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 02:58:32 2013 Received: (at 15322) by debbugs.gnu.org; 11 Sep 2013 06:58:32 +0000 Received: from localhost ([127.0.0.1]:54405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJeNj-00053j-0k for submit@debbugs.gnu.org; Wed, 11 Sep 2013 02:58:31 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:61745) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJeNe-00053S-0K for 15322@debbugs.gnu.org; Wed, 11 Sep 2013 02:58:28 -0400 Received: by mail-ob0-f174.google.com with SMTP id wd6so8127034obb.19 for <15322@debbugs.gnu.org>; Tue, 10 Sep 2013 23:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+oO7xVILRdjJFtfUhkAD7Tx+e7C971JlpSY2bC+9bWE=; b=wfOWqxxsaujWd5Uhum8V83gXo49pCmpZiQ5A4f59KSZ9ut0WquTbysTpicX2E0YzD4 6BibhJm42QeNixckqYSDXUtKnYmCAnkNEYXDkKPyitpwyGDygxjJ7x2Q0x+tbEbzvkIA QYTny4ecGuPU3aCE36GyCIVlyv1rUHA3MTq+geqfE+UGq0uHPYelHxOZJZRPip0eOj4C VyPg59s6/7QthDCgISu4X97C4IbbXSwlQq5TP/o2E9tnB+XFNZjWdU5WqdrLo1pruoOB ORGc+yHRJmkfky3MVwJneQVd3ZF8xg4/8fqPEZAMTpMS1HOVvBqXRP3fQhRD3jmmTmAm zwNg== MIME-Version: 1.0 X-Received: by 10.182.243.138 with SMTP id wy10mr119771obc.83.1378882699953; Tue, 10 Sep 2013 23:58:19 -0700 (PDT) Received: by 10.182.200.163 with HTTP; Tue, 10 Sep 2013 23:58:19 -0700 (PDT) In-Reply-To: <837geojzri.fsf@gnu.org> References: <55fvtc5z7w.fsf@fencepost.gnu.org> <837geojzri.fsf@gnu.org> Date: Wed, 11 Sep 2013 08:58:19 +0200 Message-ID: Subject: Re: bug#15322: VC log buffer scrolls itself From: Paul Pogonyshev To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a11c2a1208492e704e61625d8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 Cc: Glenn Morris , 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c2a1208492e704e61625d8 Content-Type: text/plain; charset=UTF-8 Emacs 24.3.1 (built on 2013-08-07), and yes this happens with svn. However, even if I open log buffer right from the top of 'C-x v d' buffer (i.e. nothing is be selected or even "under the point"), the buffer still jumps to some revision from Dec 2011. Paul On 10 September 2013 20:30, Eli Zaretskii wrote: > > From: Glenn Morris > > Date: Tue, 10 Sep 2013 14:05:39 -0400 > > Cc: 15322@debbugs.gnu.org > > > > I'm going to guess that this happens with svn, and that the revision you > > end up on is the working revision of whatever file happens to be listed > > last in the output of: svn status -v /path/to/svn/directory > > Yep, with svn that's what I see, too. > --001a11c2a1208492e704e61625d8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Emacs 24.3.1 (built on 2013-08-07), and yes this happ= ens with svn. However, even if I open log buffer right from the top of '= ;C-x v d' buffer (i.e. nothing is be selected or even "under the p= oint"), the buffer still jumps to some revision from Dec 2011.

Paul


On 10 September 2013 20:30, Eli Zaretskii <= eliz@gnu.org> wrote:
> From: Glenn Morris <rgm@gnu.org>
> Date: Tue, 10 Sep 2013 14:05:39 -0400
> Cc: 15322@debbugs.gnu.org=
>
> I'm going to guess that this happens with svn, and that the revisi= on you
> end up on is the working revision of whatever file happens to be liste= d
> last in the output of: svn status -v /path/to/svn/directory

Yep, with svn that's what I see, too.

--001a11c2a1208492e704e61625d8-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 09:28:14 2013 Received: (at 15322) by debbugs.gnu.org; 11 Sep 2013 13:28:14 +0000 Received: from localhost ([127.0.0.1]:55194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJkSr-0001kx-5j for submit@debbugs.gnu.org; Wed, 11 Sep 2013 09:28:13 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:39536) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJkSk-0001kO-Gm for 15322@debbugs.gnu.org; Wed, 11 Sep 2013 09:28:07 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MSY00J00QQC8B00@a-mtaout20.012.net.il> for 15322@debbugs.gnu.org; Wed, 11 Sep 2013 16:28:00 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MSY00I9CQQMTA70@a-mtaout20.012.net.il>; Wed, 11 Sep 2013 16:27:59 +0300 (IDT) Date: Wed, 11 Sep 2013 16:28:03 +0300 From: Eli Zaretskii Subject: Re: bug#15322: VC log buffer scrolls itself In-reply-to: X-012-Sender: halo1@inter.net.il To: Paul Pogonyshev Message-id: <834n9rjxng.fsf@gnu.org> References: <55fvtc5z7w.fsf@fencepost.gnu.org> <837geojzri.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15322 Cc: rgm@gnu.org, 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 11 Sep 2013 08:58:19 +0200 > From: Paul Pogonyshev > Cc: Glenn Morris , 15322@debbugs.gnu.org > > Emacs 24.3.1 (built on 2013-08-07), and yes this happens with svn. However, > even if I open log buffer right from the top of 'C-x v d' buffer (i.e. > nothing is be selected or even "under the point"), the buffer still jumps > to some revision from Dec 2011. What happens to be under point is not relevant. What is relevant is the last revision you actually have in the sandbox. Anyway, it's a bug, so what exactly does it do (wrongly) is not interesting. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 02:26:47 2013 Received: (at 15322) by debbugs.gnu.org; 12 Sep 2013 06:26:48 +0000 Received: from localhost ([127.0.0.1]:57665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VK0MV-0003Qy-69 for submit@debbugs.gnu.org; Thu, 12 Sep 2013 02:26:45 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:39506 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VK0MQ-0003Ql-6X for 15322@debbugs.gnu.org; Thu, 12 Sep 2013 02:26:39 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VK0MO-0002Ir-I8; Thu, 12 Sep 2013 02:26:36 -0400 From: Glenn Morris To: Paul Pogonyshev Subject: Re: bug#15322: VC log buffer scrolls itself References: <55fvtc5z7w.fsf@fencepost.gnu.org> X-Spook: CDMA Majic Merlin Al Jazeera Dick Cheney sweep kilderkin X-Ran: >G*^z@CiQr_>-bmA9Z~DIZ/*tLPwUY(OdbC^kY]Y_(olZiC$CjmSbTos4^{Jr9M>$VSK7V X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 12 Sep 2013 02:26:36 -0400 In-Reply-To: <55fvtc5z7w.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 10 Sep 2013 14:05:39 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.8 (-----) X-Debbugs-Envelope-To: 15322 Cc: 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.8 (-----) I believe I've fixed it so that it goes to the correct revision according to the logic of vc. In terms of svn status -v output, 4271 4264 rgm . this would be revision 4264. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 03:25:25 2013 Received: (at 15322) by debbugs.gnu.org; 12 Sep 2013 07:25:25 +0000 Received: from localhost ([127.0.0.1]:57768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VK1HI-0004xf-5l for submit@debbugs.gnu.org; Thu, 12 Sep 2013 03:25:24 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:34616) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VK1HE-0004xR-2L for 15322@debbugs.gnu.org; Thu, 12 Sep 2013 03:25:21 -0400 Received: by mail-oa0-f45.google.com with SMTP id m6so10313672oag.18 for <15322@debbugs.gnu.org>; Thu, 12 Sep 2013 00:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=PKWRAc8kKZJsMLPBW6qeR0Miw6UkEkNjUPljZmEXy8M=; b=Z1coptL8fzDevK3neID4AgHbkATGpdVMsL6TNxvMCu7XAp8EXQ1QSoPgS28JGQBH4r VQTCLpX6xnHYn1d5N1fymBNTxsLzMKMtDt338RfQmaanDnjUA9fT5FHDQXV3aeI3nvkE 7yLk+pTcY/YRPtEbCt3IkNpvM74+Fvq0JpqjwJdzw/g4zx1D02BRcOalXw6f/FKDiCEc vXj3B6V4gyhWTxMija6c9NGfqAT9qYYr0meV5XkWWB1wMjdJrKaMPsnJk57GY2tCbDPT vHB1/2OHtiqBksaFzXgBhHlQCoobqaeSs+m9B+ieJ2LWVsRod3wXd+ao71znUycBSQ+W BvKw== MIME-Version: 1.0 X-Received: by 10.182.96.100 with SMTP id dr4mr5433337obb.22.1378970714326; Thu, 12 Sep 2013 00:25:14 -0700 (PDT) Received: by 10.182.200.163 with HTTP; Thu, 12 Sep 2013 00:25:14 -0700 (PDT) In-Reply-To: References: <55fvtc5z7w.fsf@fencepost.gnu.org> Date: Thu, 12 Sep 2013 09:25:14 +0200 Message-ID: Subject: Re: bug#15322: VC log buffer scrolls itself From: Paul Pogonyshev To: Glenn Morris Content-Type: multipart/alternative; boundary=001a11c33560954de804e62aa3e5 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 Cc: 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c33560954de804e62aa3e5 Content-Type: text/plain; charset=UTF-8 Frankly, I'd prefer it to not go anywhere and just leave the buffer alone, i.e. never scroll it. At least for subversion, which is known for having "mixed revision" in working directory all the time. Also, this is much like stealing focus in UI, only in this case it doesn't steal focus but buffer point position. Paul On 12 September 2013 08:26, Glenn Morris wrote: > > I believe I've fixed it so that it goes to the correct revision > according to the logic of vc. In terms of svn status -v output, > > 4271 4264 rgm . > > this would be revision 4264. > --001a11c33560954de804e62aa3e5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Frankly, I'd prefer it to not go anywhere and jus= t leave the buffer alone, i.e. never scroll it. At least for subversion, wh= ich is known for having "mixed revision" in working directory all= the time. Also, this is much like stealing focus in UI, only in this case = it doesn't steal focus but buffer point position.

Paul


On 12 September 2013 08:26, Glenn Morris <<= a href=3D"mailto:rgm@gnu.org" target=3D"_blank">rgm@gnu.org> = wrote:

I believe I've fixed it so that it goes to the correct revision
according to the logic of vc. In terms of svn status -v output,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4271 =C2=A0 =C2=A0 4264 rg= m =C2=A0 =C2=A0 =C2=A0.

this would be revision 4264.

--001a11c33560954de804e62aa3e5-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 11:57:29 2013 Received: (at 15322) by debbugs.gnu.org; 12 Sep 2013 15:57:29 +0000 Received: from localhost ([127.0.0.1]:59201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VK9Gq-0002EB-Uv for submit@debbugs.gnu.org; Thu, 12 Sep 2013 11:57:29 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:50958 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VK9Go-0002E3-LU for 15322@debbugs.gnu.org; Thu, 12 Sep 2013 11:57:26 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VK9Gn-0001Xl-7s; Thu, 12 Sep 2013 11:57:25 -0400 From: Glenn Morris To: Paul Pogonyshev Subject: Re: bug#15322: VC log buffer scrolls itself References: <55fvtc5z7w.fsf@fencepost.gnu.org> X-Spook: FSF hackers undercover morse cryptographic Ron Brown X-Ran: "x]TjhiljCu}LrwAAyZH*##%/c2dB{Z5Wz^WV[JF(^jx{H3Rl{q3/"O3Pp6I_hO]jg/&jv X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 12 Sep 2013 11:57:25 -0400 In-Reply-To: (Paul Pogonyshev's message of "Thu, 12 Sep 2013 09:25:14 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: 15322 Cc: 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.9 (-----) Paul Pogonyshev wrote: > Frankly, I'd prefer it to not go anywhere and just leave the buffer alone, > i.e. never scroll it. I had a feeling you might say that... > At least for subversion, which is known for having "mixed revision" in > working directory all the time. Also, this is much like stealing focus > in UI, only in this case it doesn't steal focus but buffer point > position. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 13:11:40 2013 Received: (at control) by debbugs.gnu.org; 12 Sep 2013 17:11:40 +0000 Received: from localhost ([127.0.0.1]:59354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKAQd-0006Cz-Lu for submit@debbugs.gnu.org; Thu, 12 Sep 2013 13:11:40 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:52318 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKAQb-0006Cq-8e for control@debbugs.gnu.org; Thu, 12 Sep 2013 13:11:37 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VKAQa-0002K1-Tm for control@debbugs.gnu.org; Thu, 12 Sep 2013 13:11:37 -0400 Date: Thu, 12 Sep 2013 13:11:36 -0400 Message-Id: Subject: control message for bug 15322 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.9 (-----) severity 15322 wishlist From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 15:09:09 2013 Received: (at 15322) by debbugs.gnu.org; 12 Sep 2013 19:09:10 +0000 Received: from localhost ([127.0.0.1]:59547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKCGL-0001rp-LB for submit@debbugs.gnu.org; Thu, 12 Sep 2013 15:09:09 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:3450) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKCGJ-0001rQ-KO for 15322@debbugs.gnu.org; Thu, 12 Sep 2013 15:09:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFG4rxBo/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFG4rxBo/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="27524960" Received: from 184-175-16-104.dsl.teksavvy.com (HELO pastel.home) ([184.175.16.104]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Sep 2013 15:05:31 -0400 Received: by pastel.home (Postfix, from userid 20848) id 5EAD662D8E; Thu, 12 Sep 2013 15:09:01 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#15322: VC log buffer scrolls itself Message-ID: References: <55fvtc5z7w.fsf@fencepost.gnu.org> Date: Thu, 12 Sep 2013 15:09:01 -0400 In-Reply-To: (Glenn Morris's message of "Thu, 12 Sep 2013 11:57:25 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15322 Cc: Paul Pogonyshev , 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> Frankly, I'd prefer it to not go anywhere and just leave the buffer alone, >> i.e. never scroll it. > I had a feeling you might say that... And I think that makes sense. It's natural to select a particular revision when running vc-print-log from (say) vc-annotate, but for a plain `C-x v l', the user just wants to see "the log" and presumably doesn't care about which revision happens to be current. IOW, I think we're trying too hard here. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 12 15:30:10 2013 Received: (at 15322) by debbugs.gnu.org; 12 Sep 2013 19:30:10 +0000 Received: from localhost ([127.0.0.1]:59565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKCae-0002Ov-WA for submit@debbugs.gnu.org; Thu, 12 Sep 2013 15:30:09 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:54703 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VKCab-0002OT-P9 for 15322@debbugs.gnu.org; Thu, 12 Sep 2013 15:30:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VKCaa-0000Gu-G0; Thu, 12 Sep 2013 15:30:04 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#15322: VC log buffer scrolls itself References: <55fvtc5z7w.fsf@fencepost.gnu.org> X-Spook: spies pipeline ANDVT MIT-LL lock picking Israel IDEA NORAD X-Ran: EUq'_4o+R}X$* X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 12 Sep 2013 15:30:04 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 12 Sep 2013 15:09:01 -0400") Message-ID: <70six9g7nn.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: 15322 Cc: Paul Pogonyshev , 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.9 (-----) Stefan Monnier wrote: > And I think that makes sense. It's natural to select a particular > revision when running vc-print-log from (say) vc-annotate, but for > a plain `C-x v l', the user just wants to see "the log" and presumably > doesn't care about which revision happens to be current. > > IOW, I think we're trying too hard here. *** lisp/vc/vc.el 2013-09-12 06:10:12 +0000 --- lisp/vc/vc.el 2013-09-12 19:28:04 +0000 *************** *** 2299,2305 **** (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef (backend (car vc-fileset)) (files (cadr vc-fileset)) ! (working-revision (or working-revision (vc-working-revision (car files))))) (vc-print-log-internal backend files working-revision nil limit))) ;;;###autoload --- 2299,2306 ---- (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef (backend (car vc-fileset)) (files (cadr vc-fileset)) ! ;; (working-revision (or working-revision (vc-working-revision (car files)))) ! ) (vc-print-log-internal backend files working-revision nil limit))) ;;;###autoload From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 26 03:17:57 2013 Received: (at 15322) by debbugs.gnu.org; 26 Sep 2013 07:17:57 +0000 Received: from localhost ([127.0.0.1]:36856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VP5pj-0002uY-Ti for submit@debbugs.gnu.org; Thu, 26 Sep 2013 03:17:56 -0400 Received: from mail-oa0-f48.google.com ([209.85.219.48]:53878) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VP5ph-0002uL-B5 for 15322@debbugs.gnu.org; Thu, 26 Sep 2013 03:17:54 -0400 Received: by mail-oa0-f48.google.com with SMTP id m6so260550oag.35 for <15322@debbugs.gnu.org>; Thu, 26 Sep 2013 00:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=4mhcvvJWiEQFwbE9gC2X9vUwHoSTbktE01iusl3W2E0=; b=IUu39lZK5knLAP1WQwurPK3mX0vUMbO/8qjviaHVCE8aYP+VY4bzW03C5HImcvkQxI maSuLFAdK3GClhnxLoSQf4cMIVCSExIfdwTgky8tXAq3z9AI3TdQ2irdTYBq0OpNSZ8m 1OCYhIPFeNHjkrMvLia1KdTJ5raLDwG4pI0J3R+8LzWAZev89pRHTcyZtId1K+EoYxkv QAyAVGQV6uhQbgYwz1s2qcus75kHvJaesO/wGml56ZL6OdwxIWP+6WPKPXGWgPpPuVgV 52W/xd0h7NVwMy3xK/bt4JGdGSUCg86ilp/SkgogicVqARBIS1KSD4lYuFbMN1tXq8XN KJ6Q== MIME-Version: 1.0 X-Received: by 10.182.131.166 with SMTP id on6mr42583obb.60.1380179872432; Thu, 26 Sep 2013 00:17:52 -0700 (PDT) Received: by 10.182.200.163 with HTTP; Thu, 26 Sep 2013 00:17:52 -0700 (PDT) In-Reply-To: <70six9g7nn.fsf@fencepost.gnu.org> References: <55fvtc5z7w.fsf@fencepost.gnu.org> <70six9g7nn.fsf@fencepost.gnu.org> Date: Thu, 26 Sep 2013 09:17:52 +0200 Message-ID: Subject: Re: bug#15322: VC log buffer scrolls itself From: Paul Pogonyshev To: Glenn Morris Content-Type: multipart/alternative; boundary=001a11c1e22e05c79604e7442bbb X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 Cc: Stefan Monnier , 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c1e22e05c79604e7442bbb Content-Type: text/plain; charset=UTF-8 In Emacs built from trunk yesterday it still jumps, though to the "correct" version (the one reported by 'svn info'). However, given that committing changes from the buffer does not advance the working directory revision (e.g. what I have now is 26 revisions in the past), I'm not sure how useful this is, at least for subversion. Probably it's better for saner VCS's, but for subversion if feels like annoyance. Paul On 12 September 2013 21:30, Glenn Morris wrote: > Stefan Monnier wrote: > > > And I think that makes sense. It's natural to select a particular > > revision when running vc-print-log from (say) vc-annotate, but for > > a plain `C-x v l', the user just wants to see "the log" and presumably > > doesn't care about which revision happens to be current. > > > > IOW, I think we're trying too hard here. > > *** lisp/vc/vc.el 2013-09-12 06:10:12 +0000 > --- lisp/vc/vc.el 2013-09-12 19:28:04 +0000 > *************** > *** 2299,2305 **** > (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef > (backend (car vc-fileset)) > (files (cadr vc-fileset)) > ! (working-revision (or working-revision (vc-working-revision (car > files))))) > (vc-print-log-internal backend files working-revision nil limit))) > > ;;;###autoload > --- 2299,2306 ---- > (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef > (backend (car vc-fileset)) > (files (cadr vc-fileset)) > ! ;; (working-revision (or working-revision (vc-working-revision (car > files)))) > ! ) > (vc-print-log-internal backend files working-revision nil limit))) > > ;;;###autoload > --001a11c1e22e05c79604e7442bbb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
In Emacs built from trunk yesterday it still jumps, t= hough to the "correct" version (the one reported by 'svn info= '). However, given that committing changes from the buffer does not adv= ance the working directory revision (e.g. what I have now is 26 revisions i= n the past), I'm not sure how useful this is, at least for subversion. = Probably it's better for saner VCS's, but for subversion if feels l= ike annoyance.

Paul


On 12 September 2013 21:30, Glenn Morris <<= a href=3D"mailto:rgm@gnu.org" target=3D"_blank">rgm@gnu.org> = wrote:
Stefan Monnier wrote:

> And I think that makes sense. =C2=A0It's natural to select a parti= cular
> revision when running vc-print-log from (say) vc-annotate, but for
> a plain `C-x v l', the user just wants to see "the log" = and presumably
> doesn't care about which revision happens to be current.
>
> IOW, I think we're trying too hard here.

*** lisp/vc/vc.el =C2=A0 =C2=A0 =C2=A0 2013-09-12 06:10:12 +0000
--- lisp/vc/vc.el =C2=A0 =C2=A0 =C2=A0 2013-09-12 19:28:04 +0000
***************
*** 2299,2305 ****
=C2=A0 =C2=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --St= ef
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(backend (car vc-fileset))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(files (cadr vc-fileset))
! =C2=A0 =C2=A0 =C2=A0 =C2=A0(working-revision (or working-revision (vc-wor= king-revision (car files)))))
=C2=A0 =C2=A0 =C2=A0 (vc-print-log-internal backend files working-revision = nil limit)))

=C2=A0 ;;;###autoload
--- 2299,2306 ----
=C2=A0 =C2=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --St= ef
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(backend (car vc-fileset))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(files (cadr vc-fileset))
! ;; =C2=A0 =C2=A0 (working-revision (or working-revision (vc-working-revis= ion (car files))))
! =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)
=C2=A0 =C2=A0 =C2=A0 (vc-print-log-internal backend files working-revision = nil limit)))

=C2=A0 ;;;###autoload

--001a11c1e22e05c79604e7442bbb-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 24 04:39:29 2013 Received: (at 15322) by debbugs.gnu.org; 24 Oct 2013 08:39:29 +0000 Received: from localhost ([127.0.0.1]:40183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZGS0-00078S-Qf for submit@debbugs.gnu.org; Thu, 24 Oct 2013 04:39:29 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:54904) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZGRy-00078D-6Q for 15322@debbugs.gnu.org; Thu, 24 Oct 2013 04:39:26 -0400 Received: by mail-ob0-f172.google.com with SMTP id gq1so2020212obb.3 for <15322@debbugs.gnu.org>; Thu, 24 Oct 2013 01:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=v4lVwzBcHKY3uP4sP0a6oriBxJL0kRvvSBS7Va89Q2s=; b=0jxzNuN3C4tq+uz+e+8Stlw4eIiVbtVyonLNDSIvF5CtqYf39Y+0WRBVfQOCrM5lM1 FrADgTZ+VAuF7izEfng9SqXIhnnpknGewEPm4hU8G6kdjSUEfxHMq5LcGPu3QXOKGVD8 PYcA7UJNpH2dTUnmhYfCo0iJDe6TLfTS8Q6a03Ax+sJu5ljGsS0O5vpFmTDL4qvL/axB f74OCz7hthGxaM1D+HgZfIIjUkfDJYACLoNlFQXyc2Tz5TLGJIZUSwkDMcxcNPLescAz Bx+SthWEdS5nBqkHAFqrazZLdeoQqccRocLuo82zLKX4fH0QuYektpBozkkNOCV/LAXm RYvg== MIME-Version: 1.0 X-Received: by 10.182.18.9 with SMTP id s9mr1280985obd.15.1382603960146; Thu, 24 Oct 2013 01:39:20 -0700 (PDT) Received: by 10.182.200.163 with HTTP; Thu, 24 Oct 2013 01:39:20 -0700 (PDT) In-Reply-To: References: <55fvtc5z7w.fsf@fencepost.gnu.org> <70six9g7nn.fsf@fencepost.gnu.org> Date: Thu, 24 Oct 2013 10:39:20 +0200 Message-ID: Subject: Re: bug#15322: VC log buffer scrolls itself From: Paul Pogonyshev To: Glenn Morris Content-Type: multipart/alternative; boundary=001a11c2d6a0e8e0df04e9789129 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 Cc: Stefan Monnier , 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c2d6a0e8e0df04e9789129 Content-Type: text/plain; charset=UTF-8 Let me explain why I think scrolling is *bad*, even if it scrolls to correct revision. Log buffer here is generated for 5-10 seconds. In the meantime, I can start reading it, scrolling manually or C-s contents. And then (when loading is finished) it scrolls to a different position by itself. This is no better than focus stealing, because it disrupts my activities. I tried adding the following advice, nulling 'working-revision': (defadvice vc-print-log-internal (before disable-scrolling-to-working-revision activate) (ad-set-arg 2 nil)) but it helped only so much, because now it always scrolls to the buffer beginning (for SVN it's still an improvement), even if I already C-s to some older revision. Is it possible to disable scrolling completely, even if in a hackish way through my '.emacs'? Paul On 26 September 2013 09:17, Paul Pogonyshev wrote: > In Emacs built from trunk yesterday it still jumps, though to the > "correct" version (the one reported by 'svn info'). However, given that > committing changes from the buffer does not advance the working directory > revision (e.g. what I have now is 26 revisions in the past), I'm not sure > how useful this is, at least for subversion. Probably it's better for saner > VCS's, but for subversion if feels like annoyance. > > Paul > > > On 12 September 2013 21:30, Glenn Morris wrote: > >> Stefan Monnier wrote: >> >> > And I think that makes sense. It's natural to select a particular >> > revision when running vc-print-log from (say) vc-annotate, but for >> > a plain `C-x v l', the user just wants to see "the log" and presumably >> > doesn't care about which revision happens to be current. >> > >> > IOW, I think we're trying too hard here. >> >> *** lisp/vc/vc.el 2013-09-12 06:10:12 +0000 >> --- lisp/vc/vc.el 2013-09-12 19:28:04 +0000 >> *************** >> *** 2299,2305 **** >> (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef >> (backend (car vc-fileset)) >> (files (cadr vc-fileset)) >> ! (working-revision (or working-revision (vc-working-revision (car >> files))))) >> (vc-print-log-internal backend files working-revision nil limit))) >> >> ;;;###autoload >> --- 2299,2306 ---- >> (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef >> (backend (car vc-fileset)) >> (files (cadr vc-fileset)) >> ! ;; (working-revision (or working-revision (vc-working-revision (car >> files)))) >> ! ) >> (vc-print-log-internal backend files working-revision nil limit))) >> >> ;;;###autoload >> > > --001a11c2d6a0e8e0df04e9789129 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Let me explain why I think scrolling is *bad*, even i= f it scrolls to correct revision. Log buffer here is generated for 5-10 sec= onds. In the meantime, I can start reading it, scrolling manually or C-s co= ntents. And then (when loading is finished) it scrolls to a different posit= ion by itself. This is no better than focus stealing, because it disrupts m= y activities.

I tried adding the following advice, nulling 'working-revisio= n':

=C2=A0=C2=A0=C2=A0 (defadvice vc-print-log-interna= l (before disable-scrolling-to-working-revision activate)
=C2=A0 =C2=A0 = =C2=A0 (ad-set-arg 2 nil))

but it helped only so much, because now it always scrolls to= the buffer beginning (for SVN it's still an improvement), even if I al= ready C-s to some older revision.

Is it possible to disab= le scrolling completely, even if in a hackish way through my '.emacs= 9;?

Paul

On 26 September 2013 09:17, Paul Pogonyshev <pogonyshev@gmail.com> wrote:
In Emacs built from tr= unk yesterday it still jumps, though to the "correct" version (th= e one reported by 'svn info'). However, given that committing chang= es from the buffer does not advance the working directory revision (e.g. wh= at I have now is 26 revisions in the past), I'm not sure how useful thi= s is, at least for subversion. Probably it's better for saner VCS's= , but for subversion if feels like annoyance.

Paul=


On 12 September 2013 21= :30, Glenn Morris <rgm@gnu.org> wrote:
Stefan Monnier wrote:

> And I think that makes sense. =C2=A0It's natural to select a parti= cular
> revision when running vc-print-log from (say) vc-annotate, but for
> a plain `C-x v l', the user just wants to see "the log" = and presumably
> doesn't care about which revision happens to be current.
>
> IOW, I think we're trying too hard here.

*** lisp/vc/vc.el =C2=A0 =C2=A0 =C2=A0 2013-09-12 06:10:12 +0000
--- lisp/vc/vc.el =C2=A0 =C2=A0 =C2=A0 2013-09-12 19:28:04 +0000
***************
*** 2299,2305 ****
=C2=A0 =C2=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --St= ef
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(backend (car vc-fileset))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(files (cadr vc-fileset))
! =C2=A0 =C2=A0 =C2=A0 =C2=A0(working-revision (or working-revision (vc-wor= king-revision (car files)))))
=C2=A0 =C2=A0 =C2=A0 (vc-print-log-internal backend files working-revision = nil limit)))

=C2=A0 ;;;###autoload
--- 2299,2306 ----
=C2=A0 =C2=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --St= ef
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(backend (car vc-fileset))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(files (cadr vc-fileset))
! ;; =C2=A0 =C2=A0 (working-revision (or working-revision (vc-working-revis= ion (car files))))
! =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0)
=C2=A0 =C2=A0 =C2=A0 (vc-print-log-internal backend files working-revision = nil limit)))

=C2=A0 ;;;###autoload


--001a11c2d6a0e8e0df04e9789129-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 24 04:49:31 2013 Received: (at 15322) by debbugs.gnu.org; 24 Oct 2013 08:49:31 +0000 Received: from localhost ([127.0.0.1]:40195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZGbi-0007N7-AB for submit@debbugs.gnu.org; Thu, 24 Oct 2013 04:49:30 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47419 helo=mx2.suse.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZGbf-0007My-7w for 15322@debbugs.gnu.org; Thu, 24 Oct 2013 04:49:27 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 25639A57B2; Thu, 24 Oct 2013 10:49:26 +0200 (CEST) From: Andreas Schwab To: Paul Pogonyshev Subject: Re: bug#15322: VC log buffer scrolls itself References: <55fvtc5z7w.fsf@fencepost.gnu.org> <70six9g7nn.fsf@fencepost.gnu.org> X-Yow: Today, THREE WINOS from DETROIT sold me a framed photo of TAB HUNTER before his MAKEOVER! Date: Thu, 24 Oct 2013 10:49:26 +0200 In-Reply-To: (Paul Pogonyshev's message of "Thu, 24 Oct 2013 10:39:20 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: 15322 Cc: Glenn Morris , 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) IMHO scrolling should only happen if point is still at BOB. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 24 10:24:33 2013 Received: (at 15322) by debbugs.gnu.org; 24 Oct 2013 14:24:33 +0000 Received: from localhost ([127.0.0.1]:41179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZLpw-0008Pe-Eo for submit@debbugs.gnu.org; Thu, 24 Oct 2013 10:24:32 -0400 Received: from relais.videotron.ca ([24.201.245.36]:38824) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZLpt-0008PU-VN for 15322@debbugs.gnu.org; Thu, 24 Oct 2013 10:24:30 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from ceviche.home ([24.201.53.56]) by VL-VM-MR006.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MV600CKJG0TVD10@VL-VM-MR006.ip.videotron.ca> for 15322@debbugs.gnu.org; Thu, 24 Oct 2013 10:24:29 -0400 (EDT) Received: by ceviche.home (Postfix, from userid 20848) id E64046609A; Thu, 24 Oct 2013 10:24:28 -0400 (EDT) From: Stefan Monnier To: Andreas Schwab Subject: Re: bug#15322: VC log buffer scrolls itself Message-id: References: <55fvtc5z7w.fsf@fencepost.gnu.org> <70six9g7nn.fsf@fencepost.gnu.org> Date: Thu, 24 Oct 2013 10:24:28 -0400 In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15322 Cc: Paul Pogonyshev , 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > IMHO scrolling should only happen if point is still at BOB. FWIW, I agree with Paul that scrolling is just a bad idea here. It's good to do it when we specifically requested to see the log comment of a particular revision (e.g. we already have a log displayed and from vc-annotate we ask for the comment of some revision), but otherwise it's just a waste of effort that ends up annoying more often than not. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 12:04:55 2014 Received: (at 15322) by debbugs.gnu.org; 2 Aug 2014 16:04:55 +0000 Received: from localhost ([127.0.0.1]:55179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XDbni-0000PL-GQ for submit@debbugs.gnu.org; Sat, 02 Aug 2014 12:04:54 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:45912) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XDbnf-0000P6-OL for 15322@debbugs.gnu.org; Sat, 02 Aug 2014 12:04:52 -0400 Received: by mail-ob0-f181.google.com with SMTP id va2so3515808obc.12 for <15322@debbugs.gnu.org>; Sat, 02 Aug 2014 09:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=NkN9vQ10xcBx4ef1tFtbO9IkM0kZW3j2CFPYlqgWTgg=; b=JyNQAy3EBhF4inth9h20IjbwPXmw+Okgk327O54WiX93T7Tkfddqv9ZXJz+F+sLWjp 05qB/GU7eYqSQgNxyImLLZYwB6UiBnLGCkZm/dNsTs0FOB07KuZERNqmYGqeqG6T+xb+ uhWJaniWxof1rZ7w/jHO0ql4vjh4WX4t70WsGrAT6A8BrPbXsnH/UymKllr4+TT7AOLN ZqL8YMO6Dl4WOSdkwE6h/F8u1uv4cDUE5neJ/hParbKetvTKjMoHVJ6J7wVI03ir6ios vM44BTcE4afXFtMnt05asT0c3EaIrtNFim9gSgTXIpzmTBohyr6must+w29m03wOlV3S ViWw== MIME-Version: 1.0 X-Received: by 10.60.133.203 with SMTP id pe11mr18600154oeb.24.1406995485985; Sat, 02 Aug 2014 09:04:45 -0700 (PDT) Received: by 10.182.91.163 with HTTP; Sat, 2 Aug 2014 09:04:45 -0700 (PDT) In-Reply-To: References: <55fvtc5z7w.fsf@fencepost.gnu.org> <70six9g7nn.fsf@fencepost.gnu.org> Date: Sat, 2 Aug 2014 18:04:45 +0200 Message-ID: Subject: Re: bug#15322: VC log buffer scrolls itself From: Paul Pogonyshev To: Stefan Monnier Content-Type: multipart/alternative; boundary=047d7b41baea24901c04ffa7aafd X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 Cc: Andreas Schwab , 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7b41baea24901c04ffa7aafd Content-Type: text/plain; charset=UTF-8 Bumping this bug. It is very annoying, because our repository grew quite large, so almost all logs take at least 5-10 seconds to be generated fully and Emacs snatches point from me when the log generation is complete. Even if it scrolls back to the top it is still disruptive as I may be reading second page of history already. Paul On 24 October 2013 16:24, Stefan Monnier wrote: > > IMHO scrolling should only happen if point is still at BOB. > > FWIW, I agree with Paul that scrolling is just a bad idea here. > It's good to do it when we specifically requested to see the log comment > of a particular revision (e.g. we already have a log displayed and from > vc-annotate we ask for the comment of some revision), but otherwise it's > just a waste of effort that ends up annoying more often than not. > > > Stefan > --047d7b41baea24901c04ffa7aafd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Bumping this bug.

It is very annoying, because= our repository grew quite large, so almost all logs take at least 5-10 sec= onds to be generated fully and Emacs snatches point from me when the log ge= neration is complete. Even if it scrolls back to the top it is still disrup= tive as I may be reading second page of history already.

Paul


On 24 October 2013 16:24, Stefan Monnier <<= a href=3D"mailto:monnier@iro.umontreal.ca" target=3D"_blank">monnier@iro.um= ontreal.ca> wrote:
> IMHO scrolling should o= nly happen if point is still at BOB.

FWIW, I agree with Paul that scrolling is just a bad idea here.
It's good to do it when we specifically requested to see the log commen= t
of a particular revision (e.g. we already have a log displayed and from
vc-annotate we ask for the comment of some revision), but otherwise it'= s
just a waste of effort that ends up annoying more often than not.


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan

--047d7b41baea24901c04ffa7aafd-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 16:19:22 2014 Received: (at 15322) by debbugs.gnu.org; 19 Nov 2014 21:19:22 +0000 Received: from localhost ([127.0.0.1]:38742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrCen-0005Ad-P5 for submit@debbugs.gnu.org; Wed, 19 Nov 2014 16:19:22 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:38273) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrCem-0005AV-Gg for 15322@debbugs.gnu.org; Wed, 19 Nov 2014 16:19:21 -0500 Received: by mail-qa0-f54.google.com with SMTP id i13so1051925qae.13 for <15322@debbugs.gnu.org>; Wed, 19 Nov 2014 13:19:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=/O+AMjuuXHlctiRHQrpjlLkOhEYVfrIOVAi6X5OVheU=; b=GO1QpaWbyieaVE/O7YjtXh5sG5eTbMs33M7r80CtQNYIgT7zUaNX0eD/0M02Xcuhgu dfuPsg+D/3rjrT6XKNI6yRJCOV07B4Dc91TOQntBxMTXLir7532ZgQSmEs9Hf2D7A75s uuc0w0aZG0WyqlY//5eI2/9qqW84zfM+fWNamw7x9lyuUy9o3LM0ehpcka9c+zvqhDrs 3zlMDpPYcjO8X8MZU5QdOdl7pA3t8nBOfXc6dneMLM/meRfYPL8K0j103axKRHDuERMt cFW8E/n8mnCUIQ3XtRpbjcTq5jKne3MhYGponqN7sbKkBBZTX7IHm51Jo5Q53c4DrMqx RNdQ== MIME-Version: 1.0 X-Received: by 10.224.23.9 with SMTP id p9mr54225549qab.92.1416431960012; Wed, 19 Nov 2014 13:19:20 -0800 (PST) Received: by 10.229.214.67 with HTTP; Wed, 19 Nov 2014 13:19:19 -0800 (PST) Date: Wed, 19 Nov 2014 21:19:19 +0000 Message-ID: Subject: Re: bug#15322: VC log buffer scrolls itself From: Richard Copley To: 15322@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Glenn's change doesn't completely solve the problem, because `log-view-goto-rev' goes to the beginning of the buffer when REV is null, and because all the other callers of `vc-log-internal' are also affected. It would be better to comment out the `goto-location-func' call in `vc-log-internal'. Having done that, you will find that you need to comment out the following line as well, or point will move to the end of the buffer instead. Note this is a duplicate of bug 6351. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 16:34:50 2014 Received: (at control) by debbugs.gnu.org; 19 Nov 2014 21:34:50 +0000 Received: from localhost ([127.0.0.1]:38754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrCtm-0005Xp-3C for submit@debbugs.gnu.org; Wed, 19 Nov 2014 16:34:50 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:59949) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrCtk-0005Xh-A5 for control@debbugs.gnu.org; Wed, 19 Nov 2014 16:34:48 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1XrCtj-0001qk-RZ for control@debbugs.gnu.org; Wed, 19 Nov 2014 16:34:47 -0500 Date: Wed, 19 Nov 2014 16:34:47 -0500 Message-Id: Subject: control message for bug 6351 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) forcemerge 15322 6351 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 19 16:57:50 2014 Received: (at 15322) by debbugs.gnu.org; 19 Nov 2014 21:57:50 +0000 Received: from localhost ([127.0.0.1]:38781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrDG1-0007RZ-TK for submit@debbugs.gnu.org; Wed, 19 Nov 2014 16:57:50 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:62383) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrDFz-0007RR-TH for 15322@debbugs.gnu.org; Wed, 19 Nov 2014 16:57:48 -0500 Received: by mail-qa0-f54.google.com with SMTP id i13so1109930qae.27 for <15322@debbugs.gnu.org>; Wed, 19 Nov 2014 13:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=AM3O5f3q/nF1WTGT4YPpbICuGh1Sup9dBFOy4nznW/s=; b=vXPcNAVnHbLfL7xVjvRnmsiBLAo0LrShbKFj6HFHvE7mkmuUzTPQsxKGgK93foNCw+ +5tuqW+rr+axtrIMZZuiAklODv40me8bmFCHVFpzTsbbeFdr8mgk6AVlFB2/AJ/K4BX0 i3DbRQ3DHdIpjcKX7f4W8o+JEhtBy2/5rQXxu5i2y504m7gwkGDVGlxjHrzdAFetScMh U2JdiEyi47zkYvVkJm55ZybYRSFtZJ8q2bozOb0J4F8xlPBEQqcgOOAzaw+ezXxjWRnC PZnD2URiI33RK/uxnA3bxlIB4ehqdsmg7DJ+X8p9vSAHgDGMHzgZaOkw6YKl4TV8ltfa jppA== MIME-Version: 1.0 X-Received: by 10.229.188.137 with SMTP id da9mr54485197qcb.6.1416434267443; Wed, 19 Nov 2014 13:57:47 -0800 (PST) Received: by 10.229.214.67 with HTTP; Wed, 19 Nov 2014 13:57:47 -0800 (PST) In-Reply-To: References: Date: Wed, 19 Nov 2014 21:57:47 +0000 Message-ID: Subject: Re: bug#15322: VC log buffer scrolls itself From: Richard Copley To: 15322@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Having re-read Stefan's comment: > > It's natural to select a particular > > revision when running vc-print-log from (say) vc-annotate, but for > > a plain `C-x v l', the user just wants to see "the log" and presumably > > doesn't care about which revision happens to be current. ... perhaps I was going too far, but a fix is still needed to stop point jumping to the beginning of the buffer when working-revision is null (at least in Subversion). I suggest not calling `goto-location-func' or setting vc-sentinel-movepoint when working-revision is null, in `vc-print-log-internal'. I also suggest a null working-revision be passed by `vc-print-root-log', by the same argument Stefan used for `vc-print-log'. On 19 November 2014 21:19, Richard Copley wrote: > Glenn's change doesn't completely solve the problem, because > `log-view-goto-rev' goes to the beginning of the buffer when REV is > null, and because all the other callers of `vc-log-internal' are also > affected. It would be better to comment out the `goto-location-func' > call in `vc-log-internal'. Having done that, you will find that you > need to comment out the following line as well, or point will move to > the end of the buffer instead. > > Note this is a duplicate of bug 6351. From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 23:32:49 2015 Received: (at 15322) by debbugs.gnu.org; 3 May 2015 03:32:49 +0000 Received: from localhost ([127.0.0.1]:60096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yoke9-0008Mz-32 for submit@debbugs.gnu.org; Sat, 02 May 2015 23:32:49 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:34241) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yoke6-0008Mj-9q for 15322@debbugs.gnu.org; Sat, 02 May 2015 23:32:47 -0400 Received: by wicmx19 with SMTP id mx19so54690735wic.1 for <15322@debbugs.gnu.org>; Sat, 02 May 2015 20:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=9V1zkcmi1Qm358cQ6aQezEMJmA6rptTWkjW0bQE81m8=; b=y63JxX8diEucUXHTO6ugRrGYio8zJ12HVAgGyiwKnJdAWbnT1t/BZY1OHGD4h6thyI FZ2QBOVD9l7vO4apsaVWCGvsJPZE8cdHtLj5XYqNHzFPMTZoh8vhlwCBtz9GH44VBxNz o8hRYGgY6AFtX5gji9KWRnW5QvEccg05pAGmic99rnxIWrWwQKX4MlUoGvQ5yDKdkPTF nRlKntfomE4uLkqtxailFYbE/l5W/wrsvQckJwA0QAwfwTAkYxCmYipZRLWnRhkAokoA O3q/tNTQ/mVxQcqy5LWIbvQxiwiWPgGBQkjivq80cHQSTn4d6618MLGZErjRO9Km6xc5 gasg== X-Received: by 10.180.104.225 with SMTP id gh1mr8671988wib.65.1430623960569; Sat, 02 May 2015 20:32:40 -0700 (PDT) Received: from axl ([82.102.93.54]) by mx.google.com with ESMTPSA id a18sm14236822wja.46.2015.05.02.20.32.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 May 2015 20:32:40 -0700 (PDT) From: Dmitry Gutov To: Richard Copley Subject: Re: bug#15322: VC log buffer scrolls itself References: Date: Sun, 03 May 2015 06:32:37 +0300 In-Reply-To: (Richard Copley's message of "Wed, 19 Nov 2014 21:57:47 +0000") Message-ID: <861tiy5oa2.fsf@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 Cc: 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Richard Copley writes: > ... perhaps I was going too far, but a fix is still needed to stop > point jumping to the beginning of the buffer when working-revision is > null (at least in Subversion). I suggest not calling > `goto-location-func' or setting vc-sentinel-movepoint when > working-revision is null, in `vc-print-log-internal'. > > I also suggest a null working-revision be passed by > `vc-print-root-log', by the same argument Stefan used for > `vc-print-log'. Makes sense to me. Unless someone objects, I'm going to install the following patch: diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index bb4dd60..f64f42e 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2224,8 +2224,9 @@ earlier revisions. Show up to LIMIT entries (non-nil means unlimited)." (lambda (_bk _files-arg ret) (vc-print-log-setup-buttons working-revision is-start-revision limit ret)) - (lambda (bk) - (vc-call-backend bk 'show-log-entry working-revision)) + (when working-revision + (lambda (bk) + (vc-call-backend bk 'show-log-entry working-revision))) (lambda (_ignore-auto _noconfirm) (vc-print-log-internal backend files working-revision is-start-revision limit))))) @@ -2263,8 +2264,10 @@ earlier revisions. Show up to LIMIT entries (non-nil means unlimited)." (let ((inhibit-read-only t)) (funcall setup-buttons-func backend files retval) (shrink-window-if-larger-than-buffer) - (funcall goto-location-func backend) - (setq vc-sentinel-movepoint (point)) + ;; Bug#15322 + (when goto-location-func + (funcall goto-location-func backend) + (setq vc-sentinel-movepoint (point))) (set-buffer-modified-p nil))))) (defun vc-incoming-outgoing-internal (backend remote-location buffer-name type) @@ -2273,7 +2276,7 @@ earlier revisions. Show up to LIMIT entries (non-nil means unlimited)." (lambda (bk buf type-arg _files) (vc-call-backend bk type-arg buf remote-location)) (lambda (_bk _files-arg _ret) nil) - (lambda (_bk) (goto-char (point-min))) + nil (lambda (_ignore-auto _noconfirm) (vc-incoming-outgoing-internal backend remote-location buffer-name type)))) @@ -2328,16 +2331,15 @@ When called interactively with a prefix argument, prompt for LIMIT." (list (when (> vc-log-show-limit 0) vc-log-show-limit))))) (let ((backend (vc-deduce-backend)) (default-directory default-directory) - rootdir working-revision) + rootdir) (if backend (setq rootdir (vc-call-backend backend 'root default-directory)) (setq rootdir (read-directory-name "Directory for VC root-log: ")) (setq backend (vc-responsible-backend rootdir)) (unless backend (error "Directory is not version controlled"))) - (setq working-revision (vc-working-revision rootdir) - default-directory rootdir) - (vc-print-log-internal backend (list rootdir) working-revision nil limit))) + (setq default-directory rootdir) + (vc-print-log-internal backend (list rootdir) nil nil limit))) ;;;###autoload (defun vc-log-incoming (&optional remote-location) From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 23:38:48 2015 Received: (at 15322) by debbugs.gnu.org; 3 May 2015 03:38:48 +0000 Received: from localhost ([127.0.0.1]:60100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yokjw-0008W8-7z for submit@debbugs.gnu.org; Sat, 02 May 2015 23:38:48 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:38733) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yokju-0008Vw-GB for 15322@debbugs.gnu.org; Sat, 02 May 2015 23:38:47 -0400 Received: by wiun10 with SMTP id n10so80101036wiu.1 for <15322@debbugs.gnu.org>; Sat, 02 May 2015 20:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=oB9b6qNA8W9VEy6p9hu3tKLUUruWbJYoDriJj4BX6nE=; b=uUnja2kaPj31z6O8yCjikdic23bjW5CqM0uXQ5AMMrhbDbihDGMC7KB9jj/PSd/wCK oXtZkuD5VZcSx9ro9wy5I53s+QLiaKD3pZmiANE1hWss7f6Y7OTs73aTRICUqVINdjyg S3WGMmfjx2SGFDJj7v7SaRNVAHskSKB6e6FDg3HjajVxjKfTKe3FYg8NYyLXZ/6e/rL8 iNU0k6/peYWuNB9K7uiGxnp66MHOI1cJ43XocdaUy/0yB6cKjWesPPOFpYgi2zj9/SES yrS8KebNVwPuAnloLH5q+4+cnrtmY5eGaV2HAsQVRQsbRbEvzFoRAbI+3CtDgg06Az1N XPlA== X-Received: by 10.180.79.227 with SMTP id m3mr8905118wix.71.1430624320957; Sat, 02 May 2015 20:38:40 -0700 (PDT) Received: from axl ([82.102.93.54]) by mx.google.com with ESMTPSA id e10sm4873002wij.11.2015.05.02.20.38.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 May 2015 20:38:40 -0700 (PDT) From: Dmitry Gutov To: Andreas Schwab Subject: Re: bug#15322: VC log buffer scrolls itself References: <55fvtc5z7w.fsf@fencepost.gnu.org> <70six9g7nn.fsf@fencepost.gnu.org> Date: Sun, 03 May 2015 06:38:37 +0300 In-Reply-To: (Andreas Schwab's message of "Thu, 24 Oct 2013 10:49:26 +0200") Message-ID: <86y4l649fm.fsf@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 Cc: Glenn Morris , Paul Pogonyshev , 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Andreas Schwab writes: > IMHO scrolling should only happen if point is still at BOB. While this makes sense, and would help with fixing bug#20470 without re-introducing the main pain point of this one, we don't have any easy access to the "current" value of point, neither from `vc-print-log-internal' (which is called before any output is shown), nor from within the goto-location-func lambda it passes `vc-log-internal-common', because the latter is called from `vc--process-sentinel', after point is temporarily moved to (process-mark p). From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 10:34:16 2015 Received: (at 15322) by debbugs.gnu.org; 3 May 2015 14:34:16 +0000 Received: from localhost ([127.0.0.1]:60826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YouyF-00033w-S0 for submit@debbugs.gnu.org; Sun, 03 May 2015 10:34:16 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:63309) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YouyD-00033Z-QP for 15322@debbugs.gnu.org; Sun, 03 May 2015 10:34:15 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NNS00I002R90M00@a-mtaout23.012.net.il> for 15322@debbugs.gnu.org; Sun, 03 May 2015 17:34:07 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NNS00H5C34UXY60@a-mtaout23.012.net.il>; Sun, 03 May 2015 17:34:07 +0300 (IDT) Date: Sun, 03 May 2015 17:34:07 +0300 From: Eli Zaretskii Subject: Re: bug#15322: VC log buffer scrolls itself In-reply-to: <861tiy5oa2.fsf@yandex.ru> X-012-Sender: halo1@inter.net.il To: Dmitry Gutov Message-id: <83h9rtu3vk.fsf@gnu.org> References: <861tiy5oa2.fsf@yandex.ru> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15322 Cc: rcopley@gmail.com, 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Dmitry Gutov > Date: Sun, 03 May 2015 06:32:37 +0300 > Cc: 15322@debbugs.gnu.org > > @@ -2263,8 +2264,10 @@ earlier revisions. Show up to LIMIT entries (non-nil means unlimited)." > (let ((inhibit-read-only t)) > (funcall setup-buttons-func backend files retval) > (shrink-window-if-larger-than-buffer) > - (funcall goto-location-func backend) > - (setq vc-sentinel-movepoint (point)) > + ;; Bug#15322 > + (when goto-location-func > + (funcall goto-location-func backend) > + (setq vc-sentinel-movepoint (point))) I don't think it's a good idea to have in the code comments that only mention the bug number, without also trying to explain the reason(s) for what the code does. If it's possible to write a clear and concise explanation, you don't even need to mention the bug number. If the reasons are so complex that they cannot be explained without repeating too much of the bug discussion, then there should be a summary and a pointer to the bug. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 11:58:49 2015 Received: (at 15322) by debbugs.gnu.org; 3 May 2015 15:58:49 +0000 Received: from localhost ([127.0.0.1]:60845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YowI4-00058v-Vm for submit@debbugs.gnu.org; Sun, 03 May 2015 11:58:49 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:33664) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YowI2-00058i-Kj for 15322@debbugs.gnu.org; Sun, 03 May 2015 11:58:47 -0400 Received: by wief7 with SMTP id f7so61664145wie.0 for <15322@debbugs.gnu.org>; Sun, 03 May 2015 08:58:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=bUExVoB9spfcCGw8xNSBHI77F//mlmoGvGSttnR7EtA=; b=SkCcK9FM0m3Ye4Kz8trqH6nj9E7tUBPCeD/096WbZ5mTxFeKI7doAmBVmmNkOFYVqB ueeaxgGt0dO/ena/tAVIYpuMA0xOy4/UdXQerXwign807IE81UFbXwCVVzKloopNOhwz tbVjOscFPceq01Xs89QH2Gkfa4g5Qkahr3l0Zgkt60YBYHM8mLxWxZnXce7Kjs0R96gJ y99LQNXkeLTgk1bspfQEcduaof0WoHhu8b9vfc45rn6zxEGy1xBUoquhFmsKVvBH0bLt by6rTFHVZCBIzbc1t78+/7YAPRoSAPv9U3TXCtsSnwmJI1FVFzaTqkhUOX9V0cAXJdDl sNHQ== X-Received: by 10.180.85.42 with SMTP id e10mr12424232wiz.17.1430668720748; Sun, 03 May 2015 08:58:40 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id s4sm7149581wix.14.2015.05.03.08.58.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 May 2015 08:58:40 -0700 (PDT) Subject: Re: bug#15322: VC log buffer scrolls itself To: Eli Zaretskii references: <861tiy5oa2.fsf@yandex.ru> <83h9rtu3vk.fsf@gnu.org> From: Dmitry Gutov message-id: <554645AB.5080308@yandex.ru> Date: Sun, 3 May 2015 18:58:35 +0300 user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 mime-version: 1.0 in-reply-to: <83h9rtu3vk.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322 Cc: rcopley@gmail.com, 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 05/03/2015 05:34 PM, Eli Zaretskii wrote: > I don't think it's a good idea to have in the code comments that only > mention the bug number, without also trying to explain the reason(s) > for what the code does. Okay. That exact piece of code should be self-evident, but I've added some words else where, as well as the bug reference anyway. > If it's possible to write a clear and concise> explanation, you don't even need to mention the bug number. The surrounding code is pretty hairy, so might be possible to regress by accident. This way, someone changing it would look at the bug first. diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index bb4dd60..1a997a4 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -2224,8 +2224,10 @@ earlier revisions. Show up to LIMIT entries (non-nil means unlimited)." (lambda (_bk _files-arg ret) (vc-print-log-setup-buttons working-revision is-start-revision limit ret)) - (lambda (bk) - (vc-call-backend bk 'show-log-entry working-revision)) + ;; When it's nil, point really shouldn't move (bug#15322). + (when working-revision + (lambda (bk) + (vc-call-backend bk 'show-log-entry working-revision))) (lambda (_ignore-auto _noconfirm) (vc-print-log-internal backend files working-revision is-start-revision limit))))) @@ -2263,8 +2265,9 @@ earlier revisions. Show up to LIMIT entries (non-nil means unlimited)." (let ((inhibit-read-only t)) (funcall setup-buttons-func backend files retval) (shrink-window-if-larger-than-buffer) - (funcall goto-location-func backend) - (setq vc-sentinel-movepoint (point)) + (when goto-location-func + (funcall goto-location-func backend) + (setq vc-sentinel-movepoint (point))) (set-buffer-modified-p nil))))) (defun vc-incoming-outgoing-internal (backend remote-location buffer-name type) @@ -2273,7 +2276,7 @@ earlier revisions. Show up to LIMIT entries (non-nil means unlimited)." (lambda (bk buf type-arg _files) (vc-call-backend bk type-arg buf remote-location)) (lambda (_bk _files-arg _ret) nil) - (lambda (_bk) (goto-char (point-min))) + nil ;; Don't move point. (lambda (_ignore-auto _noconfirm) (vc-incoming-outgoing-internal backend remote-location buffer-name type)))) @@ -2328,16 +2331,15 @@ When called interactively with a prefix argument, prompt for LIMIT." (list (when (> vc-log-show-limit 0) vc-log-show-limit))))) (let ((backend (vc-deduce-backend)) (default-directory default-directory) - rootdir working-revision) + rootdir) (if backend (setq rootdir (vc-call-backend backend 'root default-directory)) (setq rootdir (read-directory-name "Directory for VC root-log: ")) (setq backend (vc-responsible-backend rootdir)) (unless backend (error "Directory is not version controlled"))) - (setq working-revision (vc-working-revision rootdir) - default-directory rootdir) - (vc-print-log-internal backend (list rootdir) working-revision nil limit))) + (setq default-directory rootdir) + (vc-print-log-internal backend (list rootdir) nil nil limit))) ;;;###autoload (defun vc-log-incoming (&optional remote-location) From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 12:32:09 2015 Received: (at 15322) by debbugs.gnu.org; 3 May 2015 16:32:09 +0000 Received: from localhost ([127.0.0.1]:60865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YowoK-0005ye-FB for submit@debbugs.gnu.org; Sun, 03 May 2015 12:32:08 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:35099) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YowoI-0005y9-1F for 15322@debbugs.gnu.org; Sun, 03 May 2015 12:32:07 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NNS00M008FBXU00@a-mtaout21.012.net.il> for 15322@debbugs.gnu.org; Sun, 03 May 2015 19:31:59 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NNS00M7P8LBV090@a-mtaout21.012.net.il>; Sun, 03 May 2015 19:31:59 +0300 (IDT) Date: Sun, 03 May 2015 19:32:00 +0300 From: Eli Zaretskii Subject: Re: bug#15322: VC log buffer scrolls itself In-reply-to: <554645AB.5080308@yandex.ru> X-012-Sender: halo1@inter.net.il To: Dmitry Gutov Message-id: <83bni1tyf3.fsf@gnu.org> References: <861tiy5oa2.fsf@yandex.ru> <83h9rtu3vk.fsf@gnu.org> <554645AB.5080308@yandex.ru> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15322 Cc: rcopley@gmail.com, 15322@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Cc: rcopley@gmail.com, 15322@debbugs.gnu.org > From: Dmitry Gutov > Date: Sun, 3 May 2015 18:58:35 +0300 > > On 05/03/2015 05:34 PM, Eli Zaretskii wrote: > > > I don't think it's a good idea to have in the code comments that only > > mention the bug number, without also trying to explain the reason(s) > > for what the code does. > > Okay. That exact piece of code should be self-evident, but I've added > some words else where, as well as the bug reference anyway. Thanks. > > If it's possible to write a clear and concise> explanation, you don't > even need to mention the bug number. > > The surrounding code is pretty hairy, so might be possible to regress by > accident. This way, someone changing it would look at the bug first. Quite. From debbugs-submit-bounces@debbugs.gnu.org Sun May 03 14:34:00 2015 Received: (at 15322-done) by debbugs.gnu.org; 3 May 2015 18:34:00 +0000 Received: from localhost ([127.0.0.1]:60925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoyiF-00020f-Fj for submit@debbugs.gnu.org; Sun, 03 May 2015 14:33:59 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:34992) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YoyiD-00020Q-Mi for 15322-done@debbugs.gnu.org; Sun, 03 May 2015 14:33:58 -0400 Received: by widdi4 with SMTP id di4so100164271wid.0 for <15322-done@debbugs.gnu.org>; Sun, 03 May 2015 11:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=cpwefemMvnQ0ZOX5RXE3/rxbx2lxthcYBi3mBbCXjgM=; b=wC5SotXS5d+e+JhYsKD74Xs/QcV1tjmKp2G2kvC0TeEfG6Zk0QH3FaYaQpdoM9J/HF zDDXIihib4/shqGaJRJaxZkK2Ng2qYanpiLA8UmeevKUKsiRgwy53NsyNO80DBOcef+w 7FV+jAqt3C+KeV2cLeB6vDM7HQI4/RoPjYfv0jE/4lX22xhbb7CoSR61VLTqVYahYxiB Fgb18EwtOQ3ListuFUmlEMC0dz28eI8m7GmcCV47e8vhtkS7q8i+b+Z23kx4hEQo5OpN 3Mmm9S/muuFX8N6j7TIeVlDvdxemPA4WOtLw28v2rdUo4Q4ahYFcx3CTkRHyG8NoEOkK XCIA== X-Received: by 10.180.90.169 with SMTP id bx9mr13218622wib.50.1430678032186; Sun, 03 May 2015 11:33:52 -0700 (PDT) Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id z12sm17091292wjq.12.2015.05.03.11.33.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 May 2015 11:33:51 -0700 (PDT) Subject: Re: bug#15322: VC log buffer scrolls itself To: Eli Zaretskii references: <861tiy5oa2.fsf@yandex.ru> <83h9rtu3vk.fsf@gnu.org> <554645AB.5080308@yandex.ru> <83bni1tyf3.fsf@gnu.org> From: Dmitry Gutov message-id: <55466A0A.4090109@yandex.ru> Date: Sun, 3 May 2015 21:33:46 +0300 user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0 mime-version: 1.0 in-reply-to: <83bni1tyf3.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15322-done Cc: rcopley@gmail.com, 15322-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 25.1 Thanks for the review, applied. From unknown Mon Jun 23 04:12:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 01 Jun 2015 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator