From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 14:57:27 2013 Received: (at submit) by debbugs.gnu.org; 6 Sep 2013 18:57:27 +0000 Received: from localhost ([127.0.0.1]:44804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI1Dj-0005PN-3N for submit@debbugs.gnu.org; Fri, 06 Sep 2013 14:57:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34218) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI1Dg-0005P8-15 for submit@debbugs.gnu.org; Fri, 06 Sep 2013 14:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VI1DQ-00087z-IN for submit@debbugs.gnu.org; Fri, 06 Sep 2013 14:57:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI1DQ-00087n-Fb for submit@debbugs.gnu.org; Fri, 06 Sep 2013 14:57:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI1DH-0005g9-TI for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:57:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VI1D7-000860-A7 for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:56:59 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:19014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VI1D7-00085o-3c for bug-gnu-emacs@gnu.org; Fri, 06 Sep 2013 14:56:49 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r86Iulgd011779 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 6 Sep 2013 18:56:47 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r86Iujgf006946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 6 Sep 2013 18:56:46 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r86Iuj0L008151 for ; Fri, 6 Sep 2013 18:56:45 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 6 Sep 2013 11:56:45 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; Isearch: handle commands properly when called at top level X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Isearch now has quite a few commands that can be invoked during Isearch, using keys. None of these commands currently take care of the fact that they might get called at top level, e.g., with `isearch-mode' =3D nil. Some such commands, such as `isearch-help-for-help' should be callable outside of Isearch. Others, such as `isearch-repeat-forward', should not. For those that should not, an error should be raised, saying that the command is for use only in Isearch. For those that should be allowable outside of Isearch, the code should take care to DTRT when not in `isearch-mode': * wrt messages (mostly inhibit messages, esp. if they use `isearch-message-prefix' etc.) * wrt Isearch highlighting (they should not do any highlighting) * wrt calling `isearch-update' etc. (they should not do it) * wrt calling `exit-minibuffer' (they should not do it: no catch for throw) Some commands, such as `isearch-describe-bindings' and `isearch-highlight-regexp' can be used outside of Isearch with no change - they work well already. This includes even `isearch-edit-string', which can be called outside Isearch but which then continues in Isearch with no problem. Among the comands that might be useful, or at least allowable, outside of Isearch (dunno), but that might need some minor fixup are the following. They should not call `isearch-update' etc. * isearch-help-for-help * isearch-describe-key (should explicitly use `isearch-mode-map') * isearch-describe-mode * isearch-toggle-* Dunno whether there is any use for these commands outside Isearch: * isearch-cancel (moves point to last Isearch start) * isearch-abort In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-08-23 on ODIEONE Bzr revision: 113986 rgm@gnu.org-20130823185841-zoy6h1qk433ibrlf Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include' From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 16:52:08 2013 Received: (at 15292) by debbugs.gnu.org; 6 Sep 2013 20:52:08 +0000 Received: from localhost ([127.0.0.1]:44997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI30h-0008EF-QR for submit@debbugs.gnu.org; Fri, 06 Sep 2013 16:52:08 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:34281 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI30g-0008Dr-KZ for 15292@debbugs.gnu.org; Fri, 06 Sep 2013 16:52:06 -0400 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 03DC4258B9E936; Fri, 6 Sep 2013 13:51:59 -0700 (PDT) From: Juri Linkov To: Drew Adams Subject: Re: bug#15292: 24.3.50; Isearch: handle commands properly when called at top level Organization: JURTA References: Date: Fri, 06 Sep 2013 23:49:29 +0300 In-Reply-To: (Drew Adams's message of "Fri, 6 Sep 2013 11:56:45 -0700 (PDT)") Message-ID: <87mwnp3cbq.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15292 Cc: 15292@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Among the comands that might be useful, or at least allowable, outside > of Isearch (dunno), but that might need some minor fixup are the > following. They should not call `isearch-update' etc. > > * isearch-help-for-help > * isearch-describe-key (should explicitly use `isearch-mode-map') > * isearch-describe-mode > * isearch-toggle-* Isearch is not a library of functions, and not intended for external use. I can't imagine how you might want to use e.g. isearch-help-for-help outside of Isearch. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 17:04:16 2013 Received: (at 15292) by debbugs.gnu.org; 6 Sep 2013 21:04:16 +0000 Received: from localhost ([127.0.0.1]:45031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI3CR-00006T-Pa for submit@debbugs.gnu.org; Fri, 06 Sep 2013 17:04:16 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:35449) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI3CP-00006F-RL for 15292@debbugs.gnu.org; Fri, 06 Sep 2013 17:04:14 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r86L47OV027262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Sep 2013 21:04:07 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r86L46d9023499 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 Sep 2013 21:04:07 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r86L46Fi019308; Fri, 6 Sep 2013 21:04:06 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 6 Sep 2013 14:04:05 -0700 (PDT) From: Drew Adams To: Juri Linkov Subject: RE: bug#15292: 24.3.50; Isearch: handle commands properly when called at top level References: <87mwnp3cbq.fsf@mail.jurta.org> In-Reply-To: <87mwnp3cbq.fsf@mail.jurta.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: 15292 Cc: 15292@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.7 (----) > Isearch is not a library of functions, and not intended for external use. Every library containing functions is a library of functions. And there is no "external use". But it's clear we will continue to disagree about that. > I can't imagine how you might want to use e.g. isearch-help-for-help > outside of Isearch. I have nothing particular in mind wrt that. The main point was that commands that should be called only when in `isearch-mode' could usefully raise an error if called outside that mode. Likewise, minibuffer commands that make no sense if called outside the minibuffer, and so on. IMO, such commands should barf if called outside the expected context. But it does not bother me if you decide not to do anything about such thing= s. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 18:55:51 2013 Received: (at 15292) by debbugs.gnu.org; 6 Sep 2013 22:55:51 +0000 Received: from localhost ([127.0.0.1]:45206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI4wQ-0002q7-DM for submit@debbugs.gnu.org; Fri, 06 Sep 2013 18:55:51 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:32633) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI4wK-0002pk-SE for 15292@debbugs.gnu.org; Fri, 06 Sep 2013 18:55:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rxBo/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFG4rxBo/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="26720696" Received: from 184-175-16-104.dsl.teksavvy.com (HELO pastel.home) ([184.175.16.104]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Sep 2013 18:52:28 -0400 Received: by pastel.home (Postfix, from userid 20848) id 5F42762DAD; Fri, 6 Sep 2013 18:55:38 -0400 (EDT) From: Stefan Monnier To: Drew Adams Subject: Re: bug#15292: 24.3.50; Isearch: handle commands properly when called at top level Message-ID: References: Date: Fri, 06 Sep 2013 18:55:38 -0400 In-Reply-To: (Drew Adams's message of "Fri, 6 Sep 2013 11:56:45 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15292 Cc: 15292@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Some such commands, such as `isearch-help-for-help' should be callable > outside of Isearch. You mean via something like M-x isearch-help-for-help, right? (I doubt anyone would bind such a command to a key). > Others, such as `isearch-repeat-forward', should not. For those that > should not, an error should be raised, saying that the command is for > use only in Isearch. Actually, it's not important to signal an error saying "don't use it outside Isearch mode", *unless* running that command outside Isearch mode results in nasty behavior. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 06 19:19:57 2013 Received: (at 15292) by debbugs.gnu.org; 6 Sep 2013 23:19:57 +0000 Received: from localhost ([127.0.0.1]:45221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI5Jl-0003QY-7M for submit@debbugs.gnu.org; Fri, 06 Sep 2013 19:19:57 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:36937) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VI5Ji-0003QH-HM for 15292@debbugs.gnu.org; Fri, 06 Sep 2013 19:19:55 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r86NJkhx025585 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 6 Sep 2013 23:19:48 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r86NJjKh018932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 6 Sep 2013 23:19:46 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r86NJjjT001996; Fri, 6 Sep 2013 23:19:45 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 6 Sep 2013 16:19:44 -0700 (PDT) From: Drew Adams To: Stefan Monnier Subject: RE: bug#15292: 24.3.50; Isearch: handle commands properly when called at top level References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: 15292 Cc: 15292@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.7 (----) > > Some such commands, such as `isearch-help-for-help' should be callable > > outside of Isearch. >=20 > You mean via something like M-x isearch-help-for-help, right? Yes. > (I doubt anyone would bind such a command to a key). They might. Or they might read the command name in the minibuffer from some other command that then invokes it. Or whatever. After all, that command does give you a general entry to help of various kinds on Isearch. And for the most part it does work OK at top level. There is just a minor hiccup because it calls `isearch-update'. It wouldn't cost much to make it useful pretty much anywhere, just as `isearch-describe-bindings' already is. > > Others, such as `isearch-repeat-forward', should not. For those that > > should not, an error should be raised, saying that the command is for > > use only in Isearch. >=20 > Actually, it's not important to signal an error saying "don't use it > outside Isearch mode", *unless* running that command outside Isearch > mode results in nasty behavior. I don't disagree that it's not important in such cases. Just thought it might be better. It's not important to me, in any case. Nothing in this bug report is. Particularly the toggle commands, I think, might be commands that someone might mistakenly think could be used at top level. It's not obvious, when you do something like `apropos-command' etc., whether such a command like `isearch-toggle-lax-whitespace' is relevant only in some particular context. The doc is mute about it; you find out what it does in the wrong context only by trying it there. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 19 18:25:41 2013 Received: (at control) by debbugs.gnu.org; 19 Sep 2013 22:25:41 +0000 Received: from localhost ([127.0.0.1]:50106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMmfM-0006Ei-S8 for submit@debbugs.gnu.org; Thu, 19 Sep 2013 18:25:41 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37677 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMmfJ-0006EZ-7y for control@debbugs.gnu.org; Thu, 19 Sep 2013 18:25:37 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VMmfI-0002Hq-RY for control@debbugs.gnu.org; Thu, 19 Sep 2013 18:25:36 -0400 Date: Thu, 19 Sep 2013 18:25:36 -0400 Message-Id: Subject: control message for bug 15292 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) tag 15292 wontfix From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 02:14:20 2014 Received: (at control) by debbugs.gnu.org; 1 Feb 2014 07:14:20 +0000 Received: from localhost ([127.0.0.1]:43662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W9UmR-0000kO-VG for submit@debbugs.gnu.org; Sat, 01 Feb 2014 02:14:20 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:39483) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W9UmP-0000kG-4h for control@debbugs.gnu.org; Sat, 01 Feb 2014 02:14:17 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1W9UmA-0001m2-MA for control@debbugs.gnu.org; Sat, 01 Feb 2014 08:14:03 +0100 Date: Fri, 31 Jan 2014 23:13:11 -0800 Message-Id: <87bnyrqpa0.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #15292 X-MailScanner-ID: 1W9UmA-0001m2-MA X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1391843643.22721@IDHVTex8Od1oxpPtkoMzHg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 15292 From unknown Tue Sep 09 00:44:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 01 Mar 2014 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator