GNU bug report logs - #15279
Info broken image

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> jurta.org>
Subject: bug#15279: closed (Re: bug#15279: Info broken image)
Date: Fri, 06 Sep 2013 20:45:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#15279: Info broken image

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 15279 <at> debbugs.gnu.org.

-- 
15279: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15279
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 15279-done <at> debbugs.gnu.org
Subject: Re: bug#15279: Info broken image
Date: Fri, 06 Sep 2013 23:44:06 +0300

>> When Info can't find an image file it replaces the image
>> with the placeholder "[broken image]" even when there is
>> ASCII variant of the image.  It would be more user-friendly
>> to display ASCII variant if it is provided in the Info file.
>> Additionally this patch also displays the ALT attribute
>> in the tooltip like web browsers do.
>
> Looks good, please install,

Done.

[Message part 3 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Info broken image
Date: Fri, 06 Sep 2013 00:35:17 +0300

When Info can't find an image file it replaces the image
with the placeholder "[broken image]" even when there is
ASCII variant of the image.  It would be more user-friendly
to display ASCII variant if it is provided in the Info file.
Additionally this patch also displays the ALT attribute
in the tooltip like web browsers do.

=== modified file 'lisp/info.el'
--- lisp/info.el	2013-07-03 20:47:56 +0000
+++ lisp/info.el	2013-09-05 21:33:39 +0000
@@ -1611,11 +1611,15 @@ (defun Info-display-images-node ()
                                    ""))
                      (image (if (file-exists-p image-file)
                                 (create-image image-file)
-                              "[broken image]")))
+                              (or (cdr (assoc-string "text" parameter-alist))
+				  (and src (concat "[broken image:" src "]"))
+				  "[broken image]"))))
                 (if (not (get-text-property start 'display))
                     (add-text-properties
-                     start (point) `(display ,image rear-nonsticky (display)))))
+                     start (point)
+		     `(display ,image rear-nonsticky (display)
+		       help-echo ,(cdr (assoc-string "alt" parameter-alist))))))
             ;; text-only display, show alternative text if provided, or
             ;; otherwise a clue that there's meant to be a picture
             (delete-region start (point))
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.