GNU bug report logs - #15270
24.3; ruby-mode font-lock bug related to HERE docs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15270 in the body.
You can then email your comments to 15270 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bozhidar Batsov <bozhidar.batsov <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; ruby-mode font-lock bug related to HERE docs
Date: Thu, 5 Sep 2013 11:39:03 +0300

[Message part 1 (text/plain, inline)]

Code like the following breaks font-locking logic of ruby-mode:

expected_source = <<-END.strip_indent
              each do |x|
                some_method
                other_method
              end
            END


The second END gets highlighted as a constant, instead of a string. I guess the two consecutive ends cause the problem.

Here's a screenshot - http://i42.tinypic.com/122jeap.jpg

In GNU Emacs 24.3.1 (x86_64-apple-darwin12.4.0, NS apple-appkit-1187.39)
 of 2013-08-12 on Bozhidars-MacBook-Pro.local
Windowing system distributor `Apple', version 10.3.1187
Configured using:
 `configure '--prefix=/usr/local/Cellar/emacs/24.3' '--without-dbus'
 '--enable-locallisppath=/usr/local/share/emacs/site-lisp'
 '--infodir=/usr/local/Cellar/emacs/24.3/share/info/emacs'
 '--without-gnutls' '--with-ns' '--disable-ns-self-contained' 'CC=cc''



-- 
Cheers,
Bozhidar

[Message part 2 (text/html, inline)]

Message #8 received at 15270 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Bozhidar Batsov <bozhidar.batsov <at> gmail.com>
Cc: 15270 <at> debbugs.gnu.org
Subject: Re: bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs
Date: Thu, 05 Sep 2013 14:45:11 +0300

Bozhidar Batsov <bozhidar.batsov <at> gmail.com> writes:

> Code like the following breaks font-locking logic of ruby-mode:
>
> expected_source = <<-END.strip_indent
> each do |x|
> some_method
> other_method
> end
> END
>
> The second END gets highlighted as a constant, instead of a string. I
> guess the two consecutive ends cause the problem.
>
> Here's a screenshot - http://i42.tinypic.com/122jeap.jpg

WFM: http://i.imgur.com/YPsjoDS.png

Have you tried it in the current trunk?

The first END highlighting looks out of place, but it's caused by the
"Perl-ish keywords" rule.

Message #11 received at 15270 <at> debbugs.gnu.org (full text, mbox):

From: Bozhidar Batsov <bozhidar.batsov <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 15270 <at> debbugs.gnu.org
Subject: Re: bug#15270: 24.3; ruby-mode font-lock bug related to HERE
 docs
Date: Thu, 5 Sep 2013 14:48:54 +0300

[Message part 1 (text/plain, inline)]

I guess this is fixed in the trunk, but I think the highlighting of the first END in the heredoc should be corrected as well.

-- 
Cheers,
Bozhidar


On Thursday, September 5, 2013 at 2:45 PM, Dmitry Gutov wrote:

> Bozhidar Batsov <bozhidar.batsov <at> gmail.com (mailto:bozhidar.batsov <at> gmail.com)> writes:
> 
> > Code like the following breaks font-locking logic of ruby-mode:
> > 
> > expected_source = <<-END.strip_indent
> > each do |x|
> > some_method
> > other_method
> > end
> > END
> > 
> > The second END gets highlighted as a constant, instead of a string. I
> > guess the two consecutive ends cause the problem.
> > 
> > Here's a screenshot - http://i42.tinypic.com/122jeap.jpg
> 
> WFM: http://i.imgur.com/YPsjoDS.png
> 
> Have you tried it in the current trunk?
> 
> The first END highlighting looks out of place, but it's caused by the
> "Perl-ish keywords" rule.
> 
> 

[Message part 2 (text/html, inline)]

Message #16 received at 15270-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Bozhidar Batsov <bozhidar.batsov <at> gmail.com>
Cc: 15270-done <at> debbugs.gnu.org
Subject: Re: bug#15270: 24.3; ruby-mode font-lock bug related to HERE docs
Date: Thu, 05 Sep 2013 16:06:21 +0300

Version: 24.4

On 05.09.2013 14:48, Bozhidar Batsov wrote:
> I guess this is fixed in the trunk, but I think the highlighting of the
> first END in the heredoc should be corrected as well.

Ok, fixed for heredocs (gave BEGIN/END lower priority).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.