GNU bug report logs - #15251
24.3.50; do-auto-fill "continues" comment from inside a string

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#15251: closed (24.3.50; do-auto-fill "continues" comment from
 inside a string)
Date: Tue, 01 Oct 2013 01:19:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 01 Oct 2013 04:18:25 +0300
with message-id <524A22E1.5000500 <at> yandex.ru>
and subject line Re: bug#15251: 24.3.50; do-auto-fill "continues" comment from inside a string
has caused the debbugs.gnu.org bug report #15251,
regarding 24.3.50; do-auto-fill "continues" comment from inside a string
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
15251: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15251
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; do-auto-fill "continues" comment from inside a string
Date: Tue, 03 Sep 2013 04:26:26 +0300

In certain conditions, if I press SPC, and a string on the current line
contains text matching `comment-start-skip', the filling is performed,
and the newly created line starts with a comment.

Examples (point is at |, fill-column is 70):

ruby-mode:

aa = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa#{}a" a|

press SPC =>

aa = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa#{}a"
                                #a

js-mode:

aa = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa//a" aa|

press SPC =>

aa = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa//a"
//aa 

[Message part 3 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 15251-done <at> debbugs.gnu.org,
 Andreas Röhler <andreas.roehler <at> easy-emacs.de>
Subject: Re: bug#15251: 24.3.50; do-auto-fill "continues" comment from inside
 a string
Date: Tue, 01 Oct 2013 04:18:25 +0300

Version: 24.4

On 30.09.2013 21:27, Stefan Monnier wrote:
>> Stefan, can we consider `syntax-ppss' fast enough at this point?
>
> If comment-use-syntax is t, yes.

Done, in 114486.

I kept the rest of `comment-beginning' definition, in case 
non-syntax-table-using comments can still be font-locked in some modes.

Also, `comment-use-global-state' looks like a better var to base the 
choice on, semantically, but it's not auto-detected, and it's only used 
in `comment-search-forward'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.