From unknown Sat Sep 20 05:15:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#15214 <15214@debbugs.gnu.org> To: bug#15214 <15214@debbugs.gnu.org> Subject: Status: 24.3.50; `Revert This Session's Customization' does not do what it says Reply-To: bug#15214 <15214@debbugs.gnu.org> Date: Sat, 20 Sep 2025 12:15:14 +0000 retitle 15214 24.3.50; `Revert This Session's Customization' does not do wh= at it says reassign 15214 emacs submitter 15214 Drew Adams severity 15214 minor tag 15214 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 30 01:11:23 2013 Received: (at submit) by debbugs.gnu.org; 30 Aug 2013 05:11:23 +0000 Received: from localhost ([127.0.0.1]:58046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VFGzR-0005ON-Td for submit@debbugs.gnu.org; Fri, 30 Aug 2013 01:11:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33920) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VFGzN-0005O1-28 for submit@debbugs.gnu.org; Fri, 30 Aug 2013 01:11:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFGz7-00088d-KF for submit@debbugs.gnu.org; Fri, 30 Aug 2013 01:11:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFGz7-00088Z-HK for submit@debbugs.gnu.org; Fri, 30 Aug 2013 01:11:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFGyy-0005CQ-US for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2013 01:11:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFGyq-00085a-7V for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2013 01:10:52 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:29680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFGyp-00085L-WF for bug-gnu-emacs@gnu.org; Fri, 30 Aug 2013 01:10:44 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r7U5AgZ9031329 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Aug 2013 05:10:43 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r7U5AfZ4019573 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 30 Aug 2013 05:10:42 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r7U5Afhd018127 for ; Fri, 30 Aug 2013 05:10:41 GMT MIME-Version: 1.0 Message-ID: <8b504c44-91b3-4c9f-bca5-3b4d1547f67f@default> Date: Thu, 29 Aug 2013 22:10:41 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `Revert This Session's Customization' does not do what it says X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) 1. emacs -Q M-x customize-option backup-by-copying Click Toggle, then State and Set For Current Session. You have changed the value. Click State and Revert This Session's Customization. The current value does not change back to what it was before you changed the setting for the session. This session's customization was not reverted. However, even though the value was not changed, you see the message "CHANGED outside Customize". 2. The State choice of Revert This Session's Customization is not even documented at (emacs) `Changing a Variable'. Other State actions are documented. So it's hard to tell whether #1 above is really a bug: it's not even clear what this menu item is supposed to do. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-08-23 on ODIEONE Bzr revision: 113986 rgm@gnu.org-20130823185841-zoy6h1qk433ibrlf Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include' From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 16:30:52 2019 Received: (at 15214) by debbugs.gnu.org; 30 Dec 2019 21:30:52 +0000 Received: from localhost ([127.0.0.1]:33534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1im2cl-00019c-Jq for submit@debbugs.gnu.org; Mon, 30 Dec 2019 16:30:51 -0500 Received: from mail-lj1-f171.google.com ([209.85.208.171]:33640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1im2cj-00019H-8h for 15214@debbugs.gnu.org; Mon, 30 Dec 2019 16:30:50 -0500 Received: by mail-lj1-f171.google.com with SMTP id y6so26591201lji.0 for <15214@debbugs.gnu.org>; Mon, 30 Dec 2019 13:30:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=/UoA4Nc/XHZnRc//2FMoOuRO9pOppuBetqE2VrO2AhA=; b=l8YTDWobaz1/JntNWdaAfgEvEvYtX/uIIaXpWkFmo+zX4Hwa53kSJzTsQ3OHW1GTVs 4nKyNZZj32NPfmR8OvmhrLW8wGv9+F6YHL0knzb0u+fLlAgaf15sGoMrgpbTQfPraQ3Q YdyNhgsF6hrfiNgiGizQ44qDrmEMmvjsa3knTk/Uv6Ml9Gd9eTVDo9knrbmt1iGvQ8T4 2avqU+s03+TtNSBepVYcddtygmYxFJ97qKlPFXFRIniPHT3JGYivX3y1KhfUUaygPr8J rVX0qQhzbhWIIUinYbY/g12qRWojXJsn/X7PSpmkwys8dOpNVRiKl995QVrBzURa/1hx /qkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=/UoA4Nc/XHZnRc//2FMoOuRO9pOppuBetqE2VrO2AhA=; b=Gw2k67nP0GyfuPCZKVVu9ZI+S1/ehxojR5Jr7vzgOfQc7nhZwdi0oqTmSqPQ8paNvi 9IkHW5iiKUlRF2H/TPJuAWvckKj/PeXS6ic4fXXSqaSIvvSOctFU3YmkOI7mYqvRGh4b QZ6rAPn+Am7WJOKYeLAGX1mS/aIuIPT2iFJUsh9pKkzVC9utx7xvmVTX5EHDAmxd4cnp l7HZ7rbc9NzMI5SR0gtnxxsZCJj2X9MPyRC+pqnyqdv96gm+XQBxMyIf1i7SukeQTsSg 6H/swteYJt7A/t+9ZxxfOlxA3Gdh29/4VfwE+dEVez9Jp7Ey9kZC4ahJsnmwU2Ei/96C Gb6A== X-Gm-Message-State: APjAAAXBi8PACSg92ssC3MEE1zluTP46t5LjX3HoXnyop08LHO6SIEjZ JXhm1krfmfm2giYDp7u48KDMEGeqq7RO8kjYQgdQuJ0/ X-Google-Smtp-Source: APXvYqw6EEjRV6PBGERAnxmsQl8vNo8Sfkn/6uQ64rZbq87zFj7+YRDVKnI9Olp6+IeElsxD4f+TQ1z9FnS+ZHxGyXo= X-Received: by 2002:a2e:b010:: with SMTP id y16mr40658686ljk.238.1577741443078; Mon, 30 Dec 2019 13:30:43 -0800 (PST) MIME-Version: 1.0 From: Mauro Aranda Date: Mon, 30 Dec 2019 18:30:31 -0300 Message-ID: Subject: Re: bug#15214: 24.3.50; `Revert This Session's Customization' does not do what it says To: 15214@debbugs.gnu.org Content-Type: multipart/mixed; boundary="0000000000004339e4059af28e8e" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15214 Cc: Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000004339e4059af28e8e Content-Type: multipart/alternative; boundary="0000000000004339e2059af28e8c" --0000000000004339e2059af28e8c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tags 15214 patch thanks Drew Adams writes: > 1. emacs -Q > > M-x customize-option backup-by-copying > > Click Toggle, then State and Set For Current Session. > You have changed the value. > > Click State and Revert This Session's Customization. > > The current value does not change back to what it was before you changed > the setting for the session. This session's customization was not > reverted. However, even though the value was not changed, you see the > message "CHANGED outside Customize". I can reproduce this in latest master and emacs-27 branch. > 2. The State choice of Revert This Session's Customization is not even > documented at (emacs) `Changing a Variable'. Other State actions are > documented. So it's hard to tell whether #1 above is really a bug: it's > not even clear what this menu item is supposed to do. Current (emacs) Changing a Variable says: =E2=80=98Revert This Session's Customizations=E2=80=99 This restores the value of the variable to the last saved value, if there was one. Otherwise it restores the standard value. It updates the text accordingly. The function that runs for that option is custom-variable-reset-saved, and the doc string of custom-variable-reset-saved says something similar. The attached patch fixes custom-variable-reset-saved to do what it says it does when the variable has no previous saved value. Best regards, Mauro. --0000000000004339e2059af28e8c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tags 15214 patch
thanks

Drew Adams <drew.adams@or= acle.com> writes:

> 1. emacs -Q
>
> M-x cust= omize-option backup-by-copying
>
> Click Toggle, then State and= Set For Current Session.
> You have changed the value.
>
&g= t; Click State and Revert This Session's Customization.
>
>= The current value does not change back to what it was before you changed> the setting for the session.=C2=A0 This session's customization = was not
> reverted.=C2=A0 However, even though the value was not chan= ged, you see the
> message "CHANGED outside Customize".
=
I can reproduce this in latest master and emacs-27 branch.

> = 2. The State choice of Revert This Session's Customization is not even<= br>> documented at (emacs) `Changing a Variable'.=C2=A0 Other State = actions are
> documented.=C2=A0 So it's hard to tell whether #1 a= bove is really a bug: it's
> not even clear what this menu item i= s supposed to do.

Current (emacs) Changing a Variable says:
=E2= =80=98Revert This Session's Customizations=E2=80=99
=C2=A0 =C2=A0 = =C2=A0This restores the value of the variable to the last saved value, if=C2=A0 =C2=A0 =C2=A0there was one.=C2=A0 Otherwise it restores the standa= rd value.=C2=A0 It
=C2=A0 =C2=A0 =C2=A0updates the text accordingly.
=
The function that runs for that option is custom-variable-reset-saved,<= br>and the doc string of custom-variable-reset-saved says something similar= .

The attached patch fixes custom-variable-reset-saved to do what it= says
it does when the variable has no previous saved value.

Best= regards,
Mauro.
--0000000000004339e2059af28e8c-- --0000000000004339e4059af28e8e Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Reset-to-the-standard-value-when-reverting-session-s.patch" Content-Disposition: attachment; filename="0001-Reset-to-the-standard-value-when-reverting-session-s.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k4syame10 RnJvbSAyMDkyZmIwYjlhMzY3NzVlMjJlZmM1ZmQ5NjdhMDVmNmU0YmZmYmViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IE1vbiwgMzAgRGVjIDIwMTkgMTg6MTA6MjggLTAzMDAKU3ViamVjdDogW1BBVENIXSBS ZXNldCB0byB0aGUgc3RhbmRhcmQgdmFsdWUgd2hlbiByZXZlcnRpbmcgc2Vzc2lvbidzCiBjdXN0 b21pemF0aW9uCgoqIGxpc3AvY3VzLWVkaXQuZWwgKGN1c3RvbS12YXJpYWJsZS1yZXNldC1zYXZl ZCk6IFdoZW4gdGhlcmUgaXMgbm8KcHJldmlvdXMgc2F2ZWQgdmFsdWUsIHJlc2V0IHRvIHRoZSBz dGFuZGFyZCB2YWx1ZS4gIChCdWcjMTUyMTQpCi0tLQogbGlzcC9jdXMtZWRpdC5lbCB8IDcgKysr KystLQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9saXNwL2N1cy1lZGl0LmVsIGIvbGlzcC9jdXMtZWRpdC5lbAppbmRleCA0Mzk2 NjdhLi40ZmE2ZGZlIDEwMDY0NAotLS0gYS9saXNwL2N1cy1lZGl0LmVsCisrKyBiL2xpc3AvY3Vz LWVkaXQuZWwKQEAgLTMwMzgsOCArMzAzOCwxMSBAQCBjdXN0b20tdmFyaWFibGUtcmVzZXQtc2F2 ZWQKIAkgKGNvbW1lbnQgKGdldCBzeW1ib2wgJ3NhdmVkLXZhcmlhYmxlLWNvbW1lbnQpKSkKICAg ICAoY3VzdG9tLXZhcmlhYmxlLWJhY2t1cC12YWx1ZSB3aWRnZXQpCiAgICAgKGlmIChub3QgKG9y IHNhdmVkLXZhbHVlIGNvbW1lbnQpKQotCTs7IElmIHRoZXJlIGlzIG5vIHNhdmVkIHZhbHVlLCBy ZW1vdmUgdGhlIHNldHRpbmcuCi0JKGN1c3RvbS1wdXNoLXRoZW1lICd0aGVtZS12YWx1ZSBzeW1i b2wgJ3VzZXIgJ3Jlc2V0KQorICAgICAgICAocHJvZ24KKwkgIDs7IElmIHRoZXJlIGlzIG5vIHNh dmVkIHZhbHVlLCByZW1vdmUgdGhlIHNldHRpbmcuCisJICAoY3VzdG9tLXB1c2gtdGhlbWUgJ3Ro ZW1lLXZhbHVlIHN5bWJvbCAndXNlciAncmVzZXQpCisgICAgICAgICAgKGZ1bmNhbGwgKG9yIChn ZXQgc3ltYm9sICdjdXN0b20tc2V0KSAjJ3NldC1kZWZhdWx0KSBzeW1ib2wKKyAgICAgICAgICAg ICAgICAgICAoZXZhbCAoY2FyIChnZXQgc3ltYm9sICdzdGFuZGFyZC12YWx1ZSkpKSkpCiAgICAg ICA7OyBPdGhlcndpc2UsIGFwcGx5IHRoZSBzYXZlZCB2YWx1ZS4KICAgICAgIChwdXQgc3ltYm9s ICd2YXJpYWJsZS1jb21tZW50IGNvbW1lbnQpCiAgICAgICAoY3VzdG9tLXB1c2gtdGhlbWUgJ3Ro ZW1lLXZhbHVlIHN5bWJvbCAndXNlciAnc2V0IChjYXItc2FmZSBzYXZlZC12YWx1ZSkpCi0tIAoy LjcuNAoK --0000000000004339e4059af28e8e-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 16:52:50 2019 Received: (at 15214) by debbugs.gnu.org; 30 Dec 2019 21:52:50 +0000 Received: from localhost ([127.0.0.1]:33550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1im2y2-0003aQ-52 for submit@debbugs.gnu.org; Mon, 30 Dec 2019 16:52:50 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:38214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1im2xz-0003aC-Sy for 15214@debbugs.gnu.org; Mon, 30 Dec 2019 16:52:48 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBULiR1b015693; Mon, 30 Dec 2019 21:52:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=vzZY/Jgx0h+vMyPHfzQTA9mxVJJezIL3yi1RW3UFWN8=; b=bSlGqHg2gSUX2s1G9tPyQUvpoV+HZgU2KUCLvGhDXLws9eYWhe7GpWzOJ8W9e8MQJrsY LaaiCWbdm9SjPbzOQ4c06qfg5ikgBGOkaRkWnXcwaCvyv6500dsIRNkPKyjsZ1ErFDpE lcE7+jJa/f4i4rY0ZGy7ijEo3cqbrW7CsCHBI4qT2/Rx6m/e2YYvN1FtctSNKp8zE9U+ wze8xQfPVU0iEyjivO8qR/QI4W+0MpsfRKV8procUqYdtO3GqipG9nS1IC12RthU2MwM GzZtjijIIBQfwtAB3y2C31uauZ9Jof50R6iq+LL0JsIIFLT52eLgljJ4UzcTjdPX4jxt sQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2x5ypqf398-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Dec 2019 21:52:41 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xBULmbjv094625; Mon, 30 Dec 2019 21:52:41 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2x6gh97cjs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Dec 2019 21:52:41 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xBULqeC8008179; Mon, 30 Dec 2019 21:52:41 GMT MIME-Version: 1.0 Message-ID: <69ab65d3-2da6-43fd-8670-747a3617a621@default> Date: Mon, 30 Dec 2019 13:52:39 -0800 (PST) From: Drew Adams To: Mauro Aranda , 15214@debbugs.gnu.org Subject: RE: bug#15214: 24.3.50; `Revert This Session's Customization' does not do what it says References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4939.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9486 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=989 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912300197 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9486 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1912300197 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15214 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thanks. [(emacs) `Changing a Variable' was updated to mention=20 this after the Emacs release for the bug report (24.3).] From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 11:26:47 2019 Received: (at 15214) by debbugs.gnu.org; 31 Dec 2019 16:26:47 +0000 Received: from localhost ([127.0.0.1]:35032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imKM3-0003Qg-DE for submit@debbugs.gnu.org; Tue, 31 Dec 2019 11:26:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imKM2-0003QU-OQ for 15214@debbugs.gnu.org; Tue, 31 Dec 2019 11:26:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imKLx-0002lY-Gt; Tue, 31 Dec 2019 11:26:41 -0500 Received: from [176.228.60.248] (port=4715 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imKLw-0001go-Pl; Tue, 31 Dec 2019 11:26:41 -0500 Date: Tue, 31 Dec 2019 18:26:50 +0200 Message-Id: <83mub8laut.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-reply-to: (message from Mauro Aranda on Mon, 30 Dec 2019 18:30:31 -0300) Subject: Re: bug#15214: 24.3.50; `Revert This Session's Customization' does not do what it says References: <8b504c44-91b3-4c9f-bca5-3b4d1547f67f@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15214 Cc: 15214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mauro Aranda > Date: Mon, 30 Dec 2019 18:30:31 -0300 > > > Click State and Revert This Session's Customization. You should instead click "Set to Backup Value". The Revert button is in general for variables you have saved for future sessions. > The function that runs for that option is custom-variable-reset-saved, > and the doc string of custom-variable-reset-saved says something similar. The doc string is ambiguous, and the code definitely does NOT intend to reset the value, just to remove the recorded setting, so that it won't be saved in the custom file. That code was installed in response to a very similar bug report (bug#9509, except that it complained that Emacs signals an error for a variable that was never saved). I very much doubt that Chong, who made that change, omitted setting the value by mistake. In general, there's a feature creep here: this menu item was originally only for customized options that were saved during this session. That was lifted back then, and now we want also to change the value, although another menu item exists to do just that. > The attached patch fixes custom-variable-reset-saved to do what it says > it does when the variable has no previous saved value. I won't object too much to such a change, if you still think it's TRT here after reading the above, but I wonder whether it would be cleaner and safer to set just the value, and move the funcall out of the if-else form, so that we'd have only one funcall, and it will be inside ignore-errors. > - ;; If there is no saved value, remove the setting. > - (custom-push-theme 'theme-value symbol 'user 'reset) > + (progn > + ;; If there is no saved value, remove the setting. The comment needs to be updated, since we now don't merely remove the setting. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 09:48:06 2020 Received: (at 15214) by debbugs.gnu.org; 1 Jan 2020 14:48:06 +0000 Received: from localhost ([127.0.0.1]:36360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imfI5-0007cD-KL for submit@debbugs.gnu.org; Wed, 01 Jan 2020 09:48:06 -0500 Received: from mail-lj1-f177.google.com ([209.85.208.177]:35797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imfI4-0007bk-1o for 15214@debbugs.gnu.org; Wed, 01 Jan 2020 09:48:04 -0500 Received: by mail-lj1-f177.google.com with SMTP id j1so31089414lja.2 for <15214@debbugs.gnu.org>; Wed, 01 Jan 2020 06:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eCoK6o6SBc0oPKSMGt1oH5L95tB4YaUu1pfSi9hPThk=; b=aDWo2cq2UwfLrOew/H0DuJNQbLeY9aUCp2yqJkrn74NlUf0Vz0sDVeOQOHJNOfXVS+ /62VslElYrl5cCKNS8ESvzrMUlHBzs56v4SK8Vb/0uboag7+ruU6QFYjlE6jd5wjf0ii cffu6tc4OBIFUdGtT0mJ+oNLkapv/3w2LhVk+hZ+8HlBbLYEoqjQpuSleZJyblJBJ+uI zi2FsmYbciBfGX3hdOJyWLsg6eVSWWKN3Bo68blN+ltbK+F219TEmbYfA1r1QR053JNh KPPNJ8Ck6CeuaWH1loT2mHo7TNKF6utxvJY8T6LzzteTr0riqo5xLgkdHru1kk5twLO6 f9LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eCoK6o6SBc0oPKSMGt1oH5L95tB4YaUu1pfSi9hPThk=; b=PKYBGh1ctl24jXfqW3CFTyOqQbDGn786B/c2HkjpqmGmxvj70iFeMi5lB4Q4DIlZ4S aNeT6z1JtPwfulhVMFl7qP3qI6QN0bs7oIADvYGHkWtom9lwqgBbvNZobANNlIgHSRU/ IJ0lNq8yapfWufTm912bQohRI+gjHx+3nihGFShxQfu1ZKvimEIFjlKJdqoYIjAavNGH xNQs3gPj9mfytWxeW5zeFbfhiRGyf0TtsajeSypgq8iFRmm19fOTHn2q6kVntxNkyEIG y48crNwbsnTAaB3VvAmA57oOA4gez5rrsZQx5oK5zOI6xCWiMS/zQalg+FoFPjhsMVMO ah9A== X-Gm-Message-State: APjAAAWq9ukmju+bB0rx98hbHm9dI3pa/fGgEfePEiZ6KXFPEBeS4pVf tiGJPko0zEgDHPwGPBp2PbnqXBOvGm0/LgZCJoA= X-Google-Smtp-Source: APXvYqxfgoo0mmGqmzOCQYX/cNvRvraqEM32sF3wQEPSLU/xIuqxPaV7Q3UYkLl2dMqjrgK1yF8YoKbUJU1dkO15cD8= X-Received: by 2002:a2e:8152:: with SMTP id t18mr45932282ljg.255.1577890077999; Wed, 01 Jan 2020 06:47:57 -0800 (PST) MIME-Version: 1.0 References: <8b504c44-91b3-4c9f-bca5-3b4d1547f67f@default> <83mub8laut.fsf@gnu.org> In-Reply-To: <83mub8laut.fsf@gnu.org> From: Mauro Aranda Date: Wed, 1 Jan 2020 11:47:45 -0300 Message-ID: Subject: Re: bug#15214: 24.3.50; `Revert This Session's Customization' does not do what it says To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000982373059b15292d" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15214 Cc: 15214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000982373059b15292d Content-Type: multipart/alternative; boundary="000000000000982371059b15292b" --000000000000982371059b15292b Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> From: Mauro Aranda >> Date: Mon, 30 Dec 2019 18:30:31 -0300 >> >> > Click State and Revert This Session's Customization. > > You should instead click "Set to Backup Value". The Revert button is > in general for variables you have saved for future sessions. For user options that are of boolean type, that works well. But for other kinds of user options, there is a risk it won't work: 1. emacs -Q 2. M-x customize-variable dired-kept-versions 3. Edit the field to 3 and then Set for current session. 4. Now edit it to 4, and then Set for current session. Now "Set to Backup Value" won't ever take you back to the state before your session's customizations. >> The function that runs for that option is custom-variable-reset-saved, >> and the doc string of custom-variable-reset-saved says something similar. > > The doc string is ambiguous, and the code definitely does NOT intend > to reset the value, just to remove the recorded setting, so that it > won't be saved in the custom file. That code was installed in What part of the doc string do you find ambiguous? Personally, I was baffled about the (themed or standard) part, because if there is a theme value (other than the user theme), that value counts as the saved value too. As for the intentions of the code, a symbol with no 'saved-value property set would be enough for the customization to not be saved in the custom file, AFAICS. It's true that it does not intend to reset the value, but at least my reading of the doc string makes me think it does, the Emacs manual says it does, and even though the use case is rare, I think it's better to do it. > response to a very similar bug report (bug#9509, except that it > complained that Emacs signals an error for a variable that was never > saved). I very much doubt that Chong, who made that change, omitted > setting the value by mistake. In Bug#9509 the suggestion was to revert those settings to the un-customized value. I can't tell whether Chong was inclined to take that suggestion or not, but I do think that we should take it. > In general, there's a feature creep here: this menu item was > originally only for customized options that were saved during this > session. That was lifted back then, and now we want also to change > the value, although another menu item exists to do just that. See the first part of my reply. I don't think there is another menu item in an emacs -Q session able to take one back to the uncustomized value, reliably. >> The attached patch fixes custom-variable-reset-saved to do what it says >> it does when the variable has no previous saved value. > > I won't object too much to such a change, if you still think it's TRT > here after reading the above, but I wonder whether it would be cleaner > and safer to set just the value, and move the funcall out of the > if-else form, so that we'd have only one funcall, and it will be > inside ignore-errors. I still think it would be a good addition to the code. In case you are OK with it, I attach a patch with moves the funcall outside of the if-else form. Best regards, Mauro. --000000000000982371059b15292b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> From: Mauro Aranda <maurooaranda@gmail.com>
>> Date:= Mon, 30 Dec 2019 18:30:31 -0300
>>
>> > Click State = and Revert This Session's Customization.
>
> You should ins= tead click "Set to Backup Value".=C2=A0 The Revert button is
&= gt; in general for variables you have saved for future sessions.

For= user options that are of boolean type, that works well.=C2=A0 But for
o= ther kinds of user options, there is a risk it won't work:

1. em= acs -Q
2. M-x customize-variable dired-kept-versions
3. Edit the fiel= d to 3 and then Set for current session.
4. Now edit it to 4, and then S= et for current session.

Now "Set to Backup Value" won'= t ever take you back to the state before
your session's customizatio= ns.

>> The function that runs for that option is custom-variab= le-reset-saved,
>> and the doc string of custom-variable-reset-sav= ed says something similar.
>
> The doc string is ambiguous, and= the code definitely does NOT intend
> to reset the value, just to re= move the recorded setting, so that it
> won't be saved in the cus= tom file.=C2=A0 That code was installed in

What part of the doc stri= ng do you find ambiguous? Personally, I was
baffled about the (themed or= standard) part, because if there is a
theme value (other than the user = theme), that value counts as
the saved value too.

As for the inte= ntions of the code, a symbol with no 'saved-value property
set would= be enough for the customization to not be saved in the custom
file, AFA= ICS.=C2=A0 It's true that it does not intend to reset the value, butat least my reading of the doc string makes me think it does, the Emacsmanual says it does, and even though the use case is rare, I think it'= s
better to do it.

> response to a very similar bug report (bu= g#9509, except that it
> complained that Emacs signals an error for a= variable that was never
> saved).=C2=A0 I very much doubt that Chong= , who made that change, omitted
> setting the value by mistake.
In Bug#9509 the suggestion was to revert those settings to the
un= -customized value.=C2=A0 I can't tell whether Chong was inclined to
take that suggestion or not, but I do think that we should take it.<= br>

> In general, there's a feature creep here: this menu i= tem was
> originally only for customized options that were saved duri= ng this
> session.=C2=A0 That was lifted back then, and now we want a= lso to change
> the value, although another menu item exists to do ju= st that.

See the first part of my reply.=C2=A0 I don't think the= re is another menu
item in an emacs -Q session able to take one back to = the uncustomized
value, reliably.
=C2=A0 =C2=A0 =C2=A0 =C2=A0
>= ;> The attached patch fixes custom-variable-reset-saved to do what it sa= ys
>> it does when the variable has no previous saved value.
&g= t;
> I won't object too much to such a change, if you still think= it's TRT
> here after reading the above, but I wonder whether it= would be cleaner
> and safer to set just the value, and move the fun= call out of the
> if-else form, so that we'd have only one funcal= l, and it will be
> inside ignore-errors.

I still think it wou= ld be a good addition to the code.=C2=A0 In case you are
OK with it, I a= ttach a patch with moves the funcall outside of the
if-else form.
Best regards,
Mauro.
--000000000000982371059b15292b-- --000000000000982373059b15292d Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Reset-to-the-standard-value-when-reverting-session-s.patch" Content-Disposition: attachment; filename="0001-Reset-to-the-standard-value-when-reverting-session-s.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k4vez0ot0 RnJvbSAwZjEzMDcyMzlkMjlmNGEwNjg3OGM5NTg0MGQ5YTQzMzE4Zjg1N2I1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IE1vbiwgMzAgRGVjIDIwMTkgMTg6MTA6MjggLTAzMDAKU3ViamVjdDogW1BBVENIXSBS ZXNldCB0byB0aGUgc3RhbmRhcmQgdmFsdWUgd2hlbiByZXZlcnRpbmcgc2Vzc2lvbidzCiBjdXN0 b21pemF0aW9ucwoKKiBsaXNwL2N1cy1lZGl0LmVsIChjdXN0b20tdmFyaWFibGUtcmVzZXQtc2F2 ZWQpOiBXaGVuIHRoZXJlIGlzIG5vCnByZXZpb3VzIHNhdmVkIHZhbHVlLCByZXNldCB0byB0aGUg c3RhbmRhcmQgdmFsdWUuICAoQnVnIzE1MjE0KQotLS0KIGxpc3AvY3VzLWVkaXQuZWwgfCAxOSAr KysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgOSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2N1cy1lZGl0LmVsIGIvbGlzcC9jdXMtZWRp dC5lbAppbmRleCA0Mzk2NjdhLi44YTVmYzhjIDEwMDY0NAotLS0gYS9saXNwL2N1cy1lZGl0LmVs CisrKyBiL2xpc3AvY3VzLWVkaXQuZWwKQEAgLTMwMzUsMTcgKzMwMzUsMTggQEAgY3VzdG9tLXZh cmlhYmxlLXJlc2V0LXNhdmVkCiBiZWZvcmUgdGhpcyBvcGVyYXRpb24gYmVjb21lcyB0aGUgYmFj a3VwIHZhbHVlLiIKICAgKGxldCogKChzeW1ib2wgKHdpZGdldC12YWx1ZSB3aWRnZXQpKQogCSAo c2F2ZWQtdmFsdWUgKGdldCBzeW1ib2wgJ3NhdmVkLXZhbHVlKSkKLQkgKGNvbW1lbnQgKGdldCBz eW1ib2wgJ3NhdmVkLXZhcmlhYmxlLWNvbW1lbnQpKSkKKwkgKGNvbW1lbnQgKGdldCBzeW1ib2wg J3NhdmVkLXZhcmlhYmxlLWNvbW1lbnQpKQorICAgICAgICAgdmFsdWUpCiAgICAgKGN1c3RvbS12 YXJpYWJsZS1iYWNrdXAtdmFsdWUgd2lkZ2V0KQogICAgIChpZiAobm90IChvciBzYXZlZC12YWx1 ZSBjb21tZW50KSkKLQk7OyBJZiB0aGVyZSBpcyBubyBzYXZlZCB2YWx1ZSwgcmVtb3ZlIHRoZSBz ZXR0aW5nLgotCShjdXN0b20tcHVzaC10aGVtZSAndGhlbWUtdmFsdWUgc3ltYm9sICd1c2VyICdy ZXNldCkKLSAgICAgIDs7IE90aGVyd2lzZSwgYXBwbHkgdGhlIHNhdmVkIHZhbHVlLgotICAgICAg KHB1dCBzeW1ib2wgJ3ZhcmlhYmxlLWNvbW1lbnQgY29tbWVudCkKLSAgICAgIChjdXN0b20tcHVz aC10aGVtZSAndGhlbWUtdmFsdWUgc3ltYm9sICd1c2VyICdzZXQgKGNhci1zYWZlIHNhdmVkLXZh bHVlKSkKLSAgICAgIChpZ25vcmUtZXJyb3JzCi0JKGZ1bmNhbGwgKG9yIChnZXQgc3ltYm9sICdj dXN0b20tc2V0KSAnc2V0LWRlZmF1bHQpCi0JCSBzeW1ib2wgKGV2YWwgKGNhciBzYXZlZC12YWx1 ZSkpKSkpCisgICAgICAgIDs7IElmIHRoZXJlIGlzIG5vIHNhdmVkIHZhbHVlLCByZW1vdmUgdGhl IHNldHRpbmcuCisgICAgICAgIChjdXN0b20tcHVzaC10aGVtZSAndGhlbWUtdmFsdWUgc3ltYm9s ICd1c2VyICdyZXNldCkKKyAgICAgIChzZXRxIHZhbHVlIChjYXItc2FmZSBzYXZlZC12YWx1ZSkp CisgICAgICAoY3VzdG9tLXB1c2gtdGhlbWUgJ3RoZW1lLXZhbHVlIHN5bWJvbCAndXNlciAnc2V0 IHZhbHVlKQorICAgICAgKHB1dCBzeW1ib2wgJ3ZhcmlhYmxlLWNvbW1lbnQgY29tbWVudCkpCisg ICAgKGlnbm9yZS1lcnJvcnMKKyAgICAgIChmdW5jYWxsIChvciAoZ2V0IHN5bWJvbCAnY3VzdG9t LXNldCkgIydzZXQtZGVmYXVsdCkgc3ltYm9sCisgICAgICAgICAgICAgICAoZXZhbCAob3IgdmFs dWUgKGNhciAoZ2V0IHN5bWJvbCAnc3RhbmRhcmQtdmFsdWUpKSkpKSkKICAgICAocHV0IHN5bWJv bCAnY3VzdG9taXplZC12YWx1ZSBuaWwpCiAgICAgKHB1dCBzeW1ib2wgJ2N1c3RvbWl6ZWQtdmFy aWFibGUtY29tbWVudCBuaWwpCiAgICAgKHdpZGdldC1wdXQgd2lkZ2V0IDpjdXN0b20tc3RhdGUg J3Vua25vd24pCi0tIAoyLjcuNAoK --000000000000982373059b15292d-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 11:36:28 2020 Received: (at 15214) by debbugs.gnu.org; 1 Jan 2020 16:36:28 +0000 Received: from localhost ([127.0.0.1]:37488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgyy-0002F4-6z for submit@debbugs.gnu.org; Wed, 01 Jan 2020 11:36:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1imgyx-0002Ep-By for 15214@debbugs.gnu.org; Wed, 01 Jan 2020 11:36:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1imgys-0006rN-69; Wed, 01 Jan 2020 11:36:22 -0500 Received: from [176.228.60.248] (port=1283 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1imgyp-0004FL-KI; Wed, 01 Jan 2020 11:36:20 -0500 Date: Wed, 01 Jan 2020 18:36:34 +0200 Message-Id: <83mub7jfql.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-reply-to: (message from Mauro Aranda on Wed, 1 Jan 2020 11:47:45 -0300) Subject: Re: bug#15214: 24.3.50; `Revert This Session's Customization' does not do what it says References: <8b504c44-91b3-4c9f-bca5-3b4d1547f67f@default> <83mub8laut.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15214 Cc: 15214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mauro Aranda > Date: Wed, 1 Jan 2020 11:47:45 -0300 > Cc: 15214@debbugs.gnu.org > > > You should instead click "Set to Backup Value". The Revert button is > > in general for variables you have saved for future sessions. > > For user options that are of boolean type, that works well. But for > other kinds of user options, there is a risk it won't work: > > 1. emacs -Q > 2. M-x customize-variable dired-kept-versions > 3. Edit the field to 3 and then Set for current session. > 4. Now edit it to 4, and then Set for current session. > > Now "Set to Backup Value" won't ever take you back to the state before > your session's customizations. "Set to Backup Value" reverts to the previous value, not to the original one. So this is working as intended. > > >> The function that runs for that option is custom-variable-reset-saved, > >> and the doc string of custom-variable-reset-saved says something similar. > > > > The doc string is ambiguous, and the code definitely does NOT intend > > to reset the value, just to remove the recorded setting, so that it > > won't be saved in the custom file. That code was installed in > > What part of the doc string do you find ambiguous? The "reset" part. > I still think it would be a good addition to the code. In case you are > OK with it, I attach a patch with moves the funcall outside of the > if-else form. It LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 16:58:35 2020 Received: (at 15214) by debbugs.gnu.org; 7 Jan 2020 21:58:35 +0000 Received: from localhost ([127.0.0.1]:49511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iowry-000780-Po for submit@debbugs.gnu.org; Tue, 07 Jan 2020 16:58:34 -0500 Received: from mail-lf1-f51.google.com ([209.85.167.51]:45389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iowrw-00077j-SR for 15214@debbugs.gnu.org; Tue, 07 Jan 2020 16:58:33 -0500 Received: by mail-lf1-f51.google.com with SMTP id 203so852997lfa.12 for <15214@debbugs.gnu.org>; Tue, 07 Jan 2020 13:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sCADKM/brLV1r8eWbqPUkqq8dT/tVqIPIzR5LlNM5Vg=; b=C1juIbFHvj7iLCAXS+jsAeTi5krym4RDTAoBEh0VFHtHjLhS/m7msTC2344uBgYrYg XOR40ZtrZYMnjy6o8/+Bob1GU0b33qvt5/Cr01NmK7XKnCwjxw1Ds4L0AyqojJeRVKpz us5W2CAxuEZ4qxRM8VVFuMafKf8Ad3utb5C8XB8eBCjDWz1wvkPbNgJtuUx2cklGDLPq jtqR3gn6/YWdWII0qb6Py4qjBA+f5ORDyFtQq+FXBEJLzZwS5HbuFM0Q5+gELh8z9eBJ ksrWqOkbcvxwE0X/BfiTB1rtr9yuZoUY36oDmadN7T519fPE05Oc1JSvrlkocOTmKC35 7MFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sCADKM/brLV1r8eWbqPUkqq8dT/tVqIPIzR5LlNM5Vg=; b=moq4CVcPX/CNPlA9QnoCKPhbs1v7KoSFoUcEUIVgU0fuvh3R0G6Xn9uKeZPPoECZdF KQSesd2ZTNgL9p0gJLPZJFgLFL5pexX6IMXmTp3wSnDn0TgVclmtUM5Zww0qFVecVP1L 8vfPumjOsDSwHly3W/BOHMXNFjl1Lqsg8J43lSs2Edq1Q9lL/BLn5UoXLP87zWH3re+Q /+J9Jomv8t94sUmTX2feN5FDjbtkvJDiMllxz6f54Q4h51U89TlJAz5HjHbWYSRp68m6 /ZRPYXudyesZv6eUVgK3jCL4VAtp1cYkfPWHBDweFMg7V0LZWLmIQwTIBvoE+5OS3qUs oSuA== X-Gm-Message-State: APjAAAXtEcuS4rshmMcVCHUAIWrAQpCylpM+nOxZsUpj2wbMAgeNQonO l55SYhjjQquiQPG+hFTVU6xqkG92nDm9mJ54IDI= X-Google-Smtp-Source: APXvYqxt+7cJGstpmCOpDQxhamVJyYTb+D5NolY+3kX8qiB0iYuf1i9YZ2Z2elm4M1yHXpf0ARxjVVYyE0TK1yPqPxw= X-Received: by 2002:a05:6512:c7:: with SMTP id c7mr962182lfp.120.1578434306625; Tue, 07 Jan 2020 13:58:26 -0800 (PST) MIME-Version: 1.0 References: <8b504c44-91b3-4c9f-bca5-3b4d1547f67f@default> <83mub8laut.fsf@gnu.org> <83mub7jfql.fsf@gnu.org> In-Reply-To: <83mub7jfql.fsf@gnu.org> From: Mauro Aranda Date: Tue, 7 Jan 2020 18:58:13 -0300 Message-ID: Subject: Re: bug#15214: 24.3.50; `Revert This Session's Customization' does not do what it says To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000025d4cf059b93e020" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15214 Cc: 15214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000025d4cf059b93e020 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: >> What part of the doc string do you find ambiguous? > > The "reset" part. The best I can come up with is just saying: "...; otherwise, set the variable to the standard value." (If the change is applied, of course). >> I still think it would be a good addition to the code. In case you are >> OK with it, I attach a patch with moves the funcall outside of the >> if-else form. > > It LGTM, thanks. Great. If there are no other objections, I'll wait for someone to push it. --00000000000025d4cf059b93e020 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu= .org> writes:

>> What part of the doc string do you fin= d ambiguous?
>
> The "reset" part.

The best I = can come up with is just saying:
"...; otherwise, set the variable = to the standard value."
(If the change is applied, of course).
<= br>>> I still think it would be a good addition to the code.=C2=A0 In= case you are
>> OK with it, I attach a patch with moves the funca= ll outside of the
>> if-else form.
>
> It LGTM, thanks= .

Great.=C2=A0 If there are no other objections, I'll wait for s= omeone to push
it.
--00000000000025d4cf059b93e020-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 11 03:39:24 2020 Received: (at 15214-done) by debbugs.gnu.org; 11 Jan 2020 08:39:24 +0000 Received: from localhost ([127.0.0.1]:55332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqCIm-0004bw-7t for submit@debbugs.gnu.org; Sat, 11 Jan 2020 03:39:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iqCIl-0004bl-7J for 15214-done@debbugs.gnu.org; Sat, 11 Jan 2020 03:39:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iqCIg-00006z-1D; Sat, 11 Jan 2020 03:39:18 -0500 Received: from [176.228.60.248] (port=3243 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iqCIf-0002kf-GH; Sat, 11 Jan 2020 03:39:17 -0500 Date: Sat, 11 Jan 2020 10:39:19 +0200 Message-Id: <837e1y8k08.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-reply-to: (message from Mauro Aranda on Tue, 7 Jan 2020 18:58:13 -0300) Subject: Re: bug#15214: 24.3.50; `Revert This Session's Customization' does not do what it says References: <8b504c44-91b3-4c9f-bca5-3b4d1547f67f@default> <83mub8laut.fsf@gnu.org> <83mub7jfql.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15214-done Cc: 15214-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mauro Aranda > Date: Tue, 7 Jan 2020 18:58:13 -0300 > Cc: 15214@debbugs.gnu.org > > >> I still think it would be a good addition to the code. In case you are > >> OK with it, I attach a patch with moves the funcall outside of the > >> if-else form. > > > > It LGTM, thanks. > > Great. If there are no other objections, I'll wait for someone to push > it. Thanks, pushed to the emacs-27 branch, and closing the bug. From unknown Sat Sep 20 05:15:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 08 Feb 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator