From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 29 04:51:55 2013 Received: (at submit) by debbugs.gnu.org; 29 Aug 2013 08:51:55 +0000 Received: from localhost ([127.0.0.1]:35139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VExxL-0007mb-8Q for submit@debbugs.gnu.org; Thu, 29 Aug 2013 04:51:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37337) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VExxJ-0007mQ-4a for submit@debbugs.gnu.org; Thu, 29 Aug 2013 04:51:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VExx9-00065t-OM for submit@debbugs.gnu.org; Thu, 29 Aug 2013 04:51:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VExx9-00065p-L7 for submit@debbugs.gnu.org; Thu, 29 Aug 2013 04:51:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VExx2-0003mb-2c for bug-gnu-emacs@gnu.org; Thu, 29 Aug 2013 04:51:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VExwu-00061V-PA for bug-gnu-emacs@gnu.org; Thu, 29 Aug 2013 04:51:36 -0400 Received: from mail-we0-f182.google.com ([74.125.82.182]:47322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VExwu-000618-G1 for bug-gnu-emacs@gnu.org; Thu, 29 Aug 2013 04:51:28 -0400 Received: by mail-we0-f182.google.com with SMTP id q59so141211wes.13 for ; Thu, 29 Aug 2013 01:51:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=kgEODYFdpA4PY9uz0RivzDsgOeUMMktZDSFFgyeYBmQ=; b=Fsn6aWI/kUttLPXPvfIEoB8FU6k57FCZ6T5wV8rrUYwpA1pxnraw8xcvKzk9zzVzhp RotQBF4OLjMaWAPfdRXaQFzm9JiJtjd/iD1msiRYOzmDoejktBPGpDhU7zN+VPAmkGc3 9pmk/nkINE14OhP6tAdYkzf8Bc+Kp+XaDOY24Ppb17Dr1Wv4MjAIdF2HC05AHE51Qo5k 1a/EjgOnuKWBFaLEcZkuNFer4ngDz95qzXzPA626gt86MnniFyq+tMb2Lg5h4PdM4+Ym ZeeUNX3DOdwTW3L0WU71MLNDhc4vYJ0yxINDMjm77gOKsi/C5rYd8/Q3k/DUQUzE53Bc 85lQ== X-Gm-Message-State: ALoCoQlLu0TgClPV4BI/LPXd6lsVUB8uVz4nWYAjf+LiuHM7x5CSo6AWAH/nLmACjd21sfQGJs84 X-Received: by 10.194.172.9 with SMTP id ay9mr4123543wjc.54.1377766277320; Thu, 29 Aug 2013 01:51:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.180.182.196 with HTTP; Thu, 29 Aug 2013 01:50:57 -0700 (PDT) X-Originating-IP: [212.247.43.194] From: =?ISO-8859-1?Q?Gauthier_=D6stervall?= Date: Thu, 29 Aug 2013 10:50:57 +0200 Message-ID: Subject: 24.2; C Highlight colors around CV-modifiers To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.4 (---) C highlighting is not consistent depending on the placement of CV-modifiers in variable declarations. Example: const type1 var1; type2 const var2; Both declarations are equivalent but the color of "type?" differs. Issue verified in version 24.3 as well. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 01 05:11:52 2013 Received: (at 15207) by debbugs.gnu.org; 1 Sep 2013 09:11:52 +0000 Received: from localhost ([127.0.0.1]:34175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VG3hH-0000T2-Rh for submit@debbugs.gnu.org; Sun, 01 Sep 2013 05:11:52 -0400 Received: from colin.muc.de ([193.149.48.1]:58592 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VG3hE-0000Sp-MA for 15207@debbugs.gnu.org; Sun, 01 Sep 2013 05:11:49 -0400 Received: (qmail 8238 invoked by uid 3782); 1 Sep 2013 09:11:47 -0000 Received: from acm.muc.de (pD9518B75.dip0.t-ipconnect.de [217.81.139.117]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 01 Sep 2013 11:11:46 +0200 Received: (qmail 3036 invoked by uid 1000); 1 Sep 2013 09:10:28 -0000 Date: Sun, 1 Sep 2013 09:10:27 +0000 To: 15207@debbugs.gnu.org, Gauthier ?stervall Subject: Re: bug#15207: 24.2; C Highlight colors around CV-modifiers Message-ID: <20130901091027.GA2959@acm.acm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 15207 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) Hi, Gauthier. Gauthier ?stervall wrote: > C highlighting is not consistent depending on the placement of > CV-modifiers in variable declarations. > Example: > const type1 var1; > type2 const var2; > Both declarations are equivalent but the color of "type?" differs. > Issue verified in version 24.3 as well. Bug #15211 seems to be a duplicate of this bug. It's amazing how a bug like this can remain undetected for over a decade, then suddenly two people report it within a few hours of eachother. Would you please try out the patch from #15211, and let me know whether it fixes the bug, doesn't quite fix it, or there are unwanted side effects. Here it is again: diff -r 45df171f9859 cc-engine.el --- a/cc-engine.el Sat Aug 31 11:09:30 2013 +0000 +++ b/cc-engine.el Sat Aug 31 20:32:22 2013 +0000 @@ -7440,7 +7440,8 @@ ;; interactive refontification. (c-put-c-type-property (point) 'c-decl-arg-start)) - (when (and c-record-type-identifiers at-type (not (eq at-type t))) + (when (and c-record-type-identifiers at-type ;; (not (eq at-type t)) + ) (let ((c-promote-possible-types t)) (save-excursion (goto-char type-start) I'll just repeat what I said in #15211: the code in CC Mode took trouble to _exclude_ "type2" from being fontified, and I don't understand why. There may be side effects from this patch. Thanks for reporting this bug, and thanks for making it a high quality bug report. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 18 17:01:29 2013 Received: (at 15207-done) by debbugs.gnu.org; 18 Sep 2013 21:01:29 +0000 Received: from localhost ([127.0.0.1]:47453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMOsL-0008R7-6q for submit@debbugs.gnu.org; Wed, 18 Sep 2013 17:01:29 -0400 Received: from colin.muc.de ([193.149.48.1]:56405 helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VMOsJ-0008Qv-3G for 15207-done@debbugs.gnu.org; Wed, 18 Sep 2013 17:01:27 -0400 Received: (qmail 95529 invoked by uid 3782); 18 Sep 2013 21:01:25 -0000 Received: from acm.muc.de (pD951B99B.dip0.t-ipconnect.de [217.81.185.155]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 18 Sep 2013 23:01:25 +0200 Received: (qmail 15575 invoked by uid 1000); 18 Sep 2013 20:59:51 -0000 Date: Wed, 18 Sep 2013 20:59:51 +0000 To: 15207-done@debbugs.gnu.org Subject: Re: bug#15207: 24.2; C Highlight colors around CV-modifiers Message-ID: <20130918205951.GB5640@acm.acm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 15207-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Bug fixed, by revision #114379. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 25 11:42:45 2013 Received: (at 15207) by debbugs.gnu.org; 25 Sep 2013 15:42:46 +0000 Received: from localhost ([127.0.0.1]:35436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOrEi-00034j-Vb for submit@debbugs.gnu.org; Wed, 25 Sep 2013 11:42:45 -0400 Received: from mail-wg0-f48.google.com ([74.125.82.48]:46966) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VOrEg-00034b-S6 for 15207@debbugs.gnu.org; Wed, 25 Sep 2013 11:42:43 -0400 Received: by mail-wg0-f48.google.com with SMTP id n12so6210368wgh.3 for <15207@debbugs.gnu.org>; Wed, 25 Sep 2013 08:42:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=yO8/P/gaJ1QTABtocfUgYUOs+IhTILWGvxe8HA/7f58=; b=Sqs6oW5Zd9xepOAQfrFin2XTwZwLUblP4gGPrksU0H9eVG6Swvk+9unjtNSFyjOipI jev2QuZ4epeG9SOZhaDyLxApBtTaAwbfMw80jlAnGhskivmPG/spcFxkN+RnJwAJfkgO VU9pen2Jm6crkr7SuhUixQd86ujDbtFLfeCdrZCPXELyXcWnrRxb9FhibQiHTopVC9Z9 hYy3eMTOI4+2wVjm5sFkx16bLPWV78W+lmiSBZ+n3Ilg3TE/GWtC3aK3zCkzxd+8K6/j qYSV3nEH2iCMVhZ/sNnZmxBpVsdPoSa7PdXCGXR6idelU4FHjOUoH4ua1yesV9iZaz9A ExNw== X-Gm-Message-State: ALoCoQnMqJty7Qzb70/82AV+9by2iseYthJ/XAVoA968ZGBgVTsZ/JJC6XdFeCTNJQisEQrzUQaK X-Received: by 10.180.13.210 with SMTP id j18mr23337301wic.51.1380123762123; Wed, 25 Sep 2013 08:42:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.180.182.196 with HTTP; Wed, 25 Sep 2013 08:42:21 -0700 (PDT) X-Originating-IP: [212.247.43.194] In-Reply-To: <20130901091027.GA2959@acm.acm> References: <20130901091027.GA2959@acm.acm> From: =?ISO-8859-1?Q?Gauthier_=D6stervall?= Date: Wed, 25 Sep 2013 17:42:21 +0200 Message-ID: Subject: Re: bug#15207: 24.2; C Highlight colors around CV-modifiers To: Alan Mackenzie Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15207 Cc: 15207@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi, sorry for the very late reply. On Sun, Sep 1, 2013 at 11:10 AM, Alan Mackenzie wrote: > Bug #15211 seems to be a duplicate of this bug. It's amazing how a bug > like this can remain undetected for over a decade, then suddenly two > people report it within a few hours of eachother. It is indeed amazing! I am happy to be the first of two :) > Would you please try out the patch from #15211, and let me know whether > it fixes the bug, doesn't quite fix it, or there are unwanted side > effects. Here it is again: > > > diff -r 45df171f9859 cc-engine.el > --- a/cc-engine.el Sat Aug 31 11:09:30 2013 +0000 > +++ b/cc-engine.el Sat Aug 31 20:32:22 2013 +0000 > @@ -7440,7 +7440,8 @@ > ;; interactive refontification. > (c-put-c-type-property (point) 'c-decl-arg-start)) > > - (when (and c-record-type-identifiers at-type (not (eq at-type t))) > + (when (and c-record-type-identifiers at-type ;; (not (eq at-type t)) > + ) > (let ((c-promote-possible-types t)) > (save-excursion > (goto-char type-start) This is working, thank you. However (and sorry for telling you after you closed the bug), this still is not: uint8_t *a = (uint8_t *) b; uint8_t *c = (const uint8_t *) d; uint8_t *e = (uint8_t const *) f; The erroneous behavior is still present in casts. I applied your change to the part that handles the cast, which solved the problem. I am sure you know where the cast handling is, otherwise search for "Handle the cast". The code is identical, located 20 lines earlier in version 24.3. From unknown Mon Aug 18 14:22:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 24 Oct 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator