GNU bug report logs - #15137
python mode patch

Previous Next

Package: emacs;

Reported by: Daniel Elliott <danelliottster <at> gmail.com>

Date: Mon, 19 Aug 2013 21:53:02 UTC

Severity: minor

Tags: patch

Merged with 15400

Done: fgallina <at> gnu.org

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Andreas Röhler <andreas.roehler <at> easy-emacs.de>
To: 15137 <at> debbugs.gnu.org
Subject: bug#15137: python mode patch
Date: Sun, 01 Sep 2013 09:25:13 +0200

Am 31.08.2013 14:44, schrieb fabian <at> anue.biz:
>
> monnier <at> iro.umontreal.ca writes:
>
>>> !     (buffer-substring start end))
>> [...]
>>> !     ;; wrap with a conditional to avoid errors about python unexpected indentation
>>> !     "if True:\n"
>>> !     (buffer-substring start end)
>>> !     "\n")
>>
>> That looks pretty good, thank you.
>> Fabián, could you take a look?
>>
>
> The idea is good but the patch needs bit more of work -- this approach
> will work when an indented region is sent but won't when sending a
> region which starts with no indentation at all.

Right. Current python-mode.el shifts region-or-whatever-delivered left until it starts at column 0.

> Also backtraces numbers
> will be wrong for a -1 offset.
>

Correct. BTW there is still the Emacs count-lines bug: at BOL it counts one less than from secoond column.


> I'll push something for this soon.
>
>
> Regards,
> Fabián.
>
>
>
>
This bug report was last modified 11 years and 250 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.