GNU bug report logs - #15128
24.3.50; python.el completion broken

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Rasmus Pank Roulund <rasmus <at> pank.eu>
Subject: bug#15128: closed (24.3.50; python.el completion broken)
Date: Mon, 02 Sep 2013 13:16:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#15128: 24.3.50; python.el completion broken

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 15128 <at> debbugs.gnu.org.

-- 
15128: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15128
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: fgallina <at> gnu.org
To: 15128-done <at> debbugs.gnu.org
Subject: 24.3.50; python.el completion broken
Date: Mon, 02 Sep 2013 10:15:14 -0300

Hello Rasmus,

I fixed this in revno 114094. I took a different approach, avoiding use
of the comint-last-prompt* vars in a way to keep compatiblity with Emacs
24.x.


Regards,
Fabián.

[Message part 3 (message/rfc822, inline)]

From: Rasmus Pank Roulund <rasmus <at> pank.eu>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; python.el completion broken
Date: Mon, 19 Aug 2013 02:44:15 +0200

Hi,

With Christopher Schmidt's comint changes on 2013-08-08 python.el
completion breaks.  To reproduce do

emacs -q
M-x run-python
x [TAB]

I've included a simple fix that may or may not be sufficient. Here's
the diff -c output

*** python.el	2013-08-19 02:13:21.822104349 +0200
--- python1.el	2013-08-19 02:13:52.323300415 +0200
***************
*** 2276,2283 ****
            ;; heuristic.
            (with-current-buffer (process-buffer process)
              (buffer-substring-no-properties
!              (overlay-start comint-last-prompt-overlay)
!              (overlay-end comint-last-prompt-overlay))))
           (completion-context
            ;; Check whether a prompt matches a pdb string, an import
            ;; statement or just the standard prompt and use the
--- 2276,2283 ----
            ;; heuristic.
            (with-current-buffer (process-buffer process)
              (buffer-substring-no-properties
!              (marker-position (car comint-last-prompt))
!              (marker-position (cdr comint-last-prompt)))))
           (completion-context
            ;; Check whether a prompt matches a pdb string, an import
            ;; statement or just the standard prompt and use the

Here's a changelog, if needed.

2013-08-19  Rasmus Pank Roulund  <emacs <at> pank.eu>

	* progmodes/python.el (python-shell-completion-get-completions):
	Replace reference to comint-last-prompt-overlay with
	comint-last-prompt.

Let me know if I did something wrong!

–Rasmus

In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.8.2)
 of 2013-08-17 on pank
Bzr revision: eliz <at> gnu.org-20130817171807-fxigtkbc6yy8m9iw
Windowing system distributor `The X.Org Foundation', version 11.0.11402000
System Description:	Arch Linux

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.