GNU bug report logs - #15107
24.3; replace-regexp-in-string wrong on \`

Previous Next

Package: emacs;

Reported by: Kevin Ryde <user42 <at> zip.com.au>

Date: Thu, 15 Aug 2013 22:17:02 UTC

Severity: normal

Tags: confirmed, patch

Merged with 44861

Found in versions 24.3, 25.1, 27.1

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log

Message #38 received at control <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: Shigeru Fukaya <shigeru.fukaya <at> gmail.com>
Cc: 44861 <at> debbugs.gnu.org
Subject: Re: bug#44861: 27.1; [PATCH] signal in `replace-regexp-in-string' 
Date: Wed, 25 Nov 2020 15:58:22 +0100

[Message part 1 (text/plain, inline)]
forcemerge 15107 44861
stop

Suggested patch attached. A small test suite for replace-regexp-in-string has already been pushed to master -- very rudimentary, but better than nothing -- and the patch amends it with some new relevant cases that didn't work before.

It is basically your patch but slightly optimised; it turned out that the function call and allocation overhead of the original patch made it a tad too expensive (a pity, because it was very neat). Now performance is about the same as before when the pattern contains no submatches, and slightly above (< 10% slower) with one submatch. It seems worth the correctness.


[0001-Fix-replace-regexp-in-string-substring-match-data-tr.patch (application/octet-stream, attachment)]
This bug report was last modified 4 years and 170 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.