GNU bug report logs - #15069
Introduction to Elisp 14.3: Function 'count-words-defun' does not work as described.

Previous Next

Full log

Message #16 received at 15069 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: pillule <pillule <at> riseup.net>
Cc: poenikatu <at> fastmail.co.uk, stefan <at> marxist.se, 15069 <at> debbugs.gnu.org
Subject: Re: bug#15069: [PATCH] Bug: 15069: Correct functioning in the
 *scratch* buffer
Date: Sat, 22 May 2021 09:34:19 +0300

> From: pillule <pillule <at> riseup.net>
> Date: Fri, 21 May 2021 19:39:37 +0000
> Cc: Sian Mountbatten <poenikatu <at> fastmail.co.uk>,
>  Stefan Kangas <stefan <at> marxist.se>
> 
> It has been pointed the instructions for `count-words-in-defun` are
> ambiguous : One can expect to evaluate the sexp in the Info manual but
> that would not work, so this commit explicit that it must be done in a
> clean buffer (= with a valid syntaxe tree).
> 
> Copyright-paperwork-exempt: yes
> ---
>  doc/lispintro/emacs-lisp-intro.texi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/lispintro/emacs-lisp-intro.texi b/doc/lispintro/emacs-lisp-intro.texi
> index fade4096e3..ba5fae4ff0 100644
> --- a/doc/lispintro/emacs-lisp-intro.texi
> +++ b/doc/lispintro/emacs-lisp-intro.texi
> @@ -14650,7 +14650,8 @@ Let's re-use @kbd{C-c =} as a convenient keybinding:
>  
>  Now we can try out @code{count-words-defun}: install both
>  @code{count-words-in-defun} and @code{count-words-defun}, and set the
> -keybinding, and then place the cursor within the following definition:
> +keybinding, and then place the cursor within the following definition,
> +in a clean scratch buffer:

It says "install the functions", which means they should be evaluated
or loaded, and that tells you the Lisp code should already be
available in some Lisp buffer, whether it's *scratch* or some *.el
file.

So why did you think it speaks about the text in the Info buffer?
That's not the intent of the text, and the text says as much.

So I'm not sure we should install this fix.  Any other opinions?

In any case:

  . just talking about *scratch* is too restrictive
  . the commit log message is not according to our conventions (see
    CONTRIBUTE)

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.