From emerick@gmail.com Fri Dec 5 08:51:19 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.9 required=4.0 tests=BAYES_00,FOURLA, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 5 Dec 2008 16:51:20 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB5GpG2t018416 for ; Fri, 5 Dec 2008 08:51:18 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L8dtc-0004iB-K4 for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2008 11:51:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L8dtb-0004hF-Gg for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2008 11:51:15 -0500 Received: from [199.232.76.173] (port=53109 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L8dtb-0004h0-8L for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2008 11:51:15 -0500 Received: from mail-qy0-f17.google.com ([209.85.221.17]:60574) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L8dta-0007Sr-KX for bug-gnu-emacs@gnu.org; Fri, 05 Dec 2008 11:51:14 -0500 Received: by qyk10 with SMTP id 10so132431qyk.18 for ; Fri, 05 Dec 2008 08:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=uwMWc27ITPetpGapMZsy4d3zpkQTvgBRzye9A1zkpxI=; b=CsiV9e2cqwKf0NVip73d+nRl04fJE5hEOhU9hzHL+UE7JD+8dD0ZP6lfD5g7QuEQX6 IAk0AbDa20Ty3CvgOiJxzsxulx7TFntYvFuqdQc464rxaH+B/tY/yfvl1DtEPfSRBtbp Ph0RtHGDHPTM8HHLz5CYitNda3SdXOxoufxoA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=uHyY8OKlG8I1M+BAiIRh8iyd1KBzuTkSI7lPnaBuZ1dhHmGV4447UvnxqXLIZocRET C+gOay301i90W1ai9sUNDsxNQsKLrSPPr2XfAWLWaiYjkHUlR7o342ZiVUHsk7aHcLZs WSahVGzXkXN4CldrhCr1Y1OlrSpamm7BdSXjM= Received: by 10.142.174.8 with SMTP id w8mr67005wfe.225.1228495872758; Fri, 05 Dec 2008 08:51:12 -0800 (PST) Received: by 10.143.3.17 with HTTP; Fri, 5 Dec 2008 08:51:12 -0800 (PST) Message-ID: Date: Fri, 5 Dec 2008 11:51:12 -0500 From: "Emerick Rogul" To: bug-gnu-emacs@gnu.org Subject: Emacs 22 loses undo buffer MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Using Emacs 22 on Windows (emacs-version reports "GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) of 2008-09-06 on SOFT-MJASON"): Started emacs with emacs -q --no-site-file. Opened a C header file (foo.h) containing about 100-200 lines of code. Deleted approximately 100 or so lines of code using C-k. Pressed and held C-/ to undo the deletions. Instead of eventually seeing all of my deletions restored, Emacs complained about "No further undo information" after undeleting several lines of text. This works as expected with Emacs 21.2. Please let me know if I can provide any additional information. Thanks, -Emerick From cyd@stupidchicken.com Fri Dec 5 20:01:55 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1501) by emacsbugs.donarmstrong.com; 6 Dec 2008 04:01:55 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB641rKc026779 for <1501@emacsbugs.donarmstrong.com>; Fri, 5 Dec 2008 20:01:54 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 3F47757E195; Fri, 5 Dec 2008 23:01:56 -0500 (EST) From: Chong Yidong To: "Emerick Rogul" Cc: 1501@debbugs.gnu.org Subject: Re: Emacs 22 loses undo buffer Date: Fri, 05 Dec 2008 23:01:56 -0500 Message-ID: <877i6ej6iz.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii There is insufficient information to diagnose the problem you reported. If possible, please provide the C header file that demonstrates this problem. Also, provide *exact* instructions for reproducing the problem---we need the exact keystrokes you entered, not a vague description like "deleted approximately 100 or so lines". Thanks. From emerick@gmail.com Sat Dec 6 13:03:05 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.8 required=4.0 tests=AWL,BAYES_00,FOURLA, IMPRONONCABLE_1,IMPRONONCABLE_2,MURPHY_WRONG_WORD1,MURPHY_WRONG_WORD2 autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1501) by emacsbugs.donarmstrong.com; 6 Dec 2008 21:03:06 +0000 Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.175]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB6L2xuY025824 for <1501@emacsbugs.donarmstrong.com>; Sat, 6 Dec 2008 13:03:00 -0800 Received: by wf-out-1314.google.com with SMTP id 26so601273wfd.13 for <1501@emacsbugs.donarmstrong.com>; Sat, 06 Dec 2008 13:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:mime-version:content-type; bh=h0e2v3sIyEgF0Okw+pORr/psPvZhFtXl57Cc/D6ti9M=; b=clwmsWhzHmtm9iBDaZ7HU2DCfMFRKW3dPr34e/3wne10aazkPvvRnicB66xn/i3JBo GYJDDnBPR3fxb1+1MDo56XQRUcNUhCxeJjtqHiHuNs/VgSd/ET+ItJqBK5thyJpSAnPA bstPBqA53Uggi+QYQY0T5VfLrPdGwwKuHs+Ck= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:mime-version:content-type; b=lP0jfbFThs5w6swHU8cr8SbbNeB3QxUTkAwQ01c1Yf9c8N4OqDqInzXdstzJG5madi KIdY6jxBnXb/whShqxmUssTiSxEi1zjEDciNsATnoLabsUH3KTFgFhJ3k2Nz0rRi5wlH MCYUH0+m1Iew7otdfGSZ68UREWzlWmZX49/7k= Received: by 10.143.8.17 with SMTP id l17mr665431wfi.173.1228597379446; Sat, 06 Dec 2008 13:02:59 -0800 (PST) Received: by 10.143.3.17 with HTTP; Sat, 6 Dec 2008 13:02:59 -0800 (PST) Message-ID: Date: Sat, 6 Dec 2008 16:02:59 -0500 From: "Emerick Rogul" To: 1501@debbugs.gnu.org Subject: Re: Emacs 22 loses undo buffer Cc: cyd@stupidchicken.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_28949_1639241.1228597379427" ------=_Part_28949_1639241.1228597379427 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Header file attached, although the problem occurs with any header file (i.e., it's not specific to this particular file). The trace below contains the exact key sequence that I typed. In GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) of 2008-09-06 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ENU locale-coding-system: cp1252 default-enable-multibyte-characters: t Major mode: C/l Minor modes in effect: encoded-kbd-mode: t tooltip-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t auto-compression-mode: t line-number-mode: t abbrev-mode: t Recent input: C-x C-f c l r C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ ESC x r e p o r t - e m a Recent messages: ("C:\\emacs\\bin\\emacs.exe") Loading encoded-kb...done For information about GNU Emacs and the GNU system, type C-h C-a. Loading cc-mode...done Undo! [4 times] undo-more: No further undo information [17 times] Loading emacsbug...done ------=_Part_28949_1639241.1228597379427 Content-Type: text/plain; name=clrdata.h Content-Transfer-Encoding: base64 X-Attachment-Id: f_foepp6nt0 Content-Disposition: attachment; filename=clrdata.h DQoNCi8qIHRoaXMgQUxXQVlTIEdFTkVSQVRFRCBmaWxlIGNvbnRhaW5zIHRoZSBkZWZpbml0aW9u cyBmb3IgdGhlIGludGVyZmFjZXMgKi8NCg0KDQogLyogRmlsZSBjcmVhdGVkIGJ5IE1JREwgY29t cGlsZXIgdmVyc2lvbiA2LjAwLjAzNjYgKi8NCi8qIENvbXBpbGVyIHNldHRpbmdzIGZvciBjbHJk YXRhLmlkbDoNCiAgICBPaWNmLCBXMSwgWnA4LCBlbnY9V2luMzIgKDMyYiBydW4pDQogICAgcHJv dG9jb2wgOiBkY2UgLCBtc19leHQsIGNfZXh0LCByb2J1c3QNCiAgICBlcnJvciBjaGVja3M6IGFs bG9jYXRpb24gcmVmIGJvdW5kc19jaGVjayBlbnVtIHN0dWJfZGF0YSANCiAgICBWQyBfX2RlY2xz cGVjKCkgZGVjb3JhdGlvbiBsZXZlbDogDQogICAgICAgICBfX2RlY2xzcGVjKHV1aWQoKSksIF9f ZGVjbHNwZWMoc2VsZWN0YW55KSwgX19kZWNsc3BlYyhub3Z0YWJsZSkNCiAgICAgICAgIERFQ0xT UEVDX1VVSUQoKSwgTUlETF9JTlRFUkZBQ0UoKQ0KKi8NCi8vQEBNSURMX0ZJTEVfSEVBRElORygg ICkNCg0KI3ByYWdtYSB3YXJuaW5nKCBkaXNhYmxlOiA0MDQ5ICkgIC8qIG1vcmUgdGhhbiA2NGsg c291cmNlIGxpbmVzICovDQoNCg0KLyogdmVyaWZ5IHRoYXQgdGhlIDxycGNuZHIuaD4gdmVyc2lv biBpcyBoaWdoIGVub3VnaCB0byBjb21waWxlIHRoaXMgZmlsZSovDQojaWZuZGVmIF9fUkVRVUlS RURfUlBDTkRSX0hfVkVSU0lPTl9fDQojZGVmaW5lIF9fUkVRVUlSRURfUlBDTkRSX0hfVkVSU0lP Tl9fIDQ3NQ0KI2VuZGlmDQoNCiNpbmNsdWRlICJycGMuaCINCiNpbmNsdWRlICJycGNuZHIuaCIN Cg0KI2lmbmRlZiBfX1JQQ05EUl9IX1ZFUlNJT05fXw0KI2Vycm9yIHRoaXMgc3R1YiByZXF1aXJl cyBhbiB1cGRhdGVkIHZlcnNpb24gb2YgPHJwY25kci5oPg0KI2VuZGlmIC8vIF9fUlBDTkRSX0hf VkVSU0lPTl9fDQoNCiNpZm5kZWYgQ09NX05PX1dJTkRPV1NfSA0KI2luY2x1ZGUgIndpbmRvd3Mu aCINCiNpbmNsdWRlICJvbGUyLmgiDQojZW5kaWYgLypDT01fTk9fV0lORE9XU19IKi8NCg0KI2lm bmRlZiBfX2NscmRhdGFfaF9fDQojZGVmaW5lIF9fY2xyZGF0YV9oX18NCg0KI2lmIGRlZmluZWQo X01TQ19WRVIpICYmIChfTVNDX1ZFUiA+PSAxMDIwKQ0KI3ByYWdtYSBvbmNlDQojZW5kaWYNCg0K LyogRm9yd2FyZCBEZWNsYXJhdGlvbnMgKi8gDQoNCiNpZm5kZWYgX19JQ0xSRGF0YVRhcmdldF9G V0RfREVGSU5FRF9fDQojZGVmaW5lIF9fSUNMUkRhdGFUYXJnZXRfRldEX0RFRklORURfXw0KdHlw ZWRlZiBpbnRlcmZhY2UgSUNMUkRhdGFUYXJnZXQgSUNMUkRhdGFUYXJnZXQ7DQojZW5kaWYgCS8q IF9fSUNMUkRhdGFUYXJnZXRfRldEX0RFRklORURfXyAqLw0KDQoNCiNpZm5kZWYgX19JQ0xSRGF0 YVRhcmdldDJfRldEX0RFRklORURfXw0KI2RlZmluZSBfX0lDTFJEYXRhVGFyZ2V0Ml9GV0RfREVG SU5FRF9fDQp0eXBlZGVmIGludGVyZmFjZSBJQ0xSRGF0YVRhcmdldDIgSUNMUkRhdGFUYXJnZXQy Ow0KI2VuZGlmIAkvKiBfX0lDTFJEYXRhVGFyZ2V0Ml9GV0RfREVGSU5FRF9fICovDQoNCg0KI2lm bmRlZiBfX0lDTFJNZXRhZGF0YUxvY2F0b3JfRldEX0RFRklORURfXw0KI2RlZmluZSBfX0lDTFJN ZXRhZGF0YUxvY2F0b3JfRldEX0RFRklORURfXw0KdHlwZWRlZiBpbnRlcmZhY2UgSUNMUk1ldGFk YXRhTG9jYXRvciBJQ0xSTWV0YWRhdGFMb2NhdG9yOw0KI2VuZGlmIAkvKiBfX0lDTFJNZXRhZGF0 YUxvY2F0b3JfRldEX0RFRklORURfXyAqLw0KDQoNCiNpZm5kZWYgX19JQ0xSRGF0YUVudW1NZW1v cnlSZWdpb25zQ2FsbGJhY2tfRldEX0RFRklORURfXw0KI2RlZmluZSBfX0lDTFJEYXRhRW51bU1l bW9yeVJlZ2lvbnNDYWxsYmFja19GV0RfREVGSU5FRF9fDQp0eXBlZGVmIGludGVyZmFjZSBJQ0xS RGF0YUVudW1NZW1vcnlSZWdpb25zQ2FsbGJhY2sgSUNMUkRhdGFFbnVtTWVtb3J5UmVnaW9uc0Nh bGxiYWNrOw0KI2VuZGlmIAkvKiBfX0lDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnNDYWxsYmFja19G V0RfREVGSU5FRF9fICovDQoNCg0KI2lmbmRlZiBfX0lDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnNf RldEX0RFRklORURfXw0KI2RlZmluZSBfX0lDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnNfRldEX0RF RklORURfXw0KdHlwZWRlZiBpbnRlcmZhY2UgSUNMUkRhdGFFbnVtTWVtb3J5UmVnaW9ucyBJQ0xS RGF0YUVudW1NZW1vcnlSZWdpb25zOw0KI2VuZGlmIAkvKiBfX0lDTFJEYXRhRW51bU1lbW9yeVJl Z2lvbnNfRldEX0RFRklORURfXyAqLw0KDQoNCi8qIGhlYWRlciBmaWxlcyBmb3IgaW1wb3J0ZWQg ZmlsZXMgKi8NCiNpbmNsdWRlICJ1bmtud24uaCINCg0KI2lmZGVmIF9fY3BsdXNwbHVzDQpleHRl cm4gIkMiew0KI2VuZGlmIA0KDQp2b2lkICogX19SUENfVVNFUiBNSURMX3VzZXJfYWxsb2NhdGUo c2l6ZV90KTsNCnZvaWQgX19SUENfVVNFUiBNSURMX3VzZXJfZnJlZSggdm9pZCAqICk7IA0KDQov KiBpbnRlcmZhY2UgX19NSURMX2l0Zl9jbHJkYXRhXzAwMDAgKi8NCi8qIFtsb2NhbF0gKi8gDQoN Cg0KDQoNCg0KDQp0eXBlZGVmIFVMT05HNjQgQ0xSREFUQV9BRERSRVNTOw0KDQpTVERBUEkgQ0xS RGF0YUNyZWF0ZUluc3RhbmNlKFJFRklJRCBpaWQsIElDTFJEYXRhVGFyZ2V0KiB0YXJnZXQsIHZv aWQqKiBpZmFjZSk7DQp0eXBlZGVmIEhSRVNVTFQgKFNUREFQSUNBTExUWVBFKiBQRk5fQ0xSRGF0 YUNyZWF0ZUluc3RhbmNlKShSRUZJSUQgaWlkLCBJQ0xSRGF0YVRhcmdldCogdGFyZ2V0LCB2b2lk KiogaWZhY2UpOw0KDQoNCmV4dGVybiBSUENfSUZfSEFORExFIF9fTUlETF9pdGZfY2xyZGF0YV8w MDAwX3YwXzBfY19pZnNwZWM7DQpleHRlcm4gUlBDX0lGX0hBTkRMRSBfX01JRExfaXRmX2NscmRh dGFfMDAwMF92MF8wX3NfaWZzcGVjOw0KDQojaWZuZGVmIF9fSUNMUkRhdGFUYXJnZXRfSU5URVJG QUNFX0RFRklORURfXw0KI2RlZmluZSBfX0lDTFJEYXRhVGFyZ2V0X0lOVEVSRkFDRV9ERUZJTkVE X18NCg0KLyogaW50ZXJmYWNlIElDTFJEYXRhVGFyZ2V0ICovDQovKiBbdW5pcXVlXVt1dWlkXVtv YmplY3RdICovIA0KDQoNCkVYVEVSTl9DIGNvbnN0IElJRCBJSURfSUNMUkRhdGFUYXJnZXQ7DQoN CiNpZiBkZWZpbmVkKF9fY3BsdXNwbHVzKSAmJiAhZGVmaW5lZChDSU5URVJGQUNFKQ0KICAgIA0K ICAgIE1JRExfSU5URVJGQUNFKCIzRTExQ0NFRS1EMDhCLTQzZTUtQUYwMS0zMjcxN0E2NERBMDMi KQ0KICAgIElDTFJEYXRhVGFyZ2V0IDogcHVibGljIElVbmtub3duDQogICAgew0KICAgIHB1Ymxp YzoNCiAgICAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIEdldE1hY2hpbmVU eXBlKCANCiAgICAgICAgICAgIC8qIFtvdXRdICovIFVMT05HMzIgKm1hY2hpbmVUeXBlKSA9IDA7 DQogICAgICAgIA0KICAgICAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgR2V0 UG9pbnRlclNpemUoIA0KICAgICAgICAgICAgLyogW291dF0gKi8gVUxPTkczMiAqcG9pbnRlclNp emUpID0gMDsNCiAgICAgICAgDQogICAgICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxM VFlQRSBHZXRJbWFnZUJhc2UoIA0KICAgICAgICAgICAgLyogW3N0cmluZ11baW5dICovIExQQ1dT VFIgaW1hZ2VQYXRoLA0KICAgICAgICAgICAgLyogW291dF0gKi8gQ0xSREFUQV9BRERSRVNTICpi YXNlQWRkcmVzcykgPSAwOw0KICAgICAgICANCiAgICAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1F VEhPRENBTExUWVBFIFJlYWRWaXJ0dWFsKCANCiAgICAgICAgICAgIC8qIFtpbl0gKi8gQ0xSREFU QV9BRERSRVNTIGFkZHJlc3MsDQogICAgICAgICAgICAvKiBbbGVuZ3RoX2lzXVtzaXplX2lzXVtv dXRdICovIEJZVEUgKmJ1ZmZlciwNCiAgICAgICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiBieXRl c1JlcXVlc3RlZCwNCiAgICAgICAgICAgIC8qIFtvdXRdICovIFVMT05HMzIgKmJ5dGVzUmVhZCkg PSAwOw0KICAgICAgICANCiAgICAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBF IFdyaXRlVmlydHVhbCggDQogICAgICAgICAgICAvKiBbaW5dICovIENMUkRBVEFfQUREUkVTUyBh ZGRyZXNzLA0KICAgICAgICAgICAgLyogW3NpemVfaXNdW2luXSAqLyBCWVRFICpidWZmZXIsDQog ICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgYnl0ZXNSZXF1ZXN0ZWQsDQogICAgICAgICAg ICAvKiBbb3V0XSAqLyBVTE9ORzMyICpieXRlc1dyaXR0ZW4pID0gMDsNCiAgICAgICAgDQogICAg ICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBHZXRUTFNWYWx1ZSggDQogICAg ICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgdGhyZWFkSUQsDQogICAgICAgICAgICAvKiBbaW5d ICovIFVMT05HMzIgaW5kZXgsDQogICAgICAgICAgICAvKiBbb3V0XSAqLyBDTFJEQVRBX0FERFJF U1MgKnZhbHVlKSA9IDA7DQogICAgICAgIA0KICAgICAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVU SE9EQ0FMTFRZUEUgU2V0VExTVmFsdWUoIA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMy IHRocmVhZElELA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIGluZGV4LA0KICAgICAg ICAgICAgLyogW2luXSAqLyBDTFJEQVRBX0FERFJFU1MgdmFsdWUpID0gMDsNCiAgICAgICAgDQog ICAgICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBHZXRDdXJyZW50VGhyZWFk SUQoIA0KICAgICAgICAgICAgLyogW291dF0gKi8gVUxPTkczMiAqdGhyZWFkSUQpID0gMDsNCiAg ICAgICAgDQogICAgICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBHZXRUaHJl YWRDb250ZXh0KCANCiAgICAgICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiB0aHJlYWRJRCwNCiAg ICAgICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiBjb250ZXh0RmxhZ3MsDQogICAgICAgICAgICAv KiBbaW5dICovIFVMT05HMzIgY29udGV4dFNpemUsDQogICAgICAgICAgICAvKiBbc2l6ZV9pc11b b3V0XSAqLyBCWVRFICpjb250ZXh0KSA9IDA7DQogICAgICAgIA0KICAgICAgICB2aXJ0dWFsIEhS RVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgU2V0VGhyZWFkQ29udGV4dCggDQogICAgICAgICAgICAv KiBbaW5dICovIFVMT05HMzIgdGhyZWFkSUQsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05H MzIgY29udGV4dFNpemUsDQogICAgICAgICAgICAvKiBbc2l6ZV9pc11baW5dICovIEJZVEUgKmNv bnRleHQpID0gMDsNCiAgICAgICAgDQogICAgICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RD QUxMVFlQRSBSZXF1ZXN0KCANCiAgICAgICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiByZXFDb2Rl LA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIGluQnVmZmVyU2l6ZSwNCiAgICAgICAg ICAgIC8qIFtzaXplX2lzXVtpbl0gKi8gQllURSAqaW5CdWZmZXIsDQogICAgICAgICAgICAvKiBb aW5dICovIFVMT05HMzIgb3V0QnVmZmVyU2l6ZSwNCiAgICAgICAgICAgIC8qIFtzaXplX2lzXVtv dXRdICovIEJZVEUgKm91dEJ1ZmZlcikgPSAwOw0KICAgICAgICANCiAgICB9Ow0KICAgIA0KI2Vs c2UgCS8qIEMgc3R5bGUgaW50ZXJmYWNlICovDQoNCiAgICB0eXBlZGVmIHN0cnVjdCBJQ0xSRGF0 YVRhcmdldFZ0YmwNCiAgICB7DQogICAgICAgIEJFR0lOX0lOVEVSRkFDRQ0KICAgICAgICANCiAg ICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpRdWVyeUludGVyZmFjZSApKCANCiAg ICAgICAgICAgIElDTFJEYXRhVGFyZ2V0ICogVGhpcywNCiAgICAgICAgICAgIC8qIFtpbl0gKi8g UkVGSUlEIHJpaWQsDQogICAgICAgICAgICAvKiBbaWlkX2lzXVtvdXRdICovIHZvaWQgKipwcHZP YmplY3QpOw0KICAgICAgICANCiAgICAgICAgVUxPTkcgKCBTVERNRVRIT0RDQUxMVFlQRSAqQWRk UmVmICkoIA0KICAgICAgICAgICAgSUNMUkRhdGFUYXJnZXQgKiBUaGlzKTsNCiAgICAgICAgDQog ICAgICAgIFVMT05HICggU1RETUVUSE9EQ0FMTFRZUEUgKlJlbGVhc2UgKSggDQogICAgICAgICAg ICBJQ0xSRGF0YVRhcmdldCAqIFRoaXMpOw0KICAgICAgICANCiAgICAgICAgSFJFU1VMVCAoIFNU RE1FVEhPRENBTExUWVBFICpHZXRNYWNoaW5lVHlwZSApKCANCiAgICAgICAgICAgIElDTFJEYXRh VGFyZ2V0ICogVGhpcywNCiAgICAgICAgICAgIC8qIFtvdXRdICovIFVMT05HMzIgKm1hY2hpbmVU eXBlKTsNCiAgICAgICAgDQogICAgICAgIEhSRVNVTFQgKCBTVERNRVRIT0RDQUxMVFlQRSAqR2V0 UG9pbnRlclNpemUgKSggDQogICAgICAgICAgICBJQ0xSRGF0YVRhcmdldCAqIFRoaXMsDQogICAg ICAgICAgICAvKiBbb3V0XSAqLyBVTE9ORzMyICpwb2ludGVyU2l6ZSk7DQogICAgICAgIA0KICAg ICAgICBIUkVTVUxUICggU1RETUVUSE9EQ0FMTFRZUEUgKkdldEltYWdlQmFzZSApKCANCiAgICAg ICAgICAgIElDTFJEYXRhVGFyZ2V0ICogVGhpcywNCiAgICAgICAgICAgIC8qIFtzdHJpbmddW2lu XSAqLyBMUENXU1RSIGltYWdlUGF0aCwNCiAgICAgICAgICAgIC8qIFtvdXRdICovIENMUkRBVEFf QUREUkVTUyAqYmFzZUFkZHJlc3MpOw0KICAgICAgICANCiAgICAgICAgSFJFU1VMVCAoIFNURE1F VEhPRENBTExUWVBFICpSZWFkVmlydHVhbCApKCANCiAgICAgICAgICAgIElDTFJEYXRhVGFyZ2V0 ICogVGhpcywNCiAgICAgICAgICAgIC8qIFtpbl0gKi8gQ0xSREFUQV9BRERSRVNTIGFkZHJlc3Ms DQogICAgICAgICAgICAvKiBbbGVuZ3RoX2lzXVtzaXplX2lzXVtvdXRdICovIEJZVEUgKmJ1ZmZl ciwNCiAgICAgICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiBieXRlc1JlcXVlc3RlZCwNCiAgICAg ICAgICAgIC8qIFtvdXRdICovIFVMT05HMzIgKmJ5dGVzUmVhZCk7DQogICAgICAgIA0KICAgICAg ICBIUkVTVUxUICggU1RETUVUSE9EQ0FMTFRZUEUgKldyaXRlVmlydHVhbCApKCANCiAgICAgICAg ICAgIElDTFJEYXRhVGFyZ2V0ICogVGhpcywNCiAgICAgICAgICAgIC8qIFtpbl0gKi8gQ0xSREFU QV9BRERSRVNTIGFkZHJlc3MsDQogICAgICAgICAgICAvKiBbc2l6ZV9pc11baW5dICovIEJZVEUg KmJ1ZmZlciwNCiAgICAgICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiBieXRlc1JlcXVlc3RlZCwN CiAgICAgICAgICAgIC8qIFtvdXRdICovIFVMT05HMzIgKmJ5dGVzV3JpdHRlbik7DQogICAgICAg IA0KICAgICAgICBIUkVTVUxUICggU1RETUVUSE9EQ0FMTFRZUEUgKkdldFRMU1ZhbHVlICkoIA0K ICAgICAgICAgICAgSUNMUkRhdGFUYXJnZXQgKiBUaGlzLA0KICAgICAgICAgICAgLyogW2luXSAq LyBVTE9ORzMyIHRocmVhZElELA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIGluZGV4 LA0KICAgICAgICAgICAgLyogW291dF0gKi8gQ0xSREFUQV9BRERSRVNTICp2YWx1ZSk7DQogICAg ICAgIA0KICAgICAgICBIUkVTVUxUICggU1RETUVUSE9EQ0FMTFRZUEUgKlNldFRMU1ZhbHVlICko IA0KICAgICAgICAgICAgSUNMUkRhdGFUYXJnZXQgKiBUaGlzLA0KICAgICAgICAgICAgLyogW2lu XSAqLyBVTE9ORzMyIHRocmVhZElELA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIGlu ZGV4LA0KICAgICAgICAgICAgLyogW2luXSAqLyBDTFJEQVRBX0FERFJFU1MgdmFsdWUpOw0KICAg ICAgICANCiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpHZXRDdXJyZW50VGhy ZWFkSUQgKSggDQogICAgICAgICAgICBJQ0xSRGF0YVRhcmdldCAqIFRoaXMsDQogICAgICAgICAg ICAvKiBbb3V0XSAqLyBVTE9ORzMyICp0aHJlYWRJRCk7DQogICAgICAgIA0KICAgICAgICBIUkVT VUxUICggU1RETUVUSE9EQ0FMTFRZUEUgKkdldFRocmVhZENvbnRleHQgKSggDQogICAgICAgICAg ICBJQ0xSRGF0YVRhcmdldCAqIFRoaXMsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIg dGhyZWFkSUQsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgY29udGV4dEZsYWdzLA0K ICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIGNvbnRleHRTaXplLA0KICAgICAgICAgICAg LyogW3NpemVfaXNdW291dF0gKi8gQllURSAqY29udGV4dCk7DQogICAgICAgIA0KICAgICAgICBI UkVTVUxUICggU1RETUVUSE9EQ0FMTFRZUEUgKlNldFRocmVhZENvbnRleHQgKSggDQogICAgICAg ICAgICBJQ0xSRGF0YVRhcmdldCAqIFRoaXMsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05H MzIgdGhyZWFkSUQsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgY29udGV4dFNpemUs DQogICAgICAgICAgICAvKiBbc2l6ZV9pc11baW5dICovIEJZVEUgKmNvbnRleHQpOw0KICAgICAg ICANCiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpSZXF1ZXN0ICkoIA0KICAg ICAgICAgICAgSUNMUkRhdGFUYXJnZXQgKiBUaGlzLA0KICAgICAgICAgICAgLyogW2luXSAqLyBV TE9ORzMyIHJlcUNvZGUsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgaW5CdWZmZXJT aXplLA0KICAgICAgICAgICAgLyogW3NpemVfaXNdW2luXSAqLyBCWVRFICppbkJ1ZmZlciwNCiAg ICAgICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiBvdXRCdWZmZXJTaXplLA0KICAgICAgICAgICAg LyogW3NpemVfaXNdW291dF0gKi8gQllURSAqb3V0QnVmZmVyKTsNCiAgICAgICAgDQogICAgICAg IEVORF9JTlRFUkZBQ0UNCiAgICB9IElDTFJEYXRhVGFyZ2V0VnRibDsNCg0KICAgIGludGVyZmFj ZSBJQ0xSRGF0YVRhcmdldA0KICAgIHsNCiAgICAgICAgQ09OU1RfVlRCTCBzdHJ1Y3QgSUNMUkRh dGFUYXJnZXRWdGJsICpscFZ0Ymw7DQogICAgfTsNCg0KICAgIA0KDQojaWZkZWYgQ09CSk1BQ1JP Uw0KDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXRfUXVlcnlJbnRlcmZhY2UoVGhpcyxyaWlkLHBw dk9iamVjdCkJXA0KICAgIChUaGlzKS0+bHBWdGJsIC0+IFF1ZXJ5SW50ZXJmYWNlKFRoaXMscmlp ZCxwcHZPYmplY3QpDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXRfQWRkUmVmKFRoaXMpCVwNCiAg ICAoVGhpcyktPmxwVnRibCAtPiBBZGRSZWYoVGhpcykNCg0KI2RlZmluZSBJQ0xSRGF0YVRhcmdl dF9SZWxlYXNlKFRoaXMpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBSZWxlYXNlKFRoaXMpDQoN Cg0KI2RlZmluZSBJQ0xSRGF0YVRhcmdldF9HZXRNYWNoaW5lVHlwZShUaGlzLG1hY2hpbmVUeXBl KQlcDQogICAgKFRoaXMpLT5scFZ0YmwgLT4gR2V0TWFjaGluZVR5cGUoVGhpcyxtYWNoaW5lVHlw ZSkNCg0KI2RlZmluZSBJQ0xSRGF0YVRhcmdldF9HZXRQb2ludGVyU2l6ZShUaGlzLHBvaW50ZXJT aXplKQlcDQogICAgKFRoaXMpLT5scFZ0YmwgLT4gR2V0UG9pbnRlclNpemUoVGhpcyxwb2ludGVy U2l6ZSkNCg0KI2RlZmluZSBJQ0xSRGF0YVRhcmdldF9HZXRJbWFnZUJhc2UoVGhpcyxpbWFnZVBh dGgsYmFzZUFkZHJlc3MpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBHZXRJbWFnZUJhc2UoVGhp cyxpbWFnZVBhdGgsYmFzZUFkZHJlc3MpDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXRfUmVhZFZp cnR1YWwoVGhpcyxhZGRyZXNzLGJ1ZmZlcixieXRlc1JlcXVlc3RlZCxieXRlc1JlYWQpCVwNCiAg ICAoVGhpcyktPmxwVnRibCAtPiBSZWFkVmlydHVhbChUaGlzLGFkZHJlc3MsYnVmZmVyLGJ5dGVz UmVxdWVzdGVkLGJ5dGVzUmVhZCkNCg0KI2RlZmluZSBJQ0xSRGF0YVRhcmdldF9Xcml0ZVZpcnR1 YWwoVGhpcyxhZGRyZXNzLGJ1ZmZlcixieXRlc1JlcXVlc3RlZCxieXRlc1dyaXR0ZW4pCVwNCiAg ICAoVGhpcyktPmxwVnRibCAtPiBXcml0ZVZpcnR1YWwoVGhpcyxhZGRyZXNzLGJ1ZmZlcixieXRl c1JlcXVlc3RlZCxieXRlc1dyaXR0ZW4pDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXRfR2V0VExT VmFsdWUoVGhpcyx0aHJlYWRJRCxpbmRleCx2YWx1ZSkJXA0KICAgIChUaGlzKS0+bHBWdGJsIC0+ IEdldFRMU1ZhbHVlKFRoaXMsdGhyZWFkSUQsaW5kZXgsdmFsdWUpDQoNCiNkZWZpbmUgSUNMUkRh dGFUYXJnZXRfU2V0VExTVmFsdWUoVGhpcyx0aHJlYWRJRCxpbmRleCx2YWx1ZSkJXA0KICAgIChU aGlzKS0+bHBWdGJsIC0+IFNldFRMU1ZhbHVlKFRoaXMsdGhyZWFkSUQsaW5kZXgsdmFsdWUpDQoN CiNkZWZpbmUgSUNMUkRhdGFUYXJnZXRfR2V0Q3VycmVudFRocmVhZElEKFRoaXMsdGhyZWFkSUQp CVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBHZXRDdXJyZW50VGhyZWFkSUQoVGhpcyx0aHJlYWRJ RCkNCg0KI2RlZmluZSBJQ0xSRGF0YVRhcmdldF9HZXRUaHJlYWRDb250ZXh0KFRoaXMsdGhyZWFk SUQsY29udGV4dEZsYWdzLGNvbnRleHRTaXplLGNvbnRleHQpCVwNCiAgICAoVGhpcyktPmxwVnRi bCAtPiBHZXRUaHJlYWRDb250ZXh0KFRoaXMsdGhyZWFkSUQsY29udGV4dEZsYWdzLGNvbnRleHRT aXplLGNvbnRleHQpDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXRfU2V0VGhyZWFkQ29udGV4dChU aGlzLHRocmVhZElELGNvbnRleHRTaXplLGNvbnRleHQpCVwNCiAgICAoVGhpcyktPmxwVnRibCAt PiBTZXRUaHJlYWRDb250ZXh0KFRoaXMsdGhyZWFkSUQsY29udGV4dFNpemUsY29udGV4dCkNCg0K I2RlZmluZSBJQ0xSRGF0YVRhcmdldF9SZXF1ZXN0KFRoaXMscmVxQ29kZSxpbkJ1ZmZlclNpemUs aW5CdWZmZXIsb3V0QnVmZmVyU2l6ZSxvdXRCdWZmZXIpCVwNCiAgICAoVGhpcyktPmxwVnRibCAt PiBSZXF1ZXN0KFRoaXMscmVxQ29kZSxpbkJ1ZmZlclNpemUsaW5CdWZmZXIsb3V0QnVmZmVyU2l6 ZSxvdXRCdWZmZXIpDQoNCiNlbmRpZiAvKiBDT0JKTUFDUk9TICovDQoNCg0KI2VuZGlmIAkvKiBD IHN0eWxlIGludGVyZmFjZSAqLw0KDQoNCg0KSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBJQ0xS RGF0YVRhcmdldF9HZXRNYWNoaW5lVHlwZV9Qcm94eSggDQogICAgSUNMUkRhdGFUYXJnZXQgKiBU aGlzLA0KICAgIC8qIFtvdXRdICovIFVMT05HMzIgKm1hY2hpbmVUeXBlKTsNCg0KDQp2b2lkIF9f UlBDX1NUVUIgSUNMUkRhdGFUYXJnZXRfR2V0TWFjaGluZVR5cGVfU3R1YigNCiAgICBJUnBjU3R1 YkJ1ZmZlciAqVGhpcywNCiAgICBJUnBjQ2hhbm5lbEJ1ZmZlciAqX3BScGNDaGFubmVsQnVmZmVy LA0KICAgIFBSUENfTUVTU0FHRSBfcFJwY01lc3NhZ2UsDQogICAgRFdPUkQgKl9wZHdTdHViUGhh c2UpOw0KDQoNCkhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgSUNMUkRhdGFUYXJnZXRfR2V0UG9p bnRlclNpemVfUHJveHkoIA0KICAgIElDTFJEYXRhVGFyZ2V0ICogVGhpcywNCiAgICAvKiBbb3V0 XSAqLyBVTE9ORzMyICpwb2ludGVyU2l6ZSk7DQoNCg0Kdm9pZCBfX1JQQ19TVFVCIElDTFJEYXRh VGFyZ2V0X0dldFBvaW50ZXJTaXplX1N0dWIoDQogICAgSVJwY1N0dWJCdWZmZXIgKlRoaXMsDQog ICAgSVJwY0NoYW5uZWxCdWZmZXIgKl9wUnBjQ2hhbm5lbEJ1ZmZlciwNCiAgICBQUlBDX01FU1NB R0UgX3BScGNNZXNzYWdlLA0KICAgIERXT1JEICpfcGR3U3R1YlBoYXNlKTsNCg0KDQpIUkVTVUxU IFNURE1FVEhPRENBTExUWVBFIElDTFJEYXRhVGFyZ2V0X0dldEltYWdlQmFzZV9Qcm94eSggDQog ICAgSUNMUkRhdGFUYXJnZXQgKiBUaGlzLA0KICAgIC8qIFtzdHJpbmddW2luXSAqLyBMUENXU1RS IGltYWdlUGF0aCwNCiAgICAvKiBbb3V0XSAqLyBDTFJEQVRBX0FERFJFU1MgKmJhc2VBZGRyZXNz KTsNCg0KDQp2b2lkIF9fUlBDX1NUVUIgSUNMUkRhdGFUYXJnZXRfR2V0SW1hZ2VCYXNlX1N0dWIo DQogICAgSVJwY1N0dWJCdWZmZXIgKlRoaXMsDQogICAgSVJwY0NoYW5uZWxCdWZmZXIgKl9wUnBj Q2hhbm5lbEJ1ZmZlciwNCiAgICBQUlBDX01FU1NBR0UgX3BScGNNZXNzYWdlLA0KICAgIERXT1JE ICpfcGR3U3R1YlBoYXNlKTsNCg0KDQpIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIElDTFJEYXRh VGFyZ2V0X1JlYWRWaXJ0dWFsX1Byb3h5KCANCiAgICBJQ0xSRGF0YVRhcmdldCAqIFRoaXMsDQog ICAgLyogW2luXSAqLyBDTFJEQVRBX0FERFJFU1MgYWRkcmVzcywNCiAgICAvKiBbbGVuZ3RoX2lz XVtzaXplX2lzXVtvdXRdICovIEJZVEUgKmJ1ZmZlciwNCiAgICAvKiBbaW5dICovIFVMT05HMzIg Ynl0ZXNSZXF1ZXN0ZWQsDQogICAgLyogW291dF0gKi8gVUxPTkczMiAqYnl0ZXNSZWFkKTsNCg0K DQp2b2lkIF9fUlBDX1NUVUIgSUNMUkRhdGFUYXJnZXRfUmVhZFZpcnR1YWxfU3R1YigNCiAgICBJ UnBjU3R1YkJ1ZmZlciAqVGhpcywNCiAgICBJUnBjQ2hhbm5lbEJ1ZmZlciAqX3BScGNDaGFubmVs QnVmZmVyLA0KICAgIFBSUENfTUVTU0FHRSBfcFJwY01lc3NhZ2UsDQogICAgRFdPUkQgKl9wZHdT dHViUGhhc2UpOw0KDQoNCkhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgSUNMUkRhdGFUYXJnZXRf V3JpdGVWaXJ0dWFsX1Byb3h5KCANCiAgICBJQ0xSRGF0YVRhcmdldCAqIFRoaXMsDQogICAgLyog W2luXSAqLyBDTFJEQVRBX0FERFJFU1MgYWRkcmVzcywNCiAgICAvKiBbc2l6ZV9pc11baW5dICov IEJZVEUgKmJ1ZmZlciwNCiAgICAvKiBbaW5dICovIFVMT05HMzIgYnl0ZXNSZXF1ZXN0ZWQsDQog ICAgLyogW291dF0gKi8gVUxPTkczMiAqYnl0ZXNXcml0dGVuKTsNCg0KDQp2b2lkIF9fUlBDX1NU VUIgSUNMUkRhdGFUYXJnZXRfV3JpdGVWaXJ0dWFsX1N0dWIoDQogICAgSVJwY1N0dWJCdWZmZXIg KlRoaXMsDQogICAgSVJwY0NoYW5uZWxCdWZmZXIgKl9wUnBjQ2hhbm5lbEJ1ZmZlciwNCiAgICBQ UlBDX01FU1NBR0UgX3BScGNNZXNzYWdlLA0KICAgIERXT1JEICpfcGR3U3R1YlBoYXNlKTsNCg0K DQpIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIElDTFJEYXRhVGFyZ2V0X0dldFRMU1ZhbHVlX1By b3h5KCANCiAgICBJQ0xSRGF0YVRhcmdldCAqIFRoaXMsDQogICAgLyogW2luXSAqLyBVTE9ORzMy IHRocmVhZElELA0KICAgIC8qIFtpbl0gKi8gVUxPTkczMiBpbmRleCwNCiAgICAvKiBbb3V0XSAq LyBDTFJEQVRBX0FERFJFU1MgKnZhbHVlKTsNCg0KDQp2b2lkIF9fUlBDX1NUVUIgSUNMUkRhdGFU YXJnZXRfR2V0VExTVmFsdWVfU3R1YigNCiAgICBJUnBjU3R1YkJ1ZmZlciAqVGhpcywNCiAgICBJ UnBjQ2hhbm5lbEJ1ZmZlciAqX3BScGNDaGFubmVsQnVmZmVyLA0KICAgIFBSUENfTUVTU0FHRSBf cFJwY01lc3NhZ2UsDQogICAgRFdPUkQgKl9wZHdTdHViUGhhc2UpOw0KDQoNCkhSRVNVTFQgU1RE TUVUSE9EQ0FMTFRZUEUgSUNMUkRhdGFUYXJnZXRfU2V0VExTVmFsdWVfUHJveHkoIA0KICAgIElD TFJEYXRhVGFyZ2V0ICogVGhpcywNCiAgICAvKiBbaW5dICovIFVMT05HMzIgdGhyZWFkSUQsDQog ICAgLyogW2luXSAqLyBVTE9ORzMyIGluZGV4LA0KICAgIC8qIFtpbl0gKi8gQ0xSREFUQV9BRERS RVNTIHZhbHVlKTsNCg0KDQp2b2lkIF9fUlBDX1NUVUIgSUNMUkRhdGFUYXJnZXRfU2V0VExTVmFs dWVfU3R1YigNCiAgICBJUnBjU3R1YkJ1ZmZlciAqVGhpcywNCiAgICBJUnBjQ2hhbm5lbEJ1ZmZl ciAqX3BScGNDaGFubmVsQnVmZmVyLA0KICAgIFBSUENfTUVTU0FHRSBfcFJwY01lc3NhZ2UsDQog ICAgRFdPUkQgKl9wZHdTdHViUGhhc2UpOw0KDQoNCkhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUg SUNMUkRhdGFUYXJnZXRfR2V0Q3VycmVudFRocmVhZElEX1Byb3h5KCANCiAgICBJQ0xSRGF0YVRh cmdldCAqIFRoaXMsDQogICAgLyogW291dF0gKi8gVUxPTkczMiAqdGhyZWFkSUQpOw0KDQoNCnZv aWQgX19SUENfU1RVQiBJQ0xSRGF0YVRhcmdldF9HZXRDdXJyZW50VGhyZWFkSURfU3R1YigNCiAg ICBJUnBjU3R1YkJ1ZmZlciAqVGhpcywNCiAgICBJUnBjQ2hhbm5lbEJ1ZmZlciAqX3BScGNDaGFu bmVsQnVmZmVyLA0KICAgIFBSUENfTUVTU0FHRSBfcFJwY01lc3NhZ2UsDQogICAgRFdPUkQgKl9w ZHdTdHViUGhhc2UpOw0KDQoNCkhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgSUNMUkRhdGFUYXJn ZXRfR2V0VGhyZWFkQ29udGV4dF9Qcm94eSggDQogICAgSUNMUkRhdGFUYXJnZXQgKiBUaGlzLA0K ICAgIC8qIFtpbl0gKi8gVUxPTkczMiB0aHJlYWRJRCwNCiAgICAvKiBbaW5dICovIFVMT05HMzIg Y29udGV4dEZsYWdzLA0KICAgIC8qIFtpbl0gKi8gVUxPTkczMiBjb250ZXh0U2l6ZSwNCiAgICAv KiBbc2l6ZV9pc11bb3V0XSAqLyBCWVRFICpjb250ZXh0KTsNCg0KDQp2b2lkIF9fUlBDX1NUVUIg SUNMUkRhdGFUYXJnZXRfR2V0VGhyZWFkQ29udGV4dF9TdHViKA0KICAgIElScGNTdHViQnVmZmVy ICpUaGlzLA0KICAgIElScGNDaGFubmVsQnVmZmVyICpfcFJwY0NoYW5uZWxCdWZmZXIsDQogICAg UFJQQ19NRVNTQUdFIF9wUnBjTWVzc2FnZSwNCiAgICBEV09SRCAqX3Bkd1N0dWJQaGFzZSk7DQoN Cg0KSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBJQ0xSRGF0YVRhcmdldF9TZXRUaHJlYWRDb250 ZXh0X1Byb3h5KCANCiAgICBJQ0xSRGF0YVRhcmdldCAqIFRoaXMsDQogICAgLyogW2luXSAqLyBV TE9ORzMyIHRocmVhZElELA0KICAgIC8qIFtpbl0gKi8gVUxPTkczMiBjb250ZXh0U2l6ZSwNCiAg ICAvKiBbc2l6ZV9pc11baW5dICovIEJZVEUgKmNvbnRleHQpOw0KDQoNCnZvaWQgX19SUENfU1RV QiBJQ0xSRGF0YVRhcmdldF9TZXRUaHJlYWRDb250ZXh0X1N0dWIoDQogICAgSVJwY1N0dWJCdWZm ZXIgKlRoaXMsDQogICAgSVJwY0NoYW5uZWxCdWZmZXIgKl9wUnBjQ2hhbm5lbEJ1ZmZlciwNCiAg ICBQUlBDX01FU1NBR0UgX3BScGNNZXNzYWdlLA0KICAgIERXT1JEICpfcGR3U3R1YlBoYXNlKTsN Cg0KDQpIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIElDTFJEYXRhVGFyZ2V0X1JlcXVlc3RfUHJv eHkoIA0KICAgIElDTFJEYXRhVGFyZ2V0ICogVGhpcywNCiAgICAvKiBbaW5dICovIFVMT05HMzIg cmVxQ29kZSwNCiAgICAvKiBbaW5dICovIFVMT05HMzIgaW5CdWZmZXJTaXplLA0KICAgIC8qIFtz aXplX2lzXVtpbl0gKi8gQllURSAqaW5CdWZmZXIsDQogICAgLyogW2luXSAqLyBVTE9ORzMyIG91 dEJ1ZmZlclNpemUsDQogICAgLyogW3NpemVfaXNdW291dF0gKi8gQllURSAqb3V0QnVmZmVyKTsN Cg0KDQp2b2lkIF9fUlBDX1NUVUIgSUNMUkRhdGFUYXJnZXRfUmVxdWVzdF9TdHViKA0KICAgIElS cGNTdHViQnVmZmVyICpUaGlzLA0KICAgIElScGNDaGFubmVsQnVmZmVyICpfcFJwY0NoYW5uZWxC dWZmZXIsDQogICAgUFJQQ19NRVNTQUdFIF9wUnBjTWVzc2FnZSwNCiAgICBEV09SRCAqX3Bkd1N0 dWJQaGFzZSk7DQoNCg0KDQojZW5kaWYgCS8qIF9fSUNMUkRhdGFUYXJnZXRfSU5URVJGQUNFX0RF RklORURfXyAqLw0KDQoNCiNpZm5kZWYgX19JQ0xSRGF0YVRhcmdldDJfSU5URVJGQUNFX0RFRklO RURfXw0KI2RlZmluZSBfX0lDTFJEYXRhVGFyZ2V0Ml9JTlRFUkZBQ0VfREVGSU5FRF9fDQoNCi8q IGludGVyZmFjZSBJQ0xSRGF0YVRhcmdldDIgKi8NCi8qIFt1bmlxdWVdW3V1aWRdW29iamVjdF0g Ki8gDQoNCg0KRVhURVJOX0MgY29uc3QgSUlEIElJRF9JQ0xSRGF0YVRhcmdldDI7DQoNCiNpZiBk ZWZpbmVkKF9fY3BsdXNwbHVzKSAmJiAhZGVmaW5lZChDSU5URVJGQUNFKQ0KICAgIA0KICAgIE1J RExfSU5URVJGQUNFKCI2ZDA1ZmFlMy0xODljLTQ2MzAtYTZkYy0xYzI1MWUxYzAxYWIiKQ0KICAg IElDTFJEYXRhVGFyZ2V0MiA6IHB1YmxpYyBJQ0xSRGF0YVRhcmdldA0KICAgIHsNCiAgICBwdWJs aWM6DQogICAgICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBBbGxvY1ZpcnR1 YWwoIA0KICAgICAgICAgICAgLyogW2luXSAqLyBDTFJEQVRBX0FERFJFU1MgYWRkciwNCiAgICAg ICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiBzaXplLA0KICAgICAgICAgICAgLyogW2luXSAqLyBV TE9ORzMyIHR5cGVGbGFncywNCiAgICAgICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiBwcm90ZWN0 RmxhZ3MsDQogICAgICAgICAgICAvKiBbb3V0XSAqLyBDTFJEQVRBX0FERFJFU1MgKnZpcnQpID0g MDsNCiAgICAgICAgDQogICAgICAgIHZpcnR1YWwgSFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBG cmVlVmlydHVhbCggDQogICAgICAgICAgICAvKiBbaW5dICovIENMUkRBVEFfQUREUkVTUyBhZGRy LA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIHNpemUsDQogICAgICAgICAgICAvKiBb aW5dICovIFVMT05HMzIgdHlwZUZsYWdzKSA9IDA7DQogICAgICAgIA0KICAgIH07DQogICAgDQoj ZWxzZSAJLyogQyBzdHlsZSBpbnRlcmZhY2UgKi8NCg0KICAgIHR5cGVkZWYgc3RydWN0IElDTFJE YXRhVGFyZ2V0MlZ0YmwNCiAgICB7DQogICAgICAgIEJFR0lOX0lOVEVSRkFDRQ0KICAgICAgICAN CiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpRdWVyeUludGVyZmFjZSApKCAN CiAgICAgICAgICAgIElDTFJEYXRhVGFyZ2V0MiAqIFRoaXMsDQogICAgICAgICAgICAvKiBbaW5d ICovIFJFRklJRCByaWlkLA0KICAgICAgICAgICAgLyogW2lpZF9pc11bb3V0XSAqLyB2b2lkICoq cHB2T2JqZWN0KTsNCiAgICAgICAgDQogICAgICAgIFVMT05HICggU1RETUVUSE9EQ0FMTFRZUEUg KkFkZFJlZiApKCANCiAgICAgICAgICAgIElDTFJEYXRhVGFyZ2V0MiAqIFRoaXMpOw0KICAgICAg ICANCiAgICAgICAgVUxPTkcgKCBTVERNRVRIT0RDQUxMVFlQRSAqUmVsZWFzZSApKCANCiAgICAg ICAgICAgIElDTFJEYXRhVGFyZ2V0MiAqIFRoaXMpOw0KICAgICAgICANCiAgICAgICAgSFJFU1VM VCAoIFNURE1FVEhPRENBTExUWVBFICpHZXRNYWNoaW5lVHlwZSApKCANCiAgICAgICAgICAgIElD TFJEYXRhVGFyZ2V0MiAqIFRoaXMsDQogICAgICAgICAgICAvKiBbb3V0XSAqLyBVTE9ORzMyICpt YWNoaW5lVHlwZSk7DQogICAgICAgIA0KICAgICAgICBIUkVTVUxUICggU1RETUVUSE9EQ0FMTFRZ UEUgKkdldFBvaW50ZXJTaXplICkoIA0KICAgICAgICAgICAgSUNMUkRhdGFUYXJnZXQyICogVGhp cywNCiAgICAgICAgICAgIC8qIFtvdXRdICovIFVMT05HMzIgKnBvaW50ZXJTaXplKTsNCiAgICAg ICAgDQogICAgICAgIEhSRVNVTFQgKCBTVERNRVRIT0RDQUxMVFlQRSAqR2V0SW1hZ2VCYXNlICko IA0KICAgICAgICAgICAgSUNMUkRhdGFUYXJnZXQyICogVGhpcywNCiAgICAgICAgICAgIC8qIFtz dHJpbmddW2luXSAqLyBMUENXU1RSIGltYWdlUGF0aCwNCiAgICAgICAgICAgIC8qIFtvdXRdICov IENMUkRBVEFfQUREUkVTUyAqYmFzZUFkZHJlc3MpOw0KICAgICAgICANCiAgICAgICAgSFJFU1VM VCAoIFNURE1FVEhPRENBTExUWVBFICpSZWFkVmlydHVhbCApKCANCiAgICAgICAgICAgIElDTFJE YXRhVGFyZ2V0MiAqIFRoaXMsDQogICAgICAgICAgICAvKiBbaW5dICovIENMUkRBVEFfQUREUkVT UyBhZGRyZXNzLA0KICAgICAgICAgICAgLyogW2xlbmd0aF9pc11bc2l6ZV9pc11bb3V0XSAqLyBC WVRFICpidWZmZXIsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgYnl0ZXNSZXF1ZXN0 ZWQsDQogICAgICAgICAgICAvKiBbb3V0XSAqLyBVTE9ORzMyICpieXRlc1JlYWQpOw0KICAgICAg ICANCiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpXcml0ZVZpcnR1YWwgKSgg DQogICAgICAgICAgICBJQ0xSRGF0YVRhcmdldDIgKiBUaGlzLA0KICAgICAgICAgICAgLyogW2lu XSAqLyBDTFJEQVRBX0FERFJFU1MgYWRkcmVzcywNCiAgICAgICAgICAgIC8qIFtzaXplX2lzXVtp bl0gKi8gQllURSAqYnVmZmVyLA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIGJ5dGVz UmVxdWVzdGVkLA0KICAgICAgICAgICAgLyogW291dF0gKi8gVUxPTkczMiAqYnl0ZXNXcml0dGVu KTsNCiAgICAgICAgDQogICAgICAgIEhSRVNVTFQgKCBTVERNRVRIT0RDQUxMVFlQRSAqR2V0VExT VmFsdWUgKSggDQogICAgICAgICAgICBJQ0xSRGF0YVRhcmdldDIgKiBUaGlzLA0KICAgICAgICAg ICAgLyogW2luXSAqLyBVTE9ORzMyIHRocmVhZElELA0KICAgICAgICAgICAgLyogW2luXSAqLyBV TE9ORzMyIGluZGV4LA0KICAgICAgICAgICAgLyogW291dF0gKi8gQ0xSREFUQV9BRERSRVNTICp2 YWx1ZSk7DQogICAgICAgIA0KICAgICAgICBIUkVTVUxUICggU1RETUVUSE9EQ0FMTFRZUEUgKlNl dFRMU1ZhbHVlICkoIA0KICAgICAgICAgICAgSUNMUkRhdGFUYXJnZXQyICogVGhpcywNCiAgICAg ICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiB0aHJlYWRJRCwNCiAgICAgICAgICAgIC8qIFtpbl0g Ki8gVUxPTkczMiBpbmRleCwNCiAgICAgICAgICAgIC8qIFtpbl0gKi8gQ0xSREFUQV9BRERSRVNT IHZhbHVlKTsNCiAgICAgICAgDQogICAgICAgIEhSRVNVTFQgKCBTVERNRVRIT0RDQUxMVFlQRSAq R2V0Q3VycmVudFRocmVhZElEICkoIA0KICAgICAgICAgICAgSUNMUkRhdGFUYXJnZXQyICogVGhp cywNCiAgICAgICAgICAgIC8qIFtvdXRdICovIFVMT05HMzIgKnRocmVhZElEKTsNCiAgICAgICAg DQogICAgICAgIEhSRVNVTFQgKCBTVERNRVRIT0RDQUxMVFlQRSAqR2V0VGhyZWFkQ29udGV4dCAp KCANCiAgICAgICAgICAgIElDTFJEYXRhVGFyZ2V0MiAqIFRoaXMsDQogICAgICAgICAgICAvKiBb aW5dICovIFVMT05HMzIgdGhyZWFkSUQsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIg Y29udGV4dEZsYWdzLA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIGNvbnRleHRTaXpl LA0KICAgICAgICAgICAgLyogW3NpemVfaXNdW291dF0gKi8gQllURSAqY29udGV4dCk7DQogICAg ICAgIA0KICAgICAgICBIUkVTVUxUICggU1RETUVUSE9EQ0FMTFRZUEUgKlNldFRocmVhZENvbnRl eHQgKSggDQogICAgICAgICAgICBJQ0xSRGF0YVRhcmdldDIgKiBUaGlzLA0KICAgICAgICAgICAg LyogW2luXSAqLyBVTE9ORzMyIHRocmVhZElELA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9O RzMyIGNvbnRleHRTaXplLA0KICAgICAgICAgICAgLyogW3NpemVfaXNdW2luXSAqLyBCWVRFICpj b250ZXh0KTsNCiAgICAgICAgDQogICAgICAgIEhSRVNVTFQgKCBTVERNRVRIT0RDQUxMVFlQRSAq UmVxdWVzdCApKCANCiAgICAgICAgICAgIElDTFJEYXRhVGFyZ2V0MiAqIFRoaXMsDQogICAgICAg ICAgICAvKiBbaW5dICovIFVMT05HMzIgcmVxQ29kZSwNCiAgICAgICAgICAgIC8qIFtpbl0gKi8g VUxPTkczMiBpbkJ1ZmZlclNpemUsDQogICAgICAgICAgICAvKiBbc2l6ZV9pc11baW5dICovIEJZ VEUgKmluQnVmZmVyLA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIG91dEJ1ZmZlclNp emUsDQogICAgICAgICAgICAvKiBbc2l6ZV9pc11bb3V0XSAqLyBCWVRFICpvdXRCdWZmZXIpOw0K ICAgICAgICANCiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpBbGxvY1ZpcnR1 YWwgKSggDQogICAgICAgICAgICBJQ0xSRGF0YVRhcmdldDIgKiBUaGlzLA0KICAgICAgICAgICAg LyogW2luXSAqLyBDTFJEQVRBX0FERFJFU1MgYWRkciwNCiAgICAgICAgICAgIC8qIFtpbl0gKi8g VUxPTkczMiBzaXplLA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIHR5cGVGbGFncywN CiAgICAgICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiBwcm90ZWN0RmxhZ3MsDQogICAgICAgICAg ICAvKiBbb3V0XSAqLyBDTFJEQVRBX0FERFJFU1MgKnZpcnQpOw0KICAgICAgICANCiAgICAgICAg SFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpGcmVlVmlydHVhbCApKCANCiAgICAgICAgICAg IElDTFJEYXRhVGFyZ2V0MiAqIFRoaXMsDQogICAgICAgICAgICAvKiBbaW5dICovIENMUkRBVEFf QUREUkVTUyBhZGRyLA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIHNpemUsDQogICAg ICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgdHlwZUZsYWdzKTsNCiAgICAgICAgDQogICAgICAg IEVORF9JTlRFUkZBQ0UNCiAgICB9IElDTFJEYXRhVGFyZ2V0MlZ0Ymw7DQoNCiAgICBpbnRlcmZh Y2UgSUNMUkRhdGFUYXJnZXQyDQogICAgew0KICAgICAgICBDT05TVF9WVEJMIHN0cnVjdCBJQ0xS RGF0YVRhcmdldDJWdGJsICpscFZ0Ymw7DQogICAgfTsNCg0KICAgIA0KDQojaWZkZWYgQ09CSk1B Q1JPUw0KDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXQyX1F1ZXJ5SW50ZXJmYWNlKFRoaXMscmlp ZCxwcHZPYmplY3QpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBRdWVyeUludGVyZmFjZShUaGlz LHJpaWQscHB2T2JqZWN0KQ0KDQojZGVmaW5lIElDTFJEYXRhVGFyZ2V0Ml9BZGRSZWYoVGhpcykJ XA0KICAgIChUaGlzKS0+bHBWdGJsIC0+IEFkZFJlZihUaGlzKQ0KDQojZGVmaW5lIElDTFJEYXRh VGFyZ2V0Ml9SZWxlYXNlKFRoaXMpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBSZWxlYXNlKFRo aXMpDQoNCg0KI2RlZmluZSBJQ0xSRGF0YVRhcmdldDJfR2V0TWFjaGluZVR5cGUoVGhpcyxtYWNo aW5lVHlwZSkJXA0KICAgIChUaGlzKS0+bHBWdGJsIC0+IEdldE1hY2hpbmVUeXBlKFRoaXMsbWFj aGluZVR5cGUpDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXQyX0dldFBvaW50ZXJTaXplKFRoaXMs cG9pbnRlclNpemUpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBHZXRQb2ludGVyU2l6ZShUaGlz LHBvaW50ZXJTaXplKQ0KDQojZGVmaW5lIElDTFJEYXRhVGFyZ2V0Ml9HZXRJbWFnZUJhc2UoVGhp cyxpbWFnZVBhdGgsYmFzZUFkZHJlc3MpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBHZXRJbWFn ZUJhc2UoVGhpcyxpbWFnZVBhdGgsYmFzZUFkZHJlc3MpDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJn ZXQyX1JlYWRWaXJ0dWFsKFRoaXMsYWRkcmVzcyxidWZmZXIsYnl0ZXNSZXF1ZXN0ZWQsYnl0ZXNS ZWFkKQlcDQogICAgKFRoaXMpLT5scFZ0YmwgLT4gUmVhZFZpcnR1YWwoVGhpcyxhZGRyZXNzLGJ1 ZmZlcixieXRlc1JlcXVlc3RlZCxieXRlc1JlYWQpDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXQy X1dyaXRlVmlydHVhbChUaGlzLGFkZHJlc3MsYnVmZmVyLGJ5dGVzUmVxdWVzdGVkLGJ5dGVzV3Jp dHRlbikJXA0KICAgIChUaGlzKS0+bHBWdGJsIC0+IFdyaXRlVmlydHVhbChUaGlzLGFkZHJlc3Ms YnVmZmVyLGJ5dGVzUmVxdWVzdGVkLGJ5dGVzV3JpdHRlbikNCg0KI2RlZmluZSBJQ0xSRGF0YVRh cmdldDJfR2V0VExTVmFsdWUoVGhpcyx0aHJlYWRJRCxpbmRleCx2YWx1ZSkJXA0KICAgIChUaGlz KS0+bHBWdGJsIC0+IEdldFRMU1ZhbHVlKFRoaXMsdGhyZWFkSUQsaW5kZXgsdmFsdWUpDQoNCiNk ZWZpbmUgSUNMUkRhdGFUYXJnZXQyX1NldFRMU1ZhbHVlKFRoaXMsdGhyZWFkSUQsaW5kZXgsdmFs dWUpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBTZXRUTFNWYWx1ZShUaGlzLHRocmVhZElELGlu ZGV4LHZhbHVlKQ0KDQojZGVmaW5lIElDTFJEYXRhVGFyZ2V0Ml9HZXRDdXJyZW50VGhyZWFkSUQo VGhpcyx0aHJlYWRJRCkJXA0KICAgIChUaGlzKS0+bHBWdGJsIC0+IEdldEN1cnJlbnRUaHJlYWRJ RChUaGlzLHRocmVhZElEKQ0KDQojZGVmaW5lIElDTFJEYXRhVGFyZ2V0Ml9HZXRUaHJlYWRDb250 ZXh0KFRoaXMsdGhyZWFkSUQsY29udGV4dEZsYWdzLGNvbnRleHRTaXplLGNvbnRleHQpCVwNCiAg ICAoVGhpcyktPmxwVnRibCAtPiBHZXRUaHJlYWRDb250ZXh0KFRoaXMsdGhyZWFkSUQsY29udGV4 dEZsYWdzLGNvbnRleHRTaXplLGNvbnRleHQpDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXQyX1Nl dFRocmVhZENvbnRleHQoVGhpcyx0aHJlYWRJRCxjb250ZXh0U2l6ZSxjb250ZXh0KQlcDQogICAg KFRoaXMpLT5scFZ0YmwgLT4gU2V0VGhyZWFkQ29udGV4dChUaGlzLHRocmVhZElELGNvbnRleHRT aXplLGNvbnRleHQpDQoNCiNkZWZpbmUgSUNMUkRhdGFUYXJnZXQyX1JlcXVlc3QoVGhpcyxyZXFD b2RlLGluQnVmZmVyU2l6ZSxpbkJ1ZmZlcixvdXRCdWZmZXJTaXplLG91dEJ1ZmZlcikJXA0KICAg IChUaGlzKS0+bHBWdGJsIC0+IFJlcXVlc3QoVGhpcyxyZXFDb2RlLGluQnVmZmVyU2l6ZSxpbkJ1 ZmZlcixvdXRCdWZmZXJTaXplLG91dEJ1ZmZlcikNCg0KDQojZGVmaW5lIElDTFJEYXRhVGFyZ2V0 Ml9BbGxvY1ZpcnR1YWwoVGhpcyxhZGRyLHNpemUsdHlwZUZsYWdzLHByb3RlY3RGbGFncyx2aXJ0 KQlcDQogICAgKFRoaXMpLT5scFZ0YmwgLT4gQWxsb2NWaXJ0dWFsKFRoaXMsYWRkcixzaXplLHR5 cGVGbGFncyxwcm90ZWN0RmxhZ3MsdmlydCkNCg0KI2RlZmluZSBJQ0xSRGF0YVRhcmdldDJfRnJl ZVZpcnR1YWwoVGhpcyxhZGRyLHNpemUsdHlwZUZsYWdzKQlcDQogICAgKFRoaXMpLT5scFZ0Ymwg LT4gRnJlZVZpcnR1YWwoVGhpcyxhZGRyLHNpemUsdHlwZUZsYWdzKQ0KDQojZW5kaWYgLyogQ09C Sk1BQ1JPUyAqLw0KDQoNCiNlbmRpZiAJLyogQyBzdHlsZSBpbnRlcmZhY2UgKi8NCg0KDQoNCkhS RVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgSUNMUkRhdGFUYXJnZXQyX0FsbG9jVmlydHVhbF9Qcm94 eSggDQogICAgSUNMUkRhdGFUYXJnZXQyICogVGhpcywNCiAgICAvKiBbaW5dICovIENMUkRBVEFf QUREUkVTUyBhZGRyLA0KICAgIC8qIFtpbl0gKi8gVUxPTkczMiBzaXplLA0KICAgIC8qIFtpbl0g Ki8gVUxPTkczMiB0eXBlRmxhZ3MsDQogICAgLyogW2luXSAqLyBVTE9ORzMyIHByb3RlY3RGbGFn cywNCiAgICAvKiBbb3V0XSAqLyBDTFJEQVRBX0FERFJFU1MgKnZpcnQpOw0KDQoNCnZvaWQgX19S UENfU1RVQiBJQ0xSRGF0YVRhcmdldDJfQWxsb2NWaXJ0dWFsX1N0dWIoDQogICAgSVJwY1N0dWJC dWZmZXIgKlRoaXMsDQogICAgSVJwY0NoYW5uZWxCdWZmZXIgKl9wUnBjQ2hhbm5lbEJ1ZmZlciwN CiAgICBQUlBDX01FU1NBR0UgX3BScGNNZXNzYWdlLA0KICAgIERXT1JEICpfcGR3U3R1YlBoYXNl KTsNCg0KDQpIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIElDTFJEYXRhVGFyZ2V0Ml9GcmVlVmly dHVhbF9Qcm94eSggDQogICAgSUNMUkRhdGFUYXJnZXQyICogVGhpcywNCiAgICAvKiBbaW5dICov IENMUkRBVEFfQUREUkVTUyBhZGRyLA0KICAgIC8qIFtpbl0gKi8gVUxPTkczMiBzaXplLA0KICAg IC8qIFtpbl0gKi8gVUxPTkczMiB0eXBlRmxhZ3MpOw0KDQoNCnZvaWQgX19SUENfU1RVQiBJQ0xS RGF0YVRhcmdldDJfRnJlZVZpcnR1YWxfU3R1YigNCiAgICBJUnBjU3R1YkJ1ZmZlciAqVGhpcywN CiAgICBJUnBjQ2hhbm5lbEJ1ZmZlciAqX3BScGNDaGFubmVsQnVmZmVyLA0KICAgIFBSUENfTUVT U0FHRSBfcFJwY01lc3NhZ2UsDQogICAgRFdPUkQgKl9wZHdTdHViUGhhc2UpOw0KDQoNCg0KI2Vu ZGlmIAkvKiBfX0lDTFJEYXRhVGFyZ2V0Ml9JTlRFUkZBQ0VfREVGSU5FRF9fICovDQoNCg0KI2lm bmRlZiBfX0lDTFJNZXRhZGF0YUxvY2F0b3JfSU5URVJGQUNFX0RFRklORURfXw0KI2RlZmluZSBf X0lDTFJNZXRhZGF0YUxvY2F0b3JfSU5URVJGQUNFX0RFRklORURfXw0KDQovKiBpbnRlcmZhY2Ug SUNMUk1ldGFkYXRhTG9jYXRvciAqLw0KLyogW3VuaXF1ZV1bdXVpZF1bb2JqZWN0XSAqLyANCg0K DQpFWFRFUk5fQyBjb25zdCBJSUQgSUlEX0lDTFJNZXRhZGF0YUxvY2F0b3I7DQoNCiNpZiBkZWZp bmVkKF9fY3BsdXNwbHVzKSAmJiAhZGVmaW5lZChDSU5URVJGQUNFKQ0KICAgIA0KICAgIE1JRExf SU5URVJGQUNFKCJhYThmYTgwNC1iYzA1LTQ2NDItYjJjNS1jMzUzZWQyMmZjNjMiKQ0KICAgIElD TFJNZXRhZGF0YUxvY2F0b3IgOiBwdWJsaWMgSVVua25vd24NCiAgICB7DQogICAgcHVibGljOg0K ICAgICAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgR2V0TWV0YWRhdGEoIA0K ICAgICAgICAgICAgLyogW2luXSAqLyBMUENXU1RSIGltYWdlUGF0aCwNCiAgICAgICAgICAgIC8q IFtpbl0gKi8gVUxPTkczMiBpbWFnZVRpbWVzdGFtcCwNCiAgICAgICAgICAgIC8qIFtpbl0gKi8g VUxPTkczMiBpbWFnZVNpemUsDQogICAgICAgICAgICAvKiBbaW5dICovIEdVSUQgKm12aWQsDQog ICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgbWRSdmEsDQogICAgICAgICAgICAvKiBbaW5d ICovIFVMT05HMzIgZmxhZ3MsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgYnVmZmVy U2l6ZSwNCiAgICAgICAgICAgIC8qIFtsZW5ndGhfaXNdW3NpemVfaXNdW291dF0gKi8gQllURSAq YnVmZmVyLA0KICAgICAgICAgICAgLyogW291dF0gKi8gVUxPTkczMiAqZGF0YVNpemUpID0gMDsN CiAgICAgICAgDQogICAgfTsNCiAgICANCiNlbHNlIAkvKiBDIHN0eWxlIGludGVyZmFjZSAqLw0K DQogICAgdHlwZWRlZiBzdHJ1Y3QgSUNMUk1ldGFkYXRhTG9jYXRvclZ0YmwNCiAgICB7DQogICAg ICAgIEJFR0lOX0lOVEVSRkFDRQ0KICAgICAgICANCiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhP RENBTExUWVBFICpRdWVyeUludGVyZmFjZSApKCANCiAgICAgICAgICAgIElDTFJNZXRhZGF0YUxv Y2F0b3IgKiBUaGlzLA0KICAgICAgICAgICAgLyogW2luXSAqLyBSRUZJSUQgcmlpZCwNCiAgICAg ICAgICAgIC8qIFtpaWRfaXNdW291dF0gKi8gdm9pZCAqKnBwdk9iamVjdCk7DQogICAgICAgIA0K ICAgICAgICBVTE9ORyAoIFNURE1FVEhPRENBTExUWVBFICpBZGRSZWYgKSggDQogICAgICAgICAg ICBJQ0xSTWV0YWRhdGFMb2NhdG9yICogVGhpcyk7DQogICAgICAgIA0KICAgICAgICBVTE9ORyAo IFNURE1FVEhPRENBTExUWVBFICpSZWxlYXNlICkoIA0KICAgICAgICAgICAgSUNMUk1ldGFkYXRh TG9jYXRvciAqIFRoaXMpOw0KICAgICAgICANCiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENB TExUWVBFICpHZXRNZXRhZGF0YSApKCANCiAgICAgICAgICAgIElDTFJNZXRhZGF0YUxvY2F0b3Ig KiBUaGlzLA0KICAgICAgICAgICAgLyogW2luXSAqLyBMUENXU1RSIGltYWdlUGF0aCwNCiAgICAg ICAgICAgIC8qIFtpbl0gKi8gVUxPTkczMiBpbWFnZVRpbWVzdGFtcCwNCiAgICAgICAgICAgIC8q IFtpbl0gKi8gVUxPTkczMiBpbWFnZVNpemUsDQogICAgICAgICAgICAvKiBbaW5dICovIEdVSUQg Km12aWQsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05HMzIgbWRSdmEsDQogICAgICAgICAg ICAvKiBbaW5dICovIFVMT05HMzIgZmxhZ3MsDQogICAgICAgICAgICAvKiBbaW5dICovIFVMT05H MzIgYnVmZmVyU2l6ZSwNCiAgICAgICAgICAgIC8qIFtsZW5ndGhfaXNdW3NpemVfaXNdW291dF0g Ki8gQllURSAqYnVmZmVyLA0KICAgICAgICAgICAgLyogW291dF0gKi8gVUxPTkczMiAqZGF0YVNp emUpOw0KICAgICAgICANCiAgICAgICAgRU5EX0lOVEVSRkFDRQ0KICAgIH0gSUNMUk1ldGFkYXRh TG9jYXRvclZ0Ymw7DQoNCiAgICBpbnRlcmZhY2UgSUNMUk1ldGFkYXRhTG9jYXRvcg0KICAgIHsN CiAgICAgICAgQ09OU1RfVlRCTCBzdHJ1Y3QgSUNMUk1ldGFkYXRhTG9jYXRvclZ0YmwgKmxwVnRi bDsNCiAgICB9Ow0KDQogICAgDQoNCiNpZmRlZiBDT0JKTUFDUk9TDQoNCg0KI2RlZmluZSBJQ0xS TWV0YWRhdGFMb2NhdG9yX1F1ZXJ5SW50ZXJmYWNlKFRoaXMscmlpZCxwcHZPYmplY3QpCVwNCiAg ICAoVGhpcyktPmxwVnRibCAtPiBRdWVyeUludGVyZmFjZShUaGlzLHJpaWQscHB2T2JqZWN0KQ0K DQojZGVmaW5lIElDTFJNZXRhZGF0YUxvY2F0b3JfQWRkUmVmKFRoaXMpCVwNCiAgICAoVGhpcykt PmxwVnRibCAtPiBBZGRSZWYoVGhpcykNCg0KI2RlZmluZSBJQ0xSTWV0YWRhdGFMb2NhdG9yX1Jl bGVhc2UoVGhpcykJXA0KICAgIChUaGlzKS0+bHBWdGJsIC0+IFJlbGVhc2UoVGhpcykNCg0KDQoj ZGVmaW5lIElDTFJNZXRhZGF0YUxvY2F0b3JfR2V0TWV0YWRhdGEoVGhpcyxpbWFnZVBhdGgsaW1h Z2VUaW1lc3RhbXAsaW1hZ2VTaXplLG12aWQsbWRSdmEsZmxhZ3MsYnVmZmVyU2l6ZSxidWZmZXIs ZGF0YVNpemUpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBHZXRNZXRhZGF0YShUaGlzLGltYWdl UGF0aCxpbWFnZVRpbWVzdGFtcCxpbWFnZVNpemUsbXZpZCxtZFJ2YSxmbGFncyxidWZmZXJTaXpl LGJ1ZmZlcixkYXRhU2l6ZSkNCg0KI2VuZGlmIC8qIENPQkpNQUNST1MgKi8NCg0KDQojZW5kaWYg CS8qIEMgc3R5bGUgaW50ZXJmYWNlICovDQoNCg0KDQpIUkVTVUxUIFNURE1FVEhPRENBTExUWVBF IElDTFJNZXRhZGF0YUxvY2F0b3JfR2V0TWV0YWRhdGFfUHJveHkoIA0KICAgIElDTFJNZXRhZGF0 YUxvY2F0b3IgKiBUaGlzLA0KICAgIC8qIFtpbl0gKi8gTFBDV1NUUiBpbWFnZVBhdGgsDQogICAg LyogW2luXSAqLyBVTE9ORzMyIGltYWdlVGltZXN0YW1wLA0KICAgIC8qIFtpbl0gKi8gVUxPTkcz MiBpbWFnZVNpemUsDQogICAgLyogW2luXSAqLyBHVUlEICptdmlkLA0KICAgIC8qIFtpbl0gKi8g VUxPTkczMiBtZFJ2YSwNCiAgICAvKiBbaW5dICovIFVMT05HMzIgZmxhZ3MsDQogICAgLyogW2lu XSAqLyBVTE9ORzMyIGJ1ZmZlclNpemUsDQogICAgLyogW2xlbmd0aF9pc11bc2l6ZV9pc11bb3V0 XSAqLyBCWVRFICpidWZmZXIsDQogICAgLyogW291dF0gKi8gVUxPTkczMiAqZGF0YVNpemUpOw0K DQoNCnZvaWQgX19SUENfU1RVQiBJQ0xSTWV0YWRhdGFMb2NhdG9yX0dldE1ldGFkYXRhX1N0dWIo DQogICAgSVJwY1N0dWJCdWZmZXIgKlRoaXMsDQogICAgSVJwY0NoYW5uZWxCdWZmZXIgKl9wUnBj Q2hhbm5lbEJ1ZmZlciwNCiAgICBQUlBDX01FU1NBR0UgX3BScGNNZXNzYWdlLA0KICAgIERXT1JE ICpfcGR3U3R1YlBoYXNlKTsNCg0KDQoNCiNlbmRpZiAJLyogX19JQ0xSTWV0YWRhdGFMb2NhdG9y X0lOVEVSRkFDRV9ERUZJTkVEX18gKi8NCg0KDQojaWZuZGVmIF9fSUNMUkRhdGFFbnVtTWVtb3J5 UmVnaW9uc0NhbGxiYWNrX0lOVEVSRkFDRV9ERUZJTkVEX18NCiNkZWZpbmUgX19JQ0xSRGF0YUVu dW1NZW1vcnlSZWdpb25zQ2FsbGJhY2tfSU5URVJGQUNFX0RFRklORURfXw0KDQovKiBpbnRlcmZh Y2UgSUNMUkRhdGFFbnVtTWVtb3J5UmVnaW9uc0NhbGxiYWNrICovDQovKiBbdXVpZF1bb2JqZWN0 XSAqLyANCg0KDQpFWFRFUk5fQyBjb25zdCBJSUQgSUlEX0lDTFJEYXRhRW51bU1lbW9yeVJlZ2lv bnNDYWxsYmFjazsNCg0KI2lmIGRlZmluZWQoX19jcGx1c3BsdXMpICYmICFkZWZpbmVkKENJTlRF UkZBQ0UpDQogICAgDQogICAgTUlETF9JTlRFUkZBQ0UoIkJDREQ2OTA4LUJBMkQtNGVjNS05NkNG LURGNEQ1Q0RDQjRBNCIpDQogICAgSUNMUkRhdGFFbnVtTWVtb3J5UmVnaW9uc0NhbGxiYWNrIDog cHVibGljIElVbmtub3duDQogICAgew0KICAgIHB1YmxpYzoNCiAgICAgICAgdmlydHVhbCBIUkVT VUxUIFNURE1FVEhPRENBTExUWVBFIEVudW1NZW1vcnlSZWdpb24oIA0KICAgICAgICAgICAgLyog W2luXSAqLyBDTFJEQVRBX0FERFJFU1MgYWRkcmVzcywNCiAgICAgICAgICAgIC8qIFtpbl0gKi8g VUxPTkczMiBzaXplKSA9IDA7DQogICAgICAgIA0KICAgIH07DQogICAgDQojZWxzZSAJLyogQyBz dHlsZSBpbnRlcmZhY2UgKi8NCg0KICAgIHR5cGVkZWYgc3RydWN0IElDTFJEYXRhRW51bU1lbW9y eVJlZ2lvbnNDYWxsYmFja1Z0YmwNCiAgICB7DQogICAgICAgIEJFR0lOX0lOVEVSRkFDRQ0KICAg ICAgICANCiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpRdWVyeUludGVyZmFj ZSApKCANCiAgICAgICAgICAgIElDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnNDYWxsYmFjayAqIFRo aXMsDQogICAgICAgICAgICAvKiBbaW5dICovIFJFRklJRCByaWlkLA0KICAgICAgICAgICAgLyog W2lpZF9pc11bb3V0XSAqLyB2b2lkICoqcHB2T2JqZWN0KTsNCiAgICAgICAgDQogICAgICAgIFVM T05HICggU1RETUVUSE9EQ0FMTFRZUEUgKkFkZFJlZiApKCANCiAgICAgICAgICAgIElDTFJEYXRh RW51bU1lbW9yeVJlZ2lvbnNDYWxsYmFjayAqIFRoaXMpOw0KICAgICAgICANCiAgICAgICAgVUxP TkcgKCBTVERNRVRIT0RDQUxMVFlQRSAqUmVsZWFzZSApKCANCiAgICAgICAgICAgIElDTFJEYXRh RW51bU1lbW9yeVJlZ2lvbnNDYWxsYmFjayAqIFRoaXMpOw0KICAgICAgICANCiAgICAgICAgSFJF U1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpFbnVtTWVtb3J5UmVnaW9uICkoIA0KICAgICAgICAg ICAgSUNMUkRhdGFFbnVtTWVtb3J5UmVnaW9uc0NhbGxiYWNrICogVGhpcywNCiAgICAgICAgICAg IC8qIFtpbl0gKi8gQ0xSREFUQV9BRERSRVNTIGFkZHJlc3MsDQogICAgICAgICAgICAvKiBbaW5d ICovIFVMT05HMzIgc2l6ZSk7DQogICAgICAgIA0KICAgICAgICBFTkRfSU5URVJGQUNFDQogICAg fSBJQ0xSRGF0YUVudW1NZW1vcnlSZWdpb25zQ2FsbGJhY2tWdGJsOw0KDQogICAgaW50ZXJmYWNl IElDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnNDYWxsYmFjaw0KICAgIHsNCiAgICAgICAgQ09OU1Rf VlRCTCBzdHJ1Y3QgSUNMUkRhdGFFbnVtTWVtb3J5UmVnaW9uc0NhbGxiYWNrVnRibCAqbHBWdGJs Ow0KICAgIH07DQoNCiAgICANCg0KI2lmZGVmIENPQkpNQUNST1MNCg0KDQojZGVmaW5lIElDTFJE YXRhRW51bU1lbW9yeVJlZ2lvbnNDYWxsYmFja19RdWVyeUludGVyZmFjZShUaGlzLHJpaWQscHB2 T2JqZWN0KQlcDQogICAgKFRoaXMpLT5scFZ0YmwgLT4gUXVlcnlJbnRlcmZhY2UoVGhpcyxyaWlk LHBwdk9iamVjdCkNCg0KI2RlZmluZSBJQ0xSRGF0YUVudW1NZW1vcnlSZWdpb25zQ2FsbGJhY2tf QWRkUmVmKFRoaXMpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBBZGRSZWYoVGhpcykNCg0KI2Rl ZmluZSBJQ0xSRGF0YUVudW1NZW1vcnlSZWdpb25zQ2FsbGJhY2tfUmVsZWFzZShUaGlzKQlcDQog ICAgKFRoaXMpLT5scFZ0YmwgLT4gUmVsZWFzZShUaGlzKQ0KDQoNCiNkZWZpbmUgSUNMUkRhdGFF bnVtTWVtb3J5UmVnaW9uc0NhbGxiYWNrX0VudW1NZW1vcnlSZWdpb24oVGhpcyxhZGRyZXNzLHNp emUpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBFbnVtTWVtb3J5UmVnaW9uKFRoaXMsYWRkcmVz cyxzaXplKQ0KDQojZW5kaWYgLyogQ09CSk1BQ1JPUyAqLw0KDQoNCiNlbmRpZiAJLyogQyBzdHls ZSBpbnRlcmZhY2UgKi8NCg0KDQoNCkhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgSUNMUkRhdGFF bnVtTWVtb3J5UmVnaW9uc0NhbGxiYWNrX0VudW1NZW1vcnlSZWdpb25fUHJveHkoIA0KICAgIElD TFJEYXRhRW51bU1lbW9yeVJlZ2lvbnNDYWxsYmFjayAqIFRoaXMsDQogICAgLyogW2luXSAqLyBD TFJEQVRBX0FERFJFU1MgYWRkcmVzcywNCiAgICAvKiBbaW5dICovIFVMT05HMzIgc2l6ZSk7DQoN Cg0Kdm9pZCBfX1JQQ19TVFVCIElDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnNDYWxsYmFja19FbnVt TWVtb3J5UmVnaW9uX1N0dWIoDQogICAgSVJwY1N0dWJCdWZmZXIgKlRoaXMsDQogICAgSVJwY0No YW5uZWxCdWZmZXIgKl9wUnBjQ2hhbm5lbEJ1ZmZlciwNCiAgICBQUlBDX01FU1NBR0UgX3BScGNN ZXNzYWdlLA0KICAgIERXT1JEICpfcGR3U3R1YlBoYXNlKTsNCg0KDQoNCiNlbmRpZiAJLyogX19J Q0xSRGF0YUVudW1NZW1vcnlSZWdpb25zQ2FsbGJhY2tfSU5URVJGQUNFX0RFRklORURfXyAqLw0K DQoNCi8qIGludGVyZmFjZSBfX01JRExfaXRmX2NscmRhdGFfMDAxMiAqLw0KLyogW2xvY2FsXSAq LyANCg0KdHlwZWRlZiANCmVudW0gQ0xSRGF0YUVudW1NZW1vcnlGbGFncw0KICAgIHsJQ0xSREFU QV9FTlVNX01FTV9ERUZBVUxUCT0gMCwNCglDTFJEQVRBX0VOVU1fTUVNX01JTkkJPSBDTFJEQVRB X0VOVU1fTUVNX0RFRkFVTFQsDQoJQ0xSREFUQV9FTlVNX01FTV9IRUFQCT0gMHgxDQogICAgfSAJ Q0xSRGF0YUVudW1NZW1vcnlGbGFnczsNCg0KDQoNCmV4dGVybiBSUENfSUZfSEFORExFIF9fTUlE TF9pdGZfY2xyZGF0YV8wMDEyX3YwXzBfY19pZnNwZWM7DQpleHRlcm4gUlBDX0lGX0hBTkRMRSBf X01JRExfaXRmX2NscmRhdGFfMDAxMl92MF8wX3NfaWZzcGVjOw0KDQojaWZuZGVmIF9fSUNMUkRh dGFFbnVtTWVtb3J5UmVnaW9uc19JTlRFUkZBQ0VfREVGSU5FRF9fDQojZGVmaW5lIF9fSUNMUkRh dGFFbnVtTWVtb3J5UmVnaW9uc19JTlRFUkZBQ0VfREVGSU5FRF9fDQoNCi8qIGludGVyZmFjZSBJ Q0xSRGF0YUVudW1NZW1vcnlSZWdpb25zICovDQovKiBbdXVpZF1bb2JqZWN0XSAqLyANCg0KDQpF WFRFUk5fQyBjb25zdCBJSUQgSUlEX0lDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnM7DQoNCiNpZiBk ZWZpbmVkKF9fY3BsdXNwbHVzKSAmJiAhZGVmaW5lZChDSU5URVJGQUNFKQ0KICAgIA0KICAgIE1J RExfSU5URVJGQUNFKCI0NzFjMzViNC03YzJmLTRlZjAtYTk0NS0wMGY4YzM4MDU2ZjEiKQ0KICAg IElDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnMgOiBwdWJsaWMgSVVua25vd24NCiAgICB7DQogICAg cHVibGljOg0KICAgICAgICB2aXJ0dWFsIEhSRVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgRW51bU1l bW9yeVJlZ2lvbnMoIA0KICAgICAgICAgICAgLyogW2luXSAqLyBJQ0xSRGF0YUVudW1NZW1vcnlS ZWdpb25zQ2FsbGJhY2sgKmNhbGxiYWNrLA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMy IG1pbmlEdW1wRmxhZ3MsDQogICAgICAgICAgICAvKiBbaW5dICovIENMUkRhdGFFbnVtTWVtb3J5 RmxhZ3MgY2xyRmxhZ3MpID0gMDsNCiAgICAgICAgDQogICAgfTsNCiAgICANCiNlbHNlIAkvKiBD IHN0eWxlIGludGVyZmFjZSAqLw0KDQogICAgdHlwZWRlZiBzdHJ1Y3QgSUNMUkRhdGFFbnVtTWVt b3J5UmVnaW9uc1Z0YmwNCiAgICB7DQogICAgICAgIEJFR0lOX0lOVEVSRkFDRQ0KICAgICAgICAN CiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpRdWVyeUludGVyZmFjZSApKCAN CiAgICAgICAgICAgIElDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnMgKiBUaGlzLA0KICAgICAgICAg ICAgLyogW2luXSAqLyBSRUZJSUQgcmlpZCwNCiAgICAgICAgICAgIC8qIFtpaWRfaXNdW291dF0g Ki8gdm9pZCAqKnBwdk9iamVjdCk7DQogICAgICAgIA0KICAgICAgICBVTE9ORyAoIFNURE1FVEhP RENBTExUWVBFICpBZGRSZWYgKSggDQogICAgICAgICAgICBJQ0xSRGF0YUVudW1NZW1vcnlSZWdp b25zICogVGhpcyk7DQogICAgICAgIA0KICAgICAgICBVTE9ORyAoIFNURE1FVEhPRENBTExUWVBF ICpSZWxlYXNlICkoIA0KICAgICAgICAgICAgSUNMUkRhdGFFbnVtTWVtb3J5UmVnaW9ucyAqIFRo aXMpOw0KICAgICAgICANCiAgICAgICAgSFJFU1VMVCAoIFNURE1FVEhPRENBTExUWVBFICpFbnVt TWVtb3J5UmVnaW9ucyApKCANCiAgICAgICAgICAgIElDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnMg KiBUaGlzLA0KICAgICAgICAgICAgLyogW2luXSAqLyBJQ0xSRGF0YUVudW1NZW1vcnlSZWdpb25z Q2FsbGJhY2sgKmNhbGxiYWNrLA0KICAgICAgICAgICAgLyogW2luXSAqLyBVTE9ORzMyIG1pbmlE dW1wRmxhZ3MsDQogICAgICAgICAgICAvKiBbaW5dICovIENMUkRhdGFFbnVtTWVtb3J5RmxhZ3Mg Y2xyRmxhZ3MpOw0KICAgICAgICANCiAgICAgICAgRU5EX0lOVEVSRkFDRQ0KICAgIH0gSUNMUkRh dGFFbnVtTWVtb3J5UmVnaW9uc1Z0Ymw7DQoNCiAgICBpbnRlcmZhY2UgSUNMUkRhdGFFbnVtTWVt b3J5UmVnaW9ucw0KICAgIHsNCiAgICAgICAgQ09OU1RfVlRCTCBzdHJ1Y3QgSUNMUkRhdGFFbnVt TWVtb3J5UmVnaW9uc1Z0YmwgKmxwVnRibDsNCiAgICB9Ow0KDQogICAgDQoNCiNpZmRlZiBDT0JK TUFDUk9TDQoNCg0KI2RlZmluZSBJQ0xSRGF0YUVudW1NZW1vcnlSZWdpb25zX1F1ZXJ5SW50ZXJm YWNlKFRoaXMscmlpZCxwcHZPYmplY3QpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBRdWVyeUlu dGVyZmFjZShUaGlzLHJpaWQscHB2T2JqZWN0KQ0KDQojZGVmaW5lIElDTFJEYXRhRW51bU1lbW9y eVJlZ2lvbnNfQWRkUmVmKFRoaXMpCVwNCiAgICAoVGhpcyktPmxwVnRibCAtPiBBZGRSZWYoVGhp cykNCg0KI2RlZmluZSBJQ0xSRGF0YUVudW1NZW1vcnlSZWdpb25zX1JlbGVhc2UoVGhpcykJXA0K ICAgIChUaGlzKS0+bHBWdGJsIC0+IFJlbGVhc2UoVGhpcykNCg0KDQojZGVmaW5lIElDTFJEYXRh RW51bU1lbW9yeVJlZ2lvbnNfRW51bU1lbW9yeVJlZ2lvbnMoVGhpcyxjYWxsYmFjayxtaW5pRHVt cEZsYWdzLGNsckZsYWdzKQlcDQogICAgKFRoaXMpLT5scFZ0YmwgLT4gRW51bU1lbW9yeVJlZ2lv bnMoVGhpcyxjYWxsYmFjayxtaW5pRHVtcEZsYWdzLGNsckZsYWdzKQ0KDQojZW5kaWYgLyogQ09C Sk1BQ1JPUyAqLw0KDQoNCiNlbmRpZiAJLyogQyBzdHlsZSBpbnRlcmZhY2UgKi8NCg0KDQoNCkhS RVNVTFQgU1RETUVUSE9EQ0FMTFRZUEUgSUNMUkRhdGFFbnVtTWVtb3J5UmVnaW9uc19FbnVtTWVt b3J5UmVnaW9uc19Qcm94eSggDQogICAgSUNMUkRhdGFFbnVtTWVtb3J5UmVnaW9ucyAqIFRoaXMs DQogICAgLyogW2luXSAqLyBJQ0xSRGF0YUVudW1NZW1vcnlSZWdpb25zQ2FsbGJhY2sgKmNhbGxi YWNrLA0KICAgIC8qIFtpbl0gKi8gVUxPTkczMiBtaW5pRHVtcEZsYWdzLA0KICAgIC8qIFtpbl0g Ki8gQ0xSRGF0YUVudW1NZW1vcnlGbGFncyBjbHJGbGFncyk7DQoNCg0Kdm9pZCBfX1JQQ19TVFVC IElDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnNfRW51bU1lbW9yeVJlZ2lvbnNfU3R1YigNCiAgICBJ UnBjU3R1YkJ1ZmZlciAqVGhpcywNCiAgICBJUnBjQ2hhbm5lbEJ1ZmZlciAqX3BScGNDaGFubmVs QnVmZmVyLA0KICAgIFBSUENfTUVTU0FHRSBfcFJwY01lc3NhZ2UsDQogICAgRFdPUkQgKl9wZHdT dHViUGhhc2UpOw0KDQoNCg0KI2VuZGlmIAkvKiBfX0lDTFJEYXRhRW51bU1lbW9yeVJlZ2lvbnNf SU5URVJGQUNFX0RFRklORURfXyAqLw0KDQoNCi8qIEFkZGl0aW9uYWwgUHJvdG90eXBlcyBmb3Ig QUxMIGludGVyZmFjZXMgKi8NCg0KLyogZW5kIG9mIEFkZGl0aW9uYWwgUHJvdG90eXBlcyAqLw0K DQojaWZkZWYgX19jcGx1c3BsdXMNCn0NCiNlbmRpZg0KDQojZW5kaWYNCg0KDQo= ------=_Part_28949_1639241.1228597379427-- From cyd@stupidchicken.com Sat Dec 6 17:31:09 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,BAYES_00,GMAIL autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1501) by emacsbugs.donarmstrong.com; 7 Dec 2008 01:31:09 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB71V61D029620 for <1501@emacsbugs.donarmstrong.com>; Sat, 6 Dec 2008 17:31:08 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 47F8457E204; Sat, 6 Dec 2008 20:31:10 -0500 (EST) From: Chong Yidong To: "Emerick Rogul" Cc: 1501@debbugs.gnu.org Subject: Re: Emacs 22 loses undo buffer References: Date: Sat, 06 Dec 2008 20:31:10 -0500 In-Reply-To: (Emerick Rogul's message of "Sat, 6 Dec 2008 16:02:59 -0500") Message-ID: <8763lwn541.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii "Emerick Rogul" writes: > Header file attached, although the problem occurs with any header file > (i.e., it's not specific to this particular file). The trace below > contains the exact key sequence that I typed. Thanks for the clarification. What you're encountering is the "undo-limit", which specifies the maximum amount of undo information to keep. The default is 20 kilobytes, but you can raise it by changing the variable `undo-limit'. You can also find details in the Emacs manual. From cyd@stupidchicken.com Sat Dec 6 17:35:38 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 7 Dec 2008 01:35:38 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB71ZZVS030806 for ; Sat, 6 Dec 2008 17:35:36 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 0F41657E204; Sat, 6 Dec 2008 20:35:39 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 1501 Date: Sat, 06 Dec 2008 20:35:39 -0500 Message-ID: <87zlj8lqc4.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii close 1501 thanks From emerick@gmail.com Sat Dec 6 18:03:05 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.9 required=4.0 tests=AWL,BAYES_00,GMAIL autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1501) by emacsbugs.donarmstrong.com; 7 Dec 2008 02:03:05 +0000 Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.230]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB7232DP004416 for <1501@emacsbugs.donarmstrong.com>; Sat, 6 Dec 2008 18:03:03 -0800 Received: by rv-out-0506.google.com with SMTP id k40so616418rvb.1 for <1501@emacsbugs.donarmstrong.com>; Sat, 06 Dec 2008 18:03:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=eyPThvqLgWUtH67VHcATJBFhcVxsTmj4NzbRK9KNEHQ=; b=lrwSzClu0bvxqxJ6iazK3unfWRXDGkdMBGP4GfnG1OxxtFjSN2VyMH5yn8rVRDdviv XCa83ir3AArVg7EQ2PByrwcIrD4GQcfDpeBzCtpBUW83p7DCfULc3wdAQ7hQB6Ov6ft/ gLv+0MzvDkQQp2r2eJwzd7ga55ccvRSIh6sZs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=DAqyDHYFjMHFXQ18dx/0vlnwBx5yjdd6cftV8Pf++/Be9Oo7hkO4lV7dV9jxSnbIsA CgQe44OCOc9x9cU5QIrWe4RhsV/Divab+58XYSJ22UQ/FEtp0ejJqjdQC5ccntW2upRi hJkaDL07YedyyyL3PBptQtbf8rvKdrOnT7HFM= Received: by 10.142.78.10 with SMTP id a10mr772633wfb.159.1228615381924; Sat, 06 Dec 2008 18:03:01 -0800 (PST) Received: by 10.143.3.17 with HTTP; Sat, 6 Dec 2008 18:03:01 -0800 (PST) Message-ID: Date: Sat, 6 Dec 2008 21:03:01 -0500 From: "Emerick Rogul" To: "Chong Yidong" Subject: Re: Emacs 22 loses undo buffer Cc: 1501@debbugs.gnu.org In-Reply-To: <8763lwn541.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8763lwn541.fsf@cyd.mit.edu> That's clearly not the issue at all, since the header file is only 8k in total size. What's more, I get the message after hitting the undo key sequence a couple of times. Also, this works perfectly fine in Emacs 21.2, as I mentioned in my initial report. On Sat, Dec 6, 2008 at 8:31 PM, Chong Yidong wrote: > "Emerick Rogul" writes: > >> Header file attached, although the problem occurs with any header file >> (i.e., it's not specific to this particular file). The trace below >> contains the exact key sequence that I typed. > > Thanks for the clarification. > > What you're encountering is the "undo-limit", which specifies the > maximum amount of undo information to keep. The default is 20 > kilobytes, but you can raise it by changing the variable `undo-limit'. > You can also find details in the Emacs manual. > From cyd@stupidchicken.com Sat Dec 6 21:25:35 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00, VALID_BTS_CONTROL autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 7 Dec 2008 05:25:35 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB75PXjG024216 for ; Sat, 6 Dec 2008 21:25:34 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 7B83657E1D1; Sun, 7 Dec 2008 00:25:36 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: reopen 1501 Date: Sun, 07 Dec 2008 00:25:36 -0500 Message-ID: <87y6ys7e0f.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii reopen 1501 thanks From cyd@stupidchicken.com Sat Dec 6 21:36:31 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.5 required=4.0 tests=AWL,BAYES_00,GMAIL autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1501) by emacsbugs.donarmstrong.com; 7 Dec 2008 05:36:31 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB75aTSb026645 for <1501@emacsbugs.donarmstrong.com>; Sat, 6 Dec 2008 21:36:30 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 89A0157E1D1; Sun, 7 Dec 2008 00:36:32 -0500 (EST) From: Chong Yidong To: "Emerick Rogul" Cc: 1501@debbugs.gnu.org Subject: Re: Emacs 22 loses undo buffer References: <8763lwn541.fsf@cyd.mit.edu> Date: Sun, 07 Dec 2008 00:36:32 -0500 In-Reply-To: (Emerick Rogul's message of "Sat, 6 Dec 2008 21:03:01 -0500") Message-ID: <87oczo7di7.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii "Emerick Rogul" writes: > That's clearly not the issue at all, since the header file is only 8k > in total size. What's more, I get the message after hitting the undo > key sequence a couple of times. Also, this works perfectly fine in > Emacs 21.2, as I mentioned in my initial report. In the key sequence you reported: ... C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k [snip] C-k C-k C-k C-k C-k C-k C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ ESC x r e p o r t - e m a it appears that you hit C-/ 22 times. If Emacs kept 22 undo records, and each undo record takes about 1 kilobyte, that is enough to hit the default undo limit. It might be that each undo record takes more space in Emacs 23 than in Emacs 21, which is why you don't see the problem in Emacs 21 (there are several reasons why this could happen, which could be investigated). I do observe the same behavior that you reported, using the key sequence you supplied; furthermore, if I increase undo-limit to a larger number, I find that Emacs can undo all the way back to the buffer's original state. From cyd@stupidchicken.com Sat Dec 6 21:48:52 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1501) by emacsbugs.donarmstrong.com; 7 Dec 2008 05:48:52 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB75molo029068 for <1501@emacsbugs.donarmstrong.com>; Sat, 6 Dec 2008 21:48:51 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id A3A4657E1D1; Sun, 7 Dec 2008 00:48:53 -0500 (EST) From: Chong Yidong To: "Emerick Rogul" Cc: 1501@debbugs.gnu.org Subject: Re: Emacs 22 loses undo buffer References: <8763lwn541.fsf@cyd.mit.edu> Date: Sun, 07 Dec 2008 00:48:53 -0500 In-Reply-To: (Emerick Rogul's message of "Sat, 6 Dec 2008 21:03:01 -0500") Message-ID: <87hc5g7cxm.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Actually, I went back and tried again. Using the file you supplied, I had to do C-/ about 100 times before Emacs reached its undo-limit. That implies 200 bytes per undo limit, which is about right. So there does seem to be something strange about the behavior you're seeing, where Emacs keeps only 20 or so undo records. Did you enable any other major or minor modes before testing this? Also, does turning font-lock-mode off change anything? From emerick@gmail.com Sun Dec 7 04:36:04 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.1 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1501) by emacsbugs.donarmstrong.com; 7 Dec 2008 12:36:04 +0000 Received: from wf-out-1314.google.com (wf-out-1314.google.com [209.85.200.173]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB7Ca1oO016685 for <1501@emacsbugs.donarmstrong.com>; Sun, 7 Dec 2008 04:36:02 -0800 Received: by wf-out-1314.google.com with SMTP id 26so826025wfd.13 for <1501@emacsbugs.donarmstrong.com>; Sun, 07 Dec 2008 04:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=m8p8HUcQrpn/50W/yQEoUeEZky84Al415AIbGHBrSPk=; b=egqaao7EmjJ8x7RznaIsSrszDkrwLxbJfhcVpHxnTGd+O5KyKJimswew4j371Ci21M 5SH26vi9wfHpg+Sa6X9gOmONPQlUnR5yRh7aCL8WNKneetTADxXQ4FaD6M1cE83sg4b9 TkHVQHRcTutOjwe/pkA6Ah1ITje3bmh/g/mb8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=WFRxup5QmFIccEBpRkxj0Qybrv8r/it/mDgFgiDhB07hjZUjy/fu0l1NsTkbWFguJR IAhWDwH0cboWMFKI8YMj3J94pTUrGAL9ejCmQufSeivqr7x/Jd7XIWRjz08wVtShi2tn uDcWbPFn2g7iK01r5VbojfH7tvmkI3jzjbJjI= Received: by 10.142.178.2 with SMTP id a2mr950623wff.306.1228653361152; Sun, 07 Dec 2008 04:36:01 -0800 (PST) Received: by 10.143.3.17 with HTTP; Sun, 7 Dec 2008 04:36:01 -0800 (PST) Message-ID: Date: Sun, 7 Dec 2008 07:36:01 -0500 From: "Emerick Rogul" To: "Chong Yidong" Subject: Re: Emacs 22 loses undo buffer Cc: 1501@debbugs.gnu.org In-Reply-To: <87hc5g7cxm.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8763lwn541.fsf@cyd.mit.edu> <87hc5g7cxm.fsf@cyd.mit.edu> No, I didn't enable any other major or minor modes before testing. I also ran emacs with -q --no-site-file. Your theory about it being related to font-lock-mode appears to be correct, however! I started emacs, loaded the header file, disabled font-lock-mode, and ran my test again and it behaved as expected (i.e., it retained all of my undo records). Is font-lock-mode using up more records (or more record space) than expected? I wonder if it's also Windows-specific in some way? On Sun, Dec 7, 2008 at 12:48 AM, Chong Yidong wrote: > Actually, I went back and tried again. Using the file you supplied, I > had to do C-/ about 100 times before Emacs reached its undo-limit. That > implies 200 bytes per undo limit, which is about right. > > So there does seem to be something strange about the behavior you're > seeing, where Emacs keeps only 20 or so undo records. > > Did you enable any other major or minor modes before testing this? > > Also, does turning font-lock-mode off change anything? > From jasonrumney@gmail.com Sat Dec 20 01:56:44 2008 Received: (at control) by emacsbugs.donarmstrong.com; 20 Dec 2008 09:56:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.186]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBK9ufeE021303 for ; Sat, 20 Dec 2008 01:56:42 -0800 Received: by ti-out-0910.google.com with SMTP id b6so919551tic.1 for ; Sat, 20 Dec 2008 01:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=H9cFowt+VAxpCCy5OC89rk8sbAFNQS9UqXQZKVwNfwU=; b=iUGRpfC0p7hQcBeHc9OtrEaie1J8haKUcbHusAKsVt6UXTg4N9+/7K+OzaHV3FyufH 8ULGBWfqNsa6TVbwnGJQpR5aOaXf7LN4X0wI8f1PXcZyOQJaV/kl39ShPCBPXwxxVQzc cvJfbmi5PMc31A9muyC8m0DaQs1M1sg5wAvGc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=ugERbIrFQ2HBxJI1FVuGT6hcv9DghYc1rmRhT53WJqjP3yl/+VshHUxtAZ53J+L/PB 3/DJTFL4FPRz4u6N0YYAtKUQdvYU9wLjRTlKvP14RQ7l4wjITCaT353SDjKXD/RPB/gQ 4MGx6SF2JyYbKbEdUQS2PBKe+PQhSF3HUX3Nc= Received: by 10.110.41.20 with SMTP id o20mr1683522tio.41.1229767000815; Sat, 20 Dec 2008 01:56:40 -0800 (PST) Received: from ?192.168.1.3? ([118.101.181.97]) by mx.google.com with ESMTPS id u8sm3744621tia.8.2008.12.20.01.56.39 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 20 Dec 2008 01:56:39 -0800 (PST) Sender: Jason Rumney Message-ID: <494CC13A.2070809@gnu.org> Date: Sat, 20 Dec 2008 17:56:10 +0800 From: Jason Rumney User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: more info provided Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit tags 99 -moreinfo tags 530 -moreinfo merge 1501 530 tags 656 -moreinfo From cyd@stupidchicken.com Tue Jan 27 12:58:27 2009 Received: (at 1501) by emacsbugs.donarmstrong.com; 27 Jan 2009 20:58:27 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RKwOKC006226 for <1501@emacsbugs.donarmstrong.com>; Tue, 27 Jan 2009 12:58:25 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 54A1457E205; Tue, 27 Jan 2009 15:58:55 -0500 (EST) From: Chong Yidong To: 1501@debbugs.gnu.org Subject: Re: Emacs 22 loses undo buffer Date: Tue, 27 Jan 2009 15:58:55 -0500 Message-ID: <87eiyowjn4.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I've expanded the undo limits by a factor of four. A more sophisticated fix, if one exists, will have to wait till after the release. From cyd@stupidchicken.com Tue Jan 27 12:58:46 2009 Received: (at control) by emacsbugs.donarmstrong.com; 27 Jan 2009 20:58:46 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RKwhxP006234 for ; Tue, 27 Jan 2009 12:58:44 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 364E457E205; Tue, 27 Jan 2009 15:59:14 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: severity 1501 wishlist Date: Tue, 27 Jan 2009 15:59:14 -0500 Message-ID: <87ab9cwjml.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii severity 1501 wishlist thanks From cyd@stupidchicken.com Tue Jan 27 13:01:26 2009 Received: (at control) by emacsbugs.donarmstrong.com; 27 Jan 2009 21:01:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RL1KbC007419 for ; Tue, 27 Jan 2009 13:01:21 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 5F81357E205; Tue, 27 Jan 2009 16:01:51 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: severity 530 wishlist Date: Tue, 27 Jan 2009 16:01:51 -0500 Message-ID: <8763k0wji8.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii severity 530 wishlist thanks From sureshkannan@gmail.com Fri Apr 24 15:14:24 2009 Received: (at 1501) by emacsbugs.donarmstrong.com; 24 Apr 2009 22:14:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.0 required=4.0 tests=MULTALT autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.29]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3OMEKtp020445 for <1501@emacsbugs.donarmstrong.com>; Fri, 24 Apr 2009 15:14:22 -0700 Received: by yx-out-2324.google.com with SMTP id 8so810789yxg.31 for <1501@emacsbugs.donarmstrong.com>; Fri, 24 Apr 2009 15:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=EHIETpFurQLKUoKC83Jvd+pvr177KgSFlS+Y5i5fm+o=; b=gnbGavSeVbSsE8gwiDB60kgb7m6GnJVoeJ4hrdn4wxxKUZuTuba//7WkpODRoDmmTi n7QQZj/EmO3r8rgxjBuqOIuHTg9l/VIbsbQwCAt9oAvBEt+sjWPvbs4DpBhqyQf7c3dE fZDiN6jQPalTGilqc0GIv8i9G3uh4xoEOVuek= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=kgZYQ68G9kvb3eAS4Y3gqU/wbsw1vGJePptubXRNlb4N1qb+ZbhRTg8AsBRyF63g/2 3naPqXqcxdz0fA8BTWQuEz8EtQ+kCM3IVIZVp01DHlZKQlMbueUP0Df5xtIMRGdCbkeZ 5eWQj9kYpdWec+6YT89Vq+LUW3R5txZ/YM4SM= MIME-Version: 1.0 Received: by 10.100.154.17 with SMTP id b17mr3952774ane.45.1240611260429; Fri, 24 Apr 2009 15:14:20 -0700 (PDT) Date: Fri, 24 Apr 2009 15:14:20 -0700 Message-ID: <84f679e0904241514v53e9577as69b389998edb561f@mail.gmail.com> Subject: Emacs 22 loses undo buffer From: Suresh Kannan To: 1501@debbugs.gnu.org Content-Type: multipart/alternative; boundary=0016e642d3767b77a4046854513b --0016e642d3767b77a4046854513b Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi, I'm getting the same problem in Emacs 22.2.1 in Ubuntu. Steps to reproduce. 1. start emacs without any resource file (.emacs or any other rc file) <--- this is avoid if there is some problem with user init file. 2. open file called 'test.c' 3. copy content of "http://www.rfc-editor.org/rfc/rfc2547.txt" into test.c and save it. 4. do C-k till section "3.1 Virtual Sites" in the current buffer. 5. Trying continuous C-/, emacs is **not** getting into beginning of the buffer. I get only few lines as undo. Just 5 lines i can do undo. Not more than that. Without font-lock-mode (after disabling font-lock-mode), i tried same sequence, i can get some more lines in undo but not the whole buffer. So, as you pointed out font-lock-mode has some impact with undo. Increased undo-limit,undo-strong-limit,undo-outer-limit to 100,000,000. I repeated the same steps from 1, 5. This time, I'm able to do full undo.. I dont mind setting this value in my .emacs because memory is not a problem for me. But, would this cause any other problem like performance or buffer loss ?. Thanks, Regards, Suresh Kannan. --0016e642d3767b77a4046854513b Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi,

I'm getting the same problem in Emacs 22.2.1 in Ubuntu. Ste= ps to reproduce.

1. start emacs without any resource file (.emacs o= r any other rc file)=A0 <--- this is avoid if there is some problem with= user init file.
2. open file called 'test.c'
3. copy content of "http://www.rfc-editor.org/rfc/r= fc2547.txt" into test.c and save it.
4. do=A0 C-k till section = "3.1 Virtual Sites" in the current buffer.
5. Trying continuous C-/, emacs is **not** getting into beginning of the bu= ffer. I get only few lines as undo. Just 5 lines i can do undo. Not more th= an that.

Without font-lock-mode (after disabling font-lock-mode), i= tried same sequence, i can get some more lines in undo but not the whole b= uffer. So, as you pointed out font-lock-mode has some impact with undo.
Increased undo-limit,undo-strong-limit,undo-outer-limit to 100,000,000.= I repeated the same steps from 1, 5. This time, I'm able to do full un= do.. I dont mind setting this value in my .emacs because memory is not a pr= oblem for me. But, would this cause any other problem like performance or b= uffer loss ?.

Thanks,
Regards,
Suresh Kannan.




--0016e642d3767b77a4046854513b-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 20 14:36:33 2019 Received: (at 1501) by debbugs.gnu.org; 20 Aug 2019 18:36:33 +0000 Received: from localhost ([127.0.0.1]:33910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i08zg-0000ty-MY for submit@debbugs.gnu.org; Tue, 20 Aug 2019 14:36:32 -0400 Received: from mail-pg1-f180.google.com ([209.85.215.180]:39405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i08ze-0000tX-Bq for 1501@debbugs.gnu.org; Tue, 20 Aug 2019 14:36:30 -0400 Received: by mail-pg1-f180.google.com with SMTP id u17so3713791pgi.6 for <1501@debbugs.gnu.org>; Tue, 20 Aug 2019 11:36:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=ERMKY7SuJX6hLXcGMTbEzjqaB5uKOurOk9LZPlIDKX4=; b=MGt+eI3y1XQKryQxiIBLvYpEPTDXDRxwgCAmZkId8o4gJyf6ohkzJUU6Qm2FyymMiG Hww3Rjdq9NYKTT5GId0z2SwZlkKL3V+ktvmxuSSqONrs+I/XK3CdhH2AI3F4Gf3B++ZN /fqJO3ybRWkcm2DRrQtUWRaJxtZx/7CSrS4XiIypULp+T1Ymr8kP0Npm2fhxgDhQysLY 1is67GOY/I0pSkUUTuXrEVJS7/ub+mf8asaykMXU4PIulWWCJC/PgH77JD1DpF8jGeJK eqxcmQ7zhm0EwYr6vPlnkV1s0HMxMTaYXjxHXpywPIvgEfus/SUwUdvd4jnqd/UEbEmY OCJA== X-Gm-Message-State: APjAAAUiK3Lc14FEe4Y5y3dPRmTGJjOgWXmxEv7Mv/hus7zmuOZ5uZyj WCqWObSEb16D9tMvXXYGIpzZeJYQMM//6HQPeos= X-Google-Smtp-Source: APXvYqxb3K5tOLWOlN9gcHbu4H58sDdt1LTTrqHf/zy/7RHNaiLpqgx5qQ6rMq8yOxWeM+wMAF9GAtilckMhbOgHdfQ= X-Received: by 2002:a62:7789:: with SMTP id s131mr31388223pfc.50.1566326184357; Tue, 20 Aug 2019 11:36:24 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 20 Aug 2019 20:36:13 +0200 Message-ID: Subject: Re: bug#1501: Emacs 22 loses undo buffer To: Chong Yidong Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 1501 Cc: Emerick Rogul , 1501@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Chong Yidong writes: > "Emerick Rogul" writes: > >> That's clearly not the issue at all, since the header file is only 8k >> in total size. What's more, I get the message after hitting the undo >> key sequence a couple of times. Also, this works perfectly fine in >> Emacs 21.2, as I mentioned in my initial report. > > In the key sequence you reported: > > ... C-k C-k C-k C-k C-k C-k C-k C-k C-k > C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k > [snip] > C-k C-k C-k C-k C-k C-k C-/ C-/ C-/ C-/ C-/ C-/ C-/ > C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ C-/ > C-/ ESC x r e p o r t - e m a > > it appears that you hit C-/ 22 times. If Emacs kept 22 undo records, > and each undo record takes about 1 kilobyte, that is enough to hit the > default undo limit. It might be that each undo record takes more space > in Emacs 23 than in Emacs 21, which is why you don't see the problem in > Emacs 21 (there are several reasons why this could happen, which could > be investigated). > > I do observe the same behavior that you reported, using the key sequence > you supplied; furthermore, if I increase undo-limit to a larger number, > I find that Emacs can undo all the way back to the buffer's original > state. Chong Yidong writes: > I've expanded the undo limits by a factor of four. A more sophisticated > fix, if one exists, will have to wait till after the release. The undo limits were recently again doubled on master in commit 9466372 in relation to Bug#31104. The latter change will be included in the next major version of Emacs (version 27.1). If you're still seeing this problem on a recent version of Emacs, a workaround is to increase the values of the variables undo-limit, undo-outer-limit and undo-strong-limit. You could add something like the following to your init file: (setq undo-limit (* 2 undo-limit)) (setq undo-outer-limit (* 2 undo-outer-limit)) (setq undo-strong-limit (* 2 undo-strong-limit)) Of course, you could use a bigger number than 2 should that be necessary. Given the discussion in Bug#31104, I'm not sure there's more to do here. But the discussion here also suggests that there have been an increase in the memory usage of each undo record, especially when using font-lock-mode. I'm not sure that is a serious problem, since memory is only getting cheaper, but it might be worth investigating. On the other hand, we could just decide that this is not worth the effort and close this as wontfix. Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 20 14:45:15 2019 Received: (at 1501) by debbugs.gnu.org; 20 Aug 2019 18:45:15 +0000 Received: from localhost ([127.0.0.1]:33922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0987-0001HB-BQ for submit@debbugs.gnu.org; Tue, 20 Aug 2019 14:45:15 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:37665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0986-0001Gq-53 for 1501@debbugs.gnu.org; Tue, 20 Aug 2019 14:45:14 -0400 Received: by mail-io1-f50.google.com with SMTP id q22so14364589iog.4 for <1501@debbugs.gnu.org>; Tue, 20 Aug 2019 11:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9EYSPrOdc9kqPKjtr4pma0fUtSItsiUZVhl/YLO6b+o=; b=mpxYMU2dg0zZAe00z5ayZ0k1G23yH166wCn23epG9iVQygjHsdLSC4raAxv+cSv5VO dvGlToVgqZbznFU9D68VNV6QigRMQXaspAPc45CUk1R3YNxJ+Aemhdg/pghLq/rwP77L eSdm3joepXliAfXTAyPQbrq33Z1rLxKoCMZ03MN01Bjj+tdrlMkk1wLvGC7cBxZF/qXk NpyeqjhtfGXZJNNnNGnWfVGzaTzJMYjCbHmHdD/IJaHSK2h1KBZlqImJATJTiqtJIZvo qwFwKLRcxhf4/ZXdDmylDGLb7m8lRYkDiB82S/0gBkLJCpeJmfX4Nsp1LrUETQLgI91u jouA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9EYSPrOdc9kqPKjtr4pma0fUtSItsiUZVhl/YLO6b+o=; b=d/Whv6HRGmRf7dT+uuTyLxFOMvl/4vRf9R/9DnwtNXX3/aY0/92HceWGWge0CcAnsi fnGhJoOU+Y4voHSM8uxMTCUAsW6Ezb1uqgPuPBisj9nf22CufKXE9MgSnPy5hrhqD2xq RNMZW67jJl6c/UtzegQkNSp3q3pWkwGkfLwhfA70EF0HE2kKsSFtl/t+c5Z6f8rrdSJX HsflBecmF/WTFhG4cx6dqgA6hh2UkxOgGbjptqbvPwo9FekTCsap0P1xnHH+CojFgyL5 oCVUKaFB43Cg/VetXF1HaCG2pfaGAlK2j41N8sjdx+vxMkAk0wuHEDg3C94HxJWbZQVe v0ew== X-Gm-Message-State: APjAAAV/FB1O6XoEKaX3ZtUsFci5lo20mNiPmBiC52r9joZzKsN8eTNT 7wlask8C0vT7aAzqVAvGJ+YNWdIO X-Google-Smtp-Source: APXvYqysT9QIDbGrn17J6hsQqR6HyTNY0nOrhJDcG8pjlZ++lfG+vuUNHAfv2qrUK2iw8kNva3d8lQ== X-Received: by 2002:a6b:ea02:: with SMTP id m2mr17661117ioc.155.1566326708403; Tue, 20 Aug 2019 11:45:08 -0700 (PDT) Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id c13sm22936252iok.84.2019.08.20.11.45.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Aug 2019 11:45:07 -0700 (PDT) From: Noam Postavsky To: Stefan Kangas Subject: Re: bug#1501: Emacs 22 loses undo buffer References: Date: Tue, 20 Aug 2019 14:45:08 -0400 In-Reply-To: (Stefan Kangas's message of "Tue, 20 Aug 2019 20:36:13 +0200") Message-ID: <85k1b7k763.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 1501 Cc: Emerick Rogul , 1501@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > increase in the memory usage of each undo record, especially when > using font-lock-mode. I'm not sure that is a serious problem, since > memory is only getting cheaper, but it might be worth investigating. > On the other hand, we could just decide that this is not worth the > effort and close this as wontfix. Hmm, it sounds like the problem might just be due to saving text properties in the undo records? If so, maybe a simple fix is to just drop them (or drop only face and font-lock-face properties). From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 21 10:46:48 2019 Received: (at 1501) by debbugs.gnu.org; 21 Aug 2019 14:46:48 +0000 Received: from localhost ([127.0.0.1]:36258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0Rss-0002sJ-F3 for submit@debbugs.gnu.org; Wed, 21 Aug 2019 10:46:46 -0400 Received: from mail-pg1-f175.google.com ([209.85.215.175]:38045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0Rsq-0002s6-BV for 1501@debbugs.gnu.org; Wed, 21 Aug 2019 10:46:44 -0400 Received: by mail-pg1-f175.google.com with SMTP id e11so1446690pga.5 for <1501@debbugs.gnu.org>; Wed, 21 Aug 2019 07:46:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bywfe+2YfbituzQS/tkXFjLj3KudA+qQhifI7M8zwPQ=; b=d5G3zvlyBq57VHvoDaLcWzbD6nRxrydj81cfojYqyJ2fs9JIdoSXckhxm1hfKk+uAZ td5rxXn0BTXjylkciowVdpw7DSVDAYRA0uiY/W9GOjtUu8/Nsxb3N/wJMUMDKfynx40Z UZDSsdrAhtFVdLyiWotV10+PJITyDfQ5B9x9YsStUGl8BWhrCudR0tkh1gkOJkS3ajQL xwpw9E1OFwjubQ7GNodsZ3R9XbsHjCK37AfVchNeXQ0fQZbhc3iNopczmi1ZVDxiUdUP wvtuSvfO5I44p/pywuSmDGO2tFwmKfyn/j+6pmIexR4fNEfGUDZ0UPbNSit/u5qagmvW vApw== X-Gm-Message-State: APjAAAWLgLWW6pmfCndWi08EIRql3io0dqSykXogyHVK+swYHxqeW2U/ nRFoSshlY953v4a3P31xJESY5+zADnz0jL5Quq0= X-Google-Smtp-Source: APXvYqyLDWvW8qvQkZvr9bfzj+Oo5ls76vrgjJuICCPEChJehXbeRhq/WpCSqdjwihiy0SSXcyeKtnN+jEWlTR6KR5s= X-Received: by 2002:a63:69c1:: with SMTP id e184mr28178026pgc.198.1566398798317; Wed, 21 Aug 2019 07:46:38 -0700 (PDT) MIME-Version: 1.0 References: <85k1b7k763.fsf@gmail.com> In-Reply-To: <85k1b7k763.fsf@gmail.com> From: Stefan Kangas Date: Wed, 21 Aug 2019 16:46:26 +0200 Message-ID: Subject: Re: bug#1501: Emacs 22 loses undo buffer To: Noam Postavsky Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 1501 Cc: Emerick Rogul , 1501@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Noam Postavsky writes: > Stefan Kangas writes: > > > increase in the memory usage of each undo record, especially when > > using font-lock-mode. I'm not sure that is a serious problem, since > > memory is only getting cheaper, but it might be worth investigating. > > On the other hand, we could just decide that this is not worth the > > effort and close this as wontfix. > > Hmm, it sounds like the problem might just be due to saving text > properties in the undo records? If so, maybe a simple fix is to just > drop them (or drop only face and font-lock-face properties). Is it not worth saving also that information? Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 21 21:19:42 2019 Received: (at 1501) by debbugs.gnu.org; 22 Aug 2019 01:19:43 +0000 Received: from localhost ([127.0.0.1]:36883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0blO-000808-Lf for submit@debbugs.gnu.org; Wed, 21 Aug 2019 21:19:42 -0400 Received: from mail-io1-f47.google.com ([209.85.166.47]:41108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i0blM-0007zs-7v for 1501@debbugs.gnu.org; Wed, 21 Aug 2019 21:19:41 -0400 Received: by mail-io1-f47.google.com with SMTP id j5so8534538ioj.8 for <1501@debbugs.gnu.org>; Wed, 21 Aug 2019 18:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dLEtHrmV/EMeSZFsMGSaecd004xqoxaUXD7S3GeP2dA=; b=tDFR+CPhC2ilVVsq7cAcphh9bGE7lqzxZukbUZiElThogRi0p5qMaV1hVkxcQrkG9S Kq6AlBRrCykGbvofbT63tsuxtbuKNsahsDkSXKA0IeynD0CnSk7AHjg4S4aOrg0jkbiq 2TBKTZh2190IaKW6rWziId8lSuHptTBqUpW20S1ktVVf1nxCHdIIUzNwi2O/AbbN9Mbk 1uB9ea3hLNLsYiR7Kkgu1hcYXvP7Jx88KVQCHWI9mUcvm3FhfEUtzH1e72pHQJoUxVBV mmOFfq6Mi7ml6lA3WC0ob3Hx8UkODDtK2VY2+jd05LKLg5+dXVJzn/R2joBdQpNC6Ma3 W8Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dLEtHrmV/EMeSZFsMGSaecd004xqoxaUXD7S3GeP2dA=; b=Qb6vFRH5xoJ9JCUfXL0nyvgdDt0aq0siQTDJDf4sn0uX+Yrn88NLRs0ZzXMUPxjnQ7 lUD0F5t+y25uYBZFmx4JqOul0akS/UjYgQ6o36Do+n0eU7weOwToHjzIYfBHAS/Pcxlt Q8DUYb61Qa8Ve/Qi8FQNciNYKKvxTvEz3moHpU/Ag6r1+LUADE/t5+g5IcHJ890tqarl OTQdj5OGZ8QdSj+d5kMDk5PsPqoKDIB1PRSHYsCbi9HoFBZwO4X4un8HMgNBpf1fyJxt b4nkxJn6ch9zdJouj6rohx7/lO4x9ISQt8lWLtlCHv33f6A3cSjJ2SgIxYt165hHapSH G95A== X-Gm-Message-State: APjAAAW4Y5Rs069G2ra9Er/qg5xL7bRdXbqkW7T8p9tibliOZVynWyT5 mSd21EkL4lGFbYlVYmXQMDk= X-Google-Smtp-Source: APXvYqwUpR8Q6IneS8iXFuyK1F/SEFaVc/I3oaVm5wR84asBCL0cFllTMdnOq996OmjMx7ijX9CoHw== X-Received: by 2002:a6b:7e07:: with SMTP id i7mr8526712iom.254.1566436774640; Wed, 21 Aug 2019 18:19:34 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id q22sm16646486ioj.56.2019.08.21.18.19.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Aug 2019 18:19:33 -0700 (PDT) From: Noam Postavsky To: Stefan Kangas Subject: Re: bug#1501: Emacs 22 loses undo buffer References: <85k1b7k763.fsf@gmail.com> Date: Wed, 21 Aug 2019 21:19:32 -0400 In-Reply-To: (Stefan Kangas's message of "Wed, 21 Aug 2019 16:46:26 +0200") Message-ID: <87ef1engij.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 1501 Cc: Emerick Rogul , 1501@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Noam Postavsky writes: > >> Stefan Kangas writes: >> >> > increase in the memory usage of each undo record, especially when >> > using font-lock-mode. I'm not sure that is a serious problem, since >> > memory is only getting cheaper, but it might be worth investigating. >> > On the other hand, we could just decide that this is not worth the >> > effort and close this as wontfix. >> >> Hmm, it sounds like the problem might just be due to saving text >> properties in the undo records? If so, maybe a simple fix is to just >> drop them (or drop only face and font-lock-face properties). > > Is it not worth saving also that information? Definitely not face, since it's overwritten as soon as font-lock runs. It's true font-lock-face can sometimes be set manually, though usually it's computed by font-lock rules. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 19 21:01:53 2021 Received: (at 1501) by debbugs.gnu.org; 20 Oct 2021 01:01:53 +0000 Received: from localhost ([127.0.0.1]:52314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mczzM-0006Nu-R3 for submit@debbugs.gnu.org; Tue, 19 Oct 2021 21:01:53 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:35751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mczzK-0006NX-Rj for 1501@debbugs.gnu.org; Tue, 19 Oct 2021 21:01:51 -0400 Received: by mail-pl1-f181.google.com with SMTP id b14so5151897plg.2 for <1501@debbugs.gnu.org>; Tue, 19 Oct 2021 18:01:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=V1uT8TK31jAD0X8tzIVhFKqrAV9GWZ6V9/DUFmshnTw=; b=0318T4DvgZXN95B0aBnUDtYIEpZfJgehKtoM89cVlMdDCrav+s60n+6Tzz1uyd4BLY I+YepdGfrtsC+FsrUWjaqqzkAu2TGFGEDBJ3bx2R12+azeUsUSJzZNp0S9NKx3e76O2L ANCgEqos6Jm2BnFLs5P38OU9evWanyyQp6AeTKmri6TGpnIlHw8k/9VKEYHDMXtUy/pp YRJc7SPS9+ZB5sJ0JTNDK7+8SLuoaAMB/vkoqo4F1iuGy/LUWPQvTU79o4AUTpKJ8+8d Ol/LCexH/P/11nkB2XTLdbZ7U3R2b5Qvd/DR7rTQ6bHVvNK73T9XZsrlXLgBmqMjTLM4 PTfQ== X-Gm-Message-State: AOAM533w/1sRsIetI9BxzTUjDd9M3upNOltELGGLVS/A8j4dLXL4md1H b5E58/Ku7UeycJVFSaJQ9muXdIi1vxkWvwquiig= X-Google-Smtp-Source: ABdhPJy8e8C9pM8QIm5I5gYNn2R+IA6DB4p/+BAYPeToAh2kTgWxxoLn5QuDj1CQ4MMmjCsYhwQ0i80CIRR5OLkeE18= X-Received: by 2002:a17:90b:17d2:: with SMTP id me18mr3708909pjb.132.1634691704928; Tue, 19 Oct 2021 18:01:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 19 Oct 2021 18:01:43 -0700 From: Stefan Kangas In-Reply-To: <87ef1engij.fsf@gmail.com> (Noam Postavsky's message of "Wed, 21 Aug 2019 21:19:32 -0400") References: <85k1b7k763.fsf@gmail.com> <87ef1engij.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Tue, 19 Oct 2021 18:01:43 -0700 Message-ID: Subject: Re: bug#1501: Emacs 22 loses undo buffer To: Noam Postavsky Content-Type: multipart/mixed; boundary="00000000000063cfd205cebe524c" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 1501 Cc: Emerick Rogul , 1501@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --00000000000063cfd205cebe524c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tags 1501 + patch thanks Noam Postavsky writes: > Stefan Kangas writes: > >> Noam Postavsky writes: >> >>> Stefan Kangas writes: >>> >>> > increase in the memory usage of each undo record, especially when >>> > using font-lock-mode. I'm not sure that is a serious problem, since >>> > memory is only getting cheaper, but it might be worth investigating. >>> > On the other hand, we could just decide that this is not worth the >>> > effort and close this as wontfix. >>> >>> Hmm, it sounds like the problem might just be due to saving text >>> properties in the undo records? If so, maybe a simple fix is to just >>> drop them (or drop only face and font-lock-face properties). >> >> Is it not worth saving also that information? > > Definitely not face, since it's overwritten as soon as font-lock runs. > It's true font-lock-face can sometimes be set manually, though usually > it's computed by font-lock rules. This would be fairly simple to do, as in the attached patch. But I'm not sure that we should make this change, since both `face' and `font-lock-face' could be used by a major mode at various times, without getting automatically re-added by font-lock. >From (info "(elisp) Precalculated Fontification"): But if the mode does not use the normal Font Lock machinery, it should not set the variable =E2=80=98font-lock-defaults=E2=80=99. In t= his case the =E2=80=98face=E2=80=99 property will not be overridden, so using the = =E2=80=98face=E2=80=99 property could work too. IOW, I'm not sure that the proposed change won't introduce subtle bugs. Other than that, we have doubled all undo limits in Emacs 27.1, so maybe that's enough of a fix for now? Any other opinions? --00000000000063cfd205cebe524c Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Decrease-size-of-undo-entries.patch" Content-Disposition: attachment; filename="0001-Decrease-size-of-undo-entries.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 83095a7432305b3f_0.1 RnJvbSA3YjBmZWE0MmY3OTNkN2I3ZjlmYTk5MzhiM2M5OWIxZjI4MzIzNTMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogV2VkLCAyMCBPY3QgMjAyMSAwMjo0MjozMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIERlY3Jl YXNlIHNpemUgb2YgdW5kbyBlbnRyaWVzCgoqIHNyYy91bmRvLmMgKHJlY29yZF9kZWxldGUpOiBS ZW1vdmUgdGhlICdmYWNlJyBwcm9wZXJ0eSBmcm9tIHVuZG8KZW50cmllcyB0byBzYXZlIHNwYWNl LiAgKEJ1ZzE1MDEpCi0tLQogc3JjL3VuZG8uYyB8IDcgKysrKysrKwogMSBmaWxlIGNoYW5nZWQs IDcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy91bmRvLmMgYi9zcmMvdW5kby5jCmlu ZGV4IDJkYjQwMWViYzcuLjI2MGNmNzkyYzcgMTAwNjQ0Ci0tLSBhL3NyYy91bmRvLmMKKysrIGIv c3JjL3VuZG8uYwpAQCAtMTY0LDYgKzE2NCwxMyBAQCByZWNvcmRfZGVsZXRlIChwdHJkaWZmX3Qg YmVnLCBMaXNwX09iamVjdCBzdHJpbmcsIGJvb2wgcmVjb3JkX21hcmtlcnMpCiB7CiAgIExpc3Bf T2JqZWN0IHNiZWc7CiAKKyAgLyogUmVtb3ZlIHRoZSBgZmFjZScgcHJvcGVydHkgdG8gc2F2ZSBz cGFjZS4gIChCdWcxNTAxKSAgKi8KKyAgaWYgKCFOSUxQIChzdHJpbmcpKQorICAgIEZyZW1vdmVf bGlzdF9vZl90ZXh0X3Byb3BlcnRpZXMgKG1ha2VfZml4bnVtICgwKSwKKwkJCQkgICAgIG1ha2Vf Zml4bnVtIChTQ0hBUlMgKHN0cmluZykpLAorCQkJCSAgICAgQ0FMTE4gKEZsaXN0LCBRZmFjZSks CisJCQkJICAgICBzdHJpbmcpOworCiAgIGlmIChFUSAoQlZBUiAoY3VycmVudF9idWZmZXIsIHVu ZG9fbGlzdCksIFF0KSkKICAgICByZXR1cm47CiAKLS0gCjIuMzAuMgoK --00000000000063cfd205cebe524c-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 20 08:06:02 2021 Received: (at 1501) by debbugs.gnu.org; 20 Oct 2021 12:06:02 +0000 Received: from localhost ([127.0.0.1]:52918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdAM5-00074e-Q2 for submit@debbugs.gnu.org; Wed, 20 Oct 2021 08:06:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdAM4-00074O-AX for 1501@debbugs.gnu.org; Wed, 20 Oct 2021 08:06:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35550) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdALy-00037L-NI; Wed, 20 Oct 2021 08:05:54 -0400 Received: from [87.69.77.57] (port=1056 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdALc-0002Ta-56; Wed, 20 Oct 2021 08:05:46 -0400 Date: Wed, 20 Oct 2021 15:05:34 +0300 Message-Id: <83k0i7c35d.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 19 Oct 2021 18:01:43 -0700) Subject: Re: bug#1501: Emacs 22 loses undo buffer References: <85k1b7k763.fsf@gmail.com> <87ef1engij.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 1501 Cc: emerick@gmail.com, 1501@debbugs.gnu.org, cyd@stupidchicken.com, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 19 Oct 2021 18:01:43 -0700 > Cc: Emerick Rogul , 1501@debbugs.gnu.org, > Chong Yidong > > + /* Remove the `face' property to save space. (Bug1501) */ > + if (!NILP (string)) > + Fremove_list_of_text_properties (make_fixnum (0), > + make_fixnum (SCHARS (string)), > + CALLN (Flist, Qface), > + string); This modifies the text properties of STRING, which you don't own. Also, it will do unnecessary non-trivial processing when undo is turned off. I definitely think that with the enlarged undo-limit we should leave this obscure situation alone. It isn't worth making such significant low-level changes due to such obscure problems, which are arguably cockpit errors. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 21 16:46:32 2021 Received: (at 1501) by debbugs.gnu.org; 21 Oct 2021 20:46:32 +0000 Received: from localhost ([127.0.0.1]:58727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdexL-0002wS-O2 for submit@debbugs.gnu.org; Thu, 21 Oct 2021 16:46:32 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:38662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdexJ-0002w3-IF for 1501@debbugs.gnu.org; Thu, 21 Oct 2021 16:46:30 -0400 Received: by mail-pl1-f173.google.com with SMTP id i5so1251747pla.5 for <1501@debbugs.gnu.org>; Thu, 21 Oct 2021 13:46:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:user-agent :mime-version:date:message-id:subject:to:cc; bh=/8pH3RWNknwUsxHGOkzJraBXj8CTuvNeEvOCidUVLRk=; b=NfzzSx4T+PLa3UG1Eym8LX5ndP+lOnWih7zcQMPyhPzaXCyug03WmklB1s9OsB46vg MLJRLi7ah+SzeVUFIpWebowKy04jaGy4lYhrs4ZC7nL07rpqO/PnooZEvrmC8V6N4AL5 k51JOZhWLV+I6BCzYoZamWjz2XCVfEmrW0cTprOJ5lxkpLlzK14L0acedWUVueKJnOqK Dpl0Q5fwsAPfFZMnlKHY9wvVR5n3+xvU0tufnE7Ze3UyZW2TOR6HH+4ePWeC+HWVAGE0 IMBkLJRn43rQ2FBWm9zr9ebMWpxOz98NzizHxx1IV+NwIXfHwMCYutvFs9HF1GbFI6M5 FnXQ== X-Gm-Message-State: AOAM532x75Fwhzzn2dZQe+qCLfO5Tmkvd6isvvcYunP9qj0kaJoSe2Nq xHAIMH71YZDuzhPep5VkV4yw1JB1UauqRIztvwk= X-Google-Smtp-Source: ABdhPJzgEaZPG3pl2TC7EBVCNnI+/zMZkTUoAakyBqnVyAk37ktAuZcWK7oHQgD9g4hCKUg+Rg2T/zFQC6dsAKGFgwU= X-Received: by 2002:a17:902:b691:b029:12d:2b6:d116 with SMTP id c17-20020a170902b691b029012d02b6d116mr7149298pls.71.1634849183784; Thu, 21 Oct 2021 13:46:23 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 21 Oct 2021 13:46:23 -0700 From: Stefan Kangas In-Reply-To: <83k0i7c35d.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Oct 2021 15:05:34 +0300") References: <85k1b7k763.fsf@gmail.com> <87ef1engij.fsf@gmail.com> <83k0i7c35d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Date: Thu, 21 Oct 2021 13:46:23 -0700 Message-ID: Subject: Re: bug#1501: Emacs 22 loses undo buffer To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 1501 Cc: emerick@gmail.com, 1501@debbugs.gnu.org, cyd@stupidchicken.com, npostavs@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 1501 wontfix close 1501 thanks Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Tue, 19 Oct 2021 18:01:43 -0700 >> Cc: Emerick Rogul , 1501@debbugs.gnu.org, >> Chong Yidong >> >> + /* Remove the `face' property to save space. (Bug1501) */ >> + if (!NILP (string)) >> + Fremove_list_of_text_properties (make_fixnum (0), >> + make_fixnum (SCHARS (string)), >> + CALLN (Flist, Qface), >> + string); > > This modifies the text properties of STRING, which you don't own. > > Also, it will do unnecessary non-trivial processing when undo is > turned off. > > I definitely think that with the enlarged undo-limit we should leave > this obscure situation alone. It isn't worth making such significant > low-level changes due to such obscure problems, which are arguably > cockpit errors. OK, I'm therefore closing this bug as wontfix. (Alternatively, we could just close it as "fixed" (with the doubling of undo limits) but let's be a bit more explicit.) From unknown Sat Aug 16 18:47:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 19 Nov 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator