From unknown Thu Sep 11 16:39:33 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14995 <14995@debbugs.gnu.org> To: bug#14995 <14995@debbugs.gnu.org> Subject: Status: [PATCH] vc-do-command ignores symbolic links Reply-To: bug#14995 <14995@debbugs.gnu.org> Date: Thu, 11 Sep 2025 23:39:33 +0000 retitle 14995 [PATCH] vc-do-command ignores symbolic links reassign 14995 emacs submitter 14995 Xue Fuqiao severity 14995 minor tag 14995 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 31 06:53:57 2013 Received: (at submit) by debbugs.gnu.org; 31 Jul 2013 10:53:57 +0000 Received: from localhost ([127.0.0.1]:60185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4U2W-0006ZS-TV for submit@debbugs.gnu.org; Wed, 31 Jul 2013 06:53:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57736) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4U2T-0006Z5-P7 for submit@debbugs.gnu.org; Wed, 31 Jul 2013 06:53:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4U2M-0008VG-RK for submit@debbugs.gnu.org; Wed, 31 Jul 2013 06:53:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4U2M-0008V9-O2 for submit@debbugs.gnu.org; Wed, 31 Jul 2013 06:53:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4U2K-0004wc-QJ for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2013 06:53:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4U2J-0008Tc-01 for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2013 06:53:44 -0400 Received: from mail-ob0-x231.google.com ([2607:f8b0:4003:c01::231]:39709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4U2I-0008TY-RO for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2013 06:53:42 -0400 Received: by mail-ob0-f177.google.com with SMTP id f8so1028780obp.36 for ; Wed, 31 Jul 2013 03:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=lCyHlP3E5DZZBJGY97Fm1rNnjX/ab5EJ4JKrgnnqyck=; b=FUetfb7aYdEIuTZ55qPmN2biornEF4EctV0vdqT6t+VZ/tDmAmsaqztbXxt+/VkkIY PLnwXocVPnBmz+xMwXFWpLGOX5odhdQqmQR+TTFGlRLyOS9htQVXjZyOltnGlGTUqFH/ vuzP2EwWffbGPrqYUWqnHZLyVbwtsaRsWRSwbPZwqY/WfgeKKYO/ANTBOLAySiBN2f7b 7xSv+aNJGP/SKaX6iPLbkHD9eqHFugAuPwf81ADa5yiruBe2gwmUR0diohFzZJ8KxTk3 KhcRjj4dDIZV7AMzNA8ixqlvFBgKGs4vmYHia36EOa5bAVH0q/C4wVNEzx4e+MiIo1RE D1jA== MIME-Version: 1.0 X-Received: by 10.43.159.198 with SMTP id lz6mr5055459icc.97.1375268022082; Wed, 31 Jul 2013 03:53:42 -0700 (PDT) Received: by 10.42.28.3 with HTTP; Wed, 31 Jul 2013 03:53:42 -0700 (PDT) Date: Wed, 31 Jul 2013 18:53:42 +0800 Message-ID: Subject: [PATCH] vc-do-command ignores symbolic links From: Xue Fuqiao To: bug-gnu-emacs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) tags patch This small patch fixes a bug in vc-do-command: === modified file 'lisp/vc/vc-dispatcher.el' --- lisp/vc/vc-dispatcher.el 2013-06-15 02:50:47 +0000 +++ lisp/vc/vc-dispatcher.el 2013-07-31 10:49:27 +0000 @@ -275,11 +275,8 @@ that is inserted into the command line before the filename. Return the return value of the slave command in the synchronous case, and the process object in the asynchronous case." - ;; FIXME: file-relative-name can return a bogus result because - ;; it doesn't look at the actual file-system to see if symlinks - ;; come into play. (let* ((files - (mapcar (lambda (f) (file-relative-name (expand-file-name f))) + (mapcar (lambda (f) (file-relative-name (file-truename (expand-file-name f)))) (if (listp file-or-list) file-or-list (list file-or-list)))) (full-command ;; What we're doing here is preparing a version of the command -- Best regards, Xue Fuqiao. http://www.gnu.org/software/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 31 10:13:31 2013 Received: (at 14995) by debbugs.gnu.org; 31 Jul 2013 14:13:31 +0000 Received: from localhost ([127.0.0.1]:60992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4X9f-0007td-2G for submit@debbugs.gnu.org; Wed, 31 Jul 2013 10:13:31 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:17080) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4X9d-0007tL-65 for 14995@debbugs.gnu.org; Wed, 31 Jul 2013 10:13:29 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZvt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av8EABK/CFFFpZvt/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="20244823" Received: from 69-165-155-237.dsl.teksavvy.com (HELO pastel.home) ([69.165.155.237]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 31 Jul 2013 10:13:17 -0400 Received: by pastel.home (Postfix, from userid 20848) id 1111963C70; Wed, 31 Jul 2013 10:13:23 -0400 (EDT) From: Stefan Monnier To: Xue Fuqiao Subject: Re: bug#14995: [PATCH] vc-do-command ignores symbolic links Message-ID: References: Date: Wed, 31 Jul 2013 10:13:23 -0400 In-Reply-To: (Xue Fuqiao's message of "Wed, 31 Jul 2013 18:53:42 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 14995 Cc: 14995@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > This small patch fixes a bug in vc-do-command: > === modified file 'lisp/vc/vc-dispatcher.el' > --- lisp/vc/vc-dispatcher.el 2013-06-15 02:50:47 +0000 > +++ lisp/vc/vc-dispatcher.el 2013-07-31 10:49:27 +0000 > @@ -275,11 +275,8 @@ > that is inserted into the command line before the filename. > Return the return value of the slave command in the synchronous > case, and the process object in the asynchronous case." > - ;; FIXME: file-relative-name can return a bogus result because > - ;; it doesn't look at the actual file-system to see if symlinks > - ;; come into play. > (let* ((files > - (mapcar (lambda (f) (file-relative-name (expand-file-name f))) > + (mapcar (lambda (f) (file-relative-name (file-truename > (expand-file-name f)))) > (if (listp file-or-list) file-or-list (list file-or-list)))) > (full-command > ;; What we're doing here is preparing a version of the command I'm not completely sure this fix is needed (and I'd rather avoid calling file-truename, if possible). Do you have a concrete case where this causes problems? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 31 18:39:05 2013 Received: (at 14995) by debbugs.gnu.org; 31 Jul 2013 22:39:05 +0000 Received: from localhost ([127.0.0.1]:33305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4f2v-0007TF-BQ for submit@debbugs.gnu.org; Wed, 31 Jul 2013 18:39:05 -0400 Received: from mail-oa0-f46.google.com ([209.85.219.46]:63794) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4f2t-0007Sf-0W for 14995@debbugs.gnu.org; Wed, 31 Jul 2013 18:39:03 -0400 Received: by mail-oa0-f46.google.com with SMTP id l10so2766044oag.5 for <14995@debbugs.gnu.org>; Wed, 31 Jul 2013 15:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=EavkYmV94kauN4OwT41Ui/dsi+1hhYq1CEoBC5nZXc8=; b=r+ZysCuZ6XYdOYbSkvW27mcKTSbvj7Ox9x4KWWGAaJp8An5VYS15X8+W3t5dT+b5em qdwYbgD3sdYPGrSwJzLkC6VHw3LSp2JaYBWGhEUw0PzHZR8ligUa+g7GQ6f3HO0r0958 CFDIsaAfZxeDPEwsgylCjFzWYBPWsCtXgadjj8L+hynV1q+Y3HTCUzTlYU3dd4aXawN7 kbAqKjb6/XWykTqXYxTsHqQerhSn90jPn7Ox6TDucpvtxb5vyyaygDGUdCYEPwLvR+h/ eK1+c9njtvtNoLC/mJ9JgNkh8Hr0bch+N1jiCAIlGQIDoly58QA8O9kKUTF+m7ypOHTf KRXw== MIME-Version: 1.0 X-Received: by 10.50.9.7 with SMTP id v7mr958034iga.51.1375310337338; Wed, 31 Jul 2013 15:38:57 -0700 (PDT) Received: by 10.42.28.3 with HTTP; Wed, 31 Jul 2013 15:38:57 -0700 (PDT) In-Reply-To: References: Date: Thu, 1 Aug 2013 06:38:57 +0800 Message-ID: Subject: Re: bug#14995: [PATCH] vc-do-command ignores symbolic links From: Xue Fuqiao To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14995 Cc: 14995@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Jul 31, 2013 at 10:13 PM, Stefan Monnier wrote: >> This small patch fixes a bug in vc-do-command: > >> === modified file 'lisp/vc/vc-dispatcher.el' >> --- lisp/vc/vc-dispatcher.el 2013-06-15 02:50:47 +0000 >> +++ lisp/vc/vc-dispatcher.el 2013-07-31 10:49:27 +0000 >> @@ -275,11 +275,8 @@ >> that is inserted into the command line before the filename. >> Return the return value of the slave command in the synchronous >> case, and the process object in the asynchronous case." >> - ;; FIXME: file-relative-name can return a bogus result because >> - ;; it doesn't look at the actual file-system to see if symlinks >> - ;; come into play. >> (let* ((files >> - (mapcar (lambda (f) (file-relative-name (expand-file-name f))) >> + (mapcar (lambda (f) (file-relative-name (file-truename >> (expand-file-name f)))) >> (if (listp file-or-list) file-or-list (list file-or-list)))) >> (full-command >> ;; What we're doing here is preparing a version of the command > > I'm not completely sure this fix is needed (and I'd rather avoid > calling file-truename, if possible). Do you have a concrete case where > this causes problems? No. I made this patch in passing when I was reading vc-dispatcher. -- Best regards, Xue Fuqiao. http://www.gnu.org/software/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 20:01:48 2014 Received: (at 14995) by debbugs.gnu.org; 6 Feb 2014 01:01:48 +0000 Received: from localhost ([127.0.0.1]:51633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDLg-0008UH-8z for submit@debbugs.gnu.org; Wed, 05 Feb 2014 20:01:48 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:60362) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDLd-0008U9-RN for 14995@debbugs.gnu.org; Wed, 05 Feb 2014 20:01:46 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WBDLN-00085X-8q; Thu, 06 Feb 2014 02:01:29 +0100 From: Lars Ingebrigtsen To: Xue Fuqiao Subject: Re: bug#14995: [PATCH] vc-do-command ignores symbolic links References: Date: Wed, 05 Feb 2014 17:00:26 -0800 In-Reply-To: (Xue Fuqiao's message of "Thu, 1 Aug 2013 06:38:57 +0800") Message-ID: <87k3d9xdg5.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WBDLN-00085X-8q X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392253289.75086@gXZPe6Hflyg+y4bnhYgyrQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14995 Cc: Stefan Monnier , 14995@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Xue Fuqiao writes: >> I'm not completely sure this fix is needed (and I'd rather avoid >> calling file-truename, if possible). Do you have a concrete case where >> this causes problems? > > No. I made this patch in passing when I was reading vc-dispatcher. Then I guess this can be closed. If there is a bug here, please reopen this report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 05 20:01:55 2014 Received: (at control) by debbugs.gnu.org; 6 Feb 2014 01:01:56 +0000 Received: from localhost ([127.0.0.1]:51636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDLn-0008Ug-Li for submit@debbugs.gnu.org; Wed, 05 Feb 2014 20:01:55 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:60369) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBDLm-0008UX-FY for control@debbugs.gnu.org; Wed, 05 Feb 2014 20:01:54 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WBDLY-00085h-G1 for control@debbugs.gnu.org; Thu, 06 Feb 2014 02:01:40 +0100 Date: Wed, 05 Feb 2014 17:00:37 -0800 Message-Id: <87iostxdfu.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #14995 X-MailScanner-ID: 1WBDLY-00085h-G1 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392253301.36788@RUKTtzfCEG6WWh/0mVJznQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 14995 From unknown Thu Sep 11 16:39:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 06 Mar 2014 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator