GNU bug report logs - #14991
distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS

Previous Next

Package: automake;

Reported by: Akim Demaille <akim <at> lrde.epita.fr>

Date: Wed, 31 Jul 2013 07:39:02 UTC

Severity: normal

Tags: patch

Done: Stefano Lattarini <stefano.lattarini <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Akim Demaille <akim <at> lrde.epita.fr>
To: Automake Bugs <bug-automake <at> gnu.org>
Subject: distcheck passes --prefix to configure before
 *DISTCHECK_CONFIGURE_FLAGS
Date: Wed, 31 Jul 2013 09:37:32 +0200
Hi!

Admittedly, what prompts this report is arguably a bug in
a package: It passes _all_ the configure flags to
AM_DISTCHECK_CONFIGURE_FLAGS.  Not a bright idea I guess,
but simple.

Unfortunately distcheck reads:

# This target untars the dist file and tries a VPATH configuration.  Then
# it guarantees that the distribution is self-contained by making another
# tarfile.
distcheck: dist
	case '$(DIST_ARCHIVES)' in \
	*.tar.gz*) \
…
	  && ../configure --srcdir=.. --prefix="$$dc_install_base" \
	    $(AM_DISTCHECK_CONFIGURE_FLAGS) \
	    $(DISTCHECK_CONFIGURE_FLAGS) \
	  && $(MAKE) $(AM_MAKEFLAGS) \

So the "local" flags, --srcdir and especially --prefix, are
provided by distcheck, and then overridden by the user's
DISTCHECK_CONFIGURE_FLAGS.  Since I use --prefix, boom.

Very much agreed, --prefix should not have made it into
(AM_)DISTCHECK_CONFIGURE_FLAGS; however it seems simple to
just pass --srcdir and --prefix last to be protected against
such cases.

Thanks!





This bug report was last modified 11 years and 288 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.