From unknown Thu Sep 11 06:33:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14991 <14991@debbugs.gnu.org> To: bug#14991 <14991@debbugs.gnu.org> Subject: Status: distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS Reply-To: bug#14991 <14991@debbugs.gnu.org> Date: Thu, 11 Sep 2025 13:33:53 +0000 retitle 14991 distcheck passes --prefix to configure before *DISTCHECK_CONF= IGURE_FLAGS reassign 14991 automake submitter 14991 Akim Demaille severity 14991 normal tag 14991 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 31 03:38:05 2013 Received: (at submit) by debbugs.gnu.org; 31 Jul 2013 07:38:05 +0000 Received: from localhost ([127.0.0.1]:59904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4Qyy-0003OY-4Z for submit@debbugs.gnu.org; Wed, 31 Jul 2013 03:38:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46009) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4Qyv-0003NZ-8l for submit@debbugs.gnu.org; Wed, 31 Jul 2013 03:38:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4Qyh-0007z9-50 for submit@debbugs.gnu.org; Wed, 31 Jul 2013 03:37:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-99.2 required=5.0 tests=BAYES_50,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4Qyh-0007yv-0g for submit@debbugs.gnu.org; Wed, 31 Jul 2013 03:37:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4Qya-0006xQ-T6 for bug-automake@gnu.org; Wed, 31 Jul 2013 03:37:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4QyU-0007uw-UE for bug-automake@gnu.org; Wed, 31 Jul 2013 03:37:40 -0400 Received: from sao-paulo.lrde.epita.fr ([163.5.55.1]:45528 helo=kaboul.lrde.epita.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4QyU-0007ua-Mc for bug-automake@gnu.org; Wed, 31 Jul 2013 03:37:34 -0400 Received: from erebus.lrde.epita.fr (erebus.lrde.epita.fr [192.168.101.165]) by kaboul.lrde.epita.fr (Postfix) with ESMTPSA id 2973D452CA for ; Wed, 31 Jul 2013 09:37:32 +0200 (CEST) From: Akim Demaille Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS Message-Id: Date: Wed, 31 Jul 2013 09:37:32 +0200 To: Automake Bugs Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) X-Mailer: Apple Mail (2.1508) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi! Admittedly, what prompts this report is arguably a bug in a package: It passes _all_ the configure flags to AM_DISTCHECK_CONFIGURE_FLAGS. Not a bright idea I guess, but simple. Unfortunately distcheck reads: # This target untars the dist file and tries a VPATH configuration. = Then # it guarantees that the distribution is self-contained by making = another # tarfile. distcheck: dist case '$(DIST_ARCHIVES)' in \ *.tar.gz*) \ =85 && ../configure --srcdir=3D.. --prefix=3D"$$dc_install_base" \ $(AM_DISTCHECK_CONFIGURE_FLAGS) \ $(DISTCHECK_CONFIGURE_FLAGS) \ && $(MAKE) $(AM_MAKEFLAGS) \ So the "local" flags, --srcdir and especially --prefix, are provided by distcheck, and then overridden by the user's DISTCHECK_CONFIGURE_FLAGS. Since I use --prefix, boom. Very much agreed, --prefix should not have made it into (AM_)DISTCHECK_CONFIGURE_FLAGS; however it seems simple to just pass --srcdir and --prefix last to be protected against such cases. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 30 18:02:42 2013 Received: (at 14991) by debbugs.gnu.org; 30 Oct 2013 22:02:42 +0000 Received: from localhost ([127.0.0.1]:53627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vbdqa-0007qP-Tm for submit@debbugs.gnu.org; Wed, 30 Oct 2013 18:02:41 -0400 Received: from mail-we0-f177.google.com ([74.125.82.177]:39575) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbdqX-0007q5-JV; Wed, 30 Oct 2013 18:02:38 -0400 Received: by mail-we0-f177.google.com with SMTP id x55so1897956wes.36 for ; Wed, 30 Oct 2013 15:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; bh=QVCnE6qCpdL2LaHWlmDrgXbYKZdptZnC+UJcqmpMp5k=; b=TY0w726lcMSMQebATRXXMWkEMt5p5L8Qkqc2Kjy2K63by2uYmWqIBW263U/l0rHTBA 89ARUf+vTOqPFO1lFjqaTvy1lMGUQ35I9YyzrYMrSPfwZAVUM8C7uBCRBYInT5z69/97 5FanbfwkhgpO9QLd22a8wdsV884A8C7CD+BcYbRffmVCsuUhsnOoSyziY+l5tVOwOqtJ 3/QyC1F5YYL24xKojJSksD8BSvRQ46BKcqhLKe051MIi9BUg5We8Q5rt+Jx7isXGiCgR oU4WMIQNJt7tVaTn7XDkG+K/QZJd8GTVwfS9fgqZXSr77CLbnrqt9om6NMGM+Uprtkm5 dpHQ== X-Received: by 10.180.160.147 with SMTP id xk19mr4071388wib.30.1383170551520; Wed, 30 Oct 2013 15:02:31 -0700 (PDT) Received: from [192.168.1.11] ([79.97.144.61]) by mx.google.com with ESMTPSA id ft19sm314102wic.5.2013.10.30.15.02.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Oct 2013 15:02:30 -0700 (PDT) Message-ID: <527181F4.9000809@gmail.com> Date: Wed, 30 Oct 2013 22:02:28 +0000 From: Stefano Lattarini MIME-Version: 1.0 To: Akim Demaille Subject: Re: bug#14991: distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------060307060008030105040401" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14991 Cc: 14991@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------060307060008030105040401 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reference: tags 14991 + patch close 14991 thanks On 07/31/2013 08:37 AM, Akim Demaille wrote: > Hi! > Hi Akim, thanks for the report, and sorry for the awful delay. > Admittedly, what prompts this report is arguably a bug in > a package: It passes _all_ the configure flags to > AM_DISTCHECK_CONFIGURE_FLAGS. Not a bright idea I guess, > but simple. > > Unfortunately distcheck reads: > > # This target untars the dist file and tries a VPATH configuration. Then > # it guarantees that the distribution is self-contained by making another > # tarfile. > distcheck: dist > case '$(DIST_ARCHIVES)' in \ > *.tar.gz*) \ > … > && ../configure --srcdir=.. --prefix="$$dc_install_base" \ > $(AM_DISTCHECK_CONFIGURE_FLAGS) \ > $(DISTCHECK_CONFIGURE_FLAGS) \ > && $(MAKE) $(AM_MAKEFLAGS) \ > > So the "local" flags, --srcdir and especially --prefix, are > provided by distcheck, and then overridden by the user's > DISTCHECK_CONFIGURE_FLAGS. Since I use --prefix, boom. > > Very much agreed, --prefix should not have made it into > (AM_)DISTCHECK_CONFIGURE_FLAGS; however it seems simple to > just pass --srcdir and --prefix last to be protected against > such cases. > I agree. The code in "make distcheck" implicitly assumes that the values for --srcdir and --prefix it defines cannot be changed, so it makes no sense to allow them to be overridden. I've fixed the issue with the two attached patches, that will appear in Automake 1.14.1 (someday when I'll actually get around to release it ;-). I will wait some time before pushing the patches out, so a review is welcome. Regards, Stefano --------------060307060008030105040401 Content-Type: text/x-patch; name="0001-tests-expose-bug-14991-relates-to-distcheck.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-tests-expose-bug-14991-relates-to-distcheck.patch" >From 608d1a7908893b2896f5efd2a4ed22d7901262ed Mon Sep 17 00:00:00 2001 Message-Id: <608d1a7908893b2896f5efd2a4ed22d7901262ed.1383170503.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Wed, 30 Oct 2013 21:02:14 +0000 Subject: [PATCH 1/2] tests: expose bug#14991 (relates to 'distcheck') * t/distcheck-no-prefix-or-srcdir-override.sh: New, expose the bug. * t/list-of-tests.mk (handwritten_TESTS, XFAIL_TESTS): Add it. Signed-off-by: Stefano Lattarini --- t/distcheck-no-prefix-or-srcdir-override.sh | 60 +++++++++++++++++++++++++++++ t/list-of-tests.mk | 2 + 2 files changed, 62 insertions(+) create mode 100644 t/distcheck-no-prefix-or-srcdir-override.sh diff --git a/t/distcheck-no-prefix-or-srcdir-override.sh b/t/distcheck-no-prefix-or-srcdir-override.sh new file mode 100644 index 0000000..9b9a56f --- /dev/null +++ b/t/distcheck-no-prefix-or-srcdir-override.sh @@ -0,0 +1,60 @@ +#! /bin/sh +# Copyright (C) 2013 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Check that "make distcheck" overrides any --srcdir or --prefix flag +# (mistakenly) defined in $(AM_DISTCHECK_CONFIGURE_FLAGS) or +# $(DISTCHECK_CONFIGURE_FLAGS). See automake bug#14991. + +. test-init.sh + +echo AC_OUTPUT >> configure.ac + +orig_cwd=$(pwd); export orig_cwd + +cat > Makefile.am << 'END' +# configure should choke on non-absolute prefix or non-existent +# srcdir. We'll sanity-check that later. +AM_DISTCHECK_CONFIGURE_FLAGS = --srcdir am-src --prefix am-pfx +END + +# Same comments as above applies. +DISTCHECK_CONFIGURE_FLAGS='--srcdir user-src --prefix user-pfx' +export DISTCHECK_CONFIGURE_FLAGS + +$ACLOCAL +$AUTOMAKE +$AUTOCONF + +# Sanity check: configure should choke on non-absolute prefix +# or non-existent srcdir. +./configure --prefix foobar 2>stderr && { cat stderr >&2; exit 99; } +cat stderr >&2 +grep "expected an absolute directory name for --prefix" stderr || exit 99 +./configure --srcdir foobar 2>stderr && { cat stderr >&2; exit 99; } +cat stderr >&2 +grep "cannot find sources.* in foobar" stderr || exit 99 + +./configure +run_make -E -O distcheck +test ! -s stderr +# Sanity check: the flags have been actually seen. +$PERL -e 'undef $/; $_ = <>; s/ \\\n/ /g; print;' t +grep '/configure .* --srcdir am-src' t || exit 99 +grep '/configure .* --prefix am-pfx' t || exit 99 +grep '/configure .* --srcdir user-src' t || exit 99 +grep '/configure .* --prefix user-pfx' t || exit 99 + +: diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index 9069b08..8bdbdc0 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -35,6 +35,7 @@ t/gcj6.sh \ t/override-conditional-2.sh \ t/override-conditional-pr13940.sh \ t/dist-pr109765.sh \ +t/distcheck-no-prefix-or-srcdir-override.sh \ t/instdir-cond2.sh \ t/java-nobase.sh \ t/objext-pr10128.sh \ @@ -422,6 +423,7 @@ t/distcheck-hook2.sh \ t/distcheck-writable-srcdir.sh \ t/distcheck-missing-m4.sh \ t/distcheck-outdated-m4.sh \ +t/distcheck-no-prefix-or-srcdir-override.sh \ t/distcheck-override-infodir.sh \ t/distcheck-pr9579.sh \ t/distcheck-pr10470.sh \ -- 1.8.3.1.605.g85318f5 --------------060307060008030105040401 Content-Type: text/x-patch; name="0002-distcheck-don-t-allow-overriding-of-prefix-and-srcdi.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0002-distcheck-don-t-allow-overriding-of-prefix-and-srcdi.pa"; filename*1="tch" >From cab362eee5f19c02ed6719449d1d27644f8ffc93 Mon Sep 17 00:00:00 2001 Message-Id: In-Reply-To: <608d1a7908893b2896f5efd2a4ed22d7901262ed.1383170503.git.stefano.lattarini@gmail.com> References: <608d1a7908893b2896f5efd2a4ed22d7901262ed.1383170503.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Wed, 30 Oct 2013 21:41:39 +0000 Subject: [PATCH 2/2] distcheck: don't allow overriding of --prefix and --srcdir by the user Not trough AM_DISTCHECK_FLAGS, nor through DISTCHECK_FLAGS. Apparently, some packages got in the habit of relaying all the options passed to the original ./configure invocation through to the configure invocations in "make distcheck". This was causing problems, because it also passed through the original --srcdir and --prefix options. Fixes: expose bug#14991 (relates to 'distcheck') * lib/am/distdir.am (distcheck): Pass the hard-coded --srcdir and --prefix options *after* both the developer-defined options in $(AM_DISTCHECK_FLAGS) and the user-defined options in $(DISTCHECK_FLAGS). * t/list-of-tests.mk (XFAIL_TESTS): Remove the now-passing test 'distcheck-no-destdist-or-srcdir-override.sh'. * doc/automake.texi (Checking the Distribution): Update. * NEWS: Likewise. Signed-off-by: Stefano Lattarini --- NEWS | 3 +++ doc/automake.texi | 17 ++++++++++++----- lib/am/distdir.am | 11 +++++++---- t/list-of-tests.mk | 1 - 4 files changed, 22 insertions(+), 10 deletions(-) diff --git a/NEWS b/NEWS index aaec7c0..77dcbbc 100644 --- a/NEWS +++ b/NEWS @@ -108,6 +108,9 @@ New in 1.14.1: * Bugs fixed: + - The user is no longer allowed to override the --srcdir nor the --prefix + configure options used by "make distcheck" (bug#14991). + - Fixed a gross inefficiency in the recipes for installing byte-compiled python files, that was causing an O(N^2) performance on the number N of files, instead of the expected O(N) performance. Note that this bug diff --git a/doc/automake.texi b/doc/automake.texi index 62728d4..cd33ad7 100644 --- a/doc/automake.texi +++ b/doc/automake.texi @@ -8556,11 +8556,18 @@ to supply additional flags to @command{configure}, define them in the @file{Makefile.am}. The user can still extend or override the flags provided there by defining the @code{DISTCHECK_CONFIGURE_FLAGS} variable, on the command line when invoking @command{make}. - -Still, developers are encouraged to strive to make their code buildable -without requiring any special configure option; thus, in general, you -shouldn't define @code{AM_DISTCHECK_CONFIGURE_FLAGS}. However, there -might be few scenarios in which the use of this variable is justified. +@c See automake bug#14991 for more details about how the following holds. +It's worth nothing that @command{make distcheck} needs complete control +over the @command{configure} options @option{--srcdir} and +@option{--prefix}, so those options cannot be overridden by +@code{AM_DISTCHECK_CONFIGURE_FLAGS} nor by +@code{DISTCHECK_CONFIGURE_FLAGS}. + +Also note that developers are encouraged to strive to make their code +buildable without requiring any special configure option; thus, in +general, you shouldn't define @code{AM_DISTCHECK_CONFIGURE_FLAGS}. +However, there might be few scenarios in which the use of this variable +is justified. GNU @command{m4} offers an example. GNU @command{m4} configures by default with its experimental and seldom used "changeword" feature disabled; so in its case it is useful to have @command{make distcheck} diff --git a/lib/am/distdir.am b/lib/am/distdir.am index f354987..a8ad63c 100644 --- a/lib/am/distdir.am +++ b/lib/am/distdir.am @@ -452,13 +452,16 @@ distcheck: dist ## so be sure to 'cd' back to the original directory after this. && am__cwd=`pwd` \ && $(am__cd) $(distdir)/_build \ - && ../configure --srcdir=.. --prefix="$$dc_install_base" \ + && ../configure \ ?GETTEXT? --with-included-gettext \ -## Additional flags for configure. Keep this last in the configure -## invocation so the developer and user can override previous options, -## and let the user's flags take precedence over the developer's ones. +## Additional flags for configure. $(AM_DISTCHECK_CONFIGURE_FLAGS) \ $(DISTCHECK_CONFIGURE_FLAGS) \ +## At the moment, the code doesn't actually support changes in these --srcdir +## and --prefix values, so don't allow them to be overridden by the user or +## the developer. That used to be allowed, and caused issues in practice +## (in corner-case usages); see automake bug#14991. + --srcdir=.. --prefix="$$dc_install_base" \ && $(MAKE) $(AM_MAKEFLAGS) \ && $(MAKE) $(AM_MAKEFLAGS) dvi \ && $(MAKE) $(AM_MAKEFLAGS) check \ diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index 8bdbdc0..75f303a 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -35,7 +35,6 @@ t/gcj6.sh \ t/override-conditional-2.sh \ t/override-conditional-pr13940.sh \ t/dist-pr109765.sh \ -t/distcheck-no-prefix-or-srcdir-override.sh \ t/instdir-cond2.sh \ t/java-nobase.sh \ t/objext-pr10128.sh \ -- 1.8.3.1.605.g85318f5 --------------060307060008030105040401-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 30 18:10:25 2013 Received: (at 14991) by debbugs.gnu.org; 30 Oct 2013 22:10:25 +0000 Received: from localhost ([127.0.0.1]:53647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vbdy3-00082I-HN for submit@debbugs.gnu.org; Wed, 30 Oct 2013 18:10:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19130) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vbdy0-000827-9G for 14991@debbugs.gnu.org; Wed, 30 Oct 2013 18:10:21 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9UMAJSh027456 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 30 Oct 2013 18:10:19 -0400 Received: from [10.3.113.175] (ovpn-113-175.phx2.redhat.com [10.3.113.175]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9UMAIhq023608; Wed, 30 Oct 2013 18:10:18 -0400 Message-ID: <527183CA.6000606@redhat.com> Date: Wed, 30 Oct 2013 16:10:18 -0600 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Stefano Lattarini , Akim Demaille Subject: Re: bug#14991: distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS References: <527181F4.9000809@gmail.com> In-Reply-To: <527181F4.9000809@gmail.com> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ELxpW8OXBUnRKNoXA9rTQpBsSrE7TPvD2" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 14991 Cc: 14991@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ELxpW8OXBUnRKNoXA9rTQpBsSrE7TPvD2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/30/2013 04:02 PM, Stefano Lattarini wrote: > Subject: [PATCH 2/2] distcheck: don't allow overriding of --prefix and > --srcdir by the user >=20 > Not trough AM_DISTCHECK_FLAGS, nor through DISTCHECK_FLAGS. Apparently= , s/trough/through/ > some packages got in the habit of relaying all the options passed to th= e > original ./configure invocation through to the configure invocations > in "make distcheck". This was causing problems, because it also passed= > through the original --srcdir and --prefix options. >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ELxpW8OXBUnRKNoXA9rTQpBsSrE7TPvD2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJScYPKAAoJEKeha0olJ0NqsiUH/A324US104j+RYjcnUUqtPNk L8S8akTL+mpz8sohtpaj1+HtZSvlVPsWJlQVN79HXVu8NYzxYjTjehxXCuSeGCYz N1NoxmgRBeZBmUJfKf7R5t8hsN+tjhk3DC7YQt5jjxtpJG35pDgftKMfLvQn3AVB DLaBchYDHHWYBDXSU+qxxghhTTG1cWgsJYi3qAW2Izx7F1mbFiBcQVvsspIRwjR4 TS1GyPGesPpV6ATPRqmB6tl9y9sgGFbB2nF7EcLGptmhS0L/0Gl8xjRcqXFmfalJ E2ZDF6sIy7vap73GtlIHZ7IKMamsIe0RYGiaUr+OIDHc0Fw8by2w2kWFppu8Aig= =b+Bu -----END PGP SIGNATURE----- --ELxpW8OXBUnRKNoXA9rTQpBsSrE7TPvD2-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 30 18:26:37 2013 Received: (at 14991) by debbugs.gnu.org; 30 Oct 2013 22:26:37 +0000 Received: from localhost ([127.0.0.1]:53671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbeDl-00014e-0p for submit@debbugs.gnu.org; Wed, 30 Oct 2013 18:26:37 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:56444) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbeDj-00014S-T5 for 14991@debbugs.gnu.org; Wed, 30 Oct 2013 18:26:36 -0400 Received: by mail-wi0-f182.google.com with SMTP id ez12so2164352wid.15 for <14991@debbugs.gnu.org>; Wed, 30 Oct 2013 15:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=9T2ijyeZ73rdU8/66MLOh4ot2r26qCS78dJUsS2KIf8=; b=M2ampN5fnZpw6eXXGtyH9gGqoF8mg3AcpucY77fqDbgUSVIYMo2PQGmf1+GnWkqucX GqXbnj06CO6FT7YIBVtQgBBWvaDSHCeYqGfE4BYOm9g2fovIZtm6RXqEDxaMZVvphCik 0XG7ODQS99vUl6sRGqgMMiO/tvJOynLKaZv616UVUHe5q6C+r5wO7A6Ru4O3mXPBwgrH Iw3j748cHXr2xOzCbLfK/DpYTeaa5+meeUgWojwAGuM/gO+MgmYHxD1Vu5+3IrHLj/TU +AMDXpajwbWMBZK7RM8TShcLSB1icOKhv0joH6rTKIJUETT9uEkGaF/BdTH1s6LYzAgE UiYw== X-Received: by 10.180.83.228 with SMTP id t4mr69539wiy.12.1383171990239; Wed, 30 Oct 2013 15:26:30 -0700 (PDT) Received: from [192.168.1.11] ([79.97.144.61]) by mx.google.com with ESMTPSA id bs15sm20122187wib.10.2013.10.30.15.26.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Oct 2013 15:26:29 -0700 (PDT) Message-ID: <52718793.8030903@gmail.com> Date: Wed, 30 Oct 2013 22:26:27 +0000 From: Stefano Lattarini MIME-Version: 1.0 To: Eric Blake Subject: Re: bug#14991: distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS References: <527181F4.9000809@gmail.com> <527183CA.6000606@redhat.com> In-Reply-To: <527183CA.6000606@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14991 Cc: 14991@debbugs.gnu.org, Akim Demaille , "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 10/30/2013 10:10 PM, Eric Blake wrote: > On 10/30/2013 04:02 PM, Stefano Lattarini wrote: > >> Subject: [PATCH 2/2] distcheck: don't allow overriding of --prefix and >> --srcdir by the user >> >> Not trough AM_DISTCHECK_FLAGS, nor through DISTCHECK_FLAGS. Apparently, > > s/trough/through/ > Thanks, fixed. Stefano From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 31 04:25:45 2013 Received: (at 14991) by debbugs.gnu.org; 31 Oct 2013 08:25:45 +0000 Received: from localhost ([127.0.0.1]:53986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbnZY-0008EJ-Rt for submit@debbugs.gnu.org; Thu, 31 Oct 2013 04:25:45 -0400 Received: from sao-paulo.lrde.epita.fr ([163.5.55.1]:38789 helo=kaboul.lrde.epita.fr) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbnZQ-0008Dt-Ef for 14991@debbugs.gnu.org; Thu, 31 Oct 2013 04:25:39 -0400 Received: from erebus.lrde.epita.fr (erebus.lrde.epita.fr [192.168.101.165]) by kaboul.lrde.epita.fr (Postfix) with ESMTPSA id 319B045E16; Thu, 31 Oct 2013 09:25:30 +0100 (CET) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: bug#14991: distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS From: Akim Demaille In-Reply-To: <527181F4.9000809@gmail.com> Date: Thu, 31 Oct 2013 09:25:30 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <527181F4.9000809@gmail.com> To: Stefano Lattarini X-Mailer: Apple Mail (2.1510) X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 14991 Cc: 14991@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi Stefano! Le 30 oct. 2013 =E0 23:02, Stefano Lattarini = a =E9crit : > I've fixed the issue with the two attached patches, that will appear > in Automake 1.14.1 (someday when I'll actually get around to release > it ;-). I will wait some time before pushing the patches out, so a > review is welcome. It looks fine, thanks!= From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 01 22:47:31 2013 Received: (at 14991) by debbugs.gnu.org; 2 Nov 2013 02:47:31 +0000 Received: from localhost ([127.0.0.1]:58460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VcRFL-0004pp-49 for submit@debbugs.gnu.org; Fri, 01 Nov 2013 22:47:31 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:38806) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VcRFI-0004pY-4d for 14991@debbugs.gnu.org; Fri, 01 Nov 2013 22:47:28 -0400 Received: by mail-wg0-f46.google.com with SMTP id m15so234960wgh.13 for <14991@debbugs.gnu.org>; Fri, 01 Nov 2013 19:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=63gDYQHg5zcRFiFSq7Na6lkQx6pheBdc8gvDmmCe4o8=; b=ylbpHAzRGrkK+B+TNXgjXE/PS4mDSlgkQKm3OHtyYRsqNs1EWhRZkWFnibKAwtQg+c xASCHsP7PdxHge5cAeFCwZAA0urDVBj4teY/z8R/i4Ox/xWgXn4V8Ebm6SDE75q3rRYq 6IAbdRfLklN3xCWJTvrdduDDNX4Tpf7ssKY3gMfsJ4qLvoi6gcLzC83dpacI4XWeRd+e pxLa4bymej5ECDoZpsJVHaSUPzMhIsF/cQFOhWAWmpZx10IobZFVgbaVG5yYsO2G37Ru lhK4+1RyhByZoYbV9EIeNkw9i/mOg6iKdGe+XlkPyHhfsWjCmUJZJ2l+2tlk70qYueU+ ORxw== X-Received: by 10.180.83.228 with SMTP id t4mr4301586wiy.12.1383360441993; Fri, 01 Nov 2013 19:47:21 -0700 (PDT) Received: from [192.168.1.11] ([79.97.144.61]) by mx.google.com with ESMTPSA id gg20sm664968wic.1.2013.11.01.19.47.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 01 Nov 2013 19:47:21 -0700 (PDT) Message-ID: <5274679E.3080500@gmail.com> Date: Sat, 02 Nov 2013 02:46:54 +0000 From: Stefano Lattarini MIME-Version: 1.0 To: Akim Demaille Subject: Re: bug#14991: distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS References: <527181F4.9000809@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14991 Cc: 14991@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 10/31/2013 08:25 AM, Akim Demaille wrote: > Hi Stefano! > > Le 30 oct. 2013 à 23:02, Stefano Lattarini a écrit : > >> I've fixed the issue with the two attached patches, that will appear >> in Automake 1.14.1 (someday when I'll actually get around to release >> it ;-). I will wait some time before pushing the patches out, so a >> review is welcome. > > It looks fine, thanks! > Pushed. Thanks, Stefano From unknown Thu Sep 11 06:33:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 30 Nov 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator