GNU bug report logs - #14989
24.3.50; log-view-diff and log-view-diff-changeset default to different `to' revisions for git merge commits

Previous Next

Package: emacs;

Reported by: Dmitry Gutov <dgutov <at> yandex.ru>

Date: Tue, 30 Jul 2013 22:44:01 UTC

Severity: normal

Found in version 24.3.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 14989 <at> debbugs.gnu.org
Subject: bug#14989: 24.3.50; log-view-diff and log-view-diff-changeset default to different `to' revisions for git merge commits
Date: Tue, 30 Jul 2013 21:38:03 -0400

> This fix is simple enough. Apply?

Looks good, thanks.

> The functions could also use some further cleanup:
> 1) Swap the `to' and `fr' local variables.

I think that would make sense, yes.

> 2) Extract the function bodies to one function with a third argument
> (called `whole-changeset', maybe), and make them call it.

If that can be done without too much extra code, that sounds good.


        Stefan
This bug report was last modified 12 years and 16 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.