GNU bug report logs - #14989
24.3.50; log-view-diff and log-view-diff-changeset default to different `to' revisions for git merge commits

Previous Next

Full log

Message #13 received at 14989-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 14989-done <at> debbugs.gnu.org
Subject: Re: bug#14989: 24.3.50; log-view-diff and log-view-diff-changeset
 default to different `to' revisions for git merge commits
Date: Wed, 31 Jul 2013 15:26:45 +0300

Done!

On 31.07.2013 04:38, Stefan Monnier wrote:
>> This fix is simple enough. Apply?
>
> Looks good, thanks.
>
>> The functions could also use some further cleanup:
>> 1) Swap the `to' and `fr' local variables.
>
> I think that would make sense, yes.
>
>> 2) Extract the function bodies to one function with a third argument
>> (called `whole-changeset', maybe), and make them call it.
>
> If that can be done without too much extra code, that sounds good.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.