GNU bug report logs - #14983
24.3.50; url-http-end-of-document-sentinel does not work with https

Previous Next

Full log

Message #32 received at 14983 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Erik Hetzner <erik.hetzner <at> ucop.edu>
Cc: 14983 <at> debbugs.gnu.org, Andreas Schwab <schwab <at> suse.de>
Subject: Re: bug#14983: 24.3.50; url-http-end-of-document-sentinel does not
 work with https
Date: Tue, 24 Sep 2019 09:58:42 +0200

Erik Hetzner <erik.hetzner <at> ucop.edu> writes:

> -                 (url-http url-current-object url-callback-function
> -                           url-callback-arguments (current-buffer)))))
> +                 (if (string= "https" (url-type url-current-object))
> +                     (url-https url-current-object url-callback-function
> +                                url-callback-arguments (current-buffer))
> +                   (url-http url-current-object url-callback-function
> +                             url-callback-arguments (current-buffer))))))

The code has changed in the meantime, so I applied the following patch
instead:

diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index bfc106c2a5..a6963cef70 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -1024,7 +1024,9 @@ url-http-end-of-document-sentinel
                    (setq url-using-proxy
                          (url-generic-parse-url url-using-proxy)))
                  (url-http url-current-object url-callback-function
-                           url-callback-arguments (current-buffer)))))
+                           url-callback-arguments (current-buffer)
+                           (and (string= "https" (url-type url-current-object))
+                                'tls)))))
 	    ((url-http-parse-headers)
 	     (url-http-activate-callback))))))
 


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.