GNU bug report logs - #14983
24.3.50; url-http-end-of-document-sentinel does not work with https

Previous Next

Full log

Message #23 received at 14983 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 14983 <at> debbugs.gnu.org, Andreas Schwab <schwab <at> suse.de>,
 Erik Hetzner <erik.hetzner <at> ucop.edu>
Subject: Re: bug#14983: 24.3.50;
 url-http-end-of-document-sentinel does not work with https
Date: Mon, 20 May 2019 14:56:03 -0400

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Erik Hetzner <erik.hetzner <at> ucop.edu> writes:
>
>> This patch modifies url-https to support an optional retry-buffer
>> argument, making this better approach possible.
>>
>> diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
>> index 7f21a38..868b6ff 100644
>> --- a/lisp/url/url-http.el
>> +++ b/lisp/url/url-http.el
>> @@ -895,8 +895,11 @@ should be shown to the user."
>>                 (let ((url-request-method url-http-method)
>>                       (url-request-extra-headers url-http-extra-headers)
>>                       (url-request-data url-http-data))
>> -                 (url-http url-current-object url-callback-function
>> -                           url-callback-arguments (current-buffer)))))
>> +                 (if (string= "https" (url-type url-current-object))
>> +                     (url-https url-current-object url-callback-function
>> +                                url-callback-arguments (current-buffer))
>> +                   (url-http url-current-object url-callback-function
>> +                             url-callback-arguments (current-buffer))))))
>>  	    ((url-http-parse-headers)
>>  	     (url-http-activate-callback))))))
>>  
>> @@ -1432,7 +1435,7 @@ p3p
>>         ,@(remove '&rest (remove '&optional args))))))
>>  
>>  ;;;###autoload (autoload 'url-https "url-http")
>> -(url-https-create-secure-wrapper nil (url callback cbargs))
>> +(url-https-create-secure-wrapper nil (url callback cbargs &optional retry-buffer))
>
> I think this looks sensible, but the patch it two years old, so I wonder
> whether there was a reason it wasn't applied back then?  Or whether this
> was fixed a different way?

As far as I can tell, there's nothing wrong with the patch, and the
problem wasn't fixed in some other way.

Minor question on the copyright situation, it looks like Erik Hetzner is
on the list, but the email is different and there are some other middle
names.  Is it the same person? (the patch is small enough to apply
regardless though)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.