GNU bug report logs - #14983
24.3.50; url-http-end-of-document-sentinel does not work with https

Previous Next

Full log

Message #20 received at 14983 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Erik Hetzner <erik.hetzner <at> ucop.edu>
Cc: 14983 <at> debbugs.gnu.org, Andreas Schwab <schwab <at> suse.de>
Subject: Re: bug#14983: 24.3.50;
 url-http-end-of-document-sentinel does not work with https
Date: Fri, 25 Dec 2015 22:03:35 +0100

Erik Hetzner <erik.hetzner <at> ucop.edu> writes:

> This patch modifies url-https to support an optional retry-buffer
> argument, making this better approach possible.
>
> diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
> index 7f21a38..868b6ff 100644
> --- a/lisp/url/url-http.el
> +++ b/lisp/url/url-http.el
> @@ -895,8 +895,11 @@ should be shown to the user."
>                 (let ((url-request-method url-http-method)
>                       (url-request-extra-headers url-http-extra-headers)
>                       (url-request-data url-http-data))
> -                 (url-http url-current-object url-callback-function
> -                           url-callback-arguments (current-buffer)))))
> +                 (if (string= "https" (url-type url-current-object))
> +                     (url-https url-current-object url-callback-function
> +                                url-callback-arguments (current-buffer))
> +                   (url-http url-current-object url-callback-function
> +                             url-callback-arguments (current-buffer))))))
>  	    ((url-http-parse-headers)
>  	     (url-http-activate-callback))))))
>  
> @@ -1432,7 +1435,7 @@ p3p
>         ,@(remove '&rest (remove '&optional args))))))
>  
>  ;;;###autoload (autoload 'url-https "url-http")
> -(url-https-create-secure-wrapper nil (url callback cbargs))
> +(url-https-create-secure-wrapper nil (url callback cbargs &optional retry-buffer))

I think this looks sensible, but the patch it two years old, so I wonder
whether there was a reason it wasn't applied back then?  Or whether this
was fixed a different way?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.