Subject: Re: bug#14983: 24.3.50; url-http-end-of-document-sentinel does not work with https

From: Erik Hetzner <[email-masked]>
Date: Tue, 30 Jul 2013 07:20:01 -0700

At Tue, 30 Jul 2013 10:50:56 +0200,
Andreas Schwab wrote:
> 
> Erik Hetzner <[email-masked]> writes:
> 
> […]
> 
> I think this should use url-https instead for https connections.

This patch modifies url-https to support an optional retry-buffer
argument, making this better approach possible.

diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 7f21a38..868b6ff 100644
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -895,8 +895,11 @@ should be shown to the user."
                (let ((url-request-method url-http-method)
                      (url-request-extra-headers url-http-extra-headers)
                      (url-request-data url-http-data))
-                 (url-http url-current-object url-callback-function
-                           url-callback-arguments (current-buffer)))))
+                 (if (string= "https" (url-type url-current-object))
+                     (url-https url-current-object url-callback-function
+                                url-callback-arguments (current-buffer))
+                   (url-http url-current-object url-callback-function
+                             url-callback-arguments (current-buffer))))))
 	    ((url-http-parse-headers)
 	     (url-http-activate-callback))))))
 
@@ -1432,7 +1435,7 @@ p3p
        ,@(remove '&rest (remove '&optional args))))))
 
 ;;;###autoload (autoload 'url-https "url-http")
-(url-https-create-secure-wrapper nil (url callback cbargs))
+(url-https-create-secure-wrapper nil (url callback cbargs &optional retry-buffer))
 ;;;###autoload (autoload 'url-https-file-exists-p "url-http")
 (url-https-create-secure-wrapper file-exists-p (url))
 ;;;###autoload (autoload 'url-https-file-readable-p "url-http")

best, Erik
Sent from my free software system <http://fsf.org/>.