Subject: Re: bug#14983: 24.3.50; url-http-end-of-document-sentinel does not work with https

From: Erik Hetzner <[email-masked]>
Date: Tue, 30 Jul 2013 07:01:13 -0700

At Tue, 30 Jul 2013 10:50:56 +0200,
Andreas Schwab wrote:
> 
> Erik Hetzner <[email-masked]> writes:
> 
> > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
> > index 7f21a38..4ee9377 100644
> > --- a/lisp/url/url-http.el
> > +++ b/lisp/url/url-http.el
> > @@ -895,6 +895,8 @@ should be shown to the user."
> >                 (let ((url-request-method url-http-method)
> >                       (url-request-extra-headers url-http-extra-headers)
> >                       (url-request-data url-http-data))
> > +                 (if (string= "https" (url-type url-current-object))
> > +                     (setq url-gateway-method 'tls))
> >                   (url-http url-current-object url-callback-function
> >                             url-callback-arguments (current-buffer)))))
> 
> I think this should use url-https instead for https connections.
> 
> Andreas.

Hi Andreas,

That would be a better solution, but url-https does not currently take
a retry-buffer argument:

(url-http URL CALLBACK CBARGS &optional RETRY-BUFFER)
(url-https URL CALLBACK CBARGS)

Maybe it should be modified to pass through an optional retry-buffer?

best, Erik
Sent from my free software system <http://fsf.org/>.