From unknown Tue Aug 19 02:52:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14970 <14970@debbugs.gnu.org> To: bug#14970 <14970@debbugs.gnu.org> Subject: Status: Assertion failure deleting frames Reply-To: bug#14970 <14970@debbugs.gnu.org> Date: Tue, 19 Aug 2025 09:52:56 +0000 retitle 14970 Assertion failure deleting frames reassign 14970 emacs submitter 14970 Juanma Barranquero severity 14970 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 20:23:46 2013 Received: (at submit) by debbugs.gnu.org; 28 Jul 2013 00:23:46 +0000 Received: from localhost ([127.0.0.1]:53540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Em1-0007g7-Qv for submit@debbugs.gnu.org; Sat, 27 Jul 2013 20:23:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45604) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Elz-0007fo-8J for submit@debbugs.gnu.org; Sat, 27 Jul 2013 20:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3Els-0005p1-J0 for submit@debbugs.gnu.org; Sat, 27 Jul 2013 20:23:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-99.2 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3Els-0005ox-Fo for submit@debbugs.gnu.org; Sat, 27 Jul 2013 20:23:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3Elq-0002Cs-5v for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 20:23:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3Elp-0005oL-01 for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 20:23:34 -0400 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:35217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3Elo-0005oB-Pi for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 20:23:32 -0400 Received: by mail-ee0-f41.google.com with SMTP id d17so1750405eek.28 for ; Sat, 27 Jul 2013 17:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=6LI+kqMTvP9vk0NCk72e80EuaoRghLyqgT22SGie2eU=; b=pSxA2xlBRatlzbF/7ZTd/92tlHRCOm+EiTzvQSuk1p16iZwElf2ZNGKKsPW/HCoxxM TBpYpMTSB0THW3mC2QV76xzXeh9hi23FekMvOA7VqYNFOo/E2iQYgOm9XqWTEwYX8zzx PNeJDxN6bljB24sBAxSCPsWDhgeLO5AN0qJCDNrQskWkooboKPyhRE7x4sTZZVFdrc3X xor8kTocFwlfmH+PV1SXCgy0oXzK8A3CQ73twfKNbjgVpTDiZYu3X7e75+TkAmh0YBxj LGbbwEtGpb6uBJTNJgHWPcErmOzZdm3KgT4Sxm1QD/4A3olBBkl99w0UxcVFEgX3Nd90 nJBw== X-Received: by 10.15.36.133 with SMTP id i5mr53731766eev.52.1374971011896; Sat, 27 Jul 2013 17:23:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.15.23.70 with HTTP; Sat, 27 Jul 2013 17:22:51 -0700 (PDT) From: Juanma Barranquero Date: Sun, 28 Jul 2013 02:22:51 +0200 Message-ID: Subject: crash deleting frames To: Bug-Gnu-Emacs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Package: emacs Version: 24.3.50 Context: I'm trying new desktop code to force frames onscreen. To test it, I have a function that creates a fair number of frames (around 15/20) either partially or totally offscreen. Once the new desktop code moves them onscreen, I usually close them all via another interactive test function. But if I try instead to close them by clicking on each window's Close button, sooner or later (after closing 10/15 frames, usually) Emacs crashes. In previous crashes it didn't generate a backtrace, nor did Windows offer to attach a debugger to the crashed program. Also, running under gdb I couldn't reproduce the bug. This is the first time I've been offered to attach gdb. Whatever the reason, something fishy is happening with delete-frame, #0 0x76c7321a in KERNELBASE!DeleteAce () from C:\Windows\syswow64\KernelBase.dll #1 0x011ea460 in emacs_abort () at w32fns.c:8030 #2 0x010db418 in terminate_due_to_signal (sig=22, backtrace_limit=2147483647) at emacs.c:369 #3 0x0115059d in die (msg=0x148470a "WINDOWP (a)", file=0x1484694 "lisp.h", line=798) at alloc.c:6558 #4 0x0114682c in XWINDOW (a=54749210) at lisp.h:798 #5 0x010129af in delete_frame (frame=93052933, force=54749234) at frame.c:1161 #6 0x01013496 in Fdelete_frame (frame=93052933, force=54749234) at frame.c:1451 #7 0x0116dadc in Ffuncall (nargs=3, args=0x88efe4) at eval.c:2819 #8 0x011ae49d in exec_byte_code (bytestr=19842041, vector=19842061, maxdepth=16, args_template=54749210, nargs=0, args=0x0) at bytecode.c:905 #9 0x0116e65c in funcall_lambda (fun=19842013, nargs=1, arg_vector=0x12ec40d) at eval.c:3050 #10 0x0116dcf2 in Ffuncall (nargs=2, args=0x88f320) at eval.c:2865 #11 0x01167794 in Fcall_interactively (function=54934394, record_flag=54749210, keys=90185989) at callint.c:839 #12 0x0116db0b in Ffuncall (nargs=4, args=0x88f54c) at eval.c:2823 #13 0x011ae49d in exec_byte_code (bytestr=19717001, vector=19717021, maxdepth=52, args_template=4100, nargs=4, args=0x88f860) at bytecode.c:905 #14 0x0116e298 in funcall_lambda (fun=19716981, nargs=4, arg_vector=0x88f850) at eval.c:2984 #15 0x0116dcf2 in Ffuncall (nargs=5, args=0x88f84c) at eval.c:2865 #16 0x0116d661 in call4 (fn=54795106, arg1=54934394, arg2=54749210, arg3=90185989, arg4=54749234) at eval.c:2664 #17 0x010e256f in read_char (commandflag=1, map=91059750, prev_event=54749210, used_mouse_menu=0x88fac3, end_time=0x0) at keyboard.c:2923 #18 0x010ee02f in read_key_sequence (keybuf=0x88fbe0, bufsize=30, prompt=54749210, dont_downcase_last=false, can_return_switch_frame=true, fix_current_buffer=true) at keyboard.c:9056 #19 0x010df234 in command_loop_1 () at keyboard.c:1434 #20 0x0116a91f in internal_condition_case (bfun=0x10deebd , handlers=54803674, hfun=0x10de744 ) at eval.c:1302 #21 0x010deb72 in command_loop_2 (ignore=54749210) at keyboard.c:1161 #22 0x0116a239 in internal_catch (tag=54793554, func=0x10deb4e , arg=54749210) at eval.c:1076 #23 0x010deb2a in command_loop () at keyboard.c:1140 #24 0x010de2e1 in recursive_edit_1 () at keyboard.c:779 #25 0x010de49d in Frecursive_edit () at keyboard.c:843 #26 0x010dc76b in main (argc=5, argv=0xc22d98) at emacs.c:1566 Lisp Backtrace: "delete-frame" (0x88efe8) "handle-delete-frame" (0x88f324) "call-interactively" (0x88f550) "command-execute" (0x88f850) (gdb) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 20:26:46 2013 Received: (at control) by debbugs.gnu.org; 28 Jul 2013 00:26:46 +0000 Received: from localhost ([127.0.0.1]:53546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Eov-0007nA-RZ for submit@debbugs.gnu.org; Sat, 27 Jul 2013 20:26:46 -0400 Received: from mail-ea0-f181.google.com ([209.85.215.181]:64324) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Eot-0007mo-KI for control@debbugs.gnu.org; Sat, 27 Jul 2013 20:26:44 -0400 Received: by mail-ea0-f181.google.com with SMTP id d10so1093263eaj.40 for ; Sat, 27 Jul 2013 17:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=0JRTDTC8ORtlmJk0RTZFLGe6RLYGCUHkql4aHitLJpk=; b=W1iKbZi7mwNreGFMgGHJBS1N4FWhcPI9yBu0ohNXx6X/8Xo0zjafptCmTEpQ/+TG1c hwPqCKncvMtwNub6gNlRaz0s8lq+yfI2qPAW9yC4o3aRKt3FIdvjLXzTEDkXiX4fj0HV 1uBIneK7j2RRKX4MHLhSZwqFMVe7EtnAOVWWestKhA7FCuSXx4ui4zL70It2Wdn9o+6/ 05Cbq1K6ZNGnbqpU5K1NEUTXRlFSdyHsgSgXlugJn9MYFmM6bcLKcDm8e0sWfkQnZgCd ehDsvN/EVlka6DvFhrPPdBSVJVPVd/INeJdsfUKYdCnHyuZv4R69vlqhu+hJmoFzZlQJ qHyA== X-Received: by 10.14.224.6 with SMTP id w6mr503774eep.99.1374971197772; Sat, 27 Jul 2013 17:26:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.15.23.70 with HTTP; Sat, 27 Jul 2013 17:25:56 -0700 (PDT) From: Juanma Barranquero Date: Sun, 28 Jul 2013 02:25:56 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 14970 Assertion failure deleting frames quit [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (lekktu[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.181 listed in list.dnswl.org] 2.0 BLANK_SUBJECT Subject is present but empty 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: retitle 14970 Assertion failure deleting frames quit [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.181 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (lekktu[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid retitle 14970 Assertion failure deleting frames quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 21:08:56 2013 Received: (at 14970) by debbugs.gnu.org; 28 Jul 2013 01:08:56 +0000 Received: from localhost ([127.0.0.1]:53573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3FTk-00022p-EV for submit@debbugs.gnu.org; Sat, 27 Jul 2013 21:08:56 -0400 Received: from mail-ea0-f179.google.com ([209.85.215.179]:56008) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3FTh-00022M-UU for 14970@debbugs.gnu.org; Sat, 27 Jul 2013 21:08:54 -0400 Received: by mail-ea0-f179.google.com with SMTP id b15so2274872eae.10 for <14970@debbugs.gnu.org>; Sat, 27 Jul 2013 18:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=CMpEGQRRNlJ4j9uXZwBdYGiTfsSuvp+5YQh6a3v7eZE=; b=JGmMXAApG8wuZwl0DRpeEgLOCSa34Zd0jIvHCz9yqvl8OEbWSYOWF/yuwPNRi9vSq3 wocA64tEsu/XWCINBs443GHKJ6rTKgK/xuFpNQFjAq5oAszRbEYjynO+IKNkv+j3b9QQ MR2uWqvDzQRjDOfaKNskMIq+EZfaTVFkqK1iE+pSfDObyst1js3lQXjZ5IDsRIhP1N1+ g1+PruM/xJO81sdczNeWtPxPv4p/Y1ILgsIoVtuwAxUK5JMOFKNUOSxuOTkv8E0qup9b tIetAUMmjfcQzh1LQxWWGU+70Q7d+vBsIcrwDxlFOqmePeLV4Yz/pEX4/CY9dh+OwPHm 2KkA== X-Received: by 10.15.111.69 with SMTP id ci45mr3693667eeb.14.1374973728154; Sat, 27 Jul 2013 18:08:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.15.23.70 with HTTP; Sat, 27 Jul 2013 18:08:08 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Sun, 28 Jul 2013 03:08:08 +0200 Message-ID: Subject: Re: bug#14970: crash deleting frames To: 14970@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 14970 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) A crash, while closing a maximized frame. Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 7104.0x1f30] 0x011e08b1 in w32_wnd_proc (hwnd=0x6c088c, msg=269, wParam=0, lParam=0) at w32fns.c:3216 3216 w = XWINDOW (FRAME_SELECTED_WINDOW (f)); (gdb) bt #0 0x011e08b1 in w32_wnd_proc (hwnd=0x6c088c, msg=269, wParam=0, lParam=0) at w32fns.c:3216 #1 0x762162fa in USER32!OffsetRect () from C:\Windows\syswow64\user32.dll #2 0x006c088c in ?? () #3 0x0000010d in ?? () #4 0x00000000 in ?? () Lisp Backtrace: "delete-frame" (0x88efe8) "handle-delete-frame" (0x88f324) "call-interactively" (0x88f550) "command-execute" (0x88f850) (gdb) bt full #0 0x011e08b1 in w32_wnd_proc (hwnd=0x6c088c, msg=269, wParam=0, lParam=0) at w32fns.c:3216 form = { dwStyle = 1, ptCurrentPos = { x = 8, y = 45 }, rcArea = { left = 8, top = 45, right = 1872, bottom = 540 } } context = 0 w = 0x6e4bfd68 f = 0x0 dpyinfo = 0x1523900 wmsg = { msg = { hwnd = 0xf70828, message = 1981903226, wParam = 735304265, lParam = 1981903158, time = 16189480, pt = { x = 7080076, y = 1981903226 } }, dwModifiers = 16205752, rect = { left = 16205752, top = 0, right = 70, bottom = 1850473688 } } windows_translate = 1850474000 key = 1 #1 0x762162fa in USER32!OffsetRect () from C:\Windows\syswow64\user32.dll No symbol table info available. #2 0x006c088c in ?? () No symbol table info available. #3 0x0000010d in ?? () No symbol table info available. #4 0x00000000 in ?? () No symbol table info available. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 28 04:40:13 2013 Received: (at 14970) by debbugs.gnu.org; 28 Jul 2013 08:40:13 +0000 Received: from localhost ([127.0.0.1]:53985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3MWS-0001Lt-84 for submit@debbugs.gnu.org; Sun, 28 Jul 2013 04:40:12 -0400 Received: from mout.gmx.net ([212.227.15.19]:52689) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3MWN-0001Kq-FX for 14970@debbugs.gnu.org; Sun, 28 Jul 2013 04:40:09 -0400 Received: from [62.47.48.182] ([62.47.48.182]) by mail.gmx.com (mrgmx101) with ESMTPA (Nemesis) id 0MSZ6u-1Ubpjw0iBA-00RVVl for <14970@debbugs.gnu.org>; Sun, 28 Jul 2013 10:40:00 +0200 Message-ID: <51F4D8DA.9090806@gmx.at> Date: Sun, 28 Jul 2013 10:39:54 +0200 From: martin rudalics MIME-Version: 1.0 To: Juanma Barranquero Subject: Re: bug#14970: crash deleting frames References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fPTMnhp7DwHXizMQfSYwTW0DC1sOhTGWHbwZ7epaBzZtmldgflp 5WLdZsy63dH6MdkkYDYAq4z7QKww1FQatsCOUUVSz59aOe6O7HoZ+8WyIFopqUr97Lprkv7 VNbyT5oAC2KkMZ3SvQ+ZdCZpYC5LZ3oFXJR62vSDLi2Ru6MJs+uvUUv7YFdALxnG3YbbFwn 2tpMrGOl6JMpTk/L4nxXg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14970 Cc: 14970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > 3216 w = XWINDOW (FRAME_SELECTED_WINDOW (f)); My crystal ball tells me that Eli will check whether f is a live frame in between the following two statements of w32fns.c f = x_window_to_frame (dpyinfo, hwnd); w = XWINDOW (FRAME_SELECTED_WINDOW (f)); which should considerably reduce the danger that the frame has been recycled when accessing FRAME_SELECTED_WINDOW. I'm not sure whether it's worth the effort having FRAME_SELECTED_WINDOW check that its argument is a live frame. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 28 11:25:34 2013 Received: (at 14970) by debbugs.gnu.org; 28 Jul 2013 15:25:34 +0000 Received: from localhost ([127.0.0.1]:54529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Sqi-0006xY-OL for submit@debbugs.gnu.org; Sun, 28 Jul 2013 11:25:33 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:36107) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Sqf-0006x8-9y for 14970@debbugs.gnu.org; Sun, 28 Jul 2013 11:25:30 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MQN00500K3B3M00@a-mtaout23.012.net.il> for 14970@debbugs.gnu.org; Sun, 28 Jul 2013 18:25:03 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQN005XJK5Q2W10@a-mtaout23.012.net.il>; Sun, 28 Jul 2013 18:25:03 +0300 (IDT) Date: Sun, 28 Jul 2013 18:25:08 +0300 From: Eli Zaretskii Subject: Re: bug#14970: crash deleting frames In-reply-to: X-012-Sender: halo1@inter.net.il To: Juanma Barranquero Message-id: <831u6izoyz.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 14970 Cc: 14970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Juanma Barranquero > Date: Sun, 28 Jul 2013 02:22:51 +0200 > > Package: emacs > Version: 24.3.50 > > Context: I'm trying new desktop code to force frames onscreen. To test > it, I have a function that creates a fair number of frames (around > 15/20) either partially or totally offscreen. > > Once the new desktop code moves them onscreen, I usually close them > all via another interactive test function. But if I try instead to > close them by clicking on each window's Close button, sooner or later > (after closing 10/15 frames, usually) Emacs crashes. > > In previous crashes it didn't generate a backtrace, nor did Windows > offer to attach a debugger to the crashed program. Also, running under > gdb I couldn't reproduce the bug. This is the first time I've been > offered to attach gdb. > > Whatever the reason, something fishy is happening with delete-frame, Does revision 113576 fix this? If not, please try to provide a reproducing recipe, even if it is not 100% reliable. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 28 11:28:30 2013 Received: (at 14970) by debbugs.gnu.org; 28 Jul 2013 15:28:31 +0000 Received: from localhost ([127.0.0.1]:54533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Sta-00074T-FA for submit@debbugs.gnu.org; Sun, 28 Jul 2013 11:28:30 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:41019) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3StX-00073y-9L for 14970@debbugs.gnu.org; Sun, 28 Jul 2013 11:28:28 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MQN00500JSJFE00@a-mtaout21.012.net.il> for 14970@debbugs.gnu.org; Sun, 28 Jul 2013 18:28:21 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQN0054VKB8DS60@a-mtaout21.012.net.il>; Sun, 28 Jul 2013 18:28:20 +0300 (IDT) Date: Sun, 28 Jul 2013 18:28:25 +0300 From: Eli Zaretskii Subject: Re: bug#14970: crash deleting frames In-reply-to: <51F4D8DA.9090806@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83zjt6ya92.fsf@gnu.org> References: <51F4D8DA.9090806@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 14970 Cc: lekktu@gmail.com, 14970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 28 Jul 2013 10:39:54 +0200 > From: martin rudalics > Cc: 14970@debbugs.gnu.org > > > 3216 w = XWINDOW (FRAME_SELECTED_WINDOW (f)); > > My crystal ball tells me that Eli will check whether f is a live frame > in between the following two statements of w32fns.c > > f = x_window_to_frame (dpyinfo, hwnd); > w = XWINDOW (FRAME_SELECTED_WINDOW (f)); The Force is strong with you. Yes, I did something similar, although not exactly (you cannot just use FRAME_LIVE_P here, because it will crash in the same way). > which should considerably reduce the danger that the frame has been > recycled when accessing FRAME_SELECTED_WINDOW. Actually, I think it's recycled between the code that sent WM_IME_STARTCOMPOSITION to the window and this code (which runs in a different thread). > I'm not sure whether it's worth the effort having > FRAME_SELECTED_WINDOW check that its argument is a live frame. No, of course not. We already test the value returned by x_window_to_frame almost everywhere, so this place should not be different. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 28 13:04:57 2013 Received: (at 14970) by debbugs.gnu.org; 28 Jul 2013 17:04:57 +0000 Received: from localhost ([127.0.0.1]:54632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3UOv-00022o-1u for submit@debbugs.gnu.org; Sun, 28 Jul 2013 13:04:57 -0400 Received: from mail-ea0-f179.google.com ([209.85.215.179]:60018) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3UOs-00022S-S7 for 14970@debbugs.gnu.org; Sun, 28 Jul 2013 13:04:55 -0400 Received: by mail-ea0-f179.google.com with SMTP id b10so66041eae.24 for <14970@debbugs.gnu.org>; Sun, 28 Jul 2013 10:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=i8QCGhL2nWvGuh9frjFcQBZMlXlMXJsT0ZuSYP7+7YM=; b=ansjMy7OZLoLj082OUjUuOXc8jGVTfqZlgUEAQaJSW8kNahVcggOtFrGirtLysxaso hYPHLWBAqTsBEBm/UUEH78B4OA1LUR6q9ncDAyUmeXICjgtvPCb6fm/9qGnNDJ39EZ12 x5Mc3Ay3d/RhTKA1g/XjOwPw3jxEZ7AEewI28meUm5gR/YvM2jm0iiVXjuF1LOngmvoA zxZf6c2jtoZ5bM78pspYhc5OSitWOF0lWzpMR9ry66a6FTPz3idCU0jntiub53WnKJ6R XTo7wYyZT9JorHyLAQr0a594UF10U3HpXNFb1Ix1XdIP40jmD0AC6jNoOXji8lxEHom+ KYcA== X-Received: by 10.14.4.70 with SMTP id 46mr54961929eei.42.1375031088775; Sun, 28 Jul 2013 10:04:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.15.23.70 with HTTP; Sun, 28 Jul 2013 10:04:08 -0700 (PDT) In-Reply-To: <831u6izoyz.fsf@gnu.org> References: <831u6izoyz.fsf@gnu.org> From: Juanma Barranquero Date: Sun, 28 Jul 2013 19:04:08 +0200 Message-ID: Subject: Re: bug#14970: crash deleting frames To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14970 Cc: 14970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Jul 28, 2013 at 5:25 PM, Eli Zaretskii wrote: > Does revision 113576 fix this? Hard to say, but I just deleted 40+ frames and didn't trigger the bug, so hopefully yes. Close the bug and I'll re-open it if the bug reappears. > If not, please try to provide a > reproducing recipe, even if it is not 100% reliable. The only recipe I had: enable desktop-save-mode, create 20+ frames, save, restore Emacs again, delete all the frames as fast as possible by clicking on the Close buttons. And I don't think the desktop saving & restoring is really relevant, but that's what I was doing everytime the bug happened. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 28 13:28:26 2013 Received: (at 14970-done) by debbugs.gnu.org; 28 Jul 2013 17:28:27 +0000 Received: from localhost ([127.0.0.1]:54664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Ule-0002uw-6A for submit@debbugs.gnu.org; Sun, 28 Jul 2013 13:28:26 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:54259) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Ula-0002ua-Of for 14970-done@debbugs.gnu.org; Sun, 28 Jul 2013 13:28:24 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MQN00E00PT66J00@a-mtaout22.012.net.il> for 14970-done@debbugs.gnu.org; Sun, 28 Jul 2013 20:28:16 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQN00DRHPV3TF90@a-mtaout22.012.net.il>; Sun, 28 Jul 2013 20:28:16 +0300 (IDT) Date: Sun, 28 Jul 2013 20:28:21 +0300 From: Eli Zaretskii Subject: Re: bug#14970: crash deleting frames In-reply-to: X-012-Sender: halo1@inter.net.il To: Juanma Barranquero Message-id: <83y58qy4p6.fsf@gnu.org> References: <831u6izoyz.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 14970-done Cc: 14970-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Juanma Barranquero > Date: Sun, 28 Jul 2013 19:04:08 +0200 > Cc: 14970@debbugs.gnu.org > > On Sun, Jul 28, 2013 at 5:25 PM, Eli Zaretskii wrote: > > > Does revision 113576 fix this? > > Hard to say, but I just deleted 40+ frames and didn't trigger the bug, > so hopefully yes. Close the bug and I'll re-open it if the bug > reappears. Done. > > If not, please try to provide a > > reproducing recipe, even if it is not 100% reliable. > > The only recipe I had: enable desktop-save-mode, create 20+ frames, > save, restore Emacs again, delete all the frames as fast as possible > by clicking on the Close buttons. And I don't think the desktop saving > & restoring is really relevant, but that's what I was doing everytime > the bug happened. Did you create the frames manually, or do you have some Lisp to sweeten the pill? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 28 13:35:13 2013 Received: (at 14970-done) by debbugs.gnu.org; 28 Jul 2013 17:35:13 +0000 Received: from localhost ([127.0.0.1]:54670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3UsC-0003EY-AB for submit@debbugs.gnu.org; Sun, 28 Jul 2013 13:35:13 -0400 Received: from mail-ee0-f49.google.com ([74.125.83.49]:49883) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Us9-0003EC-Oj for 14970-done@debbugs.gnu.org; Sun, 28 Jul 2013 13:35:10 -0400 Received: by mail-ee0-f49.google.com with SMTP id b57so2450080eek.36 for <14970-done@debbugs.gnu.org>; Sun, 28 Jul 2013 10:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=WAufPmdAgAi3h2TNCH2CnswMpf7zxOVVlaYRePOAF8w=; b=ps9zWv0YBFBvoabdx/+qWOzbO5LWjUQnYu8Q4YD3iKYYsuoUSpu9oeM/lv3TVjUgWD IfcMsnzmJ/JvUhlyWlViD8gAXcxkvkvb02vTlHkCPs/BQIIWqqmJAgV4Mh9h4C9WCsu7 ksv8Ng97fA6Hnel6G+hsujxUCM36qBf9QVfKWHuCrkxIjEl4fPVTYDW9ZNNaNDd+yJhy O6b6lI7sdmKR4x/LxjgzTn+H6k9D8BoIsn1GFCyOsITAtS/5reXrdHvNOhxfNXUxsfbA E7ktL/Ij488vqL4dDwOHhwxSXVm/x29jmtAGyooT+aGPt33auwT+v2beC9M5FlLFBv72 Vhdw== X-Received: by 10.14.218.8 with SMTP id j8mr56101024eep.129.1375032903819; Sun, 28 Jul 2013 10:35:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.15.23.70 with HTTP; Sun, 28 Jul 2013 10:34:23 -0700 (PDT) In-Reply-To: <83y58qy4p6.fsf@gnu.org> References: <831u6izoyz.fsf@gnu.org> <83y58qy4p6.fsf@gnu.org> From: Juanma Barranquero Date: Sun, 28 Jul 2013 19:34:23 +0200 Message-ID: Subject: Re: bug#14970: crash deleting frames To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14970-done Cc: 14970-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Jul 28, 2013 at 7:28 PM, Eli Zaretskii wrote: > Did you create the frames manually, or do you have some Lisp to > sweeten the pill? I was using this. Dimensions are harcoded to make frames be totally or partially offscren in my 1920x1040 workarea. If you create the frames and then save the frame config with desktop and restore with the current default, those frames that are totally offscreen should be moved onscreen. Once that has finished, you can start clicking Close buttons happily. (defvar test-frame-alist-list ;; 1920 x 1040 '( ((name . "top full (400 -3000)") (left . 400) (top + -3000)) ((name . "top part (500 -200)") (left . 500) (top + -200)) ;ok ((name . "bot full (400 4000)") (left . 400) (top . 4000)) ((name . "bot part (500 900)") (left . 500) (top . 900)) ;ok ((name . "left full (-3000 300)") (left + -3000) (top . 300)) ((name . "left part (-400 300)") (left + -400) (top . 300)) ;ok ((name . "right full (4000 200)") (left . 4000) (top . 200)) ((name . "right part (1800 300)") (left . 1800) (top . 300)) ;ok ((name . "upleft full (-2000 -2000)") (left + -2000) (top + -2000)) ((name . "upleft part (-100 -100)") (left + -100) (top + -100)) ;ok ((name . "dnleft full (-2000 3000)") (left + -2000) (top . 3000)) ((name . "dnleft part (-300 800)") (left + -300) (top . 800)) ;ok ((name . "upright full (3000 -2000)") (left . 3000) (top + -2000)) ((name . "upright part (1700 -200)") (left . 1700) (top + -200)) ;ok ((name . "dnright full (3000 3000)") (left . 3000) (top . 3000)) ((name . "dnright part (1600 900)") (left . 1600) (top . 900)) ;ok ((name . "top full width") (left . 100) (top + -1000) (width . 400)) ((name . "top full height") (left . 100) (top + -6000) (height . 300)) ((name . "top full full") (left . 100) (top + -6000) (width . 400) (height . 300)) ((name . "top part width") (left . 100) (top + -300) (width . 400)) ((name . "top part height") (left . 200) (top + -3900) (height . 300)) ((name . "top part full") (left . 300) (top + -4200) (width . 400) (height . 300)) ((name . "left full width") (left + -4000) (top . 200) (width . 400)) ((name . "left full height") (left + -4000) (top . 300) (height . 300)) ((name . "left full full") (left + -4000) (top . 400) (width . 400) (height . 300)) ((name . "left part width") (left + -3000) (top . 200) (width . 400)) ((name . "left part height") (left + -300) (top . 300) (height . 300)) ((name . "left part full") (left + -3200) (top . 400) (width . 400) (height . 300)) ((name . "bot full width") (left . 100) (top . 2000) (width . 400)) ((name . "bot full height") (left . 200) (top . 3000) (height . 300)) ((name . "bot full full") (left . 300) (top . 4000) (width . 400) (height . 300)) ((name . "bot part width") (left . 100) (top . 700) (width . 400)) ((name . "bot part height") (left . 200) (top . 800) (height . 300)) ((name . "bot part full") (left . 300) (top . 900) (width . 400) (height . 300)) ((name . "right full width") (left . 3000) (top . 200) (width . 400)) ((name . "right full height") (left . 3000) (top . 300) (height . 300)) ((name . "right full full") (left . 3000) (top . 400) (width . 400) (height . 300)) ((name . "right part width") (left . 1600) (top . 200) (width . 400)) ((name . "right part height") (left . 1700) (top . 300) (height . 300)) ((name . "right part full") (left . 1800) (top . 400) (width . 400) (height . 300)) ((name . "upleft full width") (left + -3000) (top + -1000) (width . 400)) ((name . "upleft full height") (left + -3000) (top + -6000) (height . 300)) ((name . "upleft full full") (left + -3000) (top + -6000) (width . 400) (height . 300)) ((name . "upleft part width") (left + -3000) (top + -300) (width . 400)) ((name . "upleft part height") (left + -500) (top + -3900) (height . 300)) ((name . "upleft part full") (left + -3200) (top + -4200) (width . 400) (height . 300)) )) (defun make-all () (interactive) (dolist (frame-cfg test-frame-alist-list) (modify-frame-parameters (make-frame) frame-cfg))) From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 28 13:37:53 2013 Received: (at 14970-done) by debbugs.gnu.org; 28 Jul 2013 17:37:54 +0000 Received: from localhost ([127.0.0.1]:54677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Uun-0003LE-Dr for submit@debbugs.gnu.org; Sun, 28 Jul 2013 13:37:53 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:45864) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3Uuk-0003Ku-TH for 14970-done@debbugs.gnu.org; Sun, 28 Jul 2013 13:37:51 -0400 Received: by mail-ee0-f53.google.com with SMTP id b15so294303eek.26 for <14970-done@debbugs.gnu.org>; Sun, 28 Jul 2013 10:37:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=bZ+cqYK1b+dws1+WDpzC50i0GWJpbTX9CwKAZ8eoLak=; b=PqyNjlCLM6jrGApdfQES82skzmxmzag/PiQNIhrwMsS3/T7ATJYIvmAInUZ1ZxxMsa E1DkSbHn9onHMDveWwImiDYgYNLQVwr5/Dfk1iXUUHmA6XD6H4g6+9hjR1baBVuzv9XG PGPtCIzKmiov9iCRmckfjck6xAT+xloRtQXUL9gS3//bZNFl4Eo3EVqnh2SZRt76UUEW pebt1DU+dq9zI0ATVZeWlBagxB0q4JH+E7fO+UDWrDysxfWMisjCyR8XHxyNxVpKTuTG PNqAYsEC3Ek4j3xAMKrQHSVylIwsvf3IQnnvAJSh0iOzgH1dWo1i0CqrAnMA1fU/RMY8 0LrA== X-Received: by 10.14.224.6 with SMTP id w6mr3242639eep.99.1375033065107; Sun, 28 Jul 2013 10:37:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.15.23.70 with HTTP; Sun, 28 Jul 2013 10:37:05 -0700 (PDT) In-Reply-To: References: <831u6izoyz.fsf@gnu.org> <83y58qy4p6.fsf@gnu.org> From: Juanma Barranquero Date: Sun, 28 Jul 2013 19:37:05 +0200 Message-ID: Subject: Re: bug#14970: crash deleting frames To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14970-done Cc: 14970-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Jul 28, 2013 at 7:34 PM, Juanma Barranquero wrote: > If you create the frames and then save the frame config with desktop > and restore with the current default, those frames that are totally > offscreen should be moved onscreen. What I meant (but didn't really say clearly ;-) is that if you want to make *all* these frames visible, you should set `desktop-restore-forces-onscreen' to `all'. J From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 29 03:55:38 2013 Received: (at 14970) by debbugs.gnu.org; 29 Jul 2013 07:55:38 +0000 Received: from localhost ([127.0.0.1]:55481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3iIr-0004Aa-RW for submit@debbugs.gnu.org; Mon, 29 Jul 2013 03:55:38 -0400 Received: from mout.gmx.net ([212.227.17.20]:55057) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3iIT-00048C-UB for 14970@debbugs.gnu.org; Mon, 29 Jul 2013 03:55:20 -0400 Received: from [62.47.50.76] ([62.47.50.76]) by mail.gmx.com (mrgmx101) with ESMTPA (Nemesis) id 0LsPwa-1U6Y4X3Y1w-011wFy for <14970@debbugs.gnu.org>; Mon, 29 Jul 2013 09:55:05 +0200 Message-ID: <51F61FD2.9060600@gmx.at> Date: Mon, 29 Jul 2013 09:54:58 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#14970: crash deleting frames References: <51F4D8DA.9090806@gmx.at> <83zjt6ya92.fsf@gnu.org> In-Reply-To: <83zjt6ya92.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Csf0mP7kZ4JYDc79MXntgMPqie9wop2Doc/df0FE6LDB03fDn23 m2IIio5v+FMrkZEF87cD91Oos+Eyw2Dw47i3X/en/iuw4SZm3XAMrLNazS5wRBuK1RRod2Y kOhR/3VonqzjO7s0PPV0e8d11MhpNTOmyHfftXJ3TxwkCfqcRUevyLqeyMvux18wh1ltOp1 lKOw5Z6n7sZVbaI6sc5eQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14970 Cc: lekktu@gmail.com, 14970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > ... (you cannot just > use FRAME_LIVE_P here, because it will crash in the same way). How does it crash? martin From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 29 11:29:36 2013 Received: (at 14970) by debbugs.gnu.org; 29 Jul 2013 15:29:36 +0000 Received: from localhost ([127.0.0.1]:56300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3pOB-0005ho-Tl for submit@debbugs.gnu.org; Mon, 29 Jul 2013 11:29:36 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:50559) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3pO9-0005gy-8I for 14970@debbugs.gnu.org; Mon, 29 Jul 2013 11:29:34 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MQP00300EX25T00@a-mtaout21.012.net.il> for 14970@debbugs.gnu.org; Mon, 29 Jul 2013 18:29:13 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQP003E6F0O5420@a-mtaout21.012.net.il>; Mon, 29 Jul 2013 18:29:13 +0300 (IDT) Date: Mon, 29 Jul 2013 18:29:20 +0300 From: Eli Zaretskii Subject: Re: bug#14970: crash deleting frames In-reply-to: <51F61FD2.9060600@gmx.at> X-012-Sender: halo1@inter.net.il To: martin rudalics Message-id: <83vc3txu3z.fsf@gnu.org> References: <51F4D8DA.9090806@gmx.at> <83zjt6ya92.fsf@gnu.org> <51F61FD2.9060600@gmx.at> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 14970 Cc: lekktu@gmail.com, 14970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 29 Jul 2013 09:54:58 +0200 > From: martin rudalics > CC: lekktu@gmail.com, 14970@debbugs.gnu.org > > > ... (you cannot just > > use FRAME_LIVE_P here, because it will crash in the same way). > > How does it crash? The original crash was a SIGSEGV because f was a null pointer, and FRAME_SELECTED_WINDOW dereferenced it. But FRAME_LIVE_P also dereferences its argument, so it would have crashed with the same SIGSEGV. I guess you are thinking about a frame pointer computed from a Lisp frame object, in which case the pointer can never be null. But this is not that case: here we get the frame pointer from a call to x_window_to_frame, which returns a null pointer to signal that it failed to find an Emacs frame that corresponds to a Windows window. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 29 13:03:59 2013 Received: (at 14970) by debbugs.gnu.org; 29 Jul 2013 17:04:00 +0000 Received: from localhost ([127.0.0.1]:56482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3qrX-0003pp-EH for submit@debbugs.gnu.org; Mon, 29 Jul 2013 13:03:59 -0400 Received: from mout.gmx.net ([212.227.17.21]:56975) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3qrV-0003pI-Bn for 14970@debbugs.gnu.org; Mon, 29 Jul 2013 13:03:58 -0400 Received: from [62.47.62.165] ([62.47.62.165]) by mail.gmx.com (mrgmx101) with ESMTPA (Nemesis) id 0MIiHs-1V63mp29f6-002J4A for <14970@debbugs.gnu.org>; Mon, 29 Jul 2013 19:03:51 +0200 Message-ID: <51F6A06C.2000702@gmx.at> Date: Mon, 29 Jul 2013 19:03:40 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#14970: crash deleting frames References: <51F4D8DA.9090806@gmx.at> <83zjt6ya92.fsf@gnu.org> <51F61FD2.9060600@gmx.at> <83vc3txu3z.fsf@gnu.org> In-Reply-To: <83vc3txu3z.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/qnzFiFjV+JKVGHiwajt3KFTqH5SwSqJP7g6aT5K4qbtkP2XIq8 3TPHf/H3J65dLVR2MrtJK6habIQg001C5AVz6W2ijhSCV77mukLyKq9ccpRgBNuKFsv52Mm ydxeGCZzkqBHPpVdw1NjJQ0f36+6hzswqOn5U+5VHnoKoBnW2bWHMkUpvLekzs3ggQjXHJ3 Ec1hjbTYylE25eff1nI5A== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14970 Cc: lekktu@gmail.com, 14970@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > The original crash was a SIGSEGV because f was a null pointer, and > FRAME_SELECTED_WINDOW dereferenced it. But FRAME_LIVE_P also > dereferences its argument, so it would have crashed with the same > SIGSEGV. Indeed. I was confusing FRAME_LIVE_P and Fframe_live_p. Thanks for the clarification. martin From unknown Tue Aug 19 02:52:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 Aug 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator