GNU bug report logs - #14967
24.3.50; package-delete deletes by trashing?

Previous Next

Full log

Message #75 received at 14967 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 14967 <at> debbugs.gnu.org
Cc: lunaryorn <at> gmail.com, Stefan Monnier <monnier <at> IRO.UMontreal.CA>,
 Alex <agrambot <at> gmail.com>, npostavs <at> users.sourceforge.net
Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing?
Date: Mon, 19 Jun 2017 14:47:52 -0400

I've applied the following.

IMO if Emacs wants to behave like system package managers (eg yum, apt),
it should (optionally) cache the _source_ when it downloads a package.
Then use that (if appropriate) if asked to (re)install.

commit 65b323e (HEAD, master)
Date:   Mon Jun 19 14:39:25 2017 -0400

    Don't put deleted packages in the trash (bug#14967)
    
    * lisp/emacs-lisp/package.el (package-delete):
    Don't pay attention to delete-by-moving-to-trash.
    
    ; * etc/NEWS: Mention this.

diff --git a/etc/NEWS b/etc/NEWS
index 85d1273..78d37484 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -755,6 +755,9 @@ header's value.
 where the GnuPG home directory (used for signature verification) is
 located and whether GnuPG's option "--homedir" is used or not.
 
+---
+*** Deleting a package no longer respects 'delete-by-moving-to-trash'.
+
 ** Tramp
 
 +++
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index bebfd18..4245294 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -2127,7 +2127,7 @@ If NOSAVE is non-nil, the package is not removed from
                   (package-desc-name pkg-used-elsewhere-by)))
           (t
            (add-hook 'post-command-hook #'package-menu--post-refresh)
-           (delete-directory dir t t)
+           (delete-directory dir t)
            ;; Remove NAME-VERSION.signed and NAME-readme.txt files.
            (dolist (suffix '(".signed" "readme.txt"))
              (let* ((version (package-version-join (package-desc-version pkg-desc)))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.