From unknown Fri Aug 15 15:30:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14967 <14967@debbugs.gnu.org> To: bug#14967 <14967@debbugs.gnu.org> Subject: Status: 24.3.50; package-delete deletes by trashing? Reply-To: bug#14967 <14967@debbugs.gnu.org> Date: Fri, 15 Aug 2025 22:30:49 +0000 retitle 14967 24.3.50; package-delete deletes by trashing? reassign 14967 emacs submitter 14967 Sebastian Wiesner severity 14967 wishlist tag 14967 notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 27 07:35:42 2013 Received: (at submit) by debbugs.gnu.org; 27 Jul 2013 11:35:42 +0000 Received: from localhost ([127.0.0.1]:52468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V32mj-0000fK-Oo for submit@debbugs.gnu.org; Sat, 27 Jul 2013 07:35:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48576) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V32mg-0000dW-RL for submit@debbugs.gnu.org; Sat, 27 Jul 2013 07:35:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V32mZ-0006y6-RC for submit@debbugs.gnu.org; Sat, 27 Jul 2013 07:35:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V32mZ-0006xo-MX for submit@debbugs.gnu.org; Sat, 27 Jul 2013 07:35:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V32mY-0000P5-5j for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 07:35:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V32mX-0006x8-4M for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 07:35:30 -0400 Received: from mail-bk0-x230.google.com ([2a00:1450:4008:c01::230]:35752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V31lU-0000Gz-Ru for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2013 06:30:20 -0400 Received: by mail-bk0-f48.google.com with SMTP id jf3so1421492bkc.7 for ; Sat, 27 Jul 2013 03:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Zxh4Rbwy1jYoS6xlfb/KomZpYab1CVk9RIfuKL482FM=; b=GgNU/USKY53sWSwYdvLI0suDkmMK6Lgc74ts3OO3wT66WTcqBjMudYpI//ZVLHfCzJ +QUvh4F9hSzYVWdBr58IBFdurdNhdPVxpC5sMDe85hZpx7iyko0UV9AQ9emotYn60WaX 7jDsWimBa0LQDpJo8vUMyjT2HlJY2TQT4iETFMaCJLa+D5gSi+mLotf+4fRmmi99QqH2 S8qBZDJb8jH1C/J6Mof+hhEY60PF/hcL9GJC4vFxivcQwzcios/n4WRlQ3Gbv22IaJZo zqNH9HWy/fVjkEG/2w5OK8SQkadwO7g/ipospHbcX60FDj2AsoBoB5jQKnpVJw5oVfcT bADw== X-Received: by 10.204.182.208 with SMTP id cd16mr7579744bkb.88.1374921019833; Sat, 27 Jul 2013 03:30:19 -0700 (PDT) Received: from lunaryorn-air.fritz.box (p57995C19.dip0.t-ipconnect.de. [87.153.92.25]) by mx.google.com with ESMTPSA id l11sm13418062bkk.13.2013.07.27.03.30.18 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 27 Jul 2013 03:30:19 -0700 (PDT) From: Sebastian Wiesner To: bug-gnu-emacs@gnu.org Subject: 24.3.50; package-delete deletes by trashing? Date: Sat, 27 Jul 2013 12:30:15 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Currently "package-delete" from package.el is implemented as follows: (defun package-delete (pkg-desc) (let ((dir (package-desc-dir pkg-desc))) (if (not (string-prefix-p (file-name-as-directory (expand-file-name package-user-dir)) (expand-file-name dir))) ;; Don't delete "system" packages. (error "Package `%s' is a system package, not deleting" (package-desc-full-name pkg-desc)) (delete-directory dir t t) ;; Update package-alist. (let* ((name (package-desc-name pkg-desc))) (delete pkg-desc (assq name package-alist))) (message "Package `%s' deleted." (package-desc-full-name pkg-desc))))) Note that the call to "delete-directory" gives t as the 3rd argument, thus allowing for deletion by moving to trash depending on "delete-by-moving-to-trash". Is that intended behavior? If so, what is the rationale behind it? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 29 18:02:50 2013 Received: (at 14967) by debbugs.gnu.org; 29 Jul 2013 22:02:50 +0000 Received: from localhost ([127.0.0.1]:56801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3vWi-00039c-6Z for submit@debbugs.gnu.org; Mon, 29 Jul 2013 18:02:48 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:32992 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3vWe-00039N-QW for 14967@debbugs.gnu.org; Mon, 29 Jul 2013 18:02:45 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1V3vWd-0006us-53; Mon, 29 Jul 2013 18:02:43 -0400 From: Glenn Morris To: Sebastian Wiesner Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: X-Spook: Waco, Texas Legion of Doom S Key FTS2000 Merlin anarchy X-Ran: A~w@S1E!jS`dp:!+wv^.y5C"}8W-q:m5NVCA#]kT6Jh6|NsRmPmOG7m~Wo~zUi,kF,.'hh X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 29 Jul 2013 18:02:43 -0400 In-Reply-To: (Sebastian Wiesner's message of "Sat, 27 Jul 2013 12:30:15 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 14967 Cc: 14967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.5 (------) Sebastian Wiesner wrote: > Note that the call to "delete-directory" gives t as the 3rd argument, > thus allowing for deletion by moving to trash depending on > "delete-by-moving-to-trash". > > Is that intended behavior? If so, what is the rationale behind it? I guess. Don't know. Maybe so you can undo a delete? What's the bug? From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 06:51:55 2013 Received: (at 14967) by debbugs.gnu.org; 30 Jul 2013 10:51:55 +0000 Received: from localhost ([127.0.0.1]:57642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V47X0-0006yC-FC for submit@debbugs.gnu.org; Tue, 30 Jul 2013 06:51:54 -0400 Received: from mail-qe0-f53.google.com ([209.85.128.53]:41299) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V47Wz-0006xf-1y for 14967@debbugs.gnu.org; Tue, 30 Jul 2013 06:51:53 -0400 Received: by mail-qe0-f53.google.com with SMTP id f6so2935787qej.12 for <14967@debbugs.gnu.org>; Tue, 30 Jul 2013 03:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ItXDwWTu36b95SDa1TTlo34SNAjhBPw44O9z6CNZscU=; b=Si44hEJ92dPi7FQ3QLLPc1OAs7ua8qNJU4bDcezNOzi5pNIUVoAvTJaCyHrhkptII/ RTBet18vgP3hp38jFiNjcJ/Bny+JGwChHBvNSwAjSmQWPumd8p5CqxHnjLmE7do9ZPUI fKSiKkFfw1OqfUvy417DcTjF7YNOP0LBv3DE/J8gTr5/7hn4LQ6rXOQ0NExgCKWoKrww 97lwg7kYCEvb7yDh9TR+TO1volMb0G/n/S18JnjDP8LRI9VQUtWkzn5j6iHLnDFQdHzm m0hwbcy73FVjbExPOpL2L+zoOWAruKX3D6CkSnFjgXAW6Bpk96Vr36A+6hDUmurUbl1+ 3PXg== MIME-Version: 1.0 X-Received: by 10.224.51.12 with SMTP id b12mr21965296qag.53.1375181507409; Tue, 30 Jul 2013 03:51:47 -0700 (PDT) Received: by 10.224.21.136 with HTTP; Tue, 30 Jul 2013 03:51:47 -0700 (PDT) In-Reply-To: References: Date: Tue, 30 Jul 2013 12:51:47 +0200 Message-ID: Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? From: Sebastian Wiesner To: Glenn Morris Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14967 Cc: 14967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 2013/7/30 Glenn Morris : > Sebastian Wiesner wrote: > >> Note that the call to "delete-directory" gives t as the 3rd argument, >> thus allowing for deletion by moving to trash depending on >> "delete-by-moving-to-trash". >> >> Is that intended behavior? If so, what is the rationale behind it? > > I guess. Don't know. Maybe so you can undo a delete? > > What's the bug? Well, obviously I consider this behavior a bug. Trash is no place for deleted packages. I mean, does apt-get remove use the Trash?! Undoing package removal by simply restoring from Trash does not work reliably anyway, so what's the point of this, despite cluttering the user's trash can? PS: Please excuse the duplicate mail. I had accidentally only mailed you directly, and forgot to CC debbugs. Sorry for any inconvenience. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 10:21:54 2013 Received: (at 14967) by debbugs.gnu.org; 30 Jul 2013 14:21:54 +0000 Received: from localhost ([127.0.0.1]:58435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4AoD-0002ef-IE for submit@debbugs.gnu.org; Tue, 30 Jul 2013 10:21:54 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:21250) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4AoA-0002eL-Rl for 14967@debbugs.gnu.org; Tue, 30 Jul 2013 10:21:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFsoXy2/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA5JbA5IcgV6DEw X-IPAS-Result: Av8EABK/CFFsoXy2/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA5JbA5IcgV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="20160393" Received: from 108-161-124-182.dsl.teksavvy.com (HELO pastel.home) ([108.161.124.182]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 30 Jul 2013 10:21:38 -0400 Received: by pastel.home (Postfix, from userid 20848) id D997E62E1A; Tue, 30 Jul 2013 10:21:44 -0400 (EDT) From: Stefan Monnier To: Sebastian Wiesner Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? Message-ID: References: Date: Tue, 30 Jul 2013 10:21:44 -0400 In-Reply-To: (Sebastian Wiesner's message of "Tue, 30 Jul 2013 12:51:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 14967 Cc: Glenn Morris , 14967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Well, obviously I consider this behavior a bug. Trash is no place for > deleted packages. I mean, does apt-get remove use the Trash?! I think the reasoning goes as follows: Emacs uses "trash" when deleting a file upon the user's request (as opposed to things like temp files used internally). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 10:41:03 2013 Received: (at 14967) by debbugs.gnu.org; 30 Jul 2013 14:41:04 +0000 Received: from localhost ([127.0.0.1]:58481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4B6f-0004Vb-89 for submit@debbugs.gnu.org; Tue, 30 Jul 2013 10:41:03 -0400 Received: from mail-qc0-f175.google.com ([209.85.216.175]:49018) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4B6G-0004UZ-8U for 14967@debbugs.gnu.org; Tue, 30 Jul 2013 10:40:33 -0400 Received: by mail-qc0-f175.google.com with SMTP id s11so868048qcv.6 for <14967@debbugs.gnu.org>; Tue, 30 Jul 2013 07:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=2ZgYAX74vbuNUP6pJYttX8eZjX2djQr7Pdgk+0pHy2c=; b=E85+6PvacEb+L1vsAZmUA1IQTKxW99yCfsswD7YTDWD+cQf3K/xzy+w4TLNrB4rEgq 8myVePFETDyQWvTXMLrVLsRRePfpuhjZY1itouOUQ+FQ6/Q/r3X1bw08JsGwbsDee/UX /K4lc9q++VJITZCLy2lmn5dwN4y3BQo5by1B5Kl8OLuQ3c2P5cj8t+LrGExt5edgizgk fIwMgFP2/w1JIe6oPoQ/29WhLzO3xF+L7Q/dS+fLWVkuC1aYO4QXXhpHGTskqNmJFVkn YuVjQkfg9Rh82ZuSVVY7AWgINIwuAeBb666fzfNFte00XGkOXIFC3ILqHgNWCca8zog0 AO5g== MIME-Version: 1.0 X-Received: by 10.224.130.68 with SMTP id r4mr32602521qas.72.1375195226604; Tue, 30 Jul 2013 07:40:26 -0700 (PDT) Received: by 10.224.21.136 with HTTP; Tue, 30 Jul 2013 07:40:26 -0700 (PDT) In-Reply-To: References: Date: Tue, 30 Jul 2013 16:40:26 +0200 Message-ID: Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? From: Sebastian Wiesner To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14967 Cc: Glenn Morris , 14967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) 2013/7/30 Stefan Monnier : >> Well, obviously I consider this behavior a bug. Trash is no place for >> deleted packages. I mean, does apt-get remove use the Trash?! > > I think the reasoning goes as follows: > Emacs uses "trash" when deleting a file upon the user's request (as > opposed to things like temp files used internally). Emacs doesn't delete =E2=80=9Cfiles=E2=80=9D here, it deletes =E2=80=9Cpack= ages=E2=80=9D. Yes, packages are just a bunch of files in the end, but conceptually a package is not just a plain bunch of files. It is a complex opaque data structure providing Emacs Lisp code, with some complex management/activation logic behind. For this reason, a package can't be treated as a plain directory with files. For instance, restoring a package from trash doesn't restore the package for any running Emacs session, simply because "package.el" doesn't know about it. Also, "package-delete" may be called in situations other than an explicit user request. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 11:24:29 2013 Received: (at 14967) by debbugs.gnu.org; 30 Jul 2013 15:24:29 +0000 Received: from localhost ([127.0.0.1]:58592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4Bmm-0007V0-GL for submit@debbugs.gnu.org; Tue, 30 Jul 2013 11:24:28 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:37264) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V4Bmk-0007Uk-Cw for 14967@debbugs.gnu.org; Tue, 30 Jul 2013 11:24:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxJpK/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA5JbA5IcgV6DEw X-IPAS-Result: Av8EABK/CFFFxJpK/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA5JbA5IcgV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="20166592" Received: from 69-196-154-74.dsl.teksavvy.com (HELO pastel.home) ([69.196.154.74]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 30 Jul 2013 11:24:14 -0400 Received: by pastel.home (Postfix, from userid 20848) id 256AE62DAF; Tue, 30 Jul 2013 11:14:29 -0400 (EDT) From: Stefan Monnier To: Sebastian Wiesner Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? Message-ID: References: Date: Tue, 30 Jul 2013 11:14:29 -0400 In-Reply-To: (Sebastian Wiesner's message of "Tue, 30 Jul 2013 16:40:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 14967 Cc: Glenn Morris , 14967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > For this reason, a package can't be treated as a plain directory with > files. It's pretty close, tho. > For instance, restoring a package from trash doesn't restore > the package for any running Emacs session, I'm not sure what you mean. Let's say you have a running Emacs session. What's the difference between: - restore the package from trash. and - start a new Emacs session, (re)install the package, exit. AFAIK, the running Emacs session will be affected in exactly the same way. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 19:40:33 2016 Received: (at 14967) by debbugs.gnu.org; 5 Aug 2016 23:40:34 +0000 Received: from localhost ([127.0.0.1]:56960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVojB-0002SP-Ov for submit@debbugs.gnu.org; Fri, 05 Aug 2016 19:40:33 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:38139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVojA-0002S6-4h; Fri, 05 Aug 2016 19:40:32 -0400 Received: by mail-it0-f44.google.com with SMTP id j124so37922381ith.1; Fri, 05 Aug 2016 16:40:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lLyFQiXJOEAmKmsu7OhdOAk7LoBdznC7ccg06hFzI4s=; b=vO1eMUGwv/NF/y00ybEoaKwazwflKERX+1Y7TbfgcXoZ7cLMmnKJwh6A5VLxmOAcKi IZaPAhirEnNFmjT5L3T3lQn7tGhM2U0DwkHs4p7IlxPXsqUUh9Hq2PFrwS1ZzH5kZFTX uZa+gUmRV2ogXEaFJ3n7qlF4AqIK0HsUwih/6oBUeEzuZZvxhIHw+QEskKNnVqiWhP/R /DVymiyAtcA9S0gNqIJ9WcnxzdYfhPKk5tbaop6/f5Om/erKL4/ms6JB6aPDsgkdY8Hq +qUDgomKXMsGXZ80kbxKDWmPN0IduLWzgXlr/ex+1h2V59fLYyKl0zBfWL6HIDSB1KY1 zBFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=lLyFQiXJOEAmKmsu7OhdOAk7LoBdznC7ccg06hFzI4s=; b=F4Gl5EpaiFVKiQuOio9M4Zcz5NSzQUzonKe88u13nKMZ91SYevDr0yMDDNbFpPqq0p GR1dHMopWon1/f2zmp7ZgsTENN4Bzbk9+XbcdRxSphLjzl7Sw70L1nkN8Q8rTADzlMLR 8f9BF9UmBcksuRKiUsIzC4jo8Chrbc9z7NGq0VHNlk7cdPTbHO3BAl8SsBSSkcLPBUBt lMAKnz1o3/fTLVg0EcEfYYjZ/e2okh0sz6QzjV5nYOXYL4R97ALBZhSuKYH/p3az6+N8 10IctVOP8YLOeEqYZW2qc5Be4Q7dxv678YanU6O6WP/4O7UvbMdEaohmk7DjMF+cwoEQ ntFQ== X-Gm-Message-State: AEkoouvy+MT73kwqQmoV0U5RkrIQAXlFe7VLR+mzxs08nwot1foeb6codH8fcsa7fhUfTA== X-Received: by 10.36.70.14 with SMTP id j14mr7686876itb.47.1470440426609; Fri, 05 Aug 2016 16:40:26 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id 9sm9041829ior.27.2016.08.05.16.40.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Aug 2016 16:40:26 -0700 (PDT) From: npostavs@users.sourceforge.net To: Stefan Monnier Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: Date: Fri, 05 Aug 2016 19:40:34 -0400 In-Reply-To: (Stefan Monnier's message of "Tue, 30 Jul 2013 11:14:29 -0400") Message-ID: <8737mi943x.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14967 Cc: Sebastian Wiesner , Glenn Morris , 14967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 14967 notabug quit Stefan Monnier writes: >> For this reason, a package can't be treated as a plain directory with >> files. > > It's pretty close, tho. > >> For instance, restoring a package from trash doesn't restore >> the package for any running Emacs session, > > I'm not sure what you mean. Let's say you have a running > Emacs session. What's the difference between: > - restore the package from trash. > and > - start a new Emacs session, (re)install the package, exit. > AFAIK, the running Emacs session will be affected in exactly the > same way. Hence notabug, I guess? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 03 00:06:28 2016 Received: (at 14967) by debbugs.gnu.org; 3 Sep 2016 04:06:28 +0000 Received: from localhost ([127.0.0.1]:48182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bg2Dr-0004UX-Th for submit@debbugs.gnu.org; Sat, 03 Sep 2016 00:06:28 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:38640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bg2Dq-0004UH-7c for 14967@debbugs.gnu.org; Sat, 03 Sep 2016 00:06:26 -0400 Received: by mail-it0-f48.google.com with SMTP id c198so72343318ith.1 for <14967@debbugs.gnu.org>; Fri, 02 Sep 2016 21:06:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=U+AKyGX4oGoJcA67itJu3LGQsh15i3So1IflkV+ep/8=; b=jZHwPexBdPjbhIA9wEeM0Qw2ytJnE3KtZecqOQO7MnzPpfI97Kt+7tuoGlRsfSvagO 3o61uQfkQ6QYixQcrETDGCInekUugz+/t5cJu6auvL2vwTkSbhxxicLvWXXBzQqpKHMA qoLJqm7cLKQnJ7eMdggF5SXuHpqVvmVDLI0SqzujcZZMC53GXPyI+vo7N8u64HNlpDw3 ezr+nyTRTKqNMCPeirinBlH3hf3JjX67CN8fbKLvP0yenxjPR60jud/H+LttLn9n/0hL J2Le0HX6HX5pEqiwWWqPvjzKj1xKKWBDWAggCSmxTLgVt0VD3nDWN1pNUC/FgXZn14h5 RwxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=U+AKyGX4oGoJcA67itJu3LGQsh15i3So1IflkV+ep/8=; b=TNCEYs5I65+x94eojylKaEuH2Leyz0p7sexZQiMHLds8gOb3+QNeNUjlndQhxLIvwI AQdtofdi4xZiCLmKy1PZkTUmxv0x5bkTSP+hMPnkGgKdzNR0chHW0PadeltlbJLSp6CQ HNjqcVL7DEzTB7tg3bVjOJtuMyh1GKrDxlhfa/GcuZaMmoqGmB3IbkNBK3nipE8w9eW4 g9xuIjVIUR6CoPMK2R8r+yS4KyinSFKr+m1Edb6MVJ2DtpHPeO6GBZBbRJBjOZn9tXce N6DouNMXBZ3AIhowwcIWE7EQT0KtsIW8xqGcnd93frz1xBPbB6Yh/IHw6h14FzcFN+p1 qrEg== X-Gm-Message-State: AE9vXwNlNq7EDVPj1Bqn3NsG4nq/owwzlhlK1B2/RXaBCAzkEHmURXTaFrWIspd5wb16sA== X-Received: by 10.107.14.133 with SMTP id 127mr2921771ioo.146.1472875580411; Fri, 02 Sep 2016 21:06:20 -0700 (PDT) Received: from lylat (S01061859339e9903.ss.shawcable.net. [174.2.107.88]) by smtp.gmail.com with ESMTPSA id 69sm3792842itf.6.2016.09.02.21.06.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Sep 2016 21:06:19 -0700 (PDT) From: Alex To: Stefan Monnier Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: Date: Fri, 02 Sep 2016 22:06:18 -0600 In-Reply-To: (Stefan Monnier's message of "Tue, 30 Jul 2013 10:21:44 -0400") Message-ID: <87k2et39vp.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14967 Cc: Sebastian Wiesner , Glenn Morris , 14967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Stefan Monnier writes: >> Well, obviously I consider this behavior a bug. Trash is no place for >> deleted packages. I mean, does apt-get remove use the Trash?! > > I think the reasoning goes as follows: > Emacs uses "trash" when deleting a file upon the user's request (as > opposed to things like temp files used internally). > > > Stefan Could there perhaps be a separate configuration option for deleting packages versus trashing them? I usually like Emacs using the trash, but I don't see a reason why packages should go there myself. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 19:56:29 2017 Received: (at 14967) by debbugs.gnu.org; 11 Jun 2017 23:56:29 +0000 Received: from localhost ([127.0.0.1]:41562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKCib-0001sn-F9 for submit@debbugs.gnu.org; Sun, 11 Jun 2017 19:56:29 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:33874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKCia-0001sT-1E; Sun, 11 Jun 2017 19:56:28 -0400 Received: by mail-io0-f196.google.com with SMTP id a96so9171172ioj.1; Sun, 11 Jun 2017 16:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rXgbTyyMxEqqjcvzldHN6rAHwng/gwvOom5eM2FjkaE=; b=LrDML4PXhRBAUEhBJNr/eiSxMPoVEFjl6YItyte0WK3YUukLlyaPUoEt0mWwoWgzS7 HIizUCCfhvBVomEBZ083fDwSe/mX0EZs3OfYmS3XxAZ4bVcyWETfqpaHHXgllu+UIOm9 sIlMYjKKnlj/V3rs6jut77phlsy70CxIA8leF9eqk56n94Y8HjK9OfNKf4N2eySte+2g jGSqk7qfnPuMunk3XsMyyM++EDhYGRgMFczF2bXCrHAgdP0Tkr7CpEaOK6+VLUgmAsAd ST5VRz6RU3ORb3FBsnLWgR3KO+KpvRQV8lVz2cKoLM44tcb7n3GPU+ZcP3Fn3QryU7+z t1KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=rXgbTyyMxEqqjcvzldHN6rAHwng/gwvOom5eM2FjkaE=; b=kl4QADokSshjRWqwLqG5NJCMH3NhJkW+V1RSU80OJmrYh0d0yqeF2Nn0XP68+JuzvV fUbST7yNLIUh3+iBgfy6yZ0P1tq+SbLhAjMLyDnRaqol6ry9L4vAoUYkXONvb/cqfzOC Hf8Qup4ZY/MZ4bMgGd1lqPYTdHVZRiVG0Whi9tYFuQ/s/Fn8Hme32XIu5n+GLYjMplsR VziiOqwreYNCDgOyiySL/v+oRgpW9odBwhgpUTKEmoUupiFZ+6C645JTQ42JUmRPSkwx Q63n5z86Hu60D4kWf1EWPw0VMfePdRnBMymgQYkAUK/maG2/H/8vHc/VJKVkRIeCuVN/ 6qXQ== X-Gm-Message-State: AODbwcDzdC3pNSB+unPPMiK4B4SFYbYi8/WHvEXhIX0ps5FoZJ0cSdAb BrqpTnwwGwuYgYqX X-Received: by 10.107.19.135 with SMTP id 7mr36415900iot.81.1497225382467; Sun, 11 Jun 2017 16:56:22 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id z191sm3906990iod.59.2017.06.11.16.56.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Jun 2017 16:56:21 -0700 (PDT) From: npostavs@users.sourceforge.net To: Alex Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> Date: Sun, 11 Jun 2017 19:58:00 -0400 In-Reply-To: <87k2et39vp.fsf@gmail.com> (Alex's message of "Fri, 02 Sep 2016 22:06:18 -0600") Message-ID: <87efuqulfb.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 14967 Cc: Sebastian Wiesner , Glenn Morris , Stefan Monnier , 14967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 14967 wishlist quit Alex writes: > Stefan Monnier writes: > >>> Well, obviously I consider this behavior a bug. Trash is no place for >>> deleted packages. I mean, does apt-get remove use the Trash?! >> >> I think the reasoning goes as follows: >> Emacs uses "trash" when deleting a file upon the user's request (as >> opposed to things like temp files used internally). > > Could there perhaps be a separate configuration option for deleting > packages versus trashing them? I usually like Emacs using the trash, but > I don't see a reason why packages should go there myself. Seems reasonable. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 23:26:31 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 03:26:31 +0000 Received: from localhost ([127.0.0.1]:41695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKFzr-0007Jd-Ge for submit@debbugs.gnu.org; Sun, 11 Jun 2017 23:26:31 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:33619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKFzp-0007JO-7f for 14967@debbugs.gnu.org; Sun, 11 Jun 2017 23:26:29 -0400 Received: by mail-it0-f65.google.com with SMTP id l6so10477415iti.0 for <14967@debbugs.gnu.org>; Sun, 11 Jun 2017 20:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=fbCm0EyZLk0UrjQL2A/DYaPktXuYZAgQcTyqmckAS+I=; b=GOIA8i9eI/cIfFnEUxAsb/2UzNH1tmmgQZeuQZfW2i6z7fcCSVDCDMqFX2j+JRHnK+ DdKNWCzmKM1LOkmYFgvkw2Ork9KVEDjAAmmgBvilqjZXCsMQJzUVQzfnwz4WCOTMbR9t T6BCBQ9wvFQYlQrULYFvO5zfU0jAED1LPecOu6+8IssHz9PY8OpbORnsCljndtDrg3c0 0DCwEOMer9iGZ1JPnxHxEOJwtkanXRYiv6ltq/mUGbijG3TXN49pORjpyG4ycil6pBuv IwQuxRReLTjKGAKtLLhbgEONR//Xxxbb/S1K/+dZuDu2hYRBWuwPBUJvpti6Oa4lGWlu e2sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=fbCm0EyZLk0UrjQL2A/DYaPktXuYZAgQcTyqmckAS+I=; b=NIfTvMIYADwwH0oluJ/mL7xWS+u84uCGIereTOAturg+PZ573pYHKjHkzNIf5uAwHa PZfp35qaI1F3J7QZsL3xLaGzp/EKx5fyFYHMBybsvqyoAgeeG1yuZ4L+w801B8kvruGB vO/K/Deh0dcHla4MqlEUvv8ksUEtmQqqkODkCplSQSC4+Z0as42poHukOTVm9K7y6od4 +BNjh8Rrr42xXsNbBw6uopTT0ETdVv/Nv0jHdT/jP1r2iuRLrF9nxWYk2eP2+LxeQOVm vexraGtpjySBe+GsW+et0CeBaELxswyyTpruPRQnoXXvCUr0MbChEP0IVQVG9BAxBJfW XPKA== X-Gm-Message-State: AODbwcDqCem7I47zTB5FvqoNEHNTR1FnQU/l7a08/ZQosNk70cyVMmOS z23Zb4M+dShoXg== X-Received: by 10.36.203.132 with SMTP id u126mr9822883itg.11.1497237983665; Sun, 11 Jun 2017 20:26:23 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id 131sm2222120ioo.5.2017.06.11.20.26.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Jun 2017 20:26:22 -0700 (PDT) From: Alex To: npostavs@users.sourceforge.net Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> Date: Sun, 11 Jun 2017 21:26:20 -0600 In-Reply-To: <87efuqulfb.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Sun, 11 Jun 2017 19:58:00 -0400") Message-ID: <87o9tt51k3.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14967 Cc: Sebastian Wiesner , Glenn Morris , Stefan Monnier , 14967@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain npostavs@users.sourceforge.net writes: > severity 14967 wishlist > quit > > Alex writes: > >> Stefan Monnier writes: >> >>>> Well, obviously I consider this behavior a bug. Trash is no place for >>>> deleted packages. I mean, does apt-get remove use the Trash?! >>> >>> I think the reasoning goes as follows: >>> Emacs uses "trash" when deleting a file upon the user's request (as >>> opposed to things like temp files used internally). >> >> Could there perhaps be a separate configuration option for deleting >> packages versus trashing them? I usually like Emacs using the trash, but >> I don't see a reason why packages should go there myself. > > Seems reasonable. Here's a patch for it. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Make-package-delete-conditionally-not-use-the-trash.patch Content-Description: patch >From cf3039f10846155fde224a1f6c249799ab7cf41d Mon Sep 17 00:00:00 2001 From: Alexander Gramiak Date: Sun, 11 Jun 2017 21:12:24 -0600 Subject: [PATCH] Make package-delete conditionally not use the trash Some users would like to trash other files, but not old package files (Bug#14967). * lisp/emacs-lisp/package.el: Add `package-trash-old-packages'. * etc/NEWS: Document it. --- etc/NEWS | 3 +++ lisp/emacs-lisp/package.el | 7 ++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 7972511f7a..fa1e5c1312 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -743,6 +743,9 @@ header's value. where the GnuPG home directory (used for signature verification) is located and whether GnuPG's option "--homedir" is used or not. +*** The new variable 'package-trash-old-packages' has been added to +control whether or not 'package-delete' trashes old packages files. + ** Tramp +++ diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index bebfd18d7a..5173a32e33 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2071,6 +2071,11 @@ package--newest-p (equal (cadr (assq (package-desc-name pkg) package-alist)) pkg)) +(defvar package-trash-old-packages t + "If non-nil, `package-delete' may trash packages. +`delete-by-moving-to-trash' must be non-nil for this variable to +have an effect.") + (defun package-delete (pkg-desc &optional force nosave) "Delete package PKG-DESC. @@ -2127,7 +2132,7 @@ package-delete (package-desc-name pkg-used-elsewhere-by))) (t (add-hook 'post-command-hook #'package-menu--post-refresh) - (delete-directory dir t t) + (delete-directory dir t package-trash-old-packages) ;; Remove NAME-VERSION.signed and NAME-readme.txt files. (dolist (suffix '(".signed" "readme.txt")) (let* ((version (package-version-join (package-desc-version pkg-desc))) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 10:28:12 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 14:28:12 +0000 Received: from localhost ([127.0.0.1]:43589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKQKC-0002zm-GO for submit@debbugs.gnu.org; Mon, 12 Jun 2017 10:28:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKQKA-0002zZ-Ri for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 10:28:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKQK2-0008Cx-Je for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 10:28:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKQK2-0008Ct-G9; Mon, 12 Jun 2017 10:28:02 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3342 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKQJy-00028Z-ID; Mon, 12 Jun 2017 10:27:58 -0400 Date: Mon, 12 Jun 2017 17:27:47 +0300 Message-Id: <83bmpt5li4.fsf@gnu.org> From: Eli Zaretskii To: Alex In-reply-to: <87o9tt51k3.fsf@gmail.com> (message from Alex on Sun, 11 Jun 2017 21:26:20 -0600) Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, monnier@iro.umontreal.ca, 14967@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Alex > Date: Sun, 11 Jun 2017 21:26:20 -0600 > Cc: Sebastian Wiesner , > Stefan Monnier , 14967@debbugs.gnu.org > > Here's a patch for it. Thanks. > +*** The new variable 'package-trash-old-packages' has been added to > +control whether or not 'package-delete' trashes old packages files. This should say something about the default behavior. > +(defvar package-trash-old-packages t > + "If non-nil, `package-delete' may trash packages. Why "may"? > +`delete-by-moving-to-trash' must be non-nil for this variable to > +have an effect.") I think it would be better to make this defcustom. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 12:03:23 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 16:03:23 +0000 Received: from localhost ([127.0.0.1]:43694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKRoJ-0002fw-KE for submit@debbugs.gnu.org; Mon, 12 Jun 2017 12:03:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKRoI-0002fe-4Q for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 12:03:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKRoC-0008Ef-9U for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 12:03:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKRo2-00087A-Ip; Mon, 12 Jun 2017 12:03:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKRo1-0005lt-5E; Mon, 12 Jun 2017 12:03:05 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> X-Spook: UMTS Bacteria Steve Case Gangs National Guard blackjack X-Ran: rh(ut#/\MsWg_*:JH&yLTQXSvqA$|!LdE1Ip9mLJwTUu X-Hue: brightblack X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 12 Jun 2017 12:03:05 -0400 In-Reply-To: <83bmpt5li4.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jun 2017 17:27:47 +0300") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, 14967@debbugs.gnu.org, monnier@iro.umontreal.ca, Alex , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Does anyone actually want deleted packages to go to trash? Yours-concerned-about-yet-another-option-ly, From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 12:33:37 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 16:33:37 +0000 Received: from localhost ([127.0.0.1]:43726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSHZ-0003Qp-7H for submit@debbugs.gnu.org; Mon, 12 Jun 2017 12:33:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSHX-0003Qd-Hh for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 12:33:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKSHP-0002Xm-DR for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 12:33:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKSHE-0002Qz-Dp; Mon, 12 Jun 2017 12:33:16 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3562 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKSHD-0005dc-0R; Mon, 12 Jun 2017 12:33:15 -0400 Date: Mon, 12 Jun 2017 19:33:03 +0300 Message-Id: <83y3sx414w.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Mon, 12 Jun 2017 12:03:05 -0400) Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, 14967@debbugs.gnu.org, monnier@iro.umontreal.ca, agrambot@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Cc: Alex , lunaryorn@gmail.com, monnier@iro.umontreal.ca, 14967@debbugs.gnu.org, npostavs@users.sourceforge.net > Date: Mon, 12 Jun 2017 12:03:05 -0400 > > > Does anyone actually want deleted packages to go to trash? Do you or did you ever use the trash facility? Because there are people who never ever actually delete files, only move them to trash. (No, I'm not one of them, but I hardly matter in this case.) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 12:56:27 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 16:56:27 +0000 Received: from localhost ([127.0.0.1]:43903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSdf-00044T-1X for submit@debbugs.gnu.org; Mon, 12 Jun 2017 12:56:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSdd-00044I-PF for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 12:56:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKSdX-0001nZ-G8 for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 12:56:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKSdN-0001jE-8p; Mon, 12 Jun 2017 12:56:09 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKSdM-00051p-4x; Mon, 12 Jun 2017 12:56:08 -0400 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> X-Spook: ETA Watergate Arnett kilo class Recovery Yuma Pakistan X-Ran: %axI^3\0'#nrS!V\<$z=sLvB3rk6)Q((_pJhwkJrM/F]z"KbH6zg~Th X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 12 Jun 2017 12:56:08 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, 14967@debbugs.gnu.org, monnier@iro.umontreal.ca, agrambot@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Eli Zaretskii wrote: > Do you or did you ever use the trash facility? No. But the people who do and commented in this report don't want it to apply to packages. So I think it's worth thinking, before adding a new option, if anyone actually wants the current behaviour. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 13:02:36 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 17:02:36 +0000 Received: from localhost ([127.0.0.1]:43918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSjc-0004ES-7s for submit@debbugs.gnu.org; Mon, 12 Jun 2017 13:02:36 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSja-0004EJ-34 for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 13:02:35 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v5CH2VAl024570; Mon, 12 Jun 2017 13:02:32 -0400 Received: by ceviche.home (Postfix, from userid 20848) id EACFA662C5; Mon, 12 Jun 2017 13:02:30 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? Message-ID: References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> Date: Mon, 12 Jun 2017 13:02:30 -0400 In-Reply-To: (Glenn Morris's message of "Mon, 12 Jun 2017 12:56:08 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6045=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6045> : inlines <5912> : streams <1749626> : uri <2442364> X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, Eli Zaretskii , 14967@debbugs.gnu.org, agrambot@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) >> Do you or did you ever use the trash facility? > No. But the people who do and commented in this report don't want it to > apply to packages. So I think it's worth thinking, before adding a new > option, if anyone actually wants the current behaviour. I'm the kind of user who'd rather alias "rm" to "rm -f" than to "rm -i" and then rely on automated backups. And since the "trash" system is not an automated backup in my view, I indeed have no idea if there are users who'd want package.el to use the trash. And I agree it's worth asking. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 13:05:17 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 17:05:17 +0000 Received: from localhost ([127.0.0.1]:43922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSmD-0004IJ-KK for submit@debbugs.gnu.org; Mon, 12 Jun 2017 13:05:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSmB-0004I6-VS for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 13:05:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKSm3-0004yY-Rp for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 13:05:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKSlu-0004uB-66; Mon, 12 Jun 2017 13:04:58 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3585 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dKSlt-0000og-2f; Mon, 12 Jun 2017 13:04:57 -0400 Date: Mon, 12 Jun 2017 20:04:46 +0300 Message-Id: <83shj53zo1.fsf@gnu.org> From: Eli Zaretskii To: Glenn Morris In-reply-to: (message from Glenn Morris on Mon, 12 Jun 2017 12:56:08 -0400) Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, 14967@debbugs.gnu.org, monnier@iro.umontreal.ca, agrambot@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Glenn Morris > Cc: agrambot@gmail.com, lunaryorn@gmail.com, monnier@iro.umontreal.ca, 14967@debbugs.gnu.org, npostavs@users.sourceforge.net > Date: Mon, 12 Jun 2017 12:56:08 -0400 > > Eli Zaretskii wrote: > > > Do you or did you ever use the trash facility? > > No. But the people who do and commented in this report don't want it to > apply to packages. So I think it's worth thinking, before adding a new > option, if anyone actually wants the current behaviour. Fine with me. All I said was that if we do add a variable, it should be a defcustom; defvar makes little sense to me. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 13:17:59 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 17:18:00 +0000 Received: from localhost ([127.0.0.1]:43942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSyV-0004aH-NL for submit@debbugs.gnu.org; Mon, 12 Jun 2017 13:17:59 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:49303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKSyT-0004a8-L3 for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 13:17:57 -0400 Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v5CHHt60025218; Mon, 12 Jun 2017 13:17:55 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 5DA58662C5; Mon, 12 Jun 2017 13:17:55 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? Message-ID: References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> <83shj53zo1.fsf@gnu.org> Date: Mon, 12 Jun 2017 13:17:55 -0400 In-Reply-To: <83shj53zo1.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jun 2017 20:04:46 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6045=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6045> : inlines <5912> : streams <1749628> : uri <2442370> X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, Glenn Morris , 14967@debbugs.gnu.org, agrambot@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) >> No. But the people who do and commented in this report don't want it to >> apply to packages. So I think it's worth thinking, before adding a new >> option, if anyone actually wants the current behaviour. > Fine with me. All I said was that if we do add a variable, it should > be a defcustom; defvar makes little sense to me. Maybe the most effective way to "ask" users is to just change the code so it doesn't use the trash system (mentioning it in NEWS, of course). And then wait to see if someone complains. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 15:38:03 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 19:38:03 +0000 Received: from localhost ([127.0.0.1]:44015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKVA3-0007kb-Ht for submit@debbugs.gnu.org; Mon, 12 Jun 2017 15:38:03 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:35372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKVA1-0007k2-Dr for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 15:38:01 -0400 Received: by mail-io0-f196.google.com with SMTP id f79so10974513ioi.2 for <14967@debbugs.gnu.org>; Mon, 12 Jun 2017 12:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=atTnlI3b1clvei4mRzrViYVdXivY9CxYivLVHNaw3E0=; b=LBBIK7b1XXOM+SaW92432C1b2EZRwKZaZCtEl1dK96KpEJBrFyAL67JGQ903a1szYf 8BvMBX+NSG+UB57BYlIAQk/+MFgdxB/OeWRu6rOzMK1VtOVAGbdQLhSQ4lY1T1GKncZy pjFbepnY6ZJJxXS18BIG5LR4BUMaxX8hG0YakhyzOOP61Pk+0GtSniPV5B8Qj/jPybmb U14ZbWclBhPCfJRLAs12HBi90jUFk9sFYfb+K9/Kny4O4lin1v6Rcjum9lLyggv2B2it RUcDiRv/Aeo7vEtUL30T/w4ydXGkRKp2G5T8WMPiF1Vrcsss5qXG+9FKwrcgZrHpRgYs eY5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=atTnlI3b1clvei4mRzrViYVdXivY9CxYivLVHNaw3E0=; b=dL7mDfBdgOX+c5ASEgqq3MH8o8/YzcyoQloT57M1pk0lG0YGlgFeS0HcHfhSjcowol twNlFpmqdb+y1gixK/wLNXM+zILc0uF2d+owybLs4F7cRI0ibEHyp0Zh0hNWSdBuVeDS YndVcZ/5a29p+RTCdsDR8XjrBpJhE3/F9cD60X2H5a+cHDeTJN+Ksj7q2Ms+oUKu9YVs VT0LQf3jNqyVtK49pH55zMBi0Mg6+vrs66wQXQlBmgXf+k2q6PhfIL7/uYzNXhZupaBm 9iOdhX1mRCoEF+HrfzEUEvMun5Tb//kgqNKX52hyIhu42PnOL7GCL2t6bJMBzaduwP9s KzTQ== X-Gm-Message-State: AODbwcBNQ643p1W4zRV/G6tCrjhdoniIcGg3GIwlEq7uhS595K+dwXBt tIe3eo/WiYDJHxz/ X-Received: by 10.107.15.87 with SMTP id x84mr46914699ioi.41.1497296275449; Mon, 12 Jun 2017 12:37:55 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id e14sm4453221itc.30.2017.06.12.12.37.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Jun 2017 12:37:53 -0700 (PDT) From: Alex To: Eli Zaretskii Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> Date: Mon, 12 Jun 2017 13:37:46 -0600 In-Reply-To: <83bmpt5li4.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jun 2017 17:27:47 +0300") Message-ID: <87vao12e0l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, monnier@iro.umontreal.ca, 14967@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> +(defvar package-trash-old-packages t >> + "If non-nil, `package-delete' may trash packages. > > Why "may"? Since after this patch, `package-delete' may trash packages, or may not, depending on the value of `delete-by-moving-to-trash'. >> +`delete-by-moving-to-trash' must be non-nil for this variable to >> +have an effect.") > > I think it would be better to make this defcustom. Right, I forgot to do that. I updated and attached a new patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-package-delete-conditionally-not-use-the-trash.patch Content-Description: trash2 >From ee33b113826efb6130dfe2d9c568b8e4ddc80eb2 Mon Sep 17 00:00:00 2001 From: Alexander Gramiak Date: Sun, 11 Jun 2017 21:12:24 -0600 Subject: [PATCH] Make package-delete conditionally not use the trash Some users would like to trash other files, but not old package files (Bug#14967). * lisp/emacs-lisp/package.el: Add `package-trash-old-packages'. --- etc/NEWS | 4 ++++ lisp/emacs-lisp/package.el | 9 ++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 7972511f7a..ee99d114a7 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -743,6 +743,10 @@ header's value. where the GnuPG home directory (used for signature verification) is located and whether GnuPG's option "--homedir" is used or not. +*** The new variable 'package-trash-old-packages' has been added to +control whether or not 'package-delete' trashes old packages +files. The default behaviour is to trash old packages. + ** Tramp +++ diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index bebfd18d7a..c92ce19e6c 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -368,6 +368,13 @@ package-menu-async :type 'boolean :version "25.1") +(defcustom package-trash-old-packages t + "If non-nil, `package-delete' may trash packages. +`delete-by-moving-to-trash' must be non-nil for this variable to +have an effect." + :type 'boolean + :version "26.1") + ;;; `package-desc' object definition ;; This is the struct used internally to represent packages. @@ -2127,7 +2134,7 @@ package-delete (package-desc-name pkg-used-elsewhere-by))) (t (add-hook 'post-command-hook #'package-menu--post-refresh) - (delete-directory dir t t) + (delete-directory dir t package-trash-old-packages) ;; Remove NAME-VERSION.signed and NAME-readme.txt files. (dolist (suffix '(".signed" "readme.txt")) (let* ((version (package-version-join (package-desc-version pkg-desc))) -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 15:46:10 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 19:46:10 +0000 Received: from localhost ([127.0.0.1]:44033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKVHu-0007x3-91 for submit@debbugs.gnu.org; Mon, 12 Jun 2017 15:46:10 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:36349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKVHs-0007wr-Pz for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 15:46:09 -0400 Received: by mail-it0-f66.google.com with SMTP id 185so9484042itv.3 for <14967@debbugs.gnu.org>; Mon, 12 Jun 2017 12:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=8CJ1UyNHFhfQIdRujOTctDPHwhm3o5fKE0vp1GJP/Qs=; b=Xc2j9U22hcgN9+KZ/0YUXKlNmLRlzVJFL9ISBHLBcGzxR6sF9BvqQ4hVbdxhaS0m/F 2xJAa7U2ZuXDmWzdoKw4474OYj/kueUyQ+e9JxFsGkGHEdRhdCkWR4iMBWJh1dRjDkte gHR1s+q0vsxmxfolAv1K/xzUdCmtcs2mYBpuRGrDSaFqsHhZ1B2+0HZdcSymj7Iij9Tr s7VDzliA/x2OTcN29h4KPI7KcDF/kjw+S5wvLdOhe3xsMBDGiPzNNdTyrdYrwRsFZxmm UuIrdWcvSt/bwdslTzgij7kBfSGeFPmx754dqvYwiHuB0RoXIjln/7tgLUJcajQvgzED ZU1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=8CJ1UyNHFhfQIdRujOTctDPHwhm3o5fKE0vp1GJP/Qs=; b=XE3Py08teOsiiR17+K7I5r5b5MiEhEGqXWlt8XTJkLH4XbqfRcpq34E2VCp+2gzNbr fnhFVFMbGTU8i/pGBKwc5eCvnSOfBLfEuE3VfjEDZunD7kqP6Q1wk2tXNVPgdpUkAPTb n2Wz/ZrKCANVvw98Q6FBvBdbxuSIXeArib07YhAUoRvzxuFY9P/bZbCv1FzuIdbjm0S8 OtRPF09+hn9istkYK5VrAvKYiXXkrfw6hmIFvK9xPFEP4Zxvu2EgKx5EVxkGO0Eh5CA9 F+r/72+LnAfK0BaE6EmcQxKPMV7sqdimX3dxntvlu7cmeK+nFRN+AKupxYIRLaK413Vm i81w== X-Gm-Message-State: AODbwcAaHycQKLAF5aocObXnVgFEFNLvrV1o8lK6CQqfyj4anRjxE+k0 Dk4tl03vwirrEg== X-Received: by 10.36.110.23 with SMTP id w23mr13105637itc.24.1497296763140; Mon, 12 Jun 2017 12:46:03 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id y188sm4594975ity.9.2017.06.12.12.46.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Jun 2017 12:46:02 -0700 (PDT) From: Alex To: Stefan Monnier Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> <83shj53zo1.fsf@gnu.org> Date: Mon, 12 Jun 2017 13:45:59 -0600 In-Reply-To: (Stefan Monnier's message of "Mon, 12 Jun 2017 13:17:55 -0400") Message-ID: <87r2yp2dmw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, Glenn Morris , Eli Zaretskii , 14967@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Stefan Monnier writes: >>> No. But the people who do and commented in this report don't want it to >>> apply to packages. So I think it's worth thinking, before adding a new >>> option, if anyone actually wants the current behaviour. >> Fine with me. All I said was that if we do add a variable, it should >> be a defcustom; defvar makes little sense to me. > > Maybe the most effective way to "ask" users is to just change the code > so it doesn't use the trash system (mentioning it in NEWS, of course). > And then wait to see if someone complains. > > > Stefan Is that a good idea for new behaviour that results in potential data loss (from the view of a user that expects `package-delete' to trash files rather than outright deleting them)? It might be easy to gloss over an entry in NEWS, after all. I don't like the default behaviour myself, so I don't personally care either way. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 16:32:43 2017 Received: (at 14967) by debbugs.gnu.org; 12 Jun 2017 20:32:43 +0000 Received: from localhost ([127.0.0.1]:44073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKW0x-0000ae-9p for submit@debbugs.gnu.org; Mon, 12 Jun 2017 16:32:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKW0v-0000aP-E9 for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 16:32:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKW0p-0007nq-It for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 16:32:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKW0e-0007kl-5I; Mon, 12 Jun 2017 16:32:24 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKW0c-0002pf-Q9; Mon, 12 Jun 2017 16:32:22 -0400 From: Glenn Morris To: Alex Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> <83shj53zo1.fsf@gnu.org> <87r2yp2dmw.fsf@gmail.com> X-Spook: industrial intelligence Lightning FTS2000 Radiation X-Ran: JX|{&.wEW)9VEMYd@Z>6S7 (Alex's message of "Mon, 12 Jun 2017 13:45:59 -0600") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, Eli Zaretskii , Stefan Monnier , 14967@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alex wrote: > Is that a good idea for new behaviour that results in potential data > loss (from the view of a user that expects `package-delete' to trash > files rather than outright deleting them)? It might be easy to gloss > over an entry in NEWS, after all. IMO there's no real potential for data loss, since you can just reinstall the package from its source. (I assume this is what people do in practice, rather than un-trashing.) Although "source is no longer available" is in theory possible, in practice I don't think it's a real concern. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 12 23:50:55 2017 Received: (at 14967) by debbugs.gnu.org; 13 Jun 2017 03:50:55 +0000 Received: from localhost ([127.0.0.1]:44231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKcr1-0005Zb-IW for submit@debbugs.gnu.org; Mon, 12 Jun 2017 23:50:55 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:35219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKcqz-0005ZQ-Mg for 14967@debbugs.gnu.org; Mon, 12 Jun 2017 23:50:54 -0400 Received: by mail-io0-f195.google.com with SMTP id f79so11799629ioi.2 for <14967@debbugs.gnu.org>; Mon, 12 Jun 2017 20:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=m+NGBuWIgFBoC9Z9N9kmRSYUhTBDom5iEBiiWyf9Qm0=; b=VL1vhu1+ZP7R/5c+jsyK26wGJg1tr0TrM4h8Pg2SeAu+OeOP0GXyH4BrN8JrHqngAo 8MD4Q7bcS0gi5PfUikNbSdpwHmDceTmylf1FPQd0bqQ49nC++WhXlMGV53O6Z1TsnvsT eQlhWzLcQTTRX7hzI2SfDiemTFxhw+p/zUYNeMQdbtJK4cbjEp/cp1VfA6uRZoDxtcWV g/MoyyXTpIstqTaQ0YzNKEUI55XV4dFf5bdLxCVALwufBOcdSK00zuroPBBwEZ+zB6At NCcLi2eEJcjJ+abfG0WBIFKCKoICRV5NA9FizIS6c1j7Zjv7yvnlpQME2+D/lar3PTGw cdsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=m+NGBuWIgFBoC9Z9N9kmRSYUhTBDom5iEBiiWyf9Qm0=; b=lclDSgupYUYpkYxOMKilVNJpOGlahO69S3FfxoyeZXAVU4ZIan3lZ0ZdO7+PHARkYM npVGLRlzyHYq4799sH9k9VpG1hFry0uSZGBNmzxP4rwixy2O+npEtbua4FxmInHWR33e 0Y2twgEAPTM1Ynx58vRGlLxUzgzHMZBCznzZOoLwBjqwmKDhi/zSllyNWbF+U0egU66q axGY5rb4He19d9kSP9cjM1iv1o/xK0uLpygXtm7+mTXw4ZEWj5O9zFDIzJWfsOEVK2cY 6MUE2va9oOVr6rbA8lu9IZ010HF6qwm66lrTFnCPup3AwOIpqlgpN5PZU5WnCxI/C0B2 2hDg== X-Gm-Message-State: AODbwcAv0LohEz7EsJ6aMWmBY2Drs5klYzat1Omxmfcvc6gnBn6gL4Yf w0VE5Mm3AeN5qg== X-Received: by 10.107.129.81 with SMTP id c78mr41603650iod.92.1497325848105; Mon, 12 Jun 2017 20:50:48 -0700 (PDT) Received: from lylat (S010664777d9cebe3.ss.shawcable.net. [70.64.85.59]) by smtp.gmail.com with ESMTPSA id i6sm5049675iti.20.2017.06.12.20.50.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Jun 2017 20:50:47 -0700 (PDT) From: Alex To: Glenn Morris Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> <83shj53zo1.fsf@gnu.org> <87r2yp2dmw.fsf@gmail.com> Date: Mon, 12 Jun 2017 21:50:45 -0600 In-Reply-To: (Glenn Morris's message of "Mon, 12 Jun 2017 16:32:22 -0400") Message-ID: <87ink035re.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, Eli Zaretskii , Stefan Monnier , 14967@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Glenn Morris writes: > Alex wrote: > >> Is that a good idea for new behaviour that results in potential data >> loss (from the view of a user that expects `package-delete' to trash >> files rather than outright deleting them)? It might be easy to gloss >> over an entry in NEWS, after all. > > IMO there's no real potential for data loss, since you can just > reinstall the package from its source. (I assume this is what people do > in practice, rather than un-trashing.) Although "source is no longer > available" is in theory possible, in practice I don't think it's a real > concern. Usually, though someone might have edited packages inside package-user-dir and might be saved from an accidental deletion by the trash can (this happened to me once or twice). If this is deemed to be too uncommon (it probably is), then it probably won't be too bad to just make package-delete always delete. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 13 22:54:25 2017 Received: (at 14967) by debbugs.gnu.org; 14 Jun 2017 02:54:25 +0000 Received: from localhost ([127.0.0.1]:46478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKyRt-0005jn-ES for submit@debbugs.gnu.org; Tue, 13 Jun 2017 22:54:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKyRr-0005jb-8D for 14967@debbugs.gnu.org; Tue, 13 Jun 2017 22:54:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKyRl-0007DE-BG for 14967@debbugs.gnu.org; Tue, 13 Jun 2017 22:54:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKyRb-00079e-Vr; Tue, 13 Jun 2017 22:54:08 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dKyRa-0002VR-VY; Tue, 13 Jun 2017 22:54:07 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Mon, 12 Jun 2017 13:02:30 -0400) Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> Message-Id: Date: Tue, 13 Jun 2017 22:54:06 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, rgm@gnu.org, 14967@debbugs.gnu.org, agrambot@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > And since the "trash" system is not > an automated backup in my view, I indeed have no idea if there are users > who'd want package.el to use the trash. Poll the users? -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 19 14:48:03 2017 Received: (at 14967) by debbugs.gnu.org; 19 Jun 2017 18:48:03 +0000 Received: from localhost ([127.0.0.1]:56522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dN1iU-0007h6-Se for submit@debbugs.gnu.org; Mon, 19 Jun 2017 14:48:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dN1iT-0007gb-5p for 14967@debbugs.gnu.org; Mon, 19 Jun 2017 14:48:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dN1iN-0002Ex-5C for 14967@debbugs.gnu.org; Mon, 19 Jun 2017 14:47:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dN1iN-0002Ep-19; Mon, 19 Jun 2017 14:47:55 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dN1iL-0001jd-2m; Mon, 19 Jun 2017 14:47:53 -0400 From: Glenn Morris To: 14967@debbugs.gnu.org Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing? References: <87k2et39vp.fsf@gmail.com> <87efuqulfb.fsf@users.sourceforge.net> <87o9tt51k3.fsf@gmail.com> <83bmpt5li4.fsf@gnu.org> <83y3sx414w.fsf@gnu.org> <83shj53zo1.fsf@gnu.org> <87r2yp2dmw.fsf@gmail.com> X-Spook: Fort Hancock rail gun Mena Hazmat investigation Indigo X-Ran: L}O+C'y}T8S|iW7=&>/{U~qMS+{]'Qx&!o7AeSM;qh9y=^T)h]v3ratE6?c7fn(0@I X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 19 Jun 2017 14:47:52 -0400 In-Reply-To: (Glenn Morris's message of "Mon, 12 Jun 2017 16:32:22 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 14967 Cc: lunaryorn@gmail.com, Stefan Monnier , Alex , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.4 (---) I've applied the following. IMO if Emacs wants to behave like system package managers (eg yum, apt), it should (optionally) cache the _source_ when it downloads a package. Then use that (if appropriate) if asked to (re)install. commit 65b323e (HEAD, master) Date: Mon Jun 19 14:39:25 2017 -0400 Don't put deleted packages in the trash (bug#14967) * lisp/emacs-lisp/package.el (package-delete): Don't pay attention to delete-by-moving-to-trash. ; * etc/NEWS: Mention this. diff --git a/etc/NEWS b/etc/NEWS index 85d1273..78d37484 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -755,6 +755,9 @@ header's value. where the GnuPG home directory (used for signature verification) is located and whether GnuPG's option "--homedir" is used or not. +--- +*** Deleting a package no longer respects 'delete-by-moving-to-trash'. + ** Tramp +++ diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index bebfd18..4245294 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2127,7 +2127,7 @@ If NOSAVE is non-nil, the package is not removed from (package-desc-name pkg-used-elsewhere-by))) (t (add-hook 'post-command-hook #'package-menu--post-refresh) - (delete-directory dir t t) + (delete-directory dir t) ;; Remove NAME-VERSION.signed and NAME-readme.txt files. (dolist (suffix '(".signed" "readme.txt")) (let* ((version (package-version-join (package-desc-version pkg-desc))) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 19 14:48:32 2017 Received: (at control) by debbugs.gnu.org; 19 Jun 2017 18:48:32 +0000 Received: from localhost ([127.0.0.1]:56525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dN1iy-0007hr-53 for submit@debbugs.gnu.org; Mon, 19 Jun 2017 14:48:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dN1ix-0007hc-FC for control@debbugs.gnu.org; Mon, 19 Jun 2017 14:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dN1ir-0002Mn-S0 for control@debbugs.gnu.org; Mon, 19 Jun 2017 14:48:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49245) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dN1ir-0002Mi-PG for control@debbugs.gnu.org; Mon, 19 Jun 2017 14:48:25 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dN1ir-0001mh-Dw for control@debbugs.gnu.org; Mon, 19 Jun 2017 14:48:25 -0400 Subject: control message for bug 14967 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 19 Jun 2017 14:48:25 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.4 (---) # 65b323e close 14967 26.1 From unknown Fri Aug 15 15:30:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 18 Jul 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator