Subject: Re: bug#14967: 24.3.50; package-delete deletes by trashing?

From: Eli Zaretskii <[email-masked]>
Date: Mon, 12 Jun 2017 17:27:47 +0300

> From: Alex <[email-masked]>
> Date: Sun, 11 Jun 2017 21:26:20 -0600
> Cc: Sebastian Wiesner <[email-masked]>,
> 	Stefan Monnier <[email-masked]>, [email-masked]
> 
> Here's a patch for it.

Thanks.

> +*** The new variable 'package-trash-old-packages' has been added to
> +control whether or not 'package-delete' trashes old packages files.

This should say something about the default behavior.

> +(defvar package-trash-old-packages t
> +  "If non-nil, `package-delete' may trash packages.

Why "may"?

> +`delete-by-moving-to-trash' must be non-nil for this variable to
> +have an effect.")

I think it would be better to make this defcustom.